From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CD50C3600C for ; Thu, 3 Apr 2025 14:53:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 425E128000B; Thu, 3 Apr 2025 10:53:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D523280008; Thu, 3 Apr 2025 10:53:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29BEE28000B; Thu, 3 Apr 2025 10:53:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0D1B9280008 for ; Thu, 3 Apr 2025 10:53:02 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 32F4480623 for ; Thu, 3 Apr 2025 14:53:03 +0000 (UTC) X-FDA: 83293025046.02.FC414F1 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) by imf11.hostedemail.com (Postfix) with ESMTP id 647174000E for ; Thu, 3 Apr 2025 14:53:01 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=TtSQ5GdK; spf=pass (imf11.hostedemail.com: domain of 3zKDuZwYKCA87tp2yrv33v0t.r310x29C-11zAprz.36v@flex--seanjc.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=3zKDuZwYKCA87tp2yrv33v0t.r310x29C-11zAprz.36v@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743691981; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lAYnbFZKyAbKvQrvS445eKEFXwY5377UYiGWqzU8Erc=; b=8DrFStSDrBazlzH+PM0VnB535YlnLzk96kWCafIKLJizGSLRwoF7QwStLhp+0FZy6s7WVP og6ianUxsk58hMCwUQvUIz8g44cb72KDErRNuces+XkO4GVOSCb7B/KjM8cXpgJ0z0NGEp D/S9cY2ISA6lcgMHyA9qBj38gJKxAFQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743691981; a=rsa-sha256; cv=none; b=LNZzPeSlhXK6BuNJTp2EeurngFU0Tyh3GWR8uNR1lu5tFE9fHT7bBKjfarXXeqNLRsb0aP bH2MWQay3at9jvjD3boa4heW+lCMqoRnkYztI8MS41VCy1ktw2I6E424ISBUf+/haz0Eyr hut623C/oBSEsmZelw3PRAq68g6iFJM= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=TtSQ5GdK; spf=pass (imf11.hostedemail.com: domain of 3zKDuZwYKCA87tp2yrv33v0t.r310x29C-11zAprz.36v@flex--seanjc.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=3zKDuZwYKCA87tp2yrv33v0t.r310x29C-11zAprz.36v@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-22651aca434so11037085ad.1 for ; Thu, 03 Apr 2025 07:53:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1743691980; x=1744296780; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=lAYnbFZKyAbKvQrvS445eKEFXwY5377UYiGWqzU8Erc=; b=TtSQ5GdKUcFAOmBihFAji1Veh1DSSVYRM0W2S1Nc8V7eAhLc3ncDKJdCAExPLK8m/z jIJr0f7t+2lNNaJ/p5GQvZ9ssxp+gLK7A/bWKLRqeNPke5K8wepPzCp/9o0+98tL4InX z/h/P43S9dWzG0sNfw7MZ9i4DtoO5NiHEIeBxvCMSjTlcZVJTYthJX5iMvN/XwNS++Aw LSxTrdDsWpMSrkbSSFXiR3ebcK8KNZvpoC+JPxLdCLKj6nh6xyYAWpMKyronxg9H9fcZ h3S3vi6ZWowVyco8E08P8J+y8FueGnZAKNqG0WsvV2I5uyFvHZa6YRxYRQhWbUywAqET dk5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743691980; x=1744296780; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lAYnbFZKyAbKvQrvS445eKEFXwY5377UYiGWqzU8Erc=; b=MUrGXTPIraiLbWF/l4y9JEnupqVNTUbEBjQlLFYpxPn8mxLhkEeGmPwHIJkYlvjOKA MtaKLh0oPiT43bOea5jxue6ug1FTULm+7kKG6fAI2LuBYsXplkoXHY934FYgvSOOO4oR dUIbNpdi9hKBB1ayshM5KCM9BFSgzzWQR7AfhtuKr0XjJUH4OG0/od/vWkhUZocFQehF yaz2MKeWM22l4HTSf8cdXbqnlvluxF0cz8vAr3lEif4XgROsDw+SeKXOQofyr07aLhDu Am2GWR+GgmNiLw/AwnYf2zHxTzybQIdaHN1yasN/AxM83GypbnIaItnNQGpCO7mbaLW4 m7wQ== X-Forwarded-Encrypted: i=1; AJvYcCUH01j+0UpfHloDocR4Hg2zVAnVcARzP17Vui6d2CxEQMMigkp53QA2PbmZy3OhK0p+KatIMk/iUg==@kvack.org X-Gm-Message-State: AOJu0Yy6ON94uKkR+xW8izUZ6Yaq3o/IxSy9uW+4qaVmxaWICn2Q0FN1 f4BIZUWicyOfOeljrRzUvYsHSKoqDEOg4brRNpSq2+nmU/CVLoZmTLtXIK9SY2ecvWJmgTvqNl/ S5g== X-Google-Smtp-Source: AGHT+IEwHAV0IdPXJuTi1AWuTFEvm067MrqutP5JF2wd5KRJr1f+gjc9bNyas3if7P/Pkfz/DaoRj5MNF4I= X-Received: from pfbif12.prod.google.com ([2002:a05:6a00:8b0c:b0:736:38eb:5860]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:e549:b0:223:4bd6:3863 with SMTP id d9443c01a7336-2292f944b79mr343506635ad.10.1743691980164; Thu, 03 Apr 2025 07:53:00 -0700 (PDT) Date: Thu, 3 Apr 2025 07:52:58 -0700 In-Reply-To: Mime-Version: 1.0 References: <20250328153133.3504118-1-tabba@google.com> <20250328153133.3504118-5-tabba@google.com> Message-ID: Subject: Re: [PATCH v7 4/7] KVM: guest_memfd: Folio sharing states and functions that manage their transition From: Sean Christopherson To: Fuad Tabba Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com Content-Type: text/plain; charset="us-ascii" X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 647174000E X-Stat-Signature: rnzhja1jm9n641j483rstbq58hh8utyu X-HE-Tag: 1743691981-641511 X-HE-Meta: U2FsdGVkX18r0drsQNOvRdkMhoLVfcCNIluBRdSyzusT+CGLObkwPdmeiL5jH9iitgoq3509P3/nGanIkdiQbZzafiLm4mv+G43msD97CIOOPA4cTSBNAkym5phP66I4Jbvdao7Ho7NgOF2U5BW63PtTxwwzI4aSGuQq7g9c7I/ZoFkWl4qKRgeQCydiMN/+keKmlZXykqBr/AkGJAKB4kdpMc3S5EA7WxLx6CwHPIouaMl0g/7AHu2qmwDHkdFSGdRL9TtvQfeBLVJPnFQXWD7RlHyGjAtwmW4JoZgnQapHDDxwkLO80YvSH6YS7U+fJ9JlKkpBcUJRXEXfVFxKF03XAWTybcaA+IW8p06H8+pfc/sZqgY3YsuXmHDECmFUCzaRJaXSKf62mIvK5ZtqH89MojFycQA53C3z76bbQ/qWaSaNTyf/YBI1nx4SpsxkWSuoBScTe+UArxtYnIvGaWekFKhvRbwBX28ET39t0hCRa5mTuwVPAa1Jqk0+5oFjUNBGiByqCQPWoZvW9OxiPAGSdOY7CPt3EbF3gSyyjKMwnWuv3H9ETTG0p7up9Rhb9OFiHYvyf2JQ/W4t4od530QD3l3mNphbkjdcb2+2QJdvqfuuRbaRvI37VSdHO7UT91cHr7g60RE+qjpVUGlI3NQlbQCNg3WATPLEjRkho9Uiijcg0JjwQ6n7FMF1HRBPVAnw4632uPjpIgM8Jx3IvDlJC+b72ofuYzxtXIslj7kzEugF3YQknr7cRzFVPO7exBxC3N8uOVIBtgtkarF3IdOvl+tJv54zgTDGWLeT3Ehl2TXIdwdNvUgiO6mo+zGmMmHI5qB8p892rPvxdPtB3i7nZv32FKbnkDM7M+F0g4RIxpyibO5eOmdH6Wq9DVIGI6gx6ByRPRTtMCfEQhW7FUmOVQqJxMOvuZ3lcULoN8XXnSUvgqmqvcAMz2y9QcmDtSITIVXTrAB49bDAgT6 q9XNripG lFaIAt/Qar25H/j+YOQ43lWCvDE2wfyypx8h5cNzF3R3XWnj+USddWymnWsf4eUdy7iNHerYukyq5exHEi3gKN7EsjeiFCBJifk4s6dzZalCJGHBpx4NoRGErIPRc4KHkU5YwFvizZEWJy31XahcGNoEs+H8RPFqbsp0MA33YLIFrhUel/0KRrbPLbQdXIA7Dy6mGeZFdVTvrvKXxj6QB3/7zGLAJI/UvKu4yMLD490yrS8G3ME0u5DpmXrpqGfWQ2V7T8lXnO412YR5Xvna8VYNqG9Un1Lt9a9srKJKM6FHTUIQI+3WDrfizXFJ88En8Qeb4EbvUN2SnpXGP1aZfKhKrm/KIl64ix4oY4wGqt3QhTfLU06pGz06A9c6oiywykkpcE5fWyfi6TthlJYoIW1t1On8YHBCkf7x9xwidhxOb5ZHJkTbq31fXN/xLiKmIBQWuP/L4dafQZKMDhv7BLzpV3TPvVWMjDOBChnUq7cbfu0fspiMjRSzEtTUdNFQuUif0+6TRASzf+3t1MjC4uuSC556Pg/Z6amF+a/lsBcepf5W3NGVWdBmAbdHWn4Xzwip2BTRala90jRmifZOJxfMXVb/7GubAHTK1ViC4lUxljfxXQAI9guzQWOG4TwYJR6lnNppuOIs27tSWz14KJy+L/bYgDhpJ2ulc0XpOcfLQKw2/DHc4Cr8tWPAVJG6cX+61 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 03, 2025, Fuad Tabba wrote: > Hi Sean, > > On Thu, 3 Apr 2025 at 01:19, Sean Christopherson wrote: > > > > On Fri, Mar 28, 2025, Fuad Tabba wrote: > > > @@ -389,22 +381,211 @@ static void kvm_gmem_init_mount(void) > > > } > > > > > > #ifdef CONFIG_KVM_GMEM_SHARED_MEM > > > -static bool kvm_gmem_offset_is_shared(struct file *file, pgoff_t index) > > > +/* > > > + * An enum of the valid folio sharing states: > > > + * Bit 0: set if not shared with the guest (guest cannot fault it in) > > > + * Bit 1: set if not shared with the host (host cannot fault it in) > > > + */ > > > +enum folio_shareability { > > > + KVM_GMEM_ALL_SHARED = 0b00, /* Shared with the host and the guest. */ > > > + KVM_GMEM_GUEST_SHARED = 0b10, /* Shared only with the guest. */ > > > + KVM_GMEM_NONE_SHARED = 0b11, /* Not shared, transient state. */ > > > > Absolutely not. The proper way to define bitmasks is to use BIT(xxx). Based on > > past discussions, I suspect you went this route so that the most common value > > is '0' to avoid extra, but that should be an implementation detail buried deep > > in the low level xarray handling, not a > > > > The name is also bizarre and confusing. To map memory into the guest as private, > > it needs to be in KVM_GMEM_GUEST_SHARED. That's completely unworkable. > > Of course, it's not at all obvious that you're actually trying to create a bitmask. > > The above looks like an inverted bitmask, but then it's used as if the values don't > > matter. > > > > return (r == KVM_GMEM_ALL_SHARED || r == KVM_GMEM_GUEST_SHARED); > > Ack. > > > Given that I can't think of a sane use case for allowing guest_memfd to be mapped > > into the host but not the guest (modulo temporary demand paging scenarios), I > > think all we need is: > > > > KVM_GMEM_SHARED = BIT(0), > > KVM_GMEM_INVALID = BIT(1), > > We need the third state for the transient case, i.e., when a page is > transitioning from being shared with the host to going back to > private, in order to ensure that neither the guest nor the host can > install a mapping/fault it in. But I see your point. That's KVM_GMEM_INVALID. Translating to what you had: KVM_GMEM_ALL_SHARED = KVM_GMEM_SHARED KVM_GMEM_GUEST_SHARED = 0 KVM_GMEM_NONE_SHARED = KVM_GMEM_INVALID