From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66A31C35FFC for ; Tue, 25 Mar 2025 14:25:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A8B5280003; Tue, 25 Mar 2025 10:25:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2584D280001; Tue, 25 Mar 2025 10:25:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FA7B280003; Tue, 25 Mar 2025 10:25:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DE0D0280001 for ; Tue, 25 Mar 2025 10:25:18 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 338021202DA for ; Tue, 25 Mar 2025 14:25:19 +0000 (UTC) X-FDA: 83260295958.07.FB5970C Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf07.hostedemail.com (Postfix) with ESMTP id 731E040006 for ; Tue, 25 Mar 2025 14:25:17 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RMmooDw5; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of frederic@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=frederic@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742912717; a=rsa-sha256; cv=none; b=kDT77t6d4IEVDro5pYL45Q3RHb2nv/iBXBoYIi85x7p1/M+Btpkn8l/eb2DJQkXmJ2HN5/ jQW7wdGibfMhY2Lq2e/dFGxuci5V2XKyxG1Pczk9xmXOjfTv68lca7iVKVdpf6sHtAflpr ZDqIfPnBe9eJZChWkgIU206G/jiRKXU= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RMmooDw5; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of frederic@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=frederic@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742912717; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2omKjx6bbVxx5cOu56BL2peTOTMnC5E5F1S7wwxwruY=; b=zov9BkIe8B9PdnZegjY3rHwg5FaxRQ0usXLGaKKF5TJi2ucH9IIH5LSI0tgXSw62EPVGgr JwH927WslmpHTJr2PqAIErF41j4wKTzbgnL0CyehVGOUFPmtcDWoPAMd9nVEJ9xRb/tJcO ZLv/s6HEaZM/PigXFAI6+ekY6LQYw/E= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id D4F26436B2; Tue, 25 Mar 2025 14:25:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8283FC4CEE4; Tue, 25 Mar 2025 14:25:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742912716; bh=N0kygDs2Nv9MG/KsCxyOCnV3RH+/UvpzkwPqB1CVxzs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RMmooDw5GZoigLUeg+ulTTHhGAJEU9UKr8r+OG0g/sWCBCH09UBi0up8Ovf9xML11 v+ygrEI8DtiyhB3lXFPq/awkQjeovrskcLvsWpaPlmZ9Mu8HjpnndWRUenp9R5DSX0 qMkedVjcecKnwfJnUK+4si0B1s8z/fwZL3l5myyfQL5ms0UambAaRGfERKQ+DcwQdI K+MDwjnLy9KWsRgUwAly82RLuub/6m0lYalj3Qwgx97vyYGSf1JPiKYSSbZcrdmtTT NCPaS4C1SLT1M7v9p0mwatzkcRgz8WrHOPvfD77fA32pyU9mRAxUphcSu9eum7r+57 SPCpDxuatyaow== Date: Tue, 25 Mar 2025 15:25:13 +0100 From: Frederic Weisbecker To: Oleg Nesterov Cc: LKML , Peter Zijlstra , Ingo Molnar , Valentin Schneider , Marcelo Tosatti , Vlastimil Babka , Andrew Morton , Michal Hocko , Thomas Gleixner , linux-mm@kvack.org Subject: Re: [PATCH 1/6 v2] task_work: Provide means to check if a work is queued Message-ID: References: <20250209223005.11519-1-frederic@kernel.org> <20250209223005.11519-2-frederic@kernel.org> <20250210124340.GD32480@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250210124340.GD32480@redhat.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 731E040006 X-Stat-Signature: nnxkjyrm1msim9n6kw6t9r6mdebyf1zz X-Rspam-User: X-HE-Tag: 1742912717-221885 X-HE-Meta: U2FsdGVkX192zt/piMhhJH/gZsiH6D/L03uvA45k1b9SNGFp3egaKmHcIMrri9Qh0b+0UkPJVhgXYmz0rFQOaBiMf9GHG0TopwcozA2cISw7mhHBaxdE7QGZ+VCoMh1IMDgwTowqcEpad+vaUiZMRoxRtuJnDSkJX6+2SgGGzaL1C0PhRXTZHMdeUE4XR58EhLMRPGuimS4RwYCyZKi6C349Lm4fmwIFdviXsTvPSjTwNbYItyAdskZjsn5NMV2agGcZ3l/rPtwGWtWEKmHoTCeNiqlM3xviaCckRbtctIUzVk/hB8ZIb6Py7QNWVT7wVDKLc370jFxaySH6ENZat+lGBGuPdTtSXmMJWYrt3g2NR8wWQcCOZerQsjxOEYgTVNmQ4SD9fmgnJfrO6nE7G6RxnHZwLiKlmlNEZ/RbEYdBbyTp8LA2R4N3hN0GSiam9e8AaH4Fp2IEopPFcycOwiWZWOliltpPXjJ4Jkfw5UVck21gs2HCnpTn3ZNkdWyqkqFSfzkSdFdWXLT/qVjMB06ekzFdADaSsnY+AmIBO2XRyd19QRGXO6eg5z/FZS8d6x5TOHoCNdJ9SuzS8Ox4g/FCMx9QxT2PXnDoXheQQAgzbeIX7wDEB3iGKBgt+WJMumd9UsQlSbOAwIEVI5oyWHpnWxYjE3G5PLTd1BR41LS1cdxYzOvUnzBob2u9gUNgzs4wriAXteoLtvL3BSaprjBUy52ZstkbfDLr2/KQC9SWVJlfipZd9sVC69XNCgwTv2uOBBXwPXcX+xtG9B//LF/qJ1C54zi5yPHsCMwKhJKNusdaSShGlHFqgfyoY3BDKmot2wc58VfXiVbQHw83XNsiut9sbqc2Wf6SGy3lO1/qUIrgx2YzMeAU8XUHhcUGUPSO/oNRZTW2SiDWU4Z4n1sQt8CdNEu9CgGIkpXzEPCT6BSA9AkdvLkHrOpf6DX0bFSoNxTmX7nI65OnFzG aQmyXYVU GRiYG1K7GpQGGEQRfKINTXXscyb1SBNTBY0JsfA7XCUIiy9rl6tE1+9V1JCCAo9s5CmiP0nRYW+ogQVqvvoOTrJmWBxGMF3hYVjddfkKvB0pFbWHI2rjv8n/uYaG51Y9xFXus4BvgNX5jOr9SWmrpj4WQ5V/p0bcFU3fWBu2gnup4XZ8Znee0PYT3VW2KDS/NLNZXJEslfsiqWWYA0dwJsUe4p1jHjGiz95fEQLhj39p1tHa7UGEauDxK8t7e8iX7E47nqZeGHiiNwFYz6VhyjcIaP59HnOguu1rjuTcKUMdkelLKKQrwCeGzGjT0cYaSYA1qlI1qU155QpwkI+6/5dIanA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Le Mon, Feb 10, 2025 at 01:43:41PM +0100, Oleg Nesterov a écrit : > On 02/09, Frederic Weisbecker wrote: > > > > @@ -56,6 +56,8 @@ int task_work_add(struct task_struct *task, struct callback_head *work, > > { > > struct callback_head *head; > > > > + work->next = TASK_WORK_DEQUEUED; > > Do we really need to do this at the start of task_work_add() ? > > If the caller didn't do init_task_work() before and task_work_add() > returns -EINVAL we probably do not care? Yes good point. Let me fix that... > > Reviewed-by: Oleg Nesterov >