From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4F4EC3600B for ; Thu, 27 Mar 2025 10:49:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FCB62800DD; Thu, 27 Mar 2025 06:49:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 884612800DB; Thu, 27 Mar 2025 06:49:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7255C2800DD; Thu, 27 Mar 2025 06:49:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 530972800DB for ; Thu, 27 Mar 2025 06:49:40 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AFE3C56E42 for ; Thu, 27 Mar 2025 10:49:40 +0000 (UTC) X-FDA: 83267010120.01.1EC8ACE Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf15.hostedemail.com (Postfix) with ESMTP id 6A85CA0005 for ; Thu, 27 Mar 2025 10:49:38 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=CKdrdXBe; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="kYIX/XN0"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=CKdrdXBe; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="kYIX/XN0"; spf=pass (imf15.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743072578; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zoUJssoAdrvJqWgjZFCmV+8e3DtgaI0aJxl0KKpj6HM=; b=AYSrIRQWRHHtWLjWgJQc1fMP5K3+IMuOXHasHIAgUzEdQGOyrDhuKFYIRWS1k/fpn5xshK /6ocvhHxKlVA5t4gWO1Nu0nCm6BDtLejdmaJ5Pio1AwYDY/3s66gtO2N9t5DGSBnq2U5sJ DaHHGyDob2VX6onM7Jd8RoRTSPSdepg= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=CKdrdXBe; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="kYIX/XN0"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=CKdrdXBe; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="kYIX/XN0"; spf=pass (imf15.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743072578; a=rsa-sha256; cv=none; b=HdmZ8TulL1QTnugb7uxzxs35xuXSPfvq2+O1fmJlWaGY3HPgTVhoGFZmBAEKBotRnAsZnD gckrwLf0wsdENSus2yROAVxrDyqm7nwrluXXjPncmwUhFT8FoSb/SMHAW/JTV2kotgkHvO vMGvNB0wjguANCIqa2EzHeGIQbG4txI= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 994052118F; Thu, 27 Mar 2025 10:49:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743072576; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zoUJssoAdrvJqWgjZFCmV+8e3DtgaI0aJxl0KKpj6HM=; b=CKdrdXBeuKC5pYXqiD4CspdJUO9MJd4q+LdpQAyzshpCKMWIpIsxJu2fx4BNXLxZ7g3IaP HfY6uJzr8XfkTne9zw/DloPb2t3/uQ3mHyKoUlJZhX1oUjRCTIYEqTFE9NqF+txg17j17J sfAVyK8djuaM80D/w1fueR5Vt7z6990= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743072576; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zoUJssoAdrvJqWgjZFCmV+8e3DtgaI0aJxl0KKpj6HM=; b=kYIX/XN07hRZqeTrySQ3zv2ha7V/7iFcN7cKr3U+WRKkVOfQSjquIYmC41sgsbpYDRNB12 mhoUd80KUVV3zNAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743072576; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zoUJssoAdrvJqWgjZFCmV+8e3DtgaI0aJxl0KKpj6HM=; b=CKdrdXBeuKC5pYXqiD4CspdJUO9MJd4q+LdpQAyzshpCKMWIpIsxJu2fx4BNXLxZ7g3IaP HfY6uJzr8XfkTne9zw/DloPb2t3/uQ3mHyKoUlJZhX1oUjRCTIYEqTFE9NqF+txg17j17J sfAVyK8djuaM80D/w1fueR5Vt7z6990= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743072576; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zoUJssoAdrvJqWgjZFCmV+8e3DtgaI0aJxl0KKpj6HM=; b=kYIX/XN07hRZqeTrySQ3zv2ha7V/7iFcN7cKr3U+WRKkVOfQSjquIYmC41sgsbpYDRNB12 mhoUd80KUVV3zNAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A7D8D139D4; Thu, 27 Mar 2025 10:49:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 3wgIIT4t5WcBHAAAD6G6ig (envelope-from ); Thu, 27 Mar 2025 10:49:34 +0000 Date: Thu, 27 Mar 2025 11:49:28 +0100 From: Oscar Salvador To: Baolin Wang Cc: akpm@linux-foundation.org, hughd@google.com, willy@infradead.org, david@redhat.com, 21cnbao@gmail.com, ryan.roberts@arm.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mm: mincore: use folio_pte_batch() to batch process large folios Message-ID: References: <7ad05bc9299de5d954fb21a2da57f46dd6ec59d0.1742960003.git.baolin.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7ad05bc9299de5d954fb21a2da57f46dd6ec59d0.1742960003.git.baolin.wang@linux.alibaba.com> X-Rspamd-Action: no action X-Rspamd-Queue-Id: 6A85CA0005 X-Stat-Signature: oz8i4g8iudeqgcfwkczi88zc366s7jap X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1743072578-34079 X-HE-Meta: U2FsdGVkX18r/ijObyBrECDWph3YpWZmece9eaJ6F/AEX+vliptjr4fisho0AfbbPyhnyBpaMtXVarANq/UgCrMSzXV+Uu6u1/95zZgxO8cpBBRMGHDH/QNJqZN6I21L/m8cX8UrA0fj5wy6SvHmueJ6yvKq5M9HiGGbgBMPyIRWXEWRI/IsSJFiVNtrzJ9jxZ1KCndNDLhIqLyh9ZMp14iGV7RSNkolqqHhgWoBVXiuA3//UFleA0XXzt5E4Kz++66uDubgnEShZKiSKkznznFRc8MflYNysMi8Pe7jFs42FkYeCQADiSX4Jdb6QEU9EWDNdrNhKsUZZzRHeAOB3ystlkEnKUzCgrXtdgK32MwtcTyMCwNXR45H9oQzsGuprmCpaBtVoAV1+LDNdMR1/wdCnoEQFi32MNOZyKa/X9oYF5aBdOKjl0dVHePJ+T6fhwNMIl0SXpk+n/qEOKX/La8lbDHVLdr69HOqfqgAsxrh3niUycL2NkMy7wmuH45fIdt19sKhE55GqcPRqFYOx7CVp4cVqsmVNyhDOha7sKIuT5LBbAojwPGuuTJE62xLxNjRKoVLqaNwpiVI2fl2diT2ilsQ2ANkAmFC1bSb5FRPLinFNAsw5G4JCEYQpaKOzeDkGXlcvDR8LC5HjiK84vOtTiMw/Tb8ZLvX0LS7qdJslAWzXzZ4n9CYJYHw7u7jnHN/JkYGHxEO7zGnxLRZ81AOc9X2gxuxjY2dxNZ8ls4uor6kM52QoYit0vd+UrsPXC7uH4c0FV0HI/4rDOLnlDLeh4IY40gDolBvmwY8cwi6CchGXSKqFuyP4eSVg4wRAUU1QhPDzuClU7t8oqcUn8IgAbDZa0UTrs4T2NjuKVSNmabmnWHVx9gawpso0kbQJOGFIOjSPG+GqFlehsUzmbb92Ai7CEsymM2opDprrwlLStqnxmS+AwTwgWtgXUN1iUvJnErPBjF/++Mlk2K vr7HVpRV OOh/74+mpUre+syfxoh8ReUI9lDPvKntTe6ApxRz5iBhuiIE47/j5P5oi9uxw2fek68pKm/jGeIBoCJA71V3teCGIuOAXRQxnVa9L9uR/jouctrhgRomuIzqCoiLTxNhFg7UXYVnMsRyWXPw3Tf3tok/+d7qFnLkUal8Lu/eE9n32gsLbLJEzQBQRQII8VdLa77C+1ngkWYpwrKEQ3fh3i0TI5+Wjtd3QHawmKr5ON54ce6S+RDZxrkOwEzDmhHRYCsjO38YMCzOO671bNxqomIO3MjEdVjAl1BNxNWFT1Pm+eSCdbbXO2wCk3A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000014, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 26, 2025 at 11:38:11AM +0800, Baolin Wang wrote: > @@ -118,16 +120,31 @@ static int mincore_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end, > walk->action = ACTION_AGAIN; > return 0; > } > - for (; addr != end; ptep++, addr += PAGE_SIZE) { > + for (; addr != end; ptep += step, addr += step * PAGE_SIZE) { > pte_t pte = ptep_get(ptep); > > + step = 1; > /* We need to do cache lookup too for pte markers */ > if (pte_none_mostly(pte)) > __mincore_unmapped_range(addr, addr + PAGE_SIZE, > vma, vec); > - else if (pte_present(pte)) > - *vec = 1; > - else { /* pte is a swap entry */ > + else if (pte_present(pte)) { > + if (pte_batch_hint(ptep, pte) > 1) { AFAIU, you will only batch if the CONT_PTE is set, but that is only true for arm64, and so we lose the ability to batch in e.g: x86 when we have contiguous entries, right? So why not have folio_pte_batch take care of it directly without involving pte_batch_hint here? -- Oscar Salvador SUSE Labs