From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 365F6C36010 for ; Thu, 27 Mar 2025 13:06:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D61D2800ED; Thu, 27 Mar 2025 09:06:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 685A72800C9; Thu, 27 Mar 2025 09:06:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 527552800ED; Thu, 27 Mar 2025 09:06:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 349652800C9 for ; Thu, 27 Mar 2025 09:06:47 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id BDB891A0D14 for ; Thu, 27 Mar 2025 13:06:47 +0000 (UTC) X-FDA: 83267355654.26.78D40E1 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by imf25.hostedemail.com (Postfix) with ESMTP id 1A469A002A for ; Thu, 27 Mar 2025 13:06:44 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="lL7Plz/F"; spf=pass (imf25.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.41 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743080805; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FHYabRsisvvewRt2ZD66z6lVds8DGMm4+9hPyYbZNl0=; b=ZBqKtvJFYVaQOOF95fOR0tMACsjCD9P07eyR7mNffNSi9rjjSxGK1jKggRiYziaK4fym2V EM2Ej9cBTLXe29OstLr0tbOdgEQioZPOuZMKVOPylwTTZHNbeN4/Jj/YnluHVTESuzw1OP 4VcoJo2FbJ3A7SM+urCjBku/8BnmFVA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="lL7Plz/F"; spf=pass (imf25.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.41 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743080805; a=rsa-sha256; cv=none; b=eT40su650LRz8GLuOpek5NZH2X6OPY64qHU5OnfGnltG6LlC8aadBEl48pETycuS7soacI yKEUEqxTGhyLk+Vy1h0kfNyhMp6uXdFT2H+OIEjBAvlvDoj/ss6PRWu+iM4HnKn+L6LC2Q AY6qbb60C7HKGHG1YCig+ayXkId8XXc= Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-5495c1e1b63so1132160e87.0 for ; Thu, 27 Mar 2025 06:06:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743080802; x=1743685602; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=FHYabRsisvvewRt2ZD66z6lVds8DGMm4+9hPyYbZNl0=; b=lL7Plz/FHrBxJqIBGp1ylVFv0ZNWf7HYyHWjguffjpTnnj/udixUDgSdlHa43yLiRD uZFXl7ywABy6XamqJ/FVedOn3xjDg9fyflFj2t9mdsJnLUcoUW/8nuDPfPEYagsbXjK6 z8iQ7iTn0W/HEu8MQmdTlOf1u/Te8jirO0+8FZHsjVTezsPXKH9S+6Vtd0TXRGqwEj8j UXUpJ1kwDFpDc9sPnAhEPWSJE5qKgqBkLfcxX6MhAeyAl2qZGxDMlpDrpqf8FE1a+rdR nuzqpPSxO6ONWo65ClwoY7kVAoDgIZ02aPew5MXkEhK1+32BKrVbSQKKCWAZQSlgMdbL qdRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743080802; x=1743685602; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FHYabRsisvvewRt2ZD66z6lVds8DGMm4+9hPyYbZNl0=; b=fgxNBneMKbb5jvksMXiUoSWeWBVgzqgb66bGPI2DwvTegTVn422fPnW3MiJvaTHv+j KUblaXRiq5p1R6zi9EO9i+CnqJcFP7ykEoOMX4LbPI//bXh0K/Bg44dxotN/3rghjupp Fk49zbA5aYBR2hZYc426GQtwXKWhm4tQxTPgC48N8Cxb5yk1QJ9l8SCELb7eUA9SP/Mv 2WRFLS/70unQBv9vACsbhmnG1SKFRIxQkpMuC3KnM/fuSxYXHQWcqg/SJ1XxECbWtV+8 wlppoln6jEgCuJNOf/c0LScgXbENeJ3kPAQBp9WsH1UG5X5DXIWEaOj6BMCuxBG9DkhG RB4g== X-Forwarded-Encrypted: i=1; AJvYcCV72ngMPpCTVk5KeR64pz0aHQ8h13vGTxqAFLoWYwsW5IgdFlrRWKaozpdybwkPutFHl2+hzvSe5w==@kvack.org X-Gm-Message-State: AOJu0YxcSZ5A3NlC1DjCWkPvlEm7ZU+7VkJOlerBf88NE5RmJqgOUXNm ENcQAD0Mo0ioyMk+3R0jNm3X6BkTvza/IeZx1VwAL4rEaFfxmXOy X-Gm-Gg: ASbGncsTzx/Y0FMkhC1M3COW5KXkSBObL0MliCiGLxLodfYsGloc1tqRV1U6SOfV+1V jhcg84ywuB1htlekMPteExwWGRs1TSJtH3JcAXB7o8PpHa/NKiZSeFdLZ+Gb+gr9uHf307erYf5 ipM22G0VEsDD4taMsPkIiVsiUg4T8QNR8k8nEuhClHHFYfMtriMLwKlupv9Sg5wmlBsxQgda3RJ sa4hnDhE1ZaEZlAN5WtQglR1i3tKDAx4m7cGuox1DG4/2D46rEasT8xdpvgM9lAjGStvKdWzlr4 eC0IusZzgqbckn4kO9mzO/Kz/q2hQU6T/7KuOq4tDtVFb997WCPOyCaajq6u5XWCPFGc5js3MdX pybBQB6cHKg== X-Google-Smtp-Source: AGHT+IEB1d2bV5NS2rf4YoT3EEb4ni6FZp7FQwziYXT+SNnYH748LFh1OTLu3uPDrh6+0Lc5RrqrBg== X-Received: by 2002:a05:6512:1393:b0:549:9044:94a9 with SMTP id 2adb3069b0e04-54b011dd142mr1232153e87.25.1743080802331; Thu, 27 Mar 2025 06:06:42 -0700 (PDT) Received: from pc636 (host-90-233-221-122.mobileonline.telia.com. [90.233.221.122]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54ad647c98dsm2088697e87.67.2025.03.27.06.06.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Mar 2025 06:06:41 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 27 Mar 2025 14:06:39 +0100 To: Ryan Roberts Cc: Catalin Marinas , Will Deacon , Pasha Tatashin , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , David Hildenbrand , "Matthew Wilcox (Oracle)" , Mark Rutland , Anshuman Khandual , Alexandre Ghiti , Kevin Brodsky , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 10/11] mm/vmalloc: Enter lazy mmu mode while manipulating vmalloc ptes Message-ID: References: <20250304150444.3788920-1-ryan.roberts@arm.com> <20250304150444.3788920-11-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250304150444.3788920-11-ryan.roberts@arm.com> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 1A469A002A X-Stat-Signature: t7wmi8zunu5gyzaebpq9fggbmf69cw6y X-HE-Tag: 1743080804-294757 X-HE-Meta: U2FsdGVkX1+9KoEBb3moM7uV40GgSGUMHcMeqJSNXYh5mGe/KsinqrnwG3EKXh+oUcSZ9DQQ1g6rAgAhm5M0n3OVMgTH0KGyjgiyiFtHSxFmCWyL7T/LCPOMJbxD38LOrYEHAVLR+IdODsfdpvjtMGqpIZFbwXdJa9OWvc8LuKd9YfO2w0V/U8oXoSpX0QmyIC0h8096y1XTCSbbSkLUDMO8ucHTQB6ajdAtJ12F2cY8bkTylVqDvkXJof2dlSrJwwq0VyHcgYmpfm7GSR0jE7DMewUJckOWlDEty90qcbxIa9BHjFDEYkTlA222MCXsxf5l7yCb3ycT9oe9LYAfTdjIkxLBP2/ZbD1pGca9HuVNrazrpdNwu0wcuY5qW4Luh7Uj6srt3QxgpomIiDEUoCV3wRv7W50bb6U7BUEyddfb/if/mmQ5UuKWl6Kq++hMEuA+WhEpmBLRllbdi6kntIEiY2Me5JP9pEA1RGLpI+7O96EXjC2HwPj8LflL2ZtM+0KJhogl/uJoGq/JhAlXn4+H+J059Ldw6BDRQLRetvu1dTCKBXtlGEKIN1P3EIP5zybWfos3mZOFni+m3udkRqBFTpPynkvf+CjbG8saPsd2OozvLZwySFNMNYwJa//w1GnLlL//W8jWvYL8zrnc3LVHYHdiibibVvuq2w71Nnln3kKlJGrrjd3ckygGDcROWaZy0imict46w9RKSVdy+paMp2+CKYEPwpZMIIuvmW9ORzZyi6rMlxdG3QSGm9+itpE7HRFUVW1Q52u1EN0XyB1NNxDorgCv93mMloVWMPJgEqyMBx5d7hzUBFsV0lDeLbgTyIpws6JZE0CCjxEdWUB9n/fNHB4cvRZtsiCuPFgAVTRpDj3flWYcpsvuBEZFr4sOYNCpz0PpYt/LAC2LAzPiqX1DvD23GltCLk6388iciqRNh8ygA7aKjIOElKyTCllLdGdRjhNjo2a79hv KgfZ/dcX rUobXFJi2eFdDXXZcoPZo8ze69OehKkjjlS8ohWW9lKfMvZhF/UzvL2dM0WcYEsfDGlVv1ML108+jU9qyi/1qmhUScOXZKyuTpJnVKUiPbicOAQkk2wMha6KmTUv4EqNkay9kprVDegkFJIRDawirUbpecsvVTcYdXCds2WM7NVTb9hVzSxN/m50GXGQP9Z/H2hPhBZJWPaBIgyr6voWXApCM4yLcdeMTVuqwuiMFK9Q2y1TGO5oUyJ8SQpmXtJADhVki8k1O7+MUd+CIrI6+shpzJVt32KhHQbHXGCq5Zz4gc+kroE8+gzHhkgsiA8B2RjqLMSDlxE0Khp+DIoOkLympfuv9k0XIliETEuoFGKoLgPm1UTOa274cLaRJO9MSExsDfhJpEr6xlsnV2qXp0jjXpi+HAdLJhI4eEusbVqw6KbOykC4FRANmmv4NzNBwMzC4trJT58yw89PCEFDV+OC0G9uMRYfUO1VP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 04, 2025 at 03:04:40PM +0000, Ryan Roberts wrote: > Wrap vmalloc's pte table manipulation loops with > arch_enter_lazy_mmu_mode() / arch_leave_lazy_mmu_mode(). This provides > the arch code with the opportunity to optimize the pte manipulations. > > Note that vmap_pfn() already uses lazy mmu mode since it delegates to > apply_to_page_range() which enters lazy mmu mode for both user and > kernel mappings. > > These hooks will shortly be used by arm64 to improve vmalloc > performance. > > Signed-off-by: Ryan Roberts > --- > mm/vmalloc.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 6111ce900ec4..b63ca0b7dd40 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -104,6 +104,9 @@ static int vmap_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end, > pte = pte_alloc_kernel_track(pmd, addr, mask); > if (!pte) > return -ENOMEM; > + > + arch_enter_lazy_mmu_mode(); > + > do { > if (unlikely(!pte_none(ptep_get(pte)))) { > if (pfn_valid(pfn)) { > @@ -127,6 +130,8 @@ static int vmap_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end, > set_pte_at(&init_mm, addr, pte, pfn_pte(pfn, prot)); > pfn++; > } while (pte += PFN_DOWN(size), addr += size, addr != end); > + > + arch_leave_lazy_mmu_mode(); > *mask |= PGTBL_PTE_MODIFIED; > return 0; > } > @@ -354,6 +359,8 @@ static void vunmap_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end, > unsigned long size = PAGE_SIZE; > > pte = pte_offset_kernel(pmd, addr); > + arch_enter_lazy_mmu_mode(); > + > do { > #ifdef CONFIG_HUGETLB_PAGE > size = arch_vmap_pte_range_unmap_size(addr, pte); > @@ -370,6 +377,8 @@ static void vunmap_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end, > ptent = ptep_get_and_clear(&init_mm, addr, pte); > WARN_ON(!pte_none(ptent) && !pte_present(ptent)); > } while (pte += (size >> PAGE_SHIFT), addr += size, addr != end); > + > + arch_leave_lazy_mmu_mode(); > *mask |= PGTBL_PTE_MODIFIED; > } > > @@ -515,6 +524,9 @@ static int vmap_pages_pte_range(pmd_t *pmd, unsigned long addr, > pte = pte_alloc_kernel_track(pmd, addr, mask); > if (!pte) > return -ENOMEM; > + > + arch_enter_lazy_mmu_mode(); > + > do { > struct page *page = pages[*nr]; > > @@ -528,6 +540,8 @@ static int vmap_pages_pte_range(pmd_t *pmd, unsigned long addr, > set_pte_at(&init_mm, addr, pte, mk_pte(page, prot)); > (*nr)++; > } while (pte++, addr += PAGE_SIZE, addr != end); > + > + arch_leave_lazy_mmu_mode(); > *mask |= PGTBL_PTE_MODIFIED; > return 0; > } > -- > 2.43.0 > Reviewed-by: Uladzislau Rezki (Sony) -- Uladzislau Rezki