From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D87DC36010 for ; Fri, 4 Apr 2025 13:40:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 459CA6B0010; Fri, 4 Apr 2025 09:40:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 409156B0011; Fri, 4 Apr 2025 09:40:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31C856B0023; Fri, 4 Apr 2025 09:40:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1398E6B0010 for ; Fri, 4 Apr 2025 09:40:25 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5A4D0A9A46 for ; Fri, 4 Apr 2025 13:40:25 +0000 (UTC) X-FDA: 83296470810.10.5AB4F3C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id C509016000D for ; Fri, 4 Apr 2025 13:40:22 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Dwd9ER4f; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743774023; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pImUKw3M0PMcHdkWuYJ7D8sB/fzB+idx0s4djWcXKZQ=; b=taZ4ukxeNfS16emkYMDFruvcEMgli3FRci71epE8blCknR7UTauEFyHFUIqaBeDAq3jBWp ppifD3qEiLT97WwvTuNV8J+llSw6IDCXQfRFUea5pryihXwvIwKPtiIFT7SHC0hCytlkSN HxkZFw6aJbvDRFbxt8fU29gEJZkoguk= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Dwd9ER4f; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743774023; a=rsa-sha256; cv=none; b=DQBgfniJ7VMIBooY4LJxy5dD0txiaZubK1Ohs19EnLwf3X5zF/uCcbxuklQDRJ9qGnY/69 sItdQ8K/4dMC50bXSOi2UlKnY2WfkF+USD7p9fQSEq5mq9szHEyJw0sYj9f3fpzV58fGjA 8uhO05iQn4rSADAit6LDeQPXEJ9h06g= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pImUKw3M0PMcHdkWuYJ7D8sB/fzB+idx0s4djWcXKZQ=; b=Dwd9ER4f9M//fOrC7g8V+L/B+J wh7pwfrTC+243uBCbeTuappR+0W/kdLGj4rQvO3Iq2eL00rYyvCzQ4hra5f0vDgWoc/ezq2TJDHtQ ts5X0W3naA/uWGIvQA5dI6M7HlMJfS+cwtSV8k4GJhP1DzS1D1ekIss18q2w/i5OjepMZXcyvQ1Gq SNZucgzw+6AcKP23JEOQGgmxpPXHjBJOdnXbp8mocTBIlzsUzrakuoK0l5ghv2xfioCG7/mIiKD1M is3sFX1TIj63rFoHvSew0p8JWNvt32zBLfmy+NvPRi5iSqIi1HbZExLb9aoeuaf7rujMHNefCyY/5 WZonuwjw==; Received: from willy by casper.infradead.org with local (Exim 4.98.1 #2 (Red Hat Linux)) id 1u0hHP-0000000FZyo-3NRd; Fri, 04 Apr 2025 13:40:19 +0000 Date: Fri, 4 Apr 2025 14:40:19 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mm@kvack.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 6/9] i915: Use writeback_iter() Message-ID: References: <20250402150005.2309458-1-willy@infradead.org> <20250402150005.2309458-7-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C509016000D X-Stat-Signature: 6171pd4kehhyqp9dmwd3tecsc7epj96z X-HE-Tag: 1743774022-956891 X-HE-Meta: U2FsdGVkX1+69MUeLykjI7QVZXAjBSw0/lf2MH1Kit4FkKmojpSbJQqTv8Zl7ZpFlymHmXQgDb3xY+nXz3WTPLOoUVqZpIXwfYQBCbcTmdN9v6RSZHwd5o2JqyMpF/V/w56Kz0HY3voTimUoC2hOhvolMxbhIF6Zp8sT+cZgjaTWZxoY+1kj2y0gmz22aw3Tg/G40a73yO7HW4nltadpP43azHBdX+1UYB3CYTPntCY6CRldzPHomqR/7VNHp/pNQe4zMXVX/drF7n5RQp1wrrIzjMyXUasICwaqWs59KKcKTq6l7Pcfud9MGU+anMyeReUhlBxMBSpDAwIcq1nRx/DIavisSzC/VnstCf+YcpXM8Y90Eca6jfLV1btzwM5dp8YC95wBMnyPQADBGUv9nolVCSWoDE3ls2ypO4mjKAm3jlNHQ8Ja+KMQkhZlxWdr8VRX+thzG8pS45OLYMzsNP3Qp2nYTJcF5fsj2JzpFk3JFd6r5bbK/Z4IadZyNPLVSpNHfLOtVvJltexe9N6+EeSvVSCFaT4yHSdd+ybz2cbcEKlmSaMxtPdl5Yew35XKNVT4LCq49Sn3tBy+DHZ4gMC9KgHYgXirgt7pco9RwVkdICSb5RonrXjQQOn3KyJEMod8uQCNuFyTTFG6G/ZeLU7TvCNu1x3SzhoYvrFMSU3HD56EZcq/fqO/etTy+JyLtNYD6rsHDyuU7Ej6Mk67zRs2/TA7pA9RE1VaJkXaDsojI+uWJgOP7h9gKngIlXdBd0TxQzaytARnGKf858O+dpt5tjukKbHmbEFdK9/v8ApxADIbGbrKh4uQCzLX4PeN2bPhM4ygOxprKb+nH506n/DO1R2MsFczu1vxShox1HXdqQHYu63q83vjmgADwpM77Gap4XQILlWVSBY0VIAzOWCV8LNDDUoDXVaYVdt/TJMn3R4iQf+SITu+cXqYawEtg1AJRaPUBLS/SSj9hVs ysPTOD4W 8DNq9qPR9aKB7pxEdYWGrJCC3b5yGbwfRX0ZuqBXXlBbgr5dXWKAVDkzJUevlN8l7ikQyKVEKDKmDa+a0MMxkgNkoDZjYrzpOrWgPiqChAdiypQMPzNc7jx6KPrLDR8KyaLm2gzXZbT74K6KG97A3CZYXGehcSz+aI7z4PDAmA6RYSpZni9dGKI+/zWs22eKXsJhn2R6XlaOQsZkcfyjFxn8uSw4Hh1so65ZLXX1lM3hlOYR3jH9eucSRPUdR9L9Mo4WnVkJZfxw7q967k7vpQcWxLA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 04, 2025 at 01:26:29AM -0700, Christoph Hellwig wrote: > On Wed, Apr 02, 2025 at 04:00:00PM +0100, Matthew Wilcox (Oracle) wrote: > > Convert from an inefficient loop to the standard writeback iterator. > > Not for this patch but a follow on: we really need to improve the > abstraction for using shmem for driver a bit. Drivers implementing > their own writeback_iter based loop is a bad idea. Instead the > code here in __shmem_writeback and the similar version in ttm need to > be consolidated into a nicely abstracted highlevel API in shmem.c. > > Similarly for the mess these drivers cause by calling into the > write_begin and write_end aops. Yes, I agree, we need an API for "I want to use some pagable memory" that's almost certainly built on shmem but doesn't expose nearly as much of the innards of shmem as this does. I've been vaguely thinking about what that might look like ever since Darrick came up with xfile for xfs online scrub. The GPUs have similar requirements, so that's three users. I don't have anything concrete to talk about yet.