From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FAFCC36010 for ; Fri, 4 Apr 2025 13:51:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 29052280004; Fri, 4 Apr 2025 09:51:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 23DC0280003; Fri, 4 Apr 2025 09:51:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B887280004; Fri, 4 Apr 2025 09:51:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DE9D3280003 for ; Fri, 4 Apr 2025 09:51:02 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 354A71601F5 for ; Fri, 4 Apr 2025 13:51:04 +0000 (UTC) X-FDA: 83296497648.06.C629655 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id 896ED180002 for ; Fri, 4 Apr 2025 13:51:02 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YADbW3Qz; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743774662; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O1WYJ2sr778I+hZD/wg3UX/tFyzh0UfBLllp1RqHz6s=; b=rIU+GqtnlyaY9yuBd3U4wD8r18AfjHAIiOivS0LpWSfahoHGDZp+k11NjjuUEGhHCQTREv BYK/hSBC0ZGp5Q5MDvOpUHcZ78VCffYTJLL3WjZ0jMDnokbeGEBtoUNCOXUnekHGlITIlR wIyrPmv08Amy/0PnxJwqjSUjIC5PAOQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YADbW3Qz; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743774662; a=rsa-sha256; cv=none; b=0SBWdnPUI5AKOZwuz+xoOTOTESlFE1ZkDDHnEr5+0j+WxhM6BYmbHXBVwRSZv70tp+7j/Z JmP3SoMV/ogZJEialGM9mrD64omE44C3YXEjN/DmQ7OfIocaZfwTbkhVtluImx4LaJdANQ aaHBZF7xsiRt+HzvyqOqcHBLsXWp4uI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=O1WYJ2sr778I+hZD/wg3UX/tFyzh0UfBLllp1RqHz6s=; b=YADbW3Qz5gz3nayfM9I8rYwXAN Z8/PqwU372LC0QifYgvyycVjwtC6/+T7at1nbchVS6lHE/tmTCqwZzamS4jUMNpo333+vcKncDA/3 ip9VLU/B0callUb3Ws8KNCETQkyV3vKlo9C7UmhkIjrV7oQXdVJFj4zF+HGSFKXgTH0hs4zs3JZaf H6uCTNodocjSFI9GQZ4ofp4vXoVYViwqhlcabe9WB+hpXmBnY39OWJBG7bVJDpkLWLyqFCy/qhxS4 xl89n6iQhS5gwc5d8arN8aWVUAXkHdiI27FjKwCcpchPlvp2Ele4fhYRyAvMTTBsfWFQiQxskC1/D GFXRbuSw==; Received: from willy by casper.infradead.org with local (Exim 4.98.1 #2 (Red Hat Linux)) id 1u0hRh-0000000Fbbe-3KrQ; Fri, 04 Apr 2025 13:50:57 +0000 Date: Fri, 4 Apr 2025 14:50:57 +0100 From: Matthew Wilcox To: Vlastimil Babka Cc: Matt Fleming , adilger.kernel@dilger.ca, akpm@linux-foundation.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, luka.2016.cs@gmail.com, tytso@mit.edu, Barry Song , kernel-team@cloudflare.com, Miklos Szeredi , Amir Goldstein , Dave Chinner , Qi Zheng , Roman Gushchin , Muchun Song , "James E.J. Bottomley" Subject: Re: Potential Linux Crash: WARNING in ext4_dirty_folio in Linux kernel v6.13-rc5 Message-ID: References: <20250326105914.3803197-1-matt@readmodwrite.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 896ED180002 X-Stat-Signature: ugktgob7ihffhgsj4emmi5zxtjzwj18r X-HE-Tag: 1743774662-312537 X-HE-Meta: U2FsdGVkX19br215NX2m4VLdVCVW/RnoDI5Jbj6QkK7CfP2dUaucRf4apsnAi0o6IEWY8HVRG4MuvfrHKYSedUeavA9UBnu2tp9SiUdjgT4UMChHQekDsd69dC9chtc7mh/gVVmhA3v0rz8sQnIZ9VPqvF8tvxJjdOG/EeCKcqoE6FHUi5G5mLFrhFEnMhQK7Fh/gqKesn7gALSWCB4uarHlJlc1IKRVit99M21kix2g41LaO6st7l40le2nnAz14YDKe+QnGLozeKBSQUPyhNomdjRKrVt2JKdiMQn9smZxyHejIos+l420X7Iuq5LmybUCdnhhNi1Fj0wQdQG6EFxGUT8jXFEHIZB1A/ZRm23sFVBlXohLtHY0zccaT9fRjhXGXP9CqzUXoy1luwbDcF+hn4bAABGYHe95/VvikHM9djnaYVJeHggAnePbEj5ilFis64D3Q7UTj3r5eCW5LBWLILLGtYtaIBSJwkDLTwuD6dG33FOkQwHLqxhgy7pYpmbfCkdjKZhOuzQmie6q9ck86I9wxR8shPnJcUQov4zyDWMP3ajQVkEfC3oRx8JNs9vi5vc9sZxmv5/F9fSXps9m2RmBnw52P1nnYEoF9E0Y8oNSuNVMS7gBFyf78/tEMZWoSIf4RcE8l7wgGM+CEznovQ+9uDaqredeFwpqbHqgi6B7wd9mvzorGn0hoPs7Oapa5ZzdY6XS3oAiuaX/Mk47moxujWeHCUPPoqqPCPqqeNNvbQ1M4Fav64hNxkp/lWxY3OLy0s8Sx8QmCoXh44Udy1XvMgUXASUtbCJb0bQdkb4Zk7OHX/WNQG/su3U+Qc1mMSFw5IpLHxoUQUQwAJ25XlmxBTx6Vn1Jp8V3Kyi+dORXq743HXbkk2a3umcLo8twJ15bz+7CJD553wsm8Z37bmmnsPk49Galj/ZFmVHemvqPvoTB1KRiLaHQG8VXP+P+wEyduCfSXd79oXV JDGx3wrJ XsUtPiacaCiEihyMtjDXEw3nWBTgjClcr+Qtbnntq3Fv3Si0EUOdb4Z5CyzyilXzWxnTtaNlCuVmqjTm92zPrINO6IKNCUUCnfyE66dXyFMR2n18BUBzOLtnBIU/inzMCAfPizFg3Z1Jq/67xwgrsFA3QuxK/iIoYr6d6n4qyR6L+c8IHMnC8Rh6ueNrZ2aEjy8Tf6i+A69ErSlLk5f6KqjXOx7t7YABM4pG1UwlfY14uJCcMtGL1xbWjsRcjvuFmblyc1jI9gx9Jknhph0AmcWQoIkM/jLPpIqn5ydgwNSkF/fAsmmcOBH959kIh45a/DUeVZqoapn9KhR6WXhHKsEfibVyfnHrr9Orh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 04, 2025 at 11:09:37AM +0200, Vlastimil Babka wrote: > On 4/3/25 19:12, Matthew Wilcox wrote: > > Ideas still on the table: > > > > - Convert all filesystems to use the XFS inode management scheme. > > Nobody is thrilled by this large amount of work. > > - Find a simpler version of the XFS scheme to implement for other > > filesystems. > > I don't know the XFS scheme, but this situation seems like a match for the > mempool semantics? (I assume it's also a lot of work to implement) Ah; no. evicting an inode may consume an arbitrary amount of memory, run transactions, wait for I/O, etc, etc. We really shouldn't be doing it as part of memory reclaim. I should probably have said that as part of this writeup, so thanks for bringing it up.