From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9900D70DFA for ; Thu, 28 Nov 2024 23:05:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 20C7B6B0083; Thu, 28 Nov 2024 18:05:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1BAE66B0085; Thu, 28 Nov 2024 18:05:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AB4A6B0088; Thu, 28 Nov 2024 18:05:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E29406B0083 for ; Thu, 28 Nov 2024 18:05:35 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6FFC01409B8 for ; Thu, 28 Nov 2024 23:05:35 +0000 (UTC) X-FDA: 82837037178.10.050A1D0 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id F10A0100003 for ; Thu, 28 Nov 2024 23:05:24 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ahFLNVwV; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732835128; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=foSCVk1TQJuLvaObUzL8Fw57glUVJKIM/G0QyVdbyWk=; b=OAMu+SfS81dUXmZkLYdcBtWprQnB9dTFt4bbYdg4Tpz/xnvQKJYwu2gE+bda9zvMU5cq3F 8tqgjQzT44sLAhVTVAIYjP4iiggI7D6CKG79u+wnLe1ezNGSSQBJJ0Mn1E6UcRomsaWAjB zSFPRdKwm8ux9uGeC7f4byeQhZQgYck= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732835129; a=rsa-sha256; cv=none; b=oiE23R9whySvsEEmb+rPqWoYXTgIba4ci+pPiyXavj4bZGUP8wUZr4bxoGm4wZFwSR2sai DPNhsLuRfJRwwE5v9pbtKhERiPBjot8CvuxvsdAS0Ohw7WVbMBhNB50RUw159Oatew4nBh gA6uqGD2kcYlRNGf3mABGL5l5u5JRHU= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ahFLNVwV; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=foSCVk1TQJuLvaObUzL8Fw57glUVJKIM/G0QyVdbyWk=; b=ahFLNVwVI/TAr8FRWzHJ9hLnNE Ue87llVqpnTgoEvpgzudUjUpLAfr7gcOhzDUsuYj+pZcl0EQIPs4BlZtO+lxgX3IGtsg3cedEXSRq ZspmoQ+xvaBjzp14q2YU1XKaKOX1sKQkfmTVIBZOCovlCYwuYCp520oQN8Bm2sBQBGSrT4jat1IZx ZAAaa1VpCrmEw9TUvXZ5SMmK+oX7EHZp8yvlLxzcIr0K7ZC8ykNZEwxj/ztRk64Y6zS9JSq32kbVc jD6F+V5dRsDRMSf5e/VDYXJJarf5xODkKblw1mTr80u2CQwDr2cd2qjt0qVCxhxF/uR7+q+S/s6AQ 0H5nJdbA==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tGnZe-00000003DIW-00TL; Thu, 28 Nov 2024 23:05:26 +0000 Date: Thu, 28 Nov 2024 23:05:25 +0000 From: Matthew Wilcox To: Alice Ryhl Cc: Dave Chinner , Andrew Morton , Johannes Weiner , Nhat Pham , Qi Zheng , Roman Gushchin , Muchun Song , Michal Hocko , Shakeel Butt , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] list_lru: expand list_lru_add() docs with info about sublists Message-ID: References: <20241128-list_lru_memcg_docs-v1-1-7e4568978f4e@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241128-list_lru_memcg_docs-v1-1-7e4568978f4e@google.com> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: F10A0100003 X-Stat-Signature: jo8gjyxga67ufsprz518ci8qcyi19f8b X-Rspam-User: X-HE-Tag: 1732835124-315082 X-HE-Meta: U2FsdGVkX1+qRqK8n27F8Kw035wUxgWiqC063QG/SJ5wTpDNdROJGPlmDmbEihrX6j3vPrbPjr2Bsnal8k2A+3dtUgu8tikvZTvaDp3c99WUcTjtsN/PlNES4blYb26IBdp6syJplVvVc26nPgjO4aOUcY/jrLXbWhSMuUettRcf9qT5z5kgr4zRjN5NmcTcL4abNvvoy9RcOFw21/Hc3IgIB+RH+WNqW+gETutoEpSC2swY9M4DFZP7UXT3vs0zbmklp21zu1aj10kLNX34XX2K+S8CGhsC/A4QnkUWNPwIElP+/x7r8/NrAiWuvmBFCxorwV2JoM//UJ4Bi4hoM7RbH/mFhseObe8iJHQwT3ycQ94Etlhh1uMhVtUSmaa9A35mGnH6JtTP6UGaOD3CzA8I1CZaooTivfV9Po1htZtpxNf86qQ5dRvWsZa2yB9bHJ4u7BT2TPCejUVnJXBHWSPA3McJSrrQ7zmqGDNuYriVjkgPEGILhjiZ91Y7oZLcqDozFYbjY0hvk40G+/tryDuedly8B70W8C1BJtY8Okg5qKw8/PUuSZla7vbUd+cC2Ux4FbA49VA61a4EeMm+oAgcrMzEvZhoSbyGRW2Ye2yPHZrwbwamt18tv74mMYzkWFHBWdKJ5IHAZjDYjmK6frf+4Y3RrcwjqcOn4XTuRwXZngVLbtDlaGf7ZGg+B/JHhyADBIWRsZJKw2yMd+WX2Gf5k1CPxYcQeibSd3OucZ4WlOf2aa+WM6+6rLuQOO0zR1AiRDnM+dxWe4e/yply4rajkhQMzFya/Te9L/WyZBNZESM5x9azlV69AudvfLZ14SsQN4Nh8J3LJBkuud2UM+xcH7NiIiKHLWQ9L+iHVsGt6QcPc84Jj6UOS71WAMeLcH1faHETwF470RDcwx1dFeX2apa61uV5AD6H5G/STXlkEnEj1nhVu7ntqDNUewxD3aIjnt7QiF4pmHUUxTM AQR73+Bs QV9wIevv/zvpE6a1YIw/+1Ga4HPK/P26TMQpF5HL5+RK9Vhh5gYm335jDGtN+j8+eLZ/RUKf3ZMbg30r670MFKFBTU2g+PVe/WdDJvGYYYBEIxRrJOHzK9avPoKJ9qFc9HlrViJrOsyl9w8HxoIuY80yGlVWfmmiIYczIs2KVfN/ihipFkk6dt+EgBVzm/lLdk3Tu/O94QTM88NfXRkVDFbJuIHX189PyCSw2utdNbZaNJY/0gzN/NdlzjQxwtQKZSVWB3zUx7BLV8RLj5h5U+bFp1g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 28, 2024 at 12:12:11PM +0000, Alice Ryhl wrote: > - * Return: true if the list was updated, false otherwise > + * Return value: true if the item was added, false otherwise This is an incorrect change. The section is always called 'Return', not 'Return value'; see Documentation/doc-guide/kernel-doc.rst. And I think it was fine to say "list was updated" rather than "item was added". They're basically synonyms. > - * Return value: true if the list was updated, false otherwise > + * Return value: true if the item was added, false otherwise Ditto (and other similar changes)