From: Uladzislau Rezki <urezki@gmail.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Uladzislau Rezki <urezki@gmail.com>,
Suren Baghdasaryan <surenb@google.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Christoph Lameter <cl@linux.com>,
David Rientjes <rientjes@google.com>,
Pekka Enberg <penberg@kernel.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Matthew Wilcox <willy@infradead.org>,
Boqun Feng <boqun.feng@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
rcu@vger.kernel.org, maple-tree@lists.infradead.org
Subject: Re: [PATCH RFC 2/6] mm/slub: add sheaf support for batching kfree_rcu() operations
Date: Fri, 29 Nov 2024 15:20:23 +0100 [thread overview]
Message-ID: <Z0nNpyBoD5x2M4jn@pc636> (raw)
In-Reply-To: <d16bef14-eaee-4917-8cb6-5571327220df@suse.cz>
Hello!
> On 11/28/24 5:24 PM, Uladzislau Rezki wrote:
> > On Mon, Nov 25, 2024 at 12:18:19PM +0100, Uladzislau Rezki wrote:
> >>> On 11/20/24 13:37, Uladzislau Rezki wrote:
> >>>> Thank you. Let me try to start moving it into mm/. I am thinking to place
> >>>> it to the slab_common.c file. I am not sure if it makes sense to have a
> >>>> dedicated file name for this purpose.
> >>>
> >>> Yeah sounds good. slub.c is becoming rather large and this should not
> >>> interact with SLUB internals heavily anyway, slab_common.c makes sense.
> >>> Thanks!
> >>>
> >> Got it :)
> >>
> > There is one question. Do you think it works if i do a migration as one
> > big commit? I am asking, because it is easier to go that way.
>
> Hi, I think one big move is fine. In case there are further adjustments,
> those would be better in separate patches. That makes it easy to review
> the move with git diff --color-moved.
>
Sounds good and thank you!
--
Uladzislau Rezki
next prev parent reply other threads:[~2024-11-29 14:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 16:38 [PATCH RFC 0/6] SLUB percpu sheaves Vlastimil Babka
2024-11-12 16:38 ` [PATCH RFC 1/6] mm/slub: add opt-in caching layer of " Vlastimil Babka
2024-11-12 16:38 ` [PATCH RFC 2/6] mm/slub: add sheaf support for batching kfree_rcu() operations Vlastimil Babka
2024-11-14 16:57 ` Uladzislau Rezki
2024-11-17 11:01 ` Vlastimil Babka
2024-11-20 12:37 ` Uladzislau Rezki
2024-11-25 11:02 ` Vlastimil Babka
2024-11-25 11:18 ` Uladzislau Rezki
2024-11-28 16:24 ` Uladzislau Rezki
2024-11-29 13:54 ` Vlastimil Babka
2024-11-29 14:20 ` Uladzislau Rezki [this message]
2024-11-12 16:38 ` [PATCH RFC 3/6] maple_tree: use percpu sheaves for maple_node_cache Vlastimil Babka
2024-11-12 16:38 ` [PATCH RFC 4/6] mm, vma: use sheaves for vm_area_struct cache Vlastimil Babka
2024-11-12 16:38 ` [PATCH RFC 5/6] mm, slub: cheaper locking for percpu sheaves Vlastimil Babka
2024-11-12 16:38 ` [PATCH RFC 6/6] mm, slub: sheaf prefilling for guaranteed allocations Vlastimil Babka
2024-11-18 13:13 ` Hyeonggon Yoo
2024-11-18 14:26 ` Vlastimil Babka
2024-11-19 2:29 ` Hyeonggon Yoo
2024-11-19 8:27 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0nNpyBoD5x2M4jn@pc636 \
--to=urezki@gmail.com \
--cc=42.hyeyoo@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=boqun.feng@gmail.com \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=maple-tree@lists.infradead.org \
--cc=paulmck@kernel.org \
--cc=penberg@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).