From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42A0FE7717F for ; Tue, 17 Dec 2024 04:17:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A3496B007B; Mon, 16 Dec 2024 23:17:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 952766B0082; Mon, 16 Dec 2024 23:17:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8425F6B0083; Mon, 16 Dec 2024 23:17:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 678656B007B for ; Mon, 16 Dec 2024 23:17:54 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id EFED2160398 for ; Tue, 17 Dec 2024 04:17:53 +0000 (UTC) X-FDA: 82903141944.22.56D9473 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id 85C3140004 for ; Tue, 17 Dec 2024 04:17:28 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="E5h/glVJ"; dmarc=none; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734409043; a=rsa-sha256; cv=none; b=saeSFbxeOzgegWpBeJr9kuT45RNaH0yVroXRq0pTcqskzDsmMatJwxQ4jL6cGl0Kp/3TPl 2rK0iHtsaoIhl31rzmSCwKs6MDcPAU2P5XeEUZJCI3Pv8pOuzDBR/7HARMyCjCWOks7gfA kG36J5V4/0r6IwiYO5ao9RbZp/3CrQE= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="E5h/glVJ"; dmarc=none; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734409043; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I/0zws/9aLkiOvy585Pgjr02thNq6CotbQy/GM3ejDA=; b=HD+m6aXyRwTrj8U+dhqolrCXCT5a6Q/W9b4fLd7IyLCzXH5qSEI0fGdLfLwf3yUH/2m23i BzBORgNmdYzEFa6WiLRT/DUBcX1a7EVeoyb+jXTekdP04F4cz6yer65KVSrhcN4Uhny5wL yTPv3NLhm6FhqtOxKi0vbNDMmzs6q7k= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=I/0zws/9aLkiOvy585Pgjr02thNq6CotbQy/GM3ejDA=; b=E5h/glVJVtrnJhTIhlTaHX6zaA zMG4t5yJWyNHQL1OljyoRoyjdD41Brrs1s86vuu5z4Ae2xkkERBvzgtk+OouitYy/SlzUsYXInMSh pCsUSELqk5NH+lrQ7E5HTCEjDxiWmf28dYramiC9oOYCSdnHXHBlgIPavdRjiLI3DaOb+Prrzq4Nr JjMqqGRLoFbpfnHWvTCCbM0SFFxC3bmLqz9FB9pB5nRjWPeVX7sfsYHfKjtrp5+nDjIaJufWp1gvm Wxm4UdswwgAfKqKiQGzz7XyEyZ9oGRXDzIo26oxhoXW3VS2XmdVRbKWQlAq8CP4XVt8iAzCZ+cqRa Ka2AIQNg==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tNP1d-00000004lT5-3TbF; Tue, 17 Dec 2024 04:17:37 +0000 Date: Tue, 17 Dec 2024 04:17:37 +0000 From: Matthew Wilcox To: Dev Jain Cc: akpm@linux-foundation.org, david@redhat.com, kirill.shutemov@linux.intel.com, ryan.roberts@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, cl@gentwo.org, vbabka@suse.cz, mhocko@suse.com, apopple@nvidia.com, dave.hansen@linux.intel.com, will@kernel.org, baohua@kernel.org, jack@suse.cz, srivatsa@csail.mit.edu, haowenchao22@gmail.com, hughd@google.com, aneesh.kumar@kernel.org, yang@os.amperecomputing.com, peterx@redhat.com, ioworker0@gmail.com, wangkefeng.wang@huawei.com, ziy@nvidia.com, jglisse@google.com, surenb@google.com, vishal.moola@gmail.com, zokeefe@google.com, zhengqi.arch@bytedance.com, jhubbard@nvidia.com, 21cnbao@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 02/12] khugepaged: Generalize alloc_charge_folio() Message-ID: References: <20241216165105.56185-1-dev.jain@arm.com> <20241216165105.56185-3-dev.jain@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241216165105.56185-3-dev.jain@arm.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 85C3140004 X-Stat-Signature: 5ckon3b89cofzm7xozdbeya8y7pddap6 X-Rspam-User: X-HE-Tag: 1734409048-566384 X-HE-Meta: U2FsdGVkX1+tcXQPjR9LACBbc3DLtfe27v5xtjT+0aLi7j4Mcw0h4rNY01zc+BYdSQ0FBQ8TdjTgTxtTWnv69+EivzaXa0HnaJevT008iK5lY5Yg+coDeGDEvtDJQbBa7mqXgbrrPSlltdrK/0x73hozWha42+X7R6LyuD+vmlHjj39yokY+cSXCO3YsVsM5+bdbGkKdPAkx3lYMa2npn7YpSvU53e1doRKyZCuLBhykjDxU+GpO81fng+t+yjJQ9abn3fkYngDDjiftYBQfqNwsMcmdwoeh6Qh7oY22xxchEzPQ2qill/CoWsoH3HJdL5G8yRs1hsPXEZJoIyGQswr+iim+2OOPgOp7jVzipaHxws4OfJvTfxXgXyeq5Ln4C0tmYGPaW/opBY7yhCKn34IVlY2OE4Uu1hicU3R8eULIp8tE/YDYXMT6/Bs5soLzCA6s55drYuwMqsP/14N9uaA0z7RRYyGFI1dahnoT/nkBAJuoPwROswpYiK5gOGyfkxwRfBGl/pnMHsjfz9+JvO8WgBYpP1MNSoGJOQsKCuQmdaNnzAJcj+eMzfiW6VSxnkm1Uv59bE2fdpC5hVirJ2NFSRW7FWR5unUn0ynQAol1iEjiqpO9SKY6B2bdaoCMtzn6XfRe21TtURNSU04IAE0fF5tkvNqDmTe+DXOpMtlfjVm0omDi/ZcCgWBVWvsjafAgVA4TIideWPvKUNvb7igey54pYUpDzr2egdngg66LjeKy7lfiIXRBl2vLp3sAZVjt4l2kaj0ERFeWmSfJQxjuyWz79CwC+p3eV4cYXVEUk680dT2n1AFWAKFnUkXmGx7VEpjg1JLcE8nd7SjSXjwe1hBkZLtBo18HayANzzXjS1RwnY55Bi7C20GgyW+XxF8JXFWqWv7Ts4eEqUNfDwyoSjvaQfemyAYl6JTNU6vhtP9G261KAyNnPJuhHb16nnK2algyt7SW+pVNF2G r+h7cclD Pyn3ClmkqbxfbK7Vntn6MaaCkRXUxjwnIspReMlTXFb9x8EhbG1sYCVxAYgus1r6KWlh9kRqnu8Eho06fZaqRrvDscMnA0il+fLCHmFbUDD+U/r8tqrUu85AxP/kfOA6KkLdRCBxd/BwaQf5wgxreOk2d8MV9Wxg6WQXmT5KlW8SB/+ELLMx7+1vZVlvoj5Rj7ktYiwzGiWDpZChyXjSigwUGbegGzCsXvWj3us53iVRO2p4gxB7/hpcFxvGY7/Ud62Yf9dNKqibmKIb1KWDcuLJJm/pjLK/vV4C2BIxT047AUR6LX3AUleyNX/Wwfe7jnyLtsggGGDi7qmS9NU4yImtL/GdEvJazTv6U X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 16, 2024 at 10:20:55PM +0530, Dev Jain wrote: > static int alloc_charge_folio(struct folio **foliop, struct mm_struct *mm, > - struct collapse_control *cc) > + int order, struct collapse_control *cc) unsigned, surely? > if (!folio) { > *foliop = NULL; > count_vm_event(THP_COLLAPSE_ALLOC_FAILED); > + if (order != HPAGE_PMD_ORDER) > + count_mthp_stat(order, MTHP_STAT_ANON_COLLAPSE_ALLOC_FAILED); i don't understand why we need new statistics here. we already have a signal that memory allocation failures are preventing collapse from being successful, why do we care if it's mthp or actual thp? > count_vm_event(THP_COLLAPSE_ALLOC); > + if (order != HPAGE_PMD_ORDER) > + count_mthp_stat(order, MTHP_STAT_ANON_COLLAPSE_ALLOC); similar question