From: Roman Gushchin <roman.gushchin@linux.dev>
To: Chen Ridong <chenridong@huaweicloud.com>
Cc: akpm@linux-foundation.org, mhocko@kernel.org, hannes@cmpxchg.org,
yosryahmed@google.com, shakeel.butt@linux.dev,
muchun.song@linux.dev, davidf@vimeo.com, vbabka@suse.cz,
mkoutny@suse.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
chenridong@huawei.com, wangweiyang2@huawei.com
Subject: Re: [PATCH -v4 next 2/4] memcg: call the free function when allocation of pn fails
Date: Sat, 25 Jan 2025 01:34:45 +0000 [thread overview]
Message-ID: <Z5Q_teZnwEjx_knF@google.com> (raw)
In-Reply-To: <20250124073514.2375622-3-chenridong@huaweicloud.com>
On Fri, Jan 24, 2025 at 07:35:12AM +0000, Chen Ridong wrote:
> From: Chen Ridong <chenridong@huawei.com>
>
> The 'free_mem_cgroup_per_node_info' function is used to free
> the 'mem_cgroup_per_node' struct. Using 'pn' as the input for the
> free_mem_cgroup_per_node_info function will be much clearer.
> Call 'free_mem_cgroup_per_node_info' when 'alloc_mem_cgroup_per_node_info'
> fails, to free 'pn' as a whole, which makes the code more cohesive.
>
> Signed-off-by: Chen Ridong <chenridong@huawei.com>
> Reviewed-by: Michal Koutný <mkoutny@suse.com>
> Acked-by: Shakeel Butt <shakeel.butt@linux.dev>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: Roman Gushchin <roman.gushchin@linux.dev>
next prev parent reply other threads:[~2025-01-25 1:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 7:35 [PATCH -v4 next 0/4] Some cleanup for memcg Chen Ridong
2025-01-24 7:35 ` [PATCH -v4 next 1/4] memcg: use OFP_PEAK_UNSET instead of -1 Chen Ridong
2025-01-25 1:34 ` Roman Gushchin
2025-01-24 7:35 ` [PATCH -v4 next 2/4] memcg: call the free function when allocation of pn fails Chen Ridong
2025-01-25 1:34 ` Roman Gushchin [this message]
2025-01-24 7:35 ` [PATCH -v4 next 3/4] memcg: factor out the replace_stock_objcg function Chen Ridong
2025-01-24 7:35 ` [PATCH -v4 next 4/4] memcg: add CONFIG_MEMCG_V1 for 'local' functions Chen Ridong
2025-01-24 15:59 ` Johannes Weiner
2025-01-24 19:57 ` Shakeel Butt
2025-01-25 1:37 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5Q_teZnwEjx_knF@google.com \
--to=roman.gushchin@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=chenridong@huawei.com \
--cc=chenridong@huaweicloud.com \
--cc=davidf@vimeo.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mkoutny@suse.com \
--cc=muchun.song@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=vbabka@suse.cz \
--cc=wangweiyang2@huawei.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).