From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F0D6C02199 for ; Thu, 6 Feb 2025 17:30:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 695FF6B0082; Thu, 6 Feb 2025 12:30:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 646476B0083; Thu, 6 Feb 2025 12:30:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5345C6B0085; Thu, 6 Feb 2025 12:30:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3AE516B0082 for ; Thu, 6 Feb 2025 12:30:43 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BDEF6A13AC for ; Thu, 6 Feb 2025 17:30:42 +0000 (UTC) X-FDA: 83090209524.07.3CFF599 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 26389C0012 for ; Thu, 6 Feb 2025 17:30:40 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="R2VgB/Zh"; spf=pass (imf10.hostedemail.com: domain of mcgrof@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mcgrof@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738863041; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=225m8GI565apbJH+ioTg+z8Gf98TM7W/zNZk2sxBFqM=; b=u1eC2GGJwLXOo/LPCxfspJNfgk/VZpsniu34vNikmNFz/p2k/8X5a1JhTnOD9quft2LC9I yQFwQN+Fxgs37CvmjVfAVIm+QG0a/xXfoGQXEYkFhFTPjQW+OW18M64izg6PfpJ9WDxLCm ZvXlJ8EdeokWCPRFrpCQMhqmzSoehCk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738863041; a=rsa-sha256; cv=none; b=7b6PrOciE+pPHl3job/0qWrRgL3opqUY3ENUMiLGuyBsBnXbJfDpRNXuAGahXCzs9sujfd guuri5TiNfplvA2ngGgdt25CMr5NYRLvh7lg/i8pCBO2YhC07sMGnbs8euXaetMAJXEN+O 9EERovzkIesWGgrlXAJWsw1eN1wjiG0= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="R2VgB/Zh"; spf=pass (imf10.hostedemail.com: domain of mcgrof@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mcgrof@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1D9EB5C670A; Thu, 6 Feb 2025 17:30:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19022C4CEDD; Thu, 6 Feb 2025 17:30:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738863039; bh=fMnGPXellcATsoTgTEpcZXWkCawqhY4ZsZLOxIxgcjY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R2VgB/ZhyftJcPwSE47rRZLndJn/gjdZBfdSAa/NV79MAmkUE+QB3pwlCQrh90ibR DWiSGHzMdTZyIe7U46vwDWayl2XxUYiUEBQKd5smb6M+wLnRrYxzDvBKrAP9pkta63 umbqy5w2cHEooBsTl6qnWJTNe0F22m32N5DOPySu/bqwnPNFosq58UG4ThkKShAoQe +3i4hdZOo53rOhiKCfRtEsyNmZsR36qJugxZx6LuJihnY7XmtfwKnJPsAZJbvrZndH FK1zl3gx0c+rIzXCVF4X8a9/DoQoE2gWU3b89n5R0R91uWOKo+lrMjgrrLniFLQZ9p SU8prm5jrnNSg== Date: Thu, 6 Feb 2025 09:30:37 -0800 From: Luis Chamberlain To: Hannes Reinecke Cc: Matthew Wilcox , dave@stgolabs.net, david@fromorbit.com, djwong@kernel.org, kbusch@kernel.org, john.g.garry@oracle.com, hch@lst.de, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com Subject: Re: [PATCH v2 1/8] fs/buffer: simplify block_read_full_folio() with bh_offset() Message-ID: References: <20250204231209.429356-1-mcgrof@kernel.org> <20250204231209.429356-2-mcgrof@kernel.org> <1b211dd3-a45d-4a2e-aa2a-e0d3e302d4ca@suse.de> <13223185-5c5e-4c52-b7ab-00155b5ebd86@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <13223185-5c5e-4c52-b7ab-00155b5ebd86@suse.de> X-Rspam-User: X-Rspamd-Queue-Id: 26389C0012 X-Rspamd-Server: rspam07 X-Stat-Signature: 8c63p7p5w8i61sqk3fkdx94144wwi17g X-HE-Tag: 1738863040-486409 X-HE-Meta: U2FsdGVkX19SJh1RXSorSMW/wUTZDQzWkSIJ+BmTC80PCG5F2u2e0cBTjgPyI2oLstpEATl59gyR/8aKqa1lVEfEYho/pycV2Mev6YF7/20DozjNN8kkQFhIHkyzoJ7ydxriflIValA+JhNG3g1S/4LXt3GLvKotymBlv9ApIz1fyhCU7cTsbs2GgoBerB1t6BqFmYXlsZM9RD6kz+ATdl/qBcCzPivoN5eTBOZ98DmwWd4zBrNFHj66Es36C9eDjFEJZbk5PJ9ArR+hv0CpgLq0LH0egpDFxGFAO9gWqW2+4SgIQZBp9gyJySJtYJFzRi0440AzV2KkNBawZwjYdv5j39y335KF8LlUwKGQ/K1cX8RYbTHu8Dviwhz7lKkQM9gtk5VjyufOPrdtdBMXmENg7R/SKiSban2mNO/ZTBYYn8EGPwP/8TwdN7x+V0NiwBZGGODCGGWNDkXDnYGQ2oFrGRk/To9Q/5/Y6RhtCF7jgfmWQQWSBniEGgf1Kizvb8Zqh8RMxvSMfWz5GntRgdPNmHIUd41ZQprCaxm+wrDr/TFWdSR1IYUPYGeUzov6IOpk3tFWyXJP+XFmMbx0fRpPnZrwkfCd/hBU8lgvIBZBUt2R3kDmN83xBb1NeePRFn9jwhbmXMmt7QtivZirGYkcEn1rdKHElKbo9Q87aa85UOObFqNBuLJQ9ATYClOW8gStMWgwOrQs9hyCRHBv1jTq/oXEKdv7iBfBWbiwpwy14fouOOIWUrey4dwEcL9mA1hmMTDLPpS9hoK2AhQcA0S+Z961LSSq38eclYDz5DW4lKkeSCk/bs7Hne9hIZXD1mNPV6wZwlk08g5aj8FdUIwlhoImuRwgFecB6W8lRjNy81q0U8Gm8WRuUmkPzWb9yGvRwQxcIXJdvjoIY0K4FkbD3UWmuWMOQ4jb6WqVc2Cyn86HIuHcBJlCOfJOH0pTmA+SjPgMQtD4qmexJ8u sq9Uyo81 0/INFA1NifnghO2SL31QwghTiu2OiKxeIICqyABio6zZXwZuPYrIuU7fprMd3Vxvr5UQSTZt8sqhfSRQEFWZBzzaMomUuVhEqqxKEf1EUOrvcVPoW9Rq5ZgcdXmDOKDa2j1UnyPhciSkuJDPEAST2Er7tVFI8KMjAxzo+YViKMcDMV3g1/2aCBB5rMKqrF+iy9likchIhYYrTrj25JbOs8ENJFiF7ZmnX8IY/UrVZ5M5ZSnu86M1yP3l/bc8LIUBe56T5pj0gMn9VIfSb5Cb36TWLjLtZTakL5qYD7KVVadCXbUwMvAkA28JHDluMayALtxFNlADiszDHXto= X-Bogosity: Ham, tests=bogofilter, spamicity=0.002767, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 06, 2025 at 08:17:32AM +0100, Hannes Reinecke wrote: > On 2/5/25 23:03, Matthew Wilcox wrote: > > On Wed, Feb 05, 2025 at 05:18:20PM +0100, Hannes Reinecke wrote: > > > One wonders: shouldn't we use plugging here to make I/O more efficient? > > > > Should we plug at a higher level? > > > > Opposite question: What if getblk() needs to do a read (ie ext2 indirect > > block)? > > Ah, that. Yes, plugging on higher level would be a good idea. > (And can we check for nested plugs? _Should_ we check for nested plugs?) I think given the discussion less is more for now, and if we really want this we can add it later. Thoughts? Luis