From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7AA8C021B8 for ; Tue, 25 Feb 2025 17:02:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D1F16B0096; Tue, 25 Feb 2025 12:02:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 081246B0098; Tue, 25 Feb 2025 12:02:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E64BA6B0099; Tue, 25 Feb 2025 12:02:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C863F6B0096 for ; Tue, 25 Feb 2025 12:02:39 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6E0E55126D for ; Tue, 25 Feb 2025 17:02:39 +0000 (UTC) X-FDA: 83159086038.15.2249F48 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id 8181D180019 for ; Tue, 25 Feb 2025 17:02:37 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BeyHXwan; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of snitzer@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=snitzer@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740502957; a=rsa-sha256; cv=none; b=AEee2iCvpBsQBMoTcUc2DZwqZdOYDkk/9SAhUWZk/9HFjeSApye1Ch1MPfnmNboUK8zhKR WTiGHIsg7vqJ5pZCDyJx0xQv7jw8iAQ2LWM+/bmyFLsmdqm/a8UQsTOU4MoJVTDh6zrNtN 1/rRMl12jlq8zVNRoRVXKNDEYZgywlc= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BeyHXwan; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of snitzer@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=snitzer@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740502957; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b+1lEJDW1+sf3mCLMGZz7EDNNOnnNf2Y/C21+nwWnF0=; b=mWEJOpQ5+jURtpqMgI6HYgCnfy+vwwQDnxn5GIIeQEAId1yDnXkGuc97lq2RCQthMN8kcx 8aXQYcAeb0/gxwCoBU79i1SsJjwD1SWInKoNWajR8kjLE/jPIf5ujUFlrtnyKLS/ufpoQZ Rtl4iiNT9bhE0A4aDMGasjbhES8KdXA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 437725C731A; Tue, 25 Feb 2025 17:01:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC044C4CEDD; Tue, 25 Feb 2025 17:02:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740502955; bh=iV+Cx8bJ8bdFma4U9kZOHVp0eYMx9ZgmUxEj/sTdonY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BeyHXwan0QGQgMyCLwlgpkzsQ2Abg6MjWHDOsnacG+6Y7Z6NKHjMWhybJQ906/PL9 pbrOq0ykIjQMcgA71HObGkcEOXq7t0Pe18t7AlcLTauIjhlnMtO2Q9zKsLI3rQOsFb JaO4/Sg8BbgsQXeb5An3Wj84VCDJJIxVWeWi257a60tt07e+Nby5Mn7Oslr2edJovz Tjcuxdh4K3ymR6D0Dc0WS806S4TYsxql1Gsnh+47zlJy8qCbXYevfxM/BJxPZlyk8I Vhb1rksFH9THB6EUiFUr9GUTEiYONgMi8Y/TDuRq5mgx3mN3m0DtGhrmrr1GewS4ak ho814PAwoePCQ== Date: Tue, 25 Feb 2025 12:02:34 -0500 From: Mike Snitzer To: Andrew Morton Cc: Trond Myklebust , Anna Schumaker , linux-nfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 for-akpm for-6.14-rcX] NFS: fix nfs_release_folio() to not deadlock via kcompactd writeback Message-ID: References: <20250225003301.25693-1-snitzer@kernel.org> <20250225022002.26141-1-snitzer@kernel.org> <20250224225306.fb08838ac74f42f1c621fd19@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250224225306.fb08838ac74f42f1c621fd19@linux-foundation.org> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8181D180019 X-Stat-Signature: ipfihoty9mx78bwuc5n7xf76pe9bgsf3 X-Rspam-User: X-HE-Tag: 1740502957-770144 X-HE-Meta: U2FsdGVkX1+mh+6YxfuiW1CiwCZ14ps6GLtcMW93Q+Db9SF3WJQxAuXBe2qcAK6WG0XSOA5++DYXwcYqTKk6e8cCdJclb9AxM3YkdZnbsaeYPUT8aoukVAnZPTCOspgQZgCTCW1FuMHsdQ5mn1oQpWTbKZD5k2yMr6B9LnpL7FYgVdGGgSM2fTxqWrKHgMRQeI/GdRPfxzqor4xPApEM+HgS/QpuCtIflJE9Dbbmh3dmzOCK0RZ3PdBNFkFQRu/Ln1CpuubRG4pPp/iat5Xk+r5jNk2pchqg9Yg0nqoGLoTDzDE7HLWZNYFp96FolZJa51AjfM6UVow65Ly0YF4OmosXtpoJ/gBxNFoOFGmUGREQfqO0BxChrCiGppuVFFCiUBMKkkLrGNrr8Fvu2VSHZLsWUeqI5YlDj0jo5pvFWEIfiRbHFqO2HIly3ey8d7jKYyIFp0/wPSYO+KR2WTjaCAG6FUajjofpITfAiPmSgF9OLPboKs0+tWZ29x+4QenPTdBXd9mF8T/SDQ//dkAZ0uaaUbnAruTjwWoN0beWZcpW/evmmhmMrj3KFYlOa41GDvAakg9cQ219982BO8bHce/CfbeYIEiTv5iPACdJXsEtA/Mvi/K2VLxAO7A6Et6ebFGn2TmOnyq3KBqnJeC+0zNnMJmgkoW8zb05JZLAnuQModhrBmml9mtbHJ2V/lOK93ZgC9iIp6PUPsM5vlUzgGQKAButxZrSsgNDHlQ0pKQ8wqf4hoWzloiNhwYU+1mMgFaoa22tMzeI3rHDadwCqvozsL7iREmgJGXD+9xjz0quyVPoo679Q0zv4HOxR3vVWydhNirzc5h6SaXywUi147zDOsv3W/WxBQJR8o7wGD/Lj3UmTX3wecw6UFzpO2kng69Puh2dFGA+Vwwb0qd6Jycx41VpdRb/E9McHaa6RrxvKLT1YNZaZwF7dlI6DKrBK+vVh9qw0iZP/M/vE4a QV+qqIiY 61QXbrPViRyLkbSRH8HhMPhEBT1U1/rcGUETDfMNZNPI3KQm+Y+X2mFVFZDjXzghyCF563eGaHO1TuuPtk1DFEqebQbz6YyEZ6w8yTPGoxvEHCThxKJWIWgL6+kEyOM3yaysVFTb2yXbTE6QysMhMcMZvJ1F2ms+Zhpz3n5Wza3DznfXAbEBQManZxmrWXke8Em51F0lzGyhKDrrW7WJq+Z3S6TWgoKeZ/4JQiFhxXHf9NjaIpyMupKuH1QKsEMaOKkjJGZ4PT4GPYQxHeYkyoUprA2iHSuQtTjVwxOhybRyzPcWNqjxvFaEWXAXjyJTTvlLu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 24, 2025 at 10:53:06PM -0800, Andrew Morton wrote: > On Mon, 24 Feb 2025 21:20:02 -0500 Mike Snitzer wrote: > > > Add PF_KCOMPACTD flag and current_is_kcompactd() helper to check for > > it so nfs_release_folio() can skip calling nfs_wb_folio() from > > kcompactd. > > > > --- a/mm/compaction.c~a > +++ a/mm/compaction.c > @@ -3182,7 +3182,7 @@ static int kcompactd(void *p) > long default_timeout = msecs_to_jiffies(HPAGE_FRAG_CHECK_INTERVAL_MSEC); > long timeout = default_timeout; > > - tsk->flags |= PF_KCOMPACTD; > + current->flags |= PF_KCOMPACTD; > set_freezable(); > > pgdat->kcompactd_max_order = 0; > @@ -3239,7 +3239,7 @@ static int kcompactd(void *p) > pgdat->proactive_compact_trigger = false; > } > > - tsk->flags &= ~PF_KCOMPACTD; > + current->flags &= ~PF_KCOMPACTD; > > return 0; > } > > I am of course concerned about how well tested this was! Understandable, the patch was created and tested against v6.12.16. Sincere apologies, I didn't rebase before submitting. I'll rebase, retest and then send v3 today. Thanks, Mike