Re: [PATCH 3/3] mm: page_alloc: group fallback functions together

Johannes Weiner
2025-02-25T15:14:24Z

On Tue, Feb 25, 2025 at 01:50:09PM +0000, Brendan Jackman wrote:
>
> On Mon, Feb 24, 2025 at 07:08:26PM -0500, Johannes Weiner wrote:
> > The way the fallback rules are spread out makes them hard to
> > follow. Move the functions next to each other at least.
> >
> > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
>
> Moving code makes blame more tiresome so I wouldn't personally do
> this, but if others find it helpful it's fine by me.

I feel you, having had to get good at git blame, git show, swear, git
blame foo^, repeat myself.

Blame has definitely become quite important to understanding code. But
I'd argue it's slightly less important than having understandable code ;)

> Reviewed-by: Brendan Jackman <jackmanb@google.com>
>
> ("Reviewed" means "git tells me there are no new lines nor totally
> deleted lines").

Thanks Brendan