From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E0D2C021AB for ; Wed, 19 Feb 2025 07:24:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 864162801FE; Wed, 19 Feb 2025 02:24:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7ED6A2801F6; Wed, 19 Feb 2025 02:24:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 68E462801FE; Wed, 19 Feb 2025 02:24:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4963B2801F6 for ; Wed, 19 Feb 2025 02:24:58 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E7312C10B0 for ; Wed, 19 Feb 2025 07:24:57 +0000 (UTC) X-FDA: 83135857434.02.85A6F96 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 47B4414000F for ; Wed, 19 Feb 2025 07:24:56 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FtKBbQaY; spf=pass (imf09.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739949896; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TWGXF7MV8G9MqF/3hcMNPYM338Vdzeo61cefvJOSakI=; b=6V6hrNRqd7VgoXobs7a9XQ5q3VWeDlfG7eOWJfTf7OC0ThzvFJc4MtccvJ4oNMa/1ugnCS F1hVjATJf79tIYoP47chdHuEdlm8tKmISaySdrANTDJYmnJWl6u6ttXk9OO5mB6zPlyrbS O/aweeZMhGOq6IKn6AbrQhpjumNgbX8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FtKBbQaY; spf=pass (imf09.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739949896; a=rsa-sha256; cv=none; b=w39uyXdDubxZlgg9snvpvhi6pPtZrmNGQ8LB0do+iTlGZ6Hq8eW+x5TTidQL+LyYMXWRLu n6kjt31l1daJcR8ixZ7s+1X/ibL6qTHrsRoU/rKCJ4xHWoGPReIUFgIRWvFJrfxClI8KHt ZXgXrkZfMQCntqhd+3PLsIWY4zQ5oIo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7F5B45C4B20; Wed, 19 Feb 2025 07:24:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1235C4CED1; Wed, 19 Feb 2025 07:24:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739949894; bh=SRqj9MZLCV8OPtw+RLc/L0/R3k9RqsqUSw55QX9OOlE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FtKBbQaYTslR+0p7SefBILIuS73xk2HkHE9X1wi3f1RYXdzexSpsyIrHcPKNtZYjL BvKiLvIz6tiQbKcH9IhyUrzpRPaTkQMGYuEz3o1+LwRY6+cXJ2ZdV6QYVU7JbUtlYQ 05YBQSpFJ0o9+4PFttNGG2I4B8gyRtwm24/vnas8DwL/rcu9i5Hz/rxhmWxht1y1Dw wkLpe3ZZgtmacfwPN46ynU8iy+ypPSs9dwF5Tdr7KWenmjNUChafxZkv2PmgFVMNfi 6mdnd8DQM0qYd4dN8GiXu45YvQUX49U1bZ45kTkOBpF0wvbKLl80gJxVUX5K2raMUR MM9jdOERGv5AQ== Date: Wed, 19 Feb 2025 09:24:31 +0200 From: Mike Rapoport To: Wei Yang Cc: linux-kernel@vger.kernel.org, Alexander Graf , Andrew Morton , Andy Lutomirski , Anthony Yznaga , Arnd Bergmann , Ashish Kalra , Benjamin Herrenschmidt , Borislav Petkov , Catalin Marinas , Dave Hansen , David Woodhouse , Eric Biederman , Ingo Molnar , James Gowans , Jonathan Corbet , Krzysztof Kozlowski , Mark Rutland , Paolo Bonzini , Pasha Tatashin , "H. Peter Anvin" , Peter Zijlstra , Pratyush Yadav , Rob Herring , Rob Herring , Saravana Kannan , Stanislav Kinsburskii , Steven Rostedt , Thomas Gleixner , Tom Lendacky , Usama Arif , Will Deacon , devicetree@vger.kernel.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH v4 02/14] memblock: add MEMBLOCK_RSRV_KERN flag Message-ID: References: <20250206132754.2596694-1-rppt@kernel.org> <20250206132754.2596694-3-rppt@kernel.org> <20250218155004.n53fcuj2lrl5rxll@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250218155004.n53fcuj2lrl5rxll@master> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 47B4414000F X-Stat-Signature: rhocn395eakpxhxojxwdzmpf1a67iiow X-HE-Tag: 1739949896-214547 X-HE-Meta: U2FsdGVkX1+kgpUBKAmIHp/P+lmHMa83PIwvSrxHxJOn6Jfg8xXsA/QKTqpRc6Q9bXrpEy+XUVCYICM3jVkwePaJ0WlrXbf7Z0df+2TObFFKopJ8YZIcuOc4F4des+bN+Aqy/fYoTpIrldQL6N8990YlaAydOaLO+LXwavqEmRBXUWN8yD+wPHUEDi+ZYcqvmu6hSOeZTcsD2sv6W/5Z5NHLJT30ulBnB1K9fFo25e//TwOBet7Itlbg0As+7sRxKeUqm15EgJyn4HQTGGAvBdIrRiEWOgIb3vUj5NqELyVjWjB+vhe3eThzmL4T7/1uxZsOiPI1T25Gz/dduOR+4hr5Nb7UHmR1+RG8XffgDa15h4B3J7tYgnPCl4vSsq6K7p+dIhsWvj0z3XhisHqPV+b5x54tnZPatKlIC07EpTX/Vn/nU6N07ZypYJkqtHBxOsBdMNpoHv0Qs6ESzuc0fzCmB9ylik9fdO9Km8TrHlVpqUh1C+7EybdWPj+bPwl6vecaCldoTebZsiK5PT7YAjNjT2CQjAEudKVx48R8dpXcJvhuIAdNPESgxoUmN7/oDsaUZG1C3jdW82p1C/KUAfN5RMh8GSS+kaXDiPL5ljvAxFUgxyj5RkM3SmlUteqB/aLNM60DF+KBkJtl8KFUpM1qMeMWzH9BUOCwV09J/zMlGIu53YfJviub68l5WcWDyZ3LZxNwkJeSPvhgb04zyRnQeDOa1WqymlN5mjTYhBy+rAPHbb3F6ZZO3dbiRAxUPHVndA0ecSZtF9J7gfsChldmbdnuz0OJ07klYiCBlqE1CBDscJTDDFzwAXIjLT+dKeoAWoTla9lce+5FdhvsVBDkeONrY5/x7nWojAKgDDDeNn+rjZsQHL848AatSAof2mX8tr+d8ZKTtBJFGHXyauJ8VgwsspS/Bund04YYgrzSv3dlTSwnFaAuOC8xRqoO2ywZTh11zXc/9qFfPlR HBA/PEbD 4KeeOhm/AIRXDLP+2iHBMHTjySLHjLMhKm1yZHAjp3Bx4wHqWO9DOr5elBHbqyu4dSzV8N++hukngsNrShcew0OZs50HsXKQ8sw1acNbqAgcljmQSFLpn/Bo2S9h9WZHk6He3W5+ui2wSCeGq+hM5mFMvv7KkhoWefQYaNe6rMsvRlCj3958j88fxneM8DGe5yOff+Tb4kvRVuDklsRemtyI+9kIA+kdoI56DBDS0r7nswKF9yDC3diQMqEF1oifkgrbOpYEfHAFydA9snECq+BZvj4Nv1i6HlE1LenJJTECRGWzd5IkK2ujEQdqOijiLsLLzZyxwKuhinhTBj73NAz9b6YGnLLdCzcU7frPMt3+FUaH9yQHSC66tT1WHonTw/J0po8m5v5ztkuB4emn0dLpi4g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Tue, Feb 18, 2025 at 03:50:04PM +0000, Wei Yang wrote: > On Thu, Feb 06, 2025 at 03:27:42PM +0200, Mike Rapoport wrote: > >From: "Mike Rapoport (Microsoft)" > > > >to denote areas that were reserved for kernel use either directly with > >memblock_reserve_kern() or via memblock allocations. > > > >Signed-off-by: Mike Rapoport (Microsoft) > >--- > > include/linux/memblock.h | 16 +++++++++++++++- > > mm/memblock.c | 32 ++++++++++++++++++++++++-------- > > 2 files changed, 39 insertions(+), 9 deletions(-) > > > >diff --git a/include/linux/memblock.h b/include/linux/memblock.h > >index e79eb6ac516f..65e274550f5d 100644 > >--- a/include/linux/memblock.h > >+++ b/include/linux/memblock.h > >@@ -50,6 +50,7 @@ enum memblock_flags { > > MEMBLOCK_NOMAP = 0x4, /* don't add to kernel direct mapping */ > > MEMBLOCK_DRIVER_MANAGED = 0x8, /* always detected via a driver */ > > MEMBLOCK_RSRV_NOINIT = 0x10, /* don't initialize struct pages */ > >+ MEMBLOCK_RSRV_KERN = 0x20, /* memory reserved for kernel use */ > > Above memblock_flags, there are comments on explaining those flags. > > Seems we miss it for MEMBLOCK_RSRV_KERN. Right, thanks! > > > > #ifdef CONFIG_HAVE_MEMBLOCK_PHYS_MAP > >@@ -1459,14 +1460,14 @@ phys_addr_t __init memblock_alloc_range_nid(phys_addr_t size, > > again: > > found = memblock_find_in_range_node(size, align, start, end, nid, > > flags); > >- if (found && !memblock_reserve(found, size)) > >+ if (found && !__memblock_reserve(found, size, nid, MEMBLOCK_RSRV_KERN)) > > Maybe we could use memblock_reserve_kern() directly. If my understanding is > correct, the reserved region's nid is not used. We use nid of reserved regions in reserve_bootmem_region() (commit 61167ad5fecd ("mm: pass nid to reserve_bootmem_region()")) but KHO needs to know the distribution of reserved memory among the nodes before memmap_init_reserved_pages(). > BTW, one question here. How we handle concurrent memblock allocation? If two > threads find the same available range and do the reservation, it seems to be a > problem to me. Or I missed something? memblock allocations end before smp_init(), there is no possible concurrency. > -- > Wei Yang > Help you, Help me -- Sincerely yours, Mike.