From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26BB0C021B3 for ; Thu, 20 Feb 2025 17:08:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A569D2802E2; Thu, 20 Feb 2025 12:08:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A06862802D6; Thu, 20 Feb 2025 12:08:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CEB22802E2; Thu, 20 Feb 2025 12:08:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6D0082802D6 for ; Thu, 20 Feb 2025 12:08:40 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CC9E01C74C2 for ; Thu, 20 Feb 2025 17:08:39 +0000 (UTC) X-FDA: 83140957158.01.0DCFE3D Received: from out-183.mta1.migadu.com (out-183.mta1.migadu.com [95.215.58.183]) by imf03.hostedemail.com (Postfix) with ESMTP id C7A4220015 for ; Thu, 20 Feb 2025 17:08:37 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=DWQOPa1p; spf=pass (imf03.hostedemail.com: domain of yosry.ahmed@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740071318; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e7RaaYPBvyR2i2/MPdBiVOheE81YWx6KyA9NN+p4Lg8=; b=qcF2t8KHnbYbPJEd1t5ndaHoIbk6sbQoLBsSX/q0OBUJEH3EbO0OjMChc1Z2BAnlgI3bCv osy9Cg7nngOYWFNdd6gw4Ci0LuQBZgDD0OfHqgUl1gF8Dxs6FsBcTj/4e+CR0Y07DTVjeA qzguPXr9tszDtTuVjJG4NCbUihx3VNM= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=DWQOPa1p; spf=pass (imf03.hostedemail.com: domain of yosry.ahmed@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740071318; a=rsa-sha256; cv=none; b=a2chg8vpD43RottVrbMbpLX5Iy4GDK1Ik/9L3GPDMAFkTc+TC5ESCsslWalVA4M1Ita1he ItSyrQX+pcC7v1gnC8/kGPD86h7dHlKQX2sU4Chzhb6ypVDvI7ZGs3agmgvItVTjKzl4/I TzxgCVx+g+TMDe3G56KS8mIKINbYTHY= Date: Thu, 20 Feb 2025 17:08:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1740071316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e7RaaYPBvyR2i2/MPdBiVOheE81YWx6KyA9NN+p4Lg8=; b=DWQOPa1p7AEsqCPS5YnozITOMxq5rIQHz5affWSsOgswOsqAFl8XO7tSo2dFZoYh10ExIU ojdjF+m3JqHZqwCwiiRvyM8Op3iiXayVZ35qByYogsAWuo7rD2MNetOqsksvm1NjgsHaoV bjXQFKdFkiMD1ML+M1KJ3VOdaSv9QT0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yosry Ahmed To: Shakeel Butt Cc: JP Kobryn , tj@kernel.org, mhocko@kernel.org, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 02/11] cgroup: add level of indirection for cgroup_rstat struct Message-ID: References: <20250218031448.46951-1-inwardvessel@gmail.com> <20250218031448.46951-3-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: C7A4220015 X-Stat-Signature: yrruxx4r3qsyne1w71m4t6bpcwkokxkq X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1740071317-102988 X-HE-Meta: U2FsdGVkX19R5oSb0BUwXWfkPVir5LJAK2sBKqChOhEXYZRW3ozMSCcooNnlJgF5zuOMBHpwWNm2YMJSpdKv1a4jtyrMgk07Em1VaWMuNtF97kBKErbrJLGWfoldAlp25vWaV+qJXsQO4nLy0aqtJtQK8VDB6+74TKyQyB1AJAtMXARh32gOL5FxceQax0Qqubmih/IAjOWYY33bLGRzs+KEFBeIp1/bYNRRs+/eUorysgvmTreNTzYmEptPd52mmfPIOnip9SZZA1zY/azKBiPauWsxOjlVFwLSRRj6Bhbp5TPV8kcJVkXNW07inlyFTBc2vuMC9PzJwKhM/aNHgxf/a6sJK5qnxZd3ZW1RFgdgWkv5VFNHuK076J+7YoeFAqSyaRTC/De83PrarRzRqzJHvEWV8EyBGuwxEk/n7wWZSXNLa7wObvyNIOg9OybdLXqO0gMKOA77dgWErSlJBZe8r+rjn9mnICNK0Z7q1ckGHehwz0D5h+aIYyREMpmTlXBGvw3pyzlJMQxTqkOxQEeu6hXT/sMplYQkES/O93V7QxVoAAHceCvDfJzhZUW5N8reP91dG4wofZji3g86n7bvaLSjYt7kucXexaS2VZoxdZ4ITCsV2o+FbND11ypXPMf7hLXxi3VV6a1v4Nuok6q1K1z9X0ln+IEidQAWSt75QC7SEdNTU57v/AQhmiPDmBIJ9QJ7U8B5crb3YIEThiyMInidNSrsPuGRMd7FWEPLVTRuVSuEc5XPIcItHnRbtlFMVsH34inzQe1oNUro6AKmcynI7ZtVfUgfCiW58G6pvH25HZ/iM6+wPHbJ+A08Tvaxm7GEEP2OJz82hrn6ic7OVTfzCxmfhWOox14KWEIMPUAG5RKx8g4YX0007wTQpZvLN8034ZN+Iqh3s0fA2uGtPaXVB/7xXU76hAscKMzjLf0CDDVnoQJmv9ZLrc4ZlFQx4jQkZ7o3+UdIIZi l8S6MEcI Y3L+GcjnF9Neeqr+L2FDFAMKLZaPJ+yzCQNl3bZ3bL+WilmEDu44LQVDusgVYl2xpUsl71ATYRXJ6SwGuMiA3336Jr74FNiPJPdLw+rIaBWYCm4p0ftB+Tol61VAJeTT4FaUGdfMbYK3o0caeCMsM1uDCrsiCwyVU2bNQUxeH/LxfhCeG8u/LkZax5mXTAtTqJqVj4ybi2JCK1Z6yHWbhu2fb55z34MTAzYjVL4uz3q4GWLwWDFKIXQH9zyVkpIOr9LA3baPc4NpZgLyC90pSdd7NbAowozF8K4t/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 18, 2025 at 06:26:07PM -0800, Shakeel Butt wrote: > On Mon, Feb 17, 2025 at 07:14:39PM -0800, JP Kobryn wrote: > > Change the type of rstat node from cgroup to the new cgroup_rstat > > struct. Then for the rstat updated/flush api calls, add double under > > versions that accept references to the cgroup_rstat struct. This new > > level of indirection will allow for extending the public api further. > > i.e. the cgroup_rstat struct can be embedded in a new type of object and > > a public api can be added for that new type. > > > > Signed-off-by: JP Kobryn > > I think the code looks good here but the commit message needs some > massaging. From what I understand, you are trying to decouple struct > cgroup_rstat from struct cgroup, so later you can move struct > cgroup_rstat in different structure (and maybe later some new structure > can all include cgroup_rstat to take advantage of rstat infra). I am not > sure I would call this "add level of indirection". +1 here and probably in other patches too. "Add level of indirection" sounds like we are dereferencing one more pointer, which is not the case here.