From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C9B4C021B1 for ; Thu, 20 Feb 2025 17:59:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8406B2802FF; Thu, 20 Feb 2025 12:59:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7EFF92802C6; Thu, 20 Feb 2025 12:59:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B8112802FF; Thu, 20 Feb 2025 12:59:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4A0DB2802C6 for ; Thu, 20 Feb 2025 12:59:22 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id F0C661CCC54 for ; Thu, 20 Feb 2025 17:59:21 +0000 (UTC) X-FDA: 83141084922.09.9AA17B3 Received: from out-185.mta1.migadu.com (out-185.mta1.migadu.com [95.215.58.185]) by imf30.hostedemail.com (Postfix) with ESMTP id 3C86380007 for ; Thu, 20 Feb 2025 17:59:19 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=KhPDqKQ2; spf=pass (imf30.hostedemail.com: domain of yosry.ahmed@linux.dev designates 95.215.58.185 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740074360; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CIE8933nkdbMTfThhnyOExCftBCOOb6dTYoTdaWqWRs=; b=IRgAauHx7KKgvN2GfxDvLisnhuRYqjPUI7TgQZ4JNI1dlroqoz5IJdawDCgBjvfcjhLSQ5 ChqbaszfheNt0WWUW3q08OmTuKP/GVWMJhKfUdyIRkbG4hr1KtHDNHnZ7Rms6n/1hKfrAN 2Be/vMeDogEutJYRYPz3jyaXLsJgOYw= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=KhPDqKQ2; spf=pass (imf30.hostedemail.com: domain of yosry.ahmed@linux.dev designates 95.215.58.185 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740074360; a=rsa-sha256; cv=none; b=xQLVhOjdN2Ej6yLrjWZ7ZnQrojBwwpYpxBvf1ua9XoZk6CBVKyFwXO5AGH1RhizJTuL5R4 k1XhSBoa1sEF7KRmczHDhdz19sT1lIKKsDN8SYoRQyefooMb4YpxkbBByqRYucbv9cydSk SjTZYUKuNiKCKmBVNfnz1fdbrnm1t9A= Date: Thu, 20 Feb 2025 17:59:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1740074358; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CIE8933nkdbMTfThhnyOExCftBCOOb6dTYoTdaWqWRs=; b=KhPDqKQ2M0vLNSPCo3oYTs0ngvjwW/9RbUTIi33SYi3Zatd8jjmmFNJLvthNY0H3jXt1vl x/krK1pwGKFcS+UPd6NGQAz2wEKNVRPOTuwKzjXVjKe0PDyDLLupu+KQgR44lZg1L+ozbL OFBBUuca6iX0KPwmxKTxa5ucDQ/jPbY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yosry Ahmed To: Shakeel Butt Cc: JP Kobryn , tj@kernel.org, mhocko@kernel.org, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 00/11] cgroup: separate rstat trees Message-ID: References: <20250218031448.46951-1-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 3C86380007 X-Stat-Signature: cw6yni66komioqzdxcqpkitzew53hxkd X-HE-Tag: 1740074359-207645 X-HE-Meta: U2FsdGVkX1+MrrCLf4Blb47VtxUuVyXffi1tv37jWlDHF1Sytog3fxNjIlreyvSWvQbTJ8x9XgXxS5e20YP24xqoLSn/BIr/2n4nptSblrfJD6KX0gNyzaUQPi+fK4BMjGVEm6KHKOHP02ftZOFS/adwyXOZtq18QlHEdtRWxQ1Nz175XQV57yKrXPE1IimxSYb4DXys7a4JS8cd6TZjerU0r/ky7uTUssX9jCcssYgTxDC3j1bkzc8HSmEvzd15H0UK8p0gvWXE8djqP+dhnw7iE0sAyB/jhmEaiGiSuZ7x0mN2mYU7hibY4uJaKPFwbagng4n29SN88KWTAQ+HIcQqlR1feJ0lJnEQnrono6UfX7vauOEOOyZhEk2VuqTceBYME+B2djPy6Y1nwqm5gsMDb3qi6UOI3mUGzCTF/hSJAjOEbN1si3z/PHwJQoG0ZmXsMjKIw+sqT6ZeDLCw6AnJl2Wm00bJsl5ysroOjVTGBiyug+moUL9iZThmIo+cKsMoIsbDHDFsBP6foUfmlBzyUZfysrseJ2DOSdC2eSyyr+td12HgNkOm/USotcuhU0fY4EarbK5ICc5WUkkFaKYUd5sWDK9ej5PogoPk5rimJ/j3tsD4u98XlmYn9HuZIFPJ+BbmQX2ODr+/7Kd0Xx2qd5bdf9vjBGrTlzmCpooYdMvB2r7J8hQ/Smrzjgdb6F/1S2ClxLJSxo2u4dQDS9yMOMOJ17VnfjXadXjpvp7uSZPeBij2mTmn0px2bEfqZOHXwvrHnETtlMykCKCyxj3fqZ1hVwp2xyn1Df6hBlJ9WJ5PaGPJ6CawKehDT9zgdv3azx3JOmwnv8w0m7G9xTmMttB4KCfS+dOhoplak+n9Fc5TWW9GkQ8hpQU2ilInICa+OCrSgJPKtrSTNtcXC97GLs6EEHLy46iKBUbUf1ShvYGUmslNZgqM51JouxmLjDzCF6ChUFM/gGtLxf7 k+sUqm3R k13Qc6OJ6vPF1Bk+VuBVZzhmTzc7KNE0hChpKYh944Xc7KN7uQ+nt5dWT9hNJ2Sq+y0U7TIVjIZjSyQ4Hkwj/DgCSfW/81jomiwwEkx8MsCAiBfhnebt+MLiJxlG/jV2h/2O09Pf2iqG+ZN9SarFyCzvCByUNfcSXJnmlgy2TUGkfKH4tGepHjydA7dEkneqtxVLlEbdi8YN/IhKi3blb+ne0JA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 20, 2025 at 09:53:33AM -0800, Shakeel Butt wrote: > On Thu, Feb 20, 2025 at 05:26:04PM +0000, Yosry Ahmed wrote: > > > > Another question is, does it make sense to keep BPF flushing in the > > "self" css with base stats flushing for now? IIUC BPF flushing is not > > very popular now anyway, and doing so will remove the need to support > > flushing and updating things that are not css's. Just food for thought. > > > > Oh if this simplifies the code, I would say go for it. I think we wouldn't need cgroup_rstat_ops and some of the refactoring may not be needed. It will also reduce the memory overhead, and keep it constant regardless of using BPF which is nice.