From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7477DC282C1 for ; Fri, 28 Feb 2025 16:27:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF058280005; Fri, 28 Feb 2025 11:27:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D7AAC280002; Fri, 28 Feb 2025 11:27:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1AD8280005; Fri, 28 Feb 2025 11:27:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A0629280002 for ; Fri, 28 Feb 2025 11:27:14 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 22DBE1A0EA2 for ; Fri, 28 Feb 2025 16:27:14 +0000 (UTC) X-FDA: 83169883188.26.88BAA28 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by imf01.hostedemail.com (Postfix) with ESMTP id 2C7F54001F for ; Fri, 28 Feb 2025 16:27:11 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ODuDe99G; spf=pass (imf01.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740760032; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ruZc5rE74kB9l6IBoGmzRC99kLEtf45pFZfGUKT4nRo=; b=vZFAKmk4NIx8UZs1m5CJltr1hhUJNKJZbcAeJMc93CSECMylP/UcHwsntwMk3NDN0CTpPG yCVC3NnP+yZVUc+7NAgHR8NxTjooIL5VfP1zjBTuXx5T+nBJ14CcQjFCI9RBTbYBDHbT8N XZxzDSnrDpVJ+yGH1H7ODYHRS4Yh2+M= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ODuDe99G; spf=pass (imf01.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740760032; a=rsa-sha256; cv=none; b=zxPTTLzw4LiVPbb+MCCMEzmA4tLSzAsIixhbZMDqrnHABO5yTMzTr25yabH6DYb/H8Lueo BgQlx56dInu7aGwpWSRRt+QiHsxVWD7Ethbrhk7fBY4P/areGo+tNyXwU23CXjjkFn6U/b sWmIDU6fl3kWpbF+LDr4XdJ6cmLZwG0= Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-30761be8fa8so26498191fa.2 for ; Fri, 28 Feb 2025 08:27:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740760030; x=1741364830; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=ruZc5rE74kB9l6IBoGmzRC99kLEtf45pFZfGUKT4nRo=; b=ODuDe99GT3M6BPQEl5FOFYhXXWivDanQjyt+HBwmD6nwlojM1nuJd6sAenjANmC+8o eDeqBTrELL0ZEr9KHCcb1SUVT1HX/acDyoY1VhRaXNx2oCLCq57w5GbiP0E46+7Ji9dI iqN0p8G+csDC+K9ekehtum9RxUW32iDoQRZD14tJW9kpa8ipi1/BeIMBS16jBxD7Dj46 1J40Khx4Hf192PbbjzD/SGOD1J6JfJDP8zfsNbQ/LD/KF8ObynKAjTwGcOH/lGHudp5R xJmH5WHGKTiLYNNZk9jSRQwoAonc75k6uPNjRR0SHAyTMAoprlVfrO6q/E8q8wtKQGvX Xy6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740760030; x=1741364830; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ruZc5rE74kB9l6IBoGmzRC99kLEtf45pFZfGUKT4nRo=; b=Dd3F/YoVnvjTWXmeoqcYX/43wD6wogl52c+DCPP9xVRx+Pg2sv3k855Cvr0aPXj1Hx WuEgVL+MZIgj+ktWwXrp2WdsmmOA35v/WoFd9fVjuMW2RJwQM5dZOHCnulvtjgmoAn2a AcfRmKWqjGBZlKhMSMRIPQ1XS2AUi39aF2JnGyPs991C4q615Z8oifscbb0uIccODO0F oQMKlWpCIiYx3LJCZ6x2Xq5rjNQjkDIe2RgDXhvFo9BuHPMJb06b5lYl1nPMqeBcDm3W 5bTK8gGmgs7xHwQVqEz78ve4WcnTajYhgPAe/2LCufX7kYR6E1EW6TYfJMZp1tlaWbAM wH0Q== X-Forwarded-Encrypted: i=1; AJvYcCUVUrcyqj9pYOsrP1XPILZVtQxOHXikSC3S9n36F54Au42U9GLsec2lls1cRVzEsP8w8kgMiy2qCg==@kvack.org X-Gm-Message-State: AOJu0YzGTBLnrCVz/vdWjEvvqrfCLCPZvxwY/5JCVh7HfpWNIKv/WjJE FPscQPESGTJzAIsA7ljjrRjhG8FoGXsGLU4I3QkLjaq1i/5vNuX0 X-Gm-Gg: ASbGncu6vAOW8+UELaJrKrjhyYadH6BXMmSTwi7CDgxGxrzzuSIE9Q5dDEO+Sb5A1dT WhQArJ0wdxqq8HxfysnWZfx7h8CK9sI44xTozz4nJfWSKQp9VCh9VDVyEVMD0koigbdCBSRMfcI b82rWVSuTVh1fElDM6yrnXbVff40lkMgU+opT+XF0mCNqY01/qZOAApdiKIejWGZFSZCjbPOX1F GgjVwFSBirYnY4XCnMri22OaWs6huhblPT0JDVqGwyUHoochotWxrsxB5BNu/JVNAhzNfKb1DEd c5+VJhQsEkAgI91tzYISXo6LdAp1RTFzOtcyn0XBu/GWiL4e X-Google-Smtp-Source: AGHT+IFBcQjlrOGAdU5olVcCKRvcQf5ITnKLMelFk+NStupCDNbjKh+wL+NxSNVcP6R75XQIKLGp5Q== X-Received: by 2002:a05:6512:1293:b0:545:a2f:22ba with SMTP id 2adb3069b0e04-5494c331e56mr1969061e87.37.1740760030078; Fri, 28 Feb 2025 08:27:10 -0800 (PST) Received: from pc636 (host-95-203-6-24.mobileonline.telia.com. [95.203.6.24]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5494417a683sm539165e87.76.2025.02.28.08.27.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 08:27:09 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 28 Feb 2025 17:27:06 +0100 To: Vlastimil Babka Cc: "Uladzislau Rezki (Sony)" , linux-mm@kvack.org, Andrew Morton , RCU , LKML , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Oleksiy Avramchenko , Keith Busch Subject: Re: [PATCH v1 1/2] kunit, slub: Add test_kfree_rcu_wq_destroy use case Message-ID: References: <20250228121356.336871-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 2C7F54001F X-Rspamd-Server: rspam09 X-Stat-Signature: ust5cryr4o6x8ik3kazmcqxqyjcknx9u X-HE-Tag: 1740760031-183047 X-HE-Meta: U2FsdGVkX1+bBl3JD+Ty1x5ttQsatjRqAEwCLyfU4ENWocwtmJ7mMXsZIVJOkEd30xadxL29oWYvx9Yz0Je2er8lUYl1/7DduAKQsrpcRHX7ZM8UxdQziALh0qJZz2nZ4eN7qu2rFLQBuSltzlisvn8wA2o6WVh1EplnQB3XFSgvEqnyCSGjrbKbSm7uR7PSAD+OQqNJVOkA13h//dsT9tVl9a5aRLOGPMpChEBVqFg5C2pr215vYrWSfWwfep+UqM8J9QOEdBgXSuXM4k618vOmbfBqQKWyQ5WTep2ejfW6mm22g9igngXl3mPwypaVgSMxgPbjhAWa/MFOZGCdeJwULuW3Pwp4bSXW+mrumnAUvJGQlLldmETd43okrPyDbtVpjFie/2bo2K3fJ8SNnkuV22SjLzNp8/86HfWj1SVIQ+9SfCsh3QjZCZHAwUGmSFbIbX801CtXtJzbpT8J3rfj29ClgtAc1sskkmaOtE06oncnSchlLffop+s87GSlO7ZUxfKwjQDI7rJBBAwoXwBtMxm+jIGnziYXn4WOkzKbQwLFQ3BFpJwlNTizhHRmVFxNjQe3utWT+kE+WC4LixDXUeVYI81mz+oHR+RQGS5BXP9j5t/SsbPEfuPOgtoX0Qs01VphdX8YKZY0wplqSIFKbukK3acyrTZ/W1SVpOL1dI/kggO0YKM4eZsBgzaCz5ui44RuLK0TAijsD8AvBaDRTSLV6RtVprKpn7AXFHQ5EKixdOkhZ4YOKV1GrsP57KkuXblDPsMf0TuhG9GelL1XKv40CSQpb1EBK4M71jiQQYbrXoVTDT6IyD7B1lUqdTmJLSQ2XuF/F20lE0uIyxm3HSg2zecusLIXv53UAEmfzd8O2NZN+Lgv1VqXIQPTvz2DDuJ5S9zqdSaVdz11NOJphqfyC9yjcmv2mxtNSr01b3AgapUXVgfZgauxfDTOcz6Q3+GGIsC3yExO9pT VBYvisXv fLa2GiFXUsfJZlafnclv+4uLjmNlgQPeUascWvqJ1djd720gqK/AVj3xCO2b9oeXkvW+UOBI46lVFV5AgrXlHB9nPiCjdJGBj9TsUI3fnyJl88AUqcOi3VxBofPT729l1ZUTzHODeYgPFqdHsdlbzjgmqtxmpytrDIBZgK0WcYRkpyTliQOo2dTOdxHsffGLdMJ4UgmurTHq8cpEdROjxzePWtkLFCpnEem1oZqBn9JpjB7USykGpk2NBUL6qIaPaIndRLI+EzB6GURyPL0GcQvduA91AB5HBxb60cirputL2x6RUvB69ZrRmYcIqxtrfMNrmkHTQGe1lwaKVeeC5Wdeyyj0TMzKGvOgJc17VAlle2iDNNb5U2nNHQRrY1UlwUBx6oA8hN4+KlXFm3PFtq8YVH0FQWV0TJ7xcXgz/90NxZSn0Ts8euz2iaFqZb32L2UnekIsc9u97KcdO0M78VCC9r8GPeL1eU2m67Da3Z8L8GXHRMrWL6v9yL3PD1/YKqOvZHYmKetj9MeXrqN9p8P0fOA5FX72zFROwentSIIvNhJVTQn3MXiY5hA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 28, 2025 at 04:49:24PM +0100, Vlastimil Babka wrote: > On 2/28/25 13:13, Uladzislau Rezki (Sony) wrote: > > Add a test_kfree_rcu_wq_destroy test to verify a kmem_cache_destroy() > > from a workqueue context. The problem is that, before destroying any > > cache the kvfree_rcu_barrier() is invoked to guarantee that in-flight > > freed objects are flushed. > > > > The _barrier() function queues and flushes its own internal workers > > which might conflict with a workqueue type a kmem-cache gets destroyed > > from. > > > > One example is when a WQ_MEM_RECLAIM workqueue is flushing !WQ_MEM_RECLAIM > > events which leads to a kernel splat. See the check_flush_dependency() in > > the workqueue.c file. > > > > If this test does not emits any kernel warning, it is passed. > > Well the workqueue warning doesn't seem to make the test fail. But someone > will notice the warning, so that should be enough. We can't instrument > warnings in other subsystem's code for slub kunit context anyway. It would > have to be a generic kunit's hook for all warns. > I agree. > > Reviewed-by: Keith Busch > > Co-developed-by: Vlastimil Babka > > Signed-off-by: Uladzislau Rezki (Sony) > > Pushed to slab/for-next, thanks. > Thanks! -- Uladzislau Rezki