From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28390C2BA1B for ; Tue, 11 Mar 2025 22:00:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BFBBC280002; Tue, 11 Mar 2025 18:00:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD1C3280001; Tue, 11 Mar 2025 18:00:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC13B280002; Tue, 11 Mar 2025 18:00:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8E86A280001 for ; Tue, 11 Mar 2025 18:00:28 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E412280711 for ; Tue, 11 Mar 2025 22:00:29 +0000 (UTC) X-FDA: 83210639778.24.81D0076 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) by imf03.hostedemail.com (Postfix) with ESMTP id CCF102001D for ; Tue, 11 Mar 2025 22:00:27 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=armlinux.org.uk header.s=pandora-2019 header.b=F1O49Jcd; spf=none (imf03.hostedemail.com: domain of "linux+linux-mm=kvack.org@armlinux.org.uk" has no SPF policy when checking 78.32.30.218) smtp.mailfrom="linux+linux-mm=kvack.org@armlinux.org.uk"; dmarc=pass (policy=none) header.from=armlinux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741730428; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LWqJoM88kHGjOcIG7y4jtQUycMU0Xkkz6/jQHA0YJWI=; b=Tk9jboSDpDc37H5bw0m3wZ4tC/1OMV3DLxl/9ed5OaEZJfEkp7bya5OWYX6NBi6bGbkrYm gybUbVJ7DRu7ufAJPbfhaU4qFl4bZhGkVMyWVl3HaD+Vupjo4WwXEXLVMhgJdAeTleU2Wc vjzFELdpU0BhDjmFtxODRY1l4JoDKho= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741730428; a=rsa-sha256; cv=none; b=YaDTmn8HfC7gsVRFEkDrW4S9ANJIRaPgtzZIs50DUSfsWpCk6v4GHnKxsR6BJ+w81XPVQ/ Dtn1jLQwgsXeW6UYK5GMIMh02QMumla5KowVQazaW4d1ksZk2BqIZxTGVPiMU80xN9Pb3h g30HSn1u9sRhHhwGQ9YHj6+Eu8p9QMg= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=armlinux.org.uk header.s=pandora-2019 header.b=F1O49Jcd; spf=none (imf03.hostedemail.com: domain of "linux+linux-mm=kvack.org@armlinux.org.uk" has no SPF policy when checking 78.32.30.218) smtp.mailfrom="linux+linux-mm=kvack.org@armlinux.org.uk"; dmarc=pass (policy=none) header.from=armlinux.org.uk DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=LWqJoM88kHGjOcIG7y4jtQUycMU0Xkkz6/jQHA0YJWI=; b=F1O49JcdrryD+c7bjEti6SJD0k 5m7yB4f0mnO5oz3PWpTGFZeEDOz6jtfbEDUSGHdJuMJUdyyJrvc8w+axXtk6TDmTIIbFbkuO1ydxZ ZkUVQwkCQYx3t/GvJXd0N89ERqlBZ1oyV/qsqt5n8bhxYILHdPBMEdtZh+E3rV1O6LTEgz6NY19dX uMkm10gBWDJvLQbGsJ+OV21R+sYmoK2kOuMEJxHVPH/5fNpWBs+wMK5IxvFr7yXp1/8ISm8hB2ZeX FrHvjmC4OQ8J8YC0afIQJre6b+7hqinDLiAbLbux5CbnHbe0gdh4CpCr9WT+96+4aXVFDLO7rTs/o DeeyVT7w==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55314) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ts7dT-0004fB-2A; Tue, 11 Mar 2025 21:59:39 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.96) (envelope-from ) id 1ts7dN-0003qv-0O; Tue, 11 Mar 2025 21:59:33 +0000 Date: Tue, 11 Mar 2025 21:59:32 +0000 From: "Russell King (Oracle)" To: Mark Brown Cc: Mike Rapoport , Andrew Morton , Alexander Gordeev , Andreas Larsson , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Dave Hansen , "David S. Miller" , Dinh Nguyen , Geert Uytterhoeven , Gerald Schaefer , Guo Ren , Heiko Carstens , Helge Deller , Huacai Chen , Ingo Molnar , Jiaxun Yang , Johannes Berg , John Paul Adrian Glaubitz , Madhavan Srinivasan , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Palmer Dabbelt , Peter Zijlstra , Richard Weinberger , Stafford Horne , Thomas Bogendoerfer , Thomas Gleixner , Vasily Gorbik , Vineet Gupta , Will Deacon , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH 10/13] arch, mm: set high_memory in free_area_init() Message-ID: References: <20250306185124.3147510-1-rppt@kernel.org> <20250306185124.3147510-11-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: CCF102001D X-Stat-Signature: 5o79i8uu5b5481t48ua7s6wtds86ywrb X-HE-Tag: 1741730427-549988 X-HE-Meta: U2FsdGVkX19kKO7uULiDA3EzlftNZ/nAk9c4Vo3LbNbt7US3ApQfa8wAx44nt3DaIEruD2Cnl1G1+iGHdJlACQS73kL+BxIKwjzQ+ZZVMCYvG3q7CH7xS50lxb4c+BYHbyK1qwv7OCbi9/3zCILovVx21iBmL1Fg3OvabdpXrzDLnal1OFMCKAmxYA6Yf5sNU/iFIX/9ccKNaueVvz3ttqQdEeIpu4xTbi/K8LOADPEx8nCAiYza6TfvGEVfwLi9ig89p8l2QmAGICHF3AfVvuHgfGtr/nwYW6G/+wrfzUBZzoT167fdzVbApIelBf2irTRUbzoDwB8qVPSwPnVfgdxtUrGhq3EHqTLcdQ3CorJNI8BEaI0v1cSBtVILDgnuu7C0+GAYqh757pPLOppitbyCtVBb1GiDmcHdxzjXrw+w9cB/EPJIkWSOUBEr3Yu5kj/i7JaUtWRIFQtK/1tXF+5xiDeA3MQPB8njMo0ElYIgCcPvgkyT5Yb9NlS5IZaqMSGhGxrf6i9kz7cSdJ3E0OIZHY8k/v/iUB8eR5XGdlDggEtrDQ1iFGZNYt8YrUJlzohZCQBzSRO25C5LJp8xuGq32DLEYwFnyChUVcQFe7qqb0SkfjMmXOmrZmRdAj/5PeGC3t7TW4p2RJUErFWrYBjadhKu6T6dhhqTSUYi75bTtj1Dt7BImwJmg2VXDgpAcF14N/1QorEHCS4JxuuImms02CWJiBNibUse9kULFvB8DyS97cSd2s0cBSAzT+5QMrJOWuTJMaZFKN/A34Csm/4id9xT5fj8eiDY9ZZa7qh13K9MKkChI+dYuXQuWj1FgGmmNIlA4gvykpI73sQdQikU6JDh2+CZeh/IvSClNQMi5CrVf8Vcqy5/wyZ7siA9Hj5WR2IRHnN9OI2ZxUDagHshYdXlndFR4LC8xo0+Bx20VjtiuV1svYaDYHFT3FyqcYWsm7PV6gX3g6KIa7L BNV884lD Rp0/M7a0XQIzvc4jh1YjtFpzViGGV4/+BIPEJUsdk8G/hfFSHSpk3RZJOCdmusVg8naM32DUrXbmrWd7uGwIsxdbyweOPvPU/a3nhTGKdtYQ5bgEi+nF9pvWDIDtctreDjkUGw2JpD8hW8xvJVzUgXvAt9qHqWNldoaNcB6a+9/odZ4IgxrNNDpYNiKRP//py/f2khOrJYi25HHv8l78ruaAEmKJ1PwWEqnY70kmqnqibq812P8jiBIgrx91Us2yz3KCYgod9Ydx5ddxQXDCaWWCKtSVGufl3DZkwPgbXpDJdkrZQpbbcS550/MxP+FeWG51lp6cedX4SnBgGHxXIb2fspQiifMKLVH3hDTxeP6cEmUZ/HMeOdyZWHz0IKvez94lc/5iy0AsWVQf/8YpmRpUnc5ON/slwQQXMOaKZR228cETeiNl302NwoAJMkxAsEqWDqS5eAlnCsGAuYQFja6/zpR31vdp8Cx1y1cRmboRDNSL0U+NGCz7TNM7gfSTDAuCXRoSo5Rb5ubQP+A79lc7AL8drv5lbQve+ts1taz1VSn8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 11, 2025 at 05:51:06PM +0000, Mark Brown wrote: > On Thu, Mar 06, 2025 at 08:51:20PM +0200, Mike Rapoport wrote: > > From: "Mike Rapoport (Microsoft)" > > > > high_memory defines upper bound on the directly mapped memory. > > This bound is defined by the beginning of ZONE_HIGHMEM when a system has > > high memory and by the end of memory otherwise. > > > > All this is known to generic memory management initialization code that > > can set high_memory while initializing core mm structures. > > > > Remove per-architecture calculation of high_memory and add a generic > > version to free_area_init(). > > This patch appears to be causing breakage on a number of 32 bit arm > platforms, including qemu's virt-2.11,gic-version=3. Affected platforms > die on boot with no output, a bisect with qemu points at this commit and > those for physical platforms appear to be converging on the same place. I'm not convinced that the old and the new code is doing the same thing. The new code: + phys_addr_t highmem = memblock_end_of_DRAM(); + +#ifdef CONFIG_HIGHMEM + unsigned long pfn = arch_zone_lowest_possible_pfn[ZONE_HIGHMEM]; + + if (arch_has_descending_max_zone_pfns() || highmem > PFN_PHYS(pfn)) + highmem = PFN_PHYS(pfn); +#endif + + high_memory = phys_to_virt(highmem - 1) + 1; First, when CONFIG_HIGHMEM is disabled, this code assumes that the last byte of DRAM declared to memblock is the highmem limit. This _could_ overflow phys_to_virt() and lead to an invalid value for high_memory. Second, arch_zone_lowest_possible_pfn[ZONE_HIGHMEM] is the _start_ of highmem. This is not what arch code sets high_memory to - because the start of highmem may not contiguously follow on from lowmem. In arch/arm/mm/mmu.c, lowmem_limit is computed to be the highest + 1 physical address that lowmem can possibly be, taking into account the amount of vmalloc memory that is required. This is used to set high_memory. We also limit the amount of usable RAM via memblock_set_current_limit() which memblock_end_of_DRAM() doesn't respect. I don't think the proposed generic version is suitable for 32-bit arm. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!