From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D793C678D4 for ; Fri, 3 Mar 2023 14:38:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C81E36B0078; Fri, 3 Mar 2023 09:38:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C30F86B007D; Fri, 3 Mar 2023 09:38:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1FB06B0080; Fri, 3 Mar 2023 09:38:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A0DBE6B0078 for ; Fri, 3 Mar 2023 09:38:46 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 74902A1293 for ; Fri, 3 Mar 2023 14:38:46 +0000 (UTC) X-FDA: 80527843452.28.66B0827 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id DC3CBC0016 for ; Fri, 3 Mar 2023 14:38:44 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=RreymLWF; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677854325; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AbaAvafZP1xfr+wB9hanYwLc2el3IrC2XvoYQ5U1N/E=; b=7piRRVihE6iODATIYr3dRP/VCv12B2whC8KF7rxEFc+9SlWLTussvuy2xheTsDF7YTPcDT BXHDcZW/TbttbJsdTqWKowdV5GQkcLXzueq17fGlQud+hSuCOt/JLPLkZNLurUUvxJvt+d nrdAOESlFx4z09wVMlglKFv4jTME1Lk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=RreymLWF; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677854325; a=rsa-sha256; cv=none; b=PXlYVt/7RU62Zp7C+8spLWjUjPAYd74IOynhjebtbj6un1v6T+7U3IxVOwKRXdLs/+ex2A 7B0q6nkekGVmlh4VTXf7IV9KLOhuE1yT75Wl4DAiXARPsH3VG98LeS6R26BGSQjJ4742i5 SijksUgYR5O7MEHTc2Zf0ciUz1JnvaI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AbaAvafZP1xfr+wB9hanYwLc2el3IrC2XvoYQ5U1N/E=; b=RreymLWFImULYU86P3aG/AZq2o JjRhu70Xaa07I+8iwn6nQrXLpOLD349x+44DHxiz3eM9dM89yGnHIUIMkhNTk3oYNhTUqncgNN9up JegIbhTXAkPI5e1yORpXwabhGxWHwK/Y1SUZUnu1VJgRA6FIqrXwqSPJ/CkJbKY5OKxrJDOjLL+Qv vxyUCmsb/4IzDDtbGClAqKNKOfvPoTakvnpuOQXJaL+Zc48ozdlj3x0pTamPwEFPtrB0BLDNXngFV X6F/OP/caX+SsIR34y6pAT4i4eTADKSgwBoX0rUkhgB9zy08/hNJhNNQ9iUNO+20l0cjYVMxAdx4C kbkKmktw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pY6YT-003BQ2-It; Fri, 03 Mar 2023 14:38:41 +0000 Date: Fri, 3 Mar 2023 14:38:41 +0000 From: Matthew Wilcox To: Mike Rapoport Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Simek Subject: Re: [PATCH v3 14/34] microblaze: Implement the new page table range API Message-ID: References: <20230228213738.272178-1-willy@infradead.org> <20230228213738.272178-15-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 85gdq9cnz93tke8iufn9m6ghzrto8x4d X-Rspamd-Queue-Id: DC3CBC0016 X-HE-Tag: 1677854324-867542 X-HE-Meta: U2FsdGVkX1+IRXjiT1d/i1weMcVImTu1A25nM6RS8CiCiaJfs1Sw0i//ZbZ5x+oeH0mVQ5BCNuaO5FMs9WnqNWlLJKfXXXnXmJKiNmsAonxvX5LjsGd1hZQKVaTTuuge/QOEhIBVGJpvy3Ouh5Tx/7xDegjD64sESrdHB0dZqdYA2FU2zG+40+d9sLH+BzIvG2ogwwRddlU2i+tosfilYZ0xQpqulcCx97QnPSdc6xJTQYq0H1tTBuCojJZ9Gl6GitSUX1w06Lv0R4w84JHXxjc0ZN+BGG4o1B1UC+JzO59tg3RKMqJW/7QecDiA9LG/K/sScvfq7BWTGMTcxd10doqcGqUvaUouFjRDR+OUEYG4SFHGsbn6+QU14zDOzejZ6q15IjIUIwtLoGn3tqphng+D5Bspw1l95Ig4hoNTLsLMwk0IQfLA53KKEhRajMa5EzvDmv+z3ROwAsumkNvjQUvGpBkgoJ+FWGBRxAJAGLrTuM90VU2PexrhM5XwXEEF4KivdpAgo7MvRqhYFmOgkhOzBBf7QYpO2QK0u1ZGbQVLtV4RD7VmG6l15W19SSF1DgzC8+NzZ+lbOfp3l4WK3J2dFI6UXoIoIxxbBI97YBBZrK2wpWUGJTi1xd22cmnZmHlOXvFiSuos9oj0vHHfLSxkiUQoc3GS3CGKSF+dgKnYpI7st1LiB/prDdHWf8kyq1vgMfwfG/Btd571LDC4i35nQku4KC+o3aep5h2gil1sVFlxmp627nTBro89Mks89vXccPQZAAfnA6C626GSoQFTrezUBmlgxSnEqx2l7Z5iDoQiaQ/VSboN68/Exu0PVQHVcneq8r07bdSekq3P9Jk6UtE4N9CxB4QfijDryv6gROCTK2rwVPNcu4EBTVF1WwW78ZPII3Q2UlZY2DwDFBKC7NiFdKRFPQ0D1NnPGkNv/5BimFe0qveepRwa5UaCFveeCKTB0sY0OcdXMWI 0AxYcVW0 1anqcH/bfJoDFjASQGGh9xCpsJhW7iXkGdLtyWNFv7sRzBrDjgx/JxJUxpq+IE3VGGMi8QZVYz1GlJM1Br7ntXm+o00nYeFoiDZcxdl7834AHEdJ/NKqjPRz5RcGIuYnUNilfkmdd1DrOfELx3nx6PlekDw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 03, 2023 at 12:53:36PM +0200, Mike Rapoport wrote: > On Tue, Feb 28, 2023 at 09:37:17PM +0000, Matthew Wilcox (Oracle) wrote: > > +static inline void set_ptes(struct mm_struct *mm, unsigned long addr, > > + pte_t *ptep, pte_t pte, unsigned int nr) > > { > > - *ptep = pte; > > + for (;;) { > > + set_pte(ptep, pte); > > + if (--nr == 0) > > + break; > > + ptep++; > > + pte_val(pte) += 1 << PFN_SHIFT_OFFSET; > > This is the same as > > pte_val(pte) += PAGE_SIZE; > > isn't it? Looks like it. Based on this: $ git grep PFN_SHIFT_OFFSET arch/microblaze/ arch/microblaze/include/asm/pgtable.h:#define PFN_SHIFT_OFFSET (PAGE_SHIFT) arch/microblaze/include/asm/pgtable.h:#define pte_pfn(x) (pte_val(x) >> PFN_SHIFT_OFFSET) I only looked at the definition of pte_pfn(); I didn't look to see how PFN_SHIFT_OFFSET was defined. I don't see the need to change it from what I have though?