From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8386C7EE2D for ; Fri, 3 Mar 2023 15:36:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6370C6B0072; Fri, 3 Mar 2023 10:36:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C0BB6B0073; Fri, 3 Mar 2023 10:36:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43A4A6B0074; Fri, 3 Mar 2023 10:36:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2C1686B0072 for ; Fri, 3 Mar 2023 10:36:00 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EF8501A043E for ; Fri, 3 Mar 2023 15:35:59 +0000 (UTC) X-FDA: 80527987638.29.3AD94CA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 71EEF1C001F for ; Fri, 3 Mar 2023 15:35:57 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="bAp6Cx/X"; spf=pass (imf18.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677857757; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i0kL2F3roXwPeTO3C+PURsaXpvpP++lBa+L0HVed97U=; b=6wmBHLDxp6nmE9GHbDw/58vFBOrusWc0V7QAAz3rgQXqhmGkkwta6nv31efQGzTvCywfE6 +W5tO7vOY99wlpx4KhQ/rS9KTdwXlxFKBtKg6LW2jHykCkp4Sx94HHw/UFBZQxiU17RPHe TUS4+CaenAo1ZOx8J9M+QBUweYrw3r8= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="bAp6Cx/X"; spf=pass (imf18.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677857757; a=rsa-sha256; cv=none; b=4EaVvSEh0W9ucR+9egQnpm00wAXFEK59kh2jVcMTXMWNu0H63CQNjjdalT3UArXTkRzrND 6vipYaJ7zVGfSqy9g4Pfr5UV+tEn0JKjPuLktQq3OQKptu7UQni0uz7chUPvVc5V9DLzXt GOzmVMAgDVTJVm/e1WX6/9eJN0OZqFI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677857756; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i0kL2F3roXwPeTO3C+PURsaXpvpP++lBa+L0HVed97U=; b=bAp6Cx/XVTUc6VAu8JYTa1cd7xAOMDwjvVApA5fQCsXUwnSJKiH/3rSAOI+PAmouIipdO5 73zF/qy47D0pYQkQ3KKsjfFmcjKA9YdEc9bmGft404W7zBjtiv/WcURNXexJXjonqi/lj+ wwpGUHTdy1jRytVnTBcC7KvbArLPxjo= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-379-HxsCobOPNvKlUr6OU7QBAQ-1; Fri, 03 Mar 2023 10:35:55 -0500 X-MC-Unique: HxsCobOPNvKlUr6OU7QBAQ-1 Received: by mail-qk1-f200.google.com with SMTP id y1-20020a05620a09c100b0070630ecfd9bso1550321qky.20 for ; Fri, 03 Mar 2023 07:35:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677857755; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=i0kL2F3roXwPeTO3C+PURsaXpvpP++lBa+L0HVed97U=; b=2hSBY+gMLU09Eh/wKcIJqBg5VUCKlGVDqfporUepPfR3z8onjCszxe/R6AzL9wPbG+ kySvYofYjTDbuWeiM8Ad8iuI0LU8W36iT2m0YDfSaopCUATabE/Pz7oFwb0lIHk2bSr3 JBbH/OFf4HFhWxv4BD857vMPXalOExh8fzW7b4H00aNQx9KSRdnOCNgfS/gR9Wu5QKrd 4rekP/TLAnwPGtjOIupKamelJLoOhqvYDC6f58zKmNJwoCxtKwdDpnzagxWD/JgZ6JkQ pU5ts1r7F82BxPGfgFwrbp2N0zdoK4E05YQxcZud1jwjhwvYlDiMDWV0ZnFFnkh6u4lm 8qgQ== X-Gm-Message-State: AO0yUKWF4Rkn0IsH2v1ym3XBndVDu7oKCVcs+Rlro4pJvVHYmzPkdVAE qeD6LWy/DSlKKewiWeSUskiNnPTfkgbBk/DIDmoGMWTraGXOJk7XhqO343ZAmpuo/lGHpzDgXAk kN6gKj2RSryg= X-Received: by 2002:a05:622a:28a:b0:3bf:a60d:43b9 with SMTP id z10-20020a05622a028a00b003bfa60d43b9mr3596854qtw.4.1677857755043; Fri, 03 Mar 2023 07:35:55 -0800 (PST) X-Google-Smtp-Source: AK7set+3mcqZLv5O6pE/bMB+WazZAA7+g7AIZGHurGdscVxsG3ogM/CcqyrobKFw1jTrlB7s1oWSsw== X-Received: by 2002:a05:622a:28a:b0:3bf:a60d:43b9 with SMTP id z10-20020a05622a028a00b003bfa60d43b9mr3596813qtw.4.1677857754759; Fri, 03 Mar 2023 07:35:54 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-56-70-30-145-63.dsl.bell.ca. [70.30.145.63]) by smtp.gmail.com with ESMTPSA id r13-20020a05622a034d00b0039cc0fbdb61sm2052593qtw.53.2023.03.03.07.35.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Mar 2023 07:35:54 -0800 (PST) Date: Fri, 3 Mar 2023 10:35:53 -0500 From: Peter Xu To: David Stevens Cc: linux-mm@kvack.org, Matthew Wilcox , Andrew Morton , "Kirill A . Shutemov" , Yang Shi , David Hildenbrand , Hugh Dickins , linux-kernel@vger.kernel.org, Zach O'Keefe Subject: Re: [PATCH v4 0/3] mm/khugepaged: fix khugepaged+shmem races Message-ID: References: <20230217085439.2826375-1-stevensd@google.com> MIME-Version: 1.0 In-Reply-To: <20230217085439.2826375-1-stevensd@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 71EEF1C001F X-Rspam-User: X-Stat-Signature: 4pxxh9kfyzjxzcjf9d61imtqftiphyg3 X-HE-Tag: 1677857757-681416 X-HE-Meta: U2FsdGVkX18OVD7FM3B7dzM2AaMp4x138H8BgB1cftGq7hbhc+/WlpeZceQVdWvGz2T09stQhGrP76q2VY9cwGgr6T9ALJJfSb/vRWzypuTsMLZOaFdjxcd9eE9fo/mn442E+3b28ZBWEANMwDrIf9JxBmabXzMV+lDv2I3i94IY2l/nkjzmZxRROJrP+ngXkQCc81Tb2t+iOkqihPSrfsyvYBiCQz38Yk4AnXXXhnalSq18jYHc2uiqypjSATXsXIb7gkniwvtq9KxM7PHfdxFl/4rZcyID+a8dkUfhA/D1OORARxQvdhRsZkMwQ2Q4QB8AnDkWiGNj8NFjbaaAoivMKat6h0ShW+bONs5rrsda8W6dLcmICmHFMmpXFnTY8I72f/PLHX0ff1vSukpi8eXkGjeZbR4Ej0Bndro8viS95cP6lm85ucDfje11PUzIHtu9DqK3+lPrkUXUkimTQERqYyCzUVZRqqAJ4mITURZKSsXMsnPHEH4csCrBGZ2JH6bqMigJD5xk1bdk1TZHKWxhuw5VXzYTu1R4nzzyMC25KaH8Qob61n1CmEyLeW4spivCZ8w0PtUmho9Fa4+a6sUYPM1qvbbOyjIhl4tSFNWCvNw+9WU4pK8dF/EU37JEvnct11uvO+dmqgMIgA58BGXDGM6UD2FJTVmhBXBwl42UwiMGu7Nm+Fo/yYxH5AO8OosSKzvQmpzx53acqZznRSRZatbeea2IgPsBnsl3Rt3sc5CwOKgHNep5V8zHwAum29XrC3grH+6J7+F7NB1sb03fBe4huDT5canffZ5uQksmk32U+rPJObI0c7V67zwEu6ykFmn+bN+cmfep5vtTuzhilHwPM5/+wOEYGbl4UZoXdFNrobhNZrBHDoKGX/2JI+Jv5uhAfPjv5XfmXgECc74joBRngf8hFwrdvw+7cE3exOWTUKltokZ+y++lTwtICZovINhS443dTLZ+RCG NOVDj4M9 egbDdqpph+NeFOwIkxyquxQUIWR6rwXguTvsZtEqn0xDyK5RAK78n6u1BTd10OoWIyiNEzAa/p/1u1wdzYU4Uapvb7r3zrR7oUPzoUPRZ9ryP4rWKmSoLNY18kaWzBZEocobKnBuREIojsyiZrZJuT3aJoWY/2QjY3lXDOX2atU0RD94u9XGG4FsVpzsT+tAKVpitCDfwDcxmRhnV2Nexo/8xaHLDOK0YZym8T51FLAma0u+X++t5uZFG8EZoYvHggiCHpF5+K8183GIFVhM6GL/hXcGj7T+nRIYZCWNJGAWXy/8Fmp0uEyxY1hceUk/pXwLPVz5ozPtowUGHnjXIAnL3CItTvQoqjfyShstRMyimWqjzO2xTUMLLw1O55HQRA/VidGem7kYhCyF/iQgTAyNszYhGuRv/FwW2E/nsIoKY2wErUcWsYe3brRSCg0lPFHp80MdQFFedDTrJ/ymBX+IhoIj+fV6WStz9QMPP7UBQFZF5WR76XuBiOe70PqVZ44DLucVoKMQmHvo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 17, 2023 at 05:54:36PM +0900, David Stevens wrote: > From: David Stevens > > Fix two races in khugepaged+shmem that cause issues with userfaultfd and > lseek, respectively. > > v3 -> v4: > - Base changes on mm-everything (fba720cb4dc0) > - Add patch to refactor error handling control flow in collapse_file > - Rebase userfaultfd patch with no significant logic changes > - Different approach for fixing lseek race I just noticed this one hasn't landed unstable, so I guess I just posted a trivial cleanup that can conflict with this so it won't apply cleanly.. https://lore.kernel.org/r/20230303151218.311015-1-peterx@redhat.com The resolution will be fairly straightforward though, and I'm happy to rebase that one to this since this targets a real bug so should have higher priority. I guess it's possible Andrew thought the series has unsettled comment so Andrew could just have ignored that whole set in the mark ups. A repost could possibly clarify that. Again, it'll always great to get another eye on this slightly involved series. Matthew / Yang were already on the list, also copying Zach for his recent works on khugepaged just in case he spots anything wrong. Thanks, -- Peter Xu