From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29EB5C64EC4 for ; Thu, 9 Mar 2023 14:39:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A343B6B0071; Thu, 9 Mar 2023 09:39:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E3686B0072; Thu, 9 Mar 2023 09:39:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D3D5280001; Thu, 9 Mar 2023 09:39:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7F8116B0071 for ; Thu, 9 Mar 2023 09:39:56 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 59407C07FE for ; Thu, 9 Mar 2023 14:39:56 +0000 (UTC) X-FDA: 80549619192.26.274ECE8 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf30.hostedemail.com (Postfix) with ESMTP id 62E6F80015 for ; Thu, 9 Mar 2023 14:39:54 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Ke6SxSZY; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678372794; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nWOww4kNM3aXVu+kNFIUOfDZdZVkaxNcnTYtu0gjbuk=; b=iHoA/D8kUDQGl4Rcz+mOHtGAx+edJubDvGmLtlW8NIhcFf8Jh7tynBItWdGL5+Fb4VCJGt ztWSc3GFk8hGjR/c2cRZeAQhNX77tVo4dL7DCAC93pIqIs6lczCSPGKGYlRnoiXmPhz6r7 GR9JQNDMdUGyl2mnxjPo6xmBh6luudE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Ke6SxSZY; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678372794; a=rsa-sha256; cv=none; b=x7bc8+e1Ukf9iCvir2fsY0EGK6VwAh7kQSKKm6w/yBtVO0z6JBDUPPNRCJG+3Esb8ybJto sL4Nc4RqRFk/ZocCBgvLSo1CF4NcHDHZKklcF/BxAuDbzdZj9jC/2vBY7J0sIu6Bfy6eKh 604YLLbV6eHJZAMaQRKyEV7LP7g7k7k= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 86BBAB81F63; Thu, 9 Mar 2023 14:39:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CED21C433EF; Thu, 9 Mar 2023 14:39:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678372791; bh=ntChJKalWPnMjCls5ag5q3azt2PJ3UUhYpF2y+sjJR8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ke6SxSZYDQMs+UK3Y8cXPvnRSlOpbkP2B2Y8c5zGh83FZEuy56dl0XCQIEzlm5KCE 8lFbv01f8kDxxHRtvh1DS/tGfdHJF7ADwZfbXSJVBjV0xFY/Ia0TW1HBnqmUY9ujLZ URH35oxzWT84LvuOOam7Y8MKpGauqioQPV5Xu4afi4cuMZ3dFMgr6NgK9Int+8bG/v CiJSHucSMYeUq7n4Nff5MPxjNDUHZKzu56v1yo/ww9B6wpZZ0yl0FDp7xr4D/rCvEQ udbTwUAOaeQwLMc+J0WVtkCFA/o7BpXWLxXoQWoZnBkMVwx296374Ja+sYL/jMy0Bl pjWeqmHp1r8vw== Date: Thu, 9 Mar 2023 16:39:36 +0200 From: Mike Rapoport To: "Edgecombe, Rick P" Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "peterz@infradead.org" , "tglx@linutronix.de" , "song@kernel.org" , "dave.hansen@linux.intel.com" , "vbabka@suse.cz" , "x86@kernel.org" , "akpm@linux-foundation.org" Subject: Re: [RFC PATCH 1/5] mm: intorduce __GFP_UNMAPPED and unmapped_alloc() Message-ID: References: <20230308094106.227365-1-rppt@kernel.org> <20230308094106.227365-2-rppt@kernel.org> <47b5156d814b88ec894f38d245d0a09061112f85.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47b5156d814b88ec894f38d245d0a09061112f85.camel@intel.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 62E6F80015 X-Stat-Signature: ramqipa76jmm4sopigcsqj5zaquw5yy9 X-HE-Tag: 1678372794-629604 X-HE-Meta: U2FsdGVkX19mPYgIkkWEOXaj8O+YSdzKHNDmpCbdFK4PdSAb5tDEbcXAjr6wmJ1G7i4JFvTNoxpDYMd5skAy2PRGeXv0wgxxAF+L61UjuUvNt4y652MeKVEkMBATk/7DhAYbpsN4k6v/1NLJnkk68Am4dOOX0adtuXmsdsLLYpRisoCwf0c4yZHwc5Q4hfQ6QnCXhMXCwmI3Cd3pdR89dEP7gIUGM7PX3e2yuxF5Gop6CTzZnu0AuynGnGRPXQVI5bPRo5nOmPscjrE/7KQkNNQKXTWb6AueRl7qZOnAEuEhVjLXRlxUR0IU/n5EPEbucq2gW/nzLx9wDzv1cOaTTJIAbwrIZJF1uYGbv+rYr/zc9UXVG7qZG+6BL1OMkrygkCRoIZGgMB6jSkTWU2H4Mm44qDX3ThLLNI74i9bDf5fHbOCaaumM+Wv37gulpgpvZdDBT0KSE4EMVK03ei85QYjmkbQj/xgao6qM1WRXKcHOdvH0zSS09riyMCshkjNjJ/8/0I1MHW591mYUCBOV1geUPf1i5tVqhx8XUqaIylkIyswT8bI/2mwylAgI6O1AHIvWYk2zSqMwd1BtzhaMuMx/7zQ2jWhe8GkSEIaY7tdbYoRkldQtqpfdoif+7TVFvRo2pqR/7TTOfHHXVCjMQDDJJOnnFX5GLoLLwSGn71Hht0jzzb3M7hm7RYMzw8V1RtSi0ELwlFJw38qCHeM+iUTCVzgFlHosCiQo4o6rHIHxUdn9Qgu3ACprp9bFVwRAL3eIvJ7NB2G9BLX4hcy3lGEp0Jn/JLbq/kA2+AsVY1Urv8hIbQHx7Nx/IM5sSuSkj1jI4OTttnIZz+C6dyl5kUeCZavk608BKUfkwOiIMPtFM1awVyMvVlu5RAVXIZRSbqAAWIdq9+4bzSNVRoXohJveqOAH1acEY3HnRhkC0SOzzCKmq2PY4NG1DM+MMUuZSjGO974X1G0EXOqwrkz jfZ4J8bB 4J9YmMCu2Un0M3/NIkD6TTJ+6m/GuGnxF977GwAhc/ESKgNP5UnKMgY8g8LwozkusZ68RxHG09izz9AC9Be1wTQceP2Fkfuc54FcnOtRR8tBYZNSQcW8G/D83WX6jDTUnKI24D4sNcjH52UHdCN+KxZlUlcrfNJhWIE8u3SYg5ZO2oNZSa/NXBonKWnicEvOO5pfvZLcdf6Elzb8mUYPTTyERao662HQgEpeta9CLh7ByiiGTVoHRuS/eicrtGsuhAkKjDS0N+gzBSXR8PazqqBKkQ44Iybo80CqW1u+qnTBlv16YbE97iDKs8RmhGKTO7FWMPxVpQXRoLUZW7Vx8FCLOpPGuhHftvpdz5u9McHu1C/3uQAcr2W5UPpfcAUx6f9iNNeTXmEjRkRw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 09, 2023 at 01:56:37AM +0000, Edgecombe, Rick P wrote: > On Wed, 2023-03-08 at 11:41 +0200, Mike Rapoport wrote: > > + > > +static inline void __free_one_page(struct page *page, unsigned int > > order, > > + bool cache_refill) > > +{ > > + unsigned long pfn = page_to_pfn(page); > > + unsigned long buddy_pfn; > > + unsigned long combined_pfn; > > + struct page *buddy; > > + unsigned long flags; > > + > > + spin_lock_irqsave(&free_area->lock, flags); > > + > > + if (cache_refill) { > > + set_pageblock_unmapped(page); > > + free_area[order].nr_cached++; > > + } > > + > > + while (order < MAX_ORDER - 1) { > > + buddy = find_unmapped_buddy_page_pfn(page, pfn, > > order, > > + &buddy_pfn); > > + if (!buddy) > > + break; > > + > > + del_page_from_free_list(buddy, order); > > + combined_pfn = buddy_pfn & pfn; > > + page = page + (combined_pfn - pfn); > > + pfn = combined_pfn; > > + order++; > > + } > > + > > + set_unmapped_order(page, order); > > + add_to_free_list(page, order); > > + spin_unlock_irqrestore(&free_area->lock, flags); > > +} > > + > > The page has to be zeroed before it goes back on the list, right? I > didn't see it. You are right, I missed it. -- Sincerely yours, Mike.