From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13753C6FD1F for ; Tue, 14 Mar 2023 07:18:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8196A6B0072; Tue, 14 Mar 2023 03:18:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C9696B0074; Tue, 14 Mar 2023 03:18:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 692666B0075; Tue, 14 Mar 2023 03:18:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 55B156B0072 for ; Tue, 14 Mar 2023 03:18:21 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 15929A6194 for ; Tue, 14 Mar 2023 07:18:21 +0000 (UTC) X-FDA: 80566650402.19.9471F20 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf01.hostedemail.com (Postfix) with ESMTP id 48B3240002 for ; Tue, 14 Mar 2023 07:18:19 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=S9AG5DWg; spf=pass (imf01.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678778299; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c46t0neyKWHP+SDAFWH/g72V/Nn1AVWpZoacRj8VyLk=; b=HY44brlqhwXVmKX84g02GPwGoGUH/iPEQEDF6aXuTKhkQWxGsZuI/X1WYLOecjN76ROcmP u14mVAS3hQaWRcxZOr/x3Aqfz7lDhRWG8XKOLyOaHZpWHxqCPMS7i3a3I/bm8J2X+/H7RH /OJN7X/rSQq1UgxbfC2W+LjYD7aFgXs= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=S9AG5DWg; spf=pass (imf01.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678778299; a=rsa-sha256; cv=none; b=qv2t9ODnLGPl2X6XgwSGlZVlCBJdrLzvjnLQuyxG0lTMCPg+Djo+rT+Q3RUXW09ww7341/ fOS0wFGZZkGDR3Sc0PYg91gx0DuUSyk9UAOn0w7bIN40xJtJvRk5W5//3UhM/n1G2NAUSB k+d5ICNTUSSR9gzYgDczNT3K0FJpyjM= Received: by mail-pl1-f181.google.com with SMTP id p20so15584614plw.13 for ; Tue, 14 Mar 2023 00:18:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678778298; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=c46t0neyKWHP+SDAFWH/g72V/Nn1AVWpZoacRj8VyLk=; b=S9AG5DWg2XZsDj6Es8WNOGYTopXFo3VAhRsa+mVSSY7aikyWk81a2OqBGTAoyPFgyu uVSkd8JwegJs5MqHNfKT/d8TdpPjlx6OQRMEIjo+QZlppEnGZRJDX91OuPtVkMVO99CF yco0uZPL8mCTz9RAB5pnm/nIB5XrBaA3wo03zf5MOaSGbdpH5uYOOMjO3PjDvP/fmDl/ xMwBnJR9CuNXV5cjhCqwFicz866yGKILl3iLTL0g5K3QFtJK2DHZqnyz6TJve3ZnUq9g TOUd/K54HU/ebv9PY82fNIom9wPQQn7eW9PTBohspDeTgn+yFJ3cyS9mC7O3rX4DGBpL q4vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678778298; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=c46t0neyKWHP+SDAFWH/g72V/Nn1AVWpZoacRj8VyLk=; b=jqNU1YwjYtxL8CVxztqdaSso+42IY9OuUdWPCvB0uNKpiLKfu6gqcxOdodru2KOwiH nGEAnyqrxbUrn3TDnldX+wp4hdjAaBi5uoxSiDcc6W3vAeVmaU2h7WamAos05//fhPTW f5o9L8L+SsBQkDIyCY/ufpvRr0E0njsedJg3ij1+sMGozm1vhvT4uZjvlHYhRARq6HZr Hi3kfBTPTUcWz3uRo7RI63/IX72ON2fEHC+TtbG4NBNnKI5q54VLQ0tSYhZ+wrnytIHi V7Ga8zHiEMUhnbn+rBztTJoNIFXxNmDhHKV11h1mgG18F/BYerB+KTb9cB4qrYrj/i8n Qp5g== X-Gm-Message-State: AO0yUKWv5DiBJVp5DxgzCEMHJ7dMvde94UdXYbXyvqJ/mjD0W6L05KG1 6cYHdoaeqkXkf4phAAVA5e8= X-Google-Smtp-Source: AK7set/TwZv/+gdR3vizxWDK5px/eSNGwwzlyNPxX57Ktb8udmkDrlYHgYRuoNUS4MHfjXuXzOFuGQ== X-Received: by 2002:a05:6a20:a88f:b0:d4:abe8:697d with SMTP id ca15-20020a056a20a88f00b000d4abe8697dmr4420286pzb.30.1678778298179; Tue, 14 Mar 2023 00:18:18 -0700 (PDT) Received: from localhost ([2400:8902::f03c:93ff:fe27:642a]) by smtp.gmail.com with ESMTPSA id c12-20020aa781cc000000b005dc70330d9bsm875550pfn.26.2023.03.14.00.18.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Mar 2023 00:18:17 -0700 (PDT) Date: Tue, 14 Mar 2023 07:18:11 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , Roman Gushchin , Andrew Morton , linux-mm@kvack.org, rcu@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, netdev@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH 1/7] mm/slob: remove CONFIG_SLOB Message-ID: References: <20230310103210.22372-1-vbabka@suse.cz> <20230310103210.22372-2-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230310103210.22372-2-vbabka@suse.cz> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 6wsg5o8kok5nxcgzab4isrt6gfsg7u5f X-Rspamd-Queue-Id: 48B3240002 X-HE-Tag: 1678778299-910911 X-HE-Meta: U2FsdGVkX1+yO/jukgXW/cyB1e9Hh6aJc+EWzLqiy6gBK36wT7jnIN3+O1Th38bBdpgZ1hAGtCZv/Q+42Ls+VyMOa9WzvIAHuVkfafGqOxU17XdoA+0IN81nAlblfHTMC0IAyPlH32L6TUhlSxhF0bq/szsnIaXUFXJlRFwc/fVW22FjRAZfAbXriyDNWW4gclXxptcigTqTzC2MNs9keoSC4JnBtEZsP2Oa66i7GoDFsEjLscGArYSinGPxSmTT4CuxjRlbxh2xqDsMfd1a6dLsp3Au0Jr7GdwwXPKCjQvvCIxVOCUV21Ufn6e5jS5oUXi2H3nHyy/+SkvgEGP9j9dVcqVaeV27PLMOtmI3NMIJcXSpeb4A+7N4rbLzre4dHGHk9WHIJENz3ykZ7RjXxvltDC65L50w/CGW2zPIA3oRdMOfpnypzaZfEdo2rv6ZO7oRO5hKHBVTaduw3VFyf/e06s+EWGcq2vZ5rWaYBIko9nE5koRVgoQV8PXSzhq0zbiEpDyYrulX03kZ8NczZVqVNTWBG6GHCQJJ2sSECxJ0kO5OmKsgIXKZ8NWWwZXonropBHvfdVxaVJieH/DF7Pi6GUl/vm4tuA5TVIx8/y961Y1x3OMw+4bCuT00+xAn8h/pFihuH/tHcZjBPMEyeYIO/spHnsEWcB/PtvChYZA/HTqxhH+JIlFOVgE/EuZPSvTtxez1xxnB5X2T4TvRcymsViWazezxKNr7pPz5Ktn221jbwXbajRVaFYlGBNv2i9gTjo1FgVre/gRIHN7enqD0CZ0ueUXNansrB5VC7NXhAQ51zPF1uO1RDVfQglXxz+m4kX55LYjzRyP46yxUB7A93UjQYpbUQXoaVNb3e6k67elAFz7ouHSnmy3LFVmJHoG1d/+1P6usglBtfahrX+r+HlwJlY8S0C04Uh4qJP59Lr8qb9XgynJmdrxUj75t3qdACLDhTNxScyHMhvz M/aNM62l jESX8CiQS77LBmJFY6G/wD9bwpoL85OxrEPhKPciYRCNLR/VS1B3rY/8GD85wxQy0/zPuwv3VPwViJZ13A6W2HG+5dILqU9/fMWiNInjDT2MVqXRBTYPlcfnwufRuqktsFfjY70wffkavscWj+Pf6z4e+Y5oAJZogzRkwa133+SDU3uhb10EWBZ+P4GLiggN22scF7/YmbMoGu670Kv1RLamU0glCcTS0V80UvjANL7ame5nXo6EOYTTMzz4/Nzb0Xrz6YYIfjcCj5XTh/rsl07wxmYy0C4nmWLd56GHm9bpgOhn2516IhJa7XPWhNRQzrKHsQFodoPcwWtULcClWJA+A6K5mqZKLxnHnIPZ5ahuONzaqGn/Jio1PJ9KNbSN+v76aok49ox0w5iJve0TYiR+ngT16BzpCQBbfh/S3oz5dpm7Sws7AaPlhW3jiotfbqei9wDZSW75bLDAFodPK/pYpgakmKB2ktEauIR/KFRU4G4ovP0cF3yEtgT+Oou1Dkzq+EQ2bq34WIxeR5oz0Jav/MzQLtOnCsFETTVRNlCC357tdFKzgPuv8l+4FTMBP+uHfrJ3vKlR5uEQJ4YLlldpGDn2rj2U4KdNFiQRCzk5K7TE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 10, 2023 at 11:32:03AM +0100, Vlastimil Babka wrote: > Remove SLOB from Kconfig and Makefile. Everything under #ifdef > CONFIG_SLOB, and mm/slob.c is now dead code. > > Signed-off-by: Vlastimil Babka > --- > init/Kconfig | 2 +- > kernel/configs/tiny.config | 1 - > mm/Kconfig | 22 ---------------------- > mm/Makefile | 1 - > 4 files changed, 1 insertion(+), 25 deletions(-) > > diff --git a/init/Kconfig b/init/Kconfig > index 1fb5f313d18f..72ac3f66bc27 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -973,7 +973,7 @@ config MEMCG > > config MEMCG_KMEM > bool > - depends on MEMCG && !SLOB > + depends on MEMCG > default y > > config BLK_CGROUP > diff --git a/kernel/configs/tiny.config b/kernel/configs/tiny.config > index c2f9c912df1c..144b2bd86b14 100644 > --- a/kernel/configs/tiny.config > +++ b/kernel/configs/tiny.config > @@ -7,6 +7,5 @@ CONFIG_KERNEL_XZ=y > # CONFIG_KERNEL_LZO is not set > # CONFIG_KERNEL_LZ4 is not set > # CONFIG_SLAB is not set > -# CONFIG_SLOB_DEPRECATED is not set > CONFIG_SLUB=y > CONFIG_SLUB_TINY=y > diff --git a/mm/Kconfig b/mm/Kconfig > index 4751031f3f05..669399ab693c 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -238,30 +238,8 @@ config SLUB > and has enhanced diagnostics. SLUB is the default choice for > a slab allocator. > > -config SLOB_DEPRECATED > - depends on EXPERT > - bool "SLOB (Simple Allocator - DEPRECATED)" > - depends on !PREEMPT_RT > - help > - Deprecated and scheduled for removal in a few cycles. SLUB > - recommended as replacement. CONFIG_SLUB_TINY can be considered > - on systems with 16MB or less RAM. > - > - If you need SLOB to stay, please contact linux-mm@kvack.org and > - people listed in the SLAB ALLOCATOR section of MAINTAINERS file, > - with your use case. > - > - SLOB replaces the stock allocator with a drastically simpler > - allocator. SLOB is generally more space efficient but > - does not perform as well on large systems. > - > endchoice > > -config SLOB > - bool > - default y > - depends on SLOB_DEPRECATED > - > config SLUB_TINY > bool "Configure SLUB for minimal memory footprint" > depends on SLUB && EXPERT > diff --git a/mm/Makefile b/mm/Makefile > index 8e105e5b3e29..2d9c1e7f6085 100644 > --- a/mm/Makefile > +++ b/mm/Makefile > @@ -81,7 +81,6 @@ obj-$(CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP) += hugetlb_vmemmap.o > obj-$(CONFIG_NUMA) += mempolicy.o > obj-$(CONFIG_SPARSEMEM) += sparse.o > obj-$(CONFIG_SPARSEMEM_VMEMMAP) += sparse-vmemmap.o > -obj-$(CONFIG_SLOB) += slob.o > obj-$(CONFIG_MMU_NOTIFIER) += mmu_notifier.o > obj-$(CONFIG_KSM) += ksm.o > obj-$(CONFIG_PAGE_POISONING) += page_poison.o With what Mike pointed: (removing 'mm/Makefile:KCOV_INSTRUMENT_slob.o := n') Acked-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > -- > 2.39.2 >