From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42771C6FD1D for ; Wed, 15 Mar 2023 09:21:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F32A6B0072; Wed, 15 Mar 2023 05:21:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A31F6B0074; Wed, 15 Mar 2023 05:21:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81C046B0075; Wed, 15 Mar 2023 05:21:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 72A8B6B0072 for ; Wed, 15 Mar 2023 05:21:26 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3D764160151 for ; Wed, 15 Mar 2023 09:21:26 +0000 (UTC) X-FDA: 80570589372.19.9A321BE Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf16.hostedemail.com (Postfix) with ESMTP id 6446518001B for ; Wed, 15 Mar 2023 09:21:24 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CC1f8HDM; spf=pass (imf16.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678872084; a=rsa-sha256; cv=none; b=4Ly48pnrGthMeg3VLyOUEGhigDt9geEHwcLrii+oTzogOG4Jrq2t+7m3D1av07w2ncu44Q Nr2j6ik8aRtSDYS6y5svHZjLMCuNwH0R6Vq43dPHBKU88ReOpJtBT9H/SbYD1jlivkZiEH SUn979DsfkJq7aoreLTYTt0zVvjp6MQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CC1f8HDM; spf=pass (imf16.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678872084; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TqHdGw531X+wyKeG+gcBy3p8/wN1uN5DTGX2GpkROZY=; b=WchyMV///p0glkKyKqrTr0+bAYPjJqb5fY0m34ujg+jdzpSzPTTE6k5fkryz2ZCZha/Nh/ 8sdG5XfDFeK4u/mxGfHsYPZ1hmbgLWH2luCnzFKkGGo9i+WxKtiR2jtzSLfSGx1M0i+T/s 9fxEwKp6ztRtjHBMzWknfX16tMlG/qI= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A51E6B81BBD; Wed, 15 Mar 2023 09:21:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4FA7C433EF; Wed, 15 Mar 2023 09:21:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678872081; bh=bma7awM6tHmIC3wO1SvO/FynqdjWMUbMRsUs73RSibM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CC1f8HDMk5mh+yXoQO1uNb2ErxcZr3nYdhbeGeShrB7B8SPUSY5lo6sgP/daZztup 6y8laGWeuU9XvN3WtrzW4cLbE0a2HI7AxD7wt+AwU5G2+0HR+tGdoYQ0Juz8jYcJ6B KOVVw+v8fgCble4wjy6cZ7w6r8pQoomkWZeJxzEvtSXwKDVr8sv62+C4FSV7jWN9J+ oSSA/DK9S61JTIG8STBS+nZfPaFyQgnpAOX+2rcS23+3+34kR5z49qkql/GBBBsY6s pw33RsU4qQjKGcgAyWEN/7lMBTu/ecLfn4OtAHATzidnNHxKgiP3VsxP4tKcUklT6O Bqo+5xyOsjaFg== Date: Wed, 15 Mar 2023 11:21:08 +0200 From: Mike Rapoport To: "Matthew Wilcox (Oracle)" Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 01/36] mm: Convert page_table_check_pte_set() to page_table_check_ptes_set() Message-ID: References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230315051444.3229621-2-willy@infradead.org> X-Rspam-User: X-Rspamd-Queue-Id: 6446518001B X-Rspamd-Server: rspam01 X-Stat-Signature: tph8py1gxuebs7kykjximok1bfkq7as5 X-HE-Tag: 1678872084-501256 X-HE-Meta: U2FsdGVkX1+n3+yOU4MOPPW394A1D0QmN4rZ0Xpa12w21t30eCggYJoZuEk3kohCQujJGlswFB5MZHSE/3o5gcozf0jX5jh8C6ITcAoxEk7Qr5b3PseK964Ut7yWT2EzhObWdojI04L2bnqGyC9nR1+kfuqTL+PlljKh/ZO31xCtgFcZOUKsl4cYKHDK6DYM4fKXSJOqBmymbMI7H/JvTOhZyAHime0bFf/yczbK/Qh2W8iVk/MHpWpMtzQkJRYcVZ3uIYVusfQaLLG78CDBzJE6Et3KonJBeCCW1TCZr5cKgpgTWyOFYwLv321sSJaLM+hSoN8ur0CRfu6axK3NlIuzibw1qY+mkh7PVQW5P+uybQrzD8dZuvtWEjesDtSLlrhJEfdxnH3x1QUy36ImhAWDBk0so4AqNfx4iJ43jX+TNwR1H9DQYlaX9uOqIcy/iifz3GyLx1x2yMJHaRGubHmxOaYZOvJhfEv3h9exmzQ4rV8FkQ4QefAQeuqFGMkUpekXRXS1Tb2apZbJefPf0Svo0qxy/g6ZyKZZFTipAzyVHwckwRAWgSNb1Cfhn6QhsIYYqKFeKi/SE1p6ZcEoOOWCY+zsChoVOMSKUUswid7pOcmOAaHzhwKMBi/rQ3JwvLy9Rubs0c2fLZZBx2o3QnkVfU7PD8pGklnD+4f81zupQmrnyjbei6fXUnXXPK8pz1cXYfVdS+xfkvCz57bALbqMsGtc4N6LeuZ72gSAHDSYcTeePiLm2YLqm3FUZW04UhdVimXubbCs3AAYPE4acbz1gN6hK9pQMeN5niHwWoC5K+kThT0KiZcIKDNRu3ItNvnXKAkc6XuOJeYUWweOI4CBzWTd2sYuPPLoGMaO2K6OAdXsIcJsqu3w5A3oClZT4nj0ZgrFPaA88L+abQF8JBV8RgxPWm1J7/uoJ2JLjfzXJtZ7YlrcXPkK4ufTDpiJcvqxTNwDD2NKaNtfWzZ izGIecZ1 /BNVVA2PUJsEXjcO177kopkJPIdWdkl6CB+fW5h64DCSfHUX1YOEro7B63vXmfXDCDnaBhJrJ5TAB9+NgHUjqYyJrMtyH8F/PIpf753CuA6dCqULJcRo9AlPpm+XDMJjZqbnrHgkOY0jYrTj4Uw4U5MqmbJedGJL0zxzg+eQaqGDG/mxF7cSctJ5rcmp+esYB+TYdpn8AhcNiEyqZkYxAwcrioTNzImDWmhkjWTD9r9lLjKlg693XDSynFXakhXbEjNpS75qlsk0bPsMsbaNWRChDXmVjVPP+7sA7oAAxvqDeVAEGpgK2WmmmL8kXaTXfn4TtJZ7rUcM6TQaoGS7Dy5+HXwwTG6RubbOScsXutXiUodQ4e/KJF6UuveHeOszKmDNnKlUPuHd/qaMqSzcieiYZi3WbNbMtoiI2yA8oMOJki6xA6FOXXbmqhdzPbiB/w9LxCI10lzQAYivj6a090mNf8jR9RUe8vC35 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 15, 2023 at 05:14:09AM +0000, Matthew Wilcox (Oracle) wrote: > Tell the page table check how many PTEs & PFNs we want it to check. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Mike Rapoport (IBM) > --- > arch/arm64/include/asm/pgtable.h | 2 +- > arch/riscv/include/asm/pgtable.h | 2 +- > arch/x86/include/asm/pgtable.h | 2 +- > include/linux/page_table_check.h | 14 +++++++------- > mm/page_table_check.c | 14 ++++++++------ > 5 files changed, 18 insertions(+), 16 deletions(-) > > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h > index 0bd18de9fd97..9428748f4691 100644 > --- a/arch/arm64/include/asm/pgtable.h > +++ b/arch/arm64/include/asm/pgtable.h > @@ -358,7 +358,7 @@ static inline void __set_pte_at(struct mm_struct *mm, unsigned long addr, > static inline void set_pte_at(struct mm_struct *mm, unsigned long addr, > pte_t *ptep, pte_t pte) > { > - page_table_check_pte_set(mm, addr, ptep, pte); > + page_table_check_ptes_set(mm, addr, ptep, pte, 1); > return __set_pte_at(mm, addr, ptep, pte); > } > > diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h > index ab05f892d317..b516f3b59616 100644 > --- a/arch/riscv/include/asm/pgtable.h > +++ b/arch/riscv/include/asm/pgtable.h > @@ -459,7 +459,7 @@ static inline void __set_pte_at(struct mm_struct *mm, > static inline void set_pte_at(struct mm_struct *mm, > unsigned long addr, pte_t *ptep, pte_t pteval) > { > - page_table_check_pte_set(mm, addr, ptep, pteval); > + page_table_check_ptes_set(mm, addr, ptep, pteval, 1); > __set_pte_at(mm, addr, ptep, pteval); > } > > diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h > index 15ae4d6ba476..1031025730d0 100644 > --- a/arch/x86/include/asm/pgtable.h > +++ b/arch/x86/include/asm/pgtable.h > @@ -1022,7 +1022,7 @@ static inline pud_t native_local_pudp_get_and_clear(pud_t *pudp) > static inline void set_pte_at(struct mm_struct *mm, unsigned long addr, > pte_t *ptep, pte_t pte) > { > - page_table_check_pte_set(mm, addr, ptep, pte); > + page_table_check_ptes_set(mm, addr, ptep, pte, 1); > set_pte(ptep, pte); > } > > diff --git a/include/linux/page_table_check.h b/include/linux/page_table_check.h > index 01e16c7696ec..ba269c7009e4 100644 > --- a/include/linux/page_table_check.h > +++ b/include/linux/page_table_check.h > @@ -20,8 +20,8 @@ void __page_table_check_pmd_clear(struct mm_struct *mm, unsigned long addr, > pmd_t pmd); > void __page_table_check_pud_clear(struct mm_struct *mm, unsigned long addr, > pud_t pud); > -void __page_table_check_pte_set(struct mm_struct *mm, unsigned long addr, > - pte_t *ptep, pte_t pte); > +void __page_table_check_ptes_set(struct mm_struct *mm, unsigned long addr, > + pte_t *ptep, pte_t pte, unsigned int nr); > void __page_table_check_pmd_set(struct mm_struct *mm, unsigned long addr, > pmd_t *pmdp, pmd_t pmd); > void __page_table_check_pud_set(struct mm_struct *mm, unsigned long addr, > @@ -73,14 +73,14 @@ static inline void page_table_check_pud_clear(struct mm_struct *mm, > __page_table_check_pud_clear(mm, addr, pud); > } > > -static inline void page_table_check_pte_set(struct mm_struct *mm, > +static inline void page_table_check_ptes_set(struct mm_struct *mm, > unsigned long addr, pte_t *ptep, > - pte_t pte) > + pte_t pte, unsigned int nr) > { > if (static_branch_likely(&page_table_check_disabled)) > return; > > - __page_table_check_pte_set(mm, addr, ptep, pte); > + __page_table_check_ptes_set(mm, addr, ptep, pte, nr); > } > > static inline void page_table_check_pmd_set(struct mm_struct *mm, > @@ -138,9 +138,9 @@ static inline void page_table_check_pud_clear(struct mm_struct *mm, > { > } > > -static inline void page_table_check_pte_set(struct mm_struct *mm, > +static inline void page_table_check_ptes_set(struct mm_struct *mm, > unsigned long addr, pte_t *ptep, > - pte_t pte) > + pte_t pte, unsigned int nr) > { > } > > diff --git a/mm/page_table_check.c b/mm/page_table_check.c > index 25d8610c0042..e6f4d40caaa2 100644 > --- a/mm/page_table_check.c > +++ b/mm/page_table_check.c > @@ -184,20 +184,22 @@ void __page_table_check_pud_clear(struct mm_struct *mm, unsigned long addr, > } > EXPORT_SYMBOL(__page_table_check_pud_clear); > > -void __page_table_check_pte_set(struct mm_struct *mm, unsigned long addr, > - pte_t *ptep, pte_t pte) > +void __page_table_check_ptes_set(struct mm_struct *mm, unsigned long addr, > + pte_t *ptep, pte_t pte, unsigned int nr) > { > + unsigned int i; > + > if (&init_mm == mm) > return; > > - __page_table_check_pte_clear(mm, addr, *ptep); > + for (i = 0; i < nr; i++) > + __page_table_check_pte_clear(mm, addr, ptep[i]); > if (pte_user_accessible_page(pte)) { > - page_table_check_set(mm, addr, pte_pfn(pte), > - PAGE_SIZE >> PAGE_SHIFT, > + page_table_check_set(mm, addr, pte_pfn(pte), nr, > pte_write(pte)); > } > } > -EXPORT_SYMBOL(__page_table_check_pte_set); > +EXPORT_SYMBOL(__page_table_check_ptes_set); > > void __page_table_check_pmd_set(struct mm_struct *mm, unsigned long addr, > pmd_t *pmdp, pmd_t pmd) > -- > 2.39.2 > > -- Sincerely yours, Mike.