From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E3B3C6FD1D for ; Wed, 15 Mar 2023 09:28:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DBD126B0072; Wed, 15 Mar 2023 05:28:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D6D786B0078; Wed, 15 Mar 2023 05:28:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C35766B007B; Wed, 15 Mar 2023 05:28:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AD5136B0072 for ; Wed, 15 Mar 2023 05:28:44 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7DD7F4027B for ; Wed, 15 Mar 2023 09:28:44 +0000 (UTC) X-FDA: 80570607768.21.C6AC729 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf12.hostedemail.com (Postfix) with ESMTP id C98474001A for ; Wed, 15 Mar 2023 09:28:42 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PBitN9VY; spf=pass (imf12.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678872522; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+8yakh3+X92uhNOJM+0VqEXWxoIUwpS/r2rc63dLPZE=; b=bLDIbp+iS5zMrrL5RbugAlGTZ+IiTNaEUuZjteKymtM5SivL4lmltIiRSVKx2OhY3sijHt KI2EV15ZbhwdD2/daJSYNCOe23TPhW2J11CudMYvUoE2PdT5W83L2qPEmfVbsrjmBOCgtz 1W0RxTWgn9nU6jrcvFVBNHjJalw4GtY= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PBitN9VY; spf=pass (imf12.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678872523; a=rsa-sha256; cv=none; b=6qRArnfbojoRJWV5PWhpfu62l528ei7ela2Yj2HmBumyzO117kUbCudNBBGzO3xEp45EKT cb8d64OCpFxh+5I3X5SWVmS3dW1ULFuOxt5IVx0pEVfQ5B+LfhKhrzAs78rooksv2muMHt 2+MV+ppKWX4VTCUDT0n2n9PXCVSWstU= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8970FB81DB7; Wed, 15 Mar 2023 09:28:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E884C433D2; Wed, 15 Mar 2023 09:28:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678872520; bh=iqRg2qO3GWrEc0EoQMp3T6JPcclnenU1RS60M1C2JkQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PBitN9VYog13FLH/phZ3daXoGBntZuEE/cNH9QXFLtf0rPjEO6Tq3wkFCY2XP24dw B8TqSJNqAujFJPOfGFXBKIK4hlAXOqr9sn09jJZvN3W3ktUTmsaDmPez3pwqJZS6Lz cIyLRwY9OXu/RwxkCWyEC0LqsXAe/G5SUqEN6H7Zgo6RYu6vBJw1sSA3NS9WoVdng2 neVDiztIHIvk4Iz8ymdVjTR0QSS6jfQVD0RZCfnkMBn1krGWQCHovqjB5cd9kdv9ln F1owxBJbcMhx5fxhhxj1Tn3n/CeN0Iv9wBdXkNGgNcFih1efSQetPNEs+24XpnCnrX Djv9ZcxggACcA== Date: Wed, 15 Mar 2023 11:28:27 +0200 From: Mike Rapoport To: "Matthew Wilcox (Oracle)" Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 03/36] mm: Add folio_flush_mapping() Message-ID: References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-4-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230315051444.3229621-4-willy@infradead.org> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C98474001A X-Rspam-User: X-Stat-Signature: 8phimbggwma3k1kofkiuuysj9pccitkt X-HE-Tag: 1678872522-649145 X-HE-Meta: U2FsdGVkX18czLB/vPA9kpN6pbkd8P4GNDrkUvhahzXGlFjGa+QaFWXP6PI/n/xOOyN1canRuewlLufx8gzPOZicvC0W8Isd8CtY/7JeGBNOv61cdHy58XDP3lL5mg672RGep+zRHmX43cLWQFcj5+NX3P0sYUBoc6h5L5LOn2NuPxzaLR2kDN7rRz3nvSSTqvMXNLwfmMgW2nuWGHMkSIi/KYpZvM/3S3fMDEqwDo2itZCW9SaMqB/vah2OPMVY3axG+pv91CCQ8zA1j/KR35MUXy0XyBGX3HIlXPV2KDhEGDvGWWkqwZK5gH/9I+uhZ4wXeylXD5smChqja82goLKRZVshWCGU3hJCVIYByQWB3/j01q1sGTPD3U1zfvBtWJf00LbgbVoJjpUl+uSRqKle85pOSxa0DVAemCVJzvLr9AFBXfLETGUT9qYuSrYJE1zdA4bjCGucCAhw3U/PYKWeL13BCTxAFlgWgFBJSWjUXWeD/RK8XASliYSggTaqGiQSBUQDlvg5xFTh9D5HZQV6QIp15tB3Kle3y8bzjANyXLZ8FuZxTX2MLAMH6mw4OnyPNkWzX/cbrrt3aik0g0pc0vuuxmM+sAkzgyLvygMSlCH8TvAE7sgVOA2wIyi1Qsh2inib8qnIAC7LrHhMqfjhby7vhvkGO+21WLfCaJ/MGMrb0UI4QAgvuFpP7GFSIKjVc8FycxHS9jvzGXd51cwWRdLQq2URpNp0XB9KQtVdashj1aHy4IJEV/w6y2dig8i67CSSsK+epswYVdNljw+gn3fETZpY2swTkhQWzQMQlninciH9psnpAnMxy5vcIMd2g9l48QY2Di25u8TqzpbcU6GjmnW2CT5PIm9LiDpBRB2bDERUXDebLDA3HEBxNxydoEDbbFVcgD0xYyirCv+etyI8eQbV7aA5Vibw0m7dIzvMJRv/KMh1OvKZ4qLUci6JwSIowDw1cWqWzwC H1RGSLSa /LvhROp15Bo9QOovgHFNMqfON11budPLbTWPZXZd/tK3FZpCWdjI55DCXiD83/lJkL58vdWuRy4Ji8NT5nzpepMQh8JsxTDNNlQJhtC3hqRDs4iOPmj8R3FH5il9qz0n+MQtWHLMeGKPKDoi/FqrK5uDuvaV3oFh1qtySIsSu8NdlnG9FnLjEO3dQfCyBllzaj82g9xU7Tnm1wMBY3vUkgIdhki/7pkv77jQVxH/o2Hm48heOaByD5tUbdlqpYW8Is2RztldjYDK7bdLV4/kwLFKqHg4b+MI6cPf7F5WIPjXqq2RyWtL414tKid5mylo31LaIgd/5lnuzhBV7e8aO/Lccg7D+d/Gg+lM84DEuDXGPwlDM0iTMBc91QIeslkIjan++XSkk33JiNOLRs9BOMobSelpvUulcX+v4xVXws3/P/vPaa+YWfiphGH0LS4kny06U9jCLH4usPxd74Go5OyJs5g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 15, 2023 at 05:14:11AM +0000, Matthew Wilcox (Oracle) wrote: > This is the folio equivalent of page_mapping_file(), but rename it > to make it clear that it's very different from page_file_mapping(). > Theoretically, there's nothing flush-only about it, but there are no > other users today, and I doubt there will be; it's almost always more > useful to know the swapfile's mapping or the swapcache's mapping. > > Signed-off-by: Matthew Wilcox (Oracle) Acked-by: Mike Rapoport (IBM) > --- > include/linux/pagemap.h | 26 +++++++++++++++++++++----- > 1 file changed, 21 insertions(+), 5 deletions(-) > > diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h > index a56308a9d1a4..e56c2023aa0e 100644 > --- a/include/linux/pagemap.h > +++ b/include/linux/pagemap.h > @@ -369,6 +369,26 @@ static inline struct address_space *folio_file_mapping(struct folio *folio) > return folio->mapping; > } > > +/** > + * folio_flush_mapping - Find the file mapping this folio belongs to. > + * @folio: The folio. > + * > + * For folios which are in the page cache, return the mapping that this > + * page belongs to. Anonymous folios return NULL, even if they're in > + * the swap cache. Other kinds of folio also return NULL. > + * > + * This is ONLY used by architecture cache flushing code. If you aren't > + * writing cache flushing code, you want either folio_mapping() or > + * folio_file_mapping(). > + */ > +static inline struct address_space *folio_flush_mapping(struct folio *folio) > +{ > + if (unlikely(folio_test_swapcache(folio))) > + return NULL; > + > + return folio_mapping(folio); > +} > + > static inline struct address_space *page_file_mapping(struct page *page) > { > return folio_file_mapping(page_folio(page)); > @@ -379,11 +399,7 @@ static inline struct address_space *page_file_mapping(struct page *page) > */ > static inline struct address_space *page_mapping_file(struct page *page) > { > - struct folio *folio = page_folio(page); > - > - if (unlikely(folio_test_swapcache(folio))) > - return NULL; > - return folio_mapping(folio); > + return folio_flush_mapping(page_folio(page)); > } > > /** > -- > 2.39.2 > -- Sincerely yours, Mike.