From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C885FC6FD1D for ; Wed, 15 Mar 2023 09:34:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5CABF6B0072; Wed, 15 Mar 2023 05:34:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 579F76B0078; Wed, 15 Mar 2023 05:34:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 468AE6B007B; Wed, 15 Mar 2023 05:34:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 376B46B0072 for ; Wed, 15 Mar 2023 05:34:19 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E782BA0330 for ; Wed, 15 Mar 2023 09:34:18 +0000 (UTC) X-FDA: 80570621796.11.A4BC47A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id 266D0140015 for ; Wed, 15 Mar 2023 09:34:16 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=W4ngLAyp; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678872857; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Izm1c5p5XOe5RQ1OqFNU1nUOyFRBgca+ZRbyyJPEjS0=; b=7xllWth8TQ8iWWuhxxbvsTIOBf3Z4BrPunByxgS/zAhsnmtVhaxErVI2SEo70uykis/Q6J O2lyTVinDCsiGn9/gAM18otZtNC26Oj9+RQOnXlgZ6w9TbxEiaNYNlZZV3RVYNDZQPct8L lOTPigaNDhADry8QIFQluhqjlYsLwD0= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=W4ngLAyp; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678872857; a=rsa-sha256; cv=none; b=gfLYqXwdExK9N7Wz2rvm7XXz9KBiZ/QHx+Xcdwe4LJUVuYGbouVcXto7lzdeB6FGxVq2Zu MUglKuT+Ad8xiDDSVQNmcjMgI0La49SWCIU8oR1yrg1GFpbicNTSv9nrbKT6YMXMuZ2NUc vM7yH9o72/S0rk6JE2R5xnUtbALOhQI= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 15FA161C50; Wed, 15 Mar 2023 09:34:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 465A2C43442; Wed, 15 Mar 2023 09:34:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678872855; bh=ftvE27r2/itndnDYpSpSUlELYAs7KQyhYOcfR2cSXm8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W4ngLAyp46uvRxKkXnrXn2FaR3WldO5fW0F/L8VxsgD1shNgw3jYXgmAVe3BWPv1O PmYW4sx83vwcX4Oj5XSF89eJ+ynndqSnSd4IWkBHpnhrCCm5edJDs7x4hJ2rAp4Oxc 5/Qa/JrXRbuMzCGebjqUBVqcAtObJwy0aKVN6RMRIkahcJkSD+IK6vcgNE+Q2XkosG VrnK0bOvRtLXqt0XX8KCffezYqtO0zVDcOlp7TdrC3fNVRzqnmZwJmIZQC+qdl/zIK 1Akt4WLf7pGxYDMWfB6MnEXJMSgQXwbWbNae4eCggFkszKVwH58hZeZTMN4re+lWZ/ f9bTYstrDbLRQ== Date: Wed, 15 Mar 2023 11:34:03 +0200 From: Mike Rapoport To: "Matthew Wilcox (Oracle)" Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 05/36] mm: Add default definition of set_ptes() Message-ID: References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-6-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230315051444.3229621-6-willy@infradead.org> X-Rspamd-Queue-Id: 266D0140015 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 6jgind6wpqynprxwnmufgfxtokfza8i6 X-HE-Tag: 1678872856-985266 X-HE-Meta: U2FsdGVkX1/9/UZY6oviFWuoM9tt61uwhQExqEJSOWfCu/dMk3oHRH0Nf3VHrkDGB2eDiK8pRGB7/Tla4VW76Jro8vN3MWGrIrJ9wKu3NTC7HTWr/ZlTN9DC+JCIAicYWmRbk8t/8ZnLYYDtYbH4SXuwmhTPN8wUl/ArPDkBTAQpaC1/+bvfGDLs8GydtowFFu1bH66kH3Siwrd0MmLDxirR61s3TR1ShZPfQkYnBlif9MBTf8hVpaIIZuW4XMjzCna1Hs6w61vgDakOdDHJwc3ghqlU0gCZAcMUD6v3kpxo6HwdsoaIYV1wPepmK+7uqSSD8FovVYXTv0KDAxAq4dMAaKrubYmt1dltOfJep0Hq2O0OWFTKFk7JFFrbCWF3j+wnhIklEMdqeQsSQ8dq7IDPdb6mDOLD0QKy/UbNKDRhzBgMvrJ3VaRCLmo7Q+XI36jFUqesKrDqUNWydP4TOmpD/O1eC1OFr9BmVs6G/tlWCwf7HagqGZQ2UwjxOVxeqvHmCMwDAld/No+jPIjaSUx5s7woscPSxPbBfIFH38LuZB6VzZ+N3ljaAORkQdH0rFKFxqPjNZwFnt3ziKO4Om/6/B4jHe4c51fBYreZEQzFO33+5JmWx/tkVslBT+vfROcEa9I+IC90wTEUscCDCxyryt3DnBrkkKQSTQSH9BWelhCUYPUga2Rz5tBNeGnFEQU0pKZO0BSz89BzA/SeQLHgrhiOnbUbrFdsquCENIAtNRkVbxtwpFfB2X7xJ9mz6s6tpb+zZ86ukMv0SnRF3ytjaxSoIxpAajghRcpcHnJ8njGKzDjoT09/rdBHo/kuXAnrmbVb/azfqKea/RDaklJ13j1rYIU08dsfzA3aZfD7/VxgHsMiNHOcP4jKrObNNCu4+63lTgPAfj4w38xLrh3fIE7zn6u5tD/2SD/5Uukzj4TdDWtOKzKYLTvm+qPpZxMKJ99vT6L02ZK3A8n m8oQoNVq VHIXOrU4TSH9xJScVtfN+4xMyn8WeOsZ5ucgNlg/zuIXyqRU8Zu7cEbKxTBie+5yZGeJ4EF/DpPQijNxDS7SRnO93+YI+TfaSjCLaIKnbkGpPskGLAOOtXdRc3fv5HDBjqyK2JOEUIvpWpakTJSkDLuaX9NCb9KwyXq9WJPO4QXB9K/X0u9zRS9gDPD3qGCBwW6a/mzUP4F4dArV1t23fr2pLHZPyJq2mYr8tCQulv6ryUmDN5Zw3y6vNNsyeE8KbIZcnN89LhrP50hWbwbhg7vUpEsl637FNEjszcsa6cEmGOl0HMvu4VOIS76AbjO8fOoQrPkUW9Q1pgLFLfl7P6KftKmQSWdykM6XZbyWF+IqDDNeR+tC1qjg79/YYyCoEALVUygHCNunjYkO4EJBI8jW/qvyxVy5+3WxyNgVBfqzoNDyEqhqLssri0vmTJV3N5h7mdkPmaNr28JdCSD2jDhWHiA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 15, 2023 at 05:14:13AM +0000, Matthew Wilcox (Oracle) wrote: > Most architectures can just define set_pte() and PFN_PTE_SHIFT to > use this definition. It's also a handy spot to document the guarantees > provided by the MM. > > Suggested-by: Mike Rapoport (IBM) > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Mike Rapoport (IBM) > --- > include/linux/pgtable.h | 37 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h > index c5a51481bbb9..a755fe94b4b4 100644 > --- a/include/linux/pgtable.h > +++ b/include/linux/pgtable.h > @@ -172,6 +172,43 @@ static inline int pmd_young(pmd_t pmd) > } > #endif > > +#ifndef set_ptes > +#ifdef PFN_PTE_SHIFT > +/** > + * set_ptes - Map consecutive pages to a contiguous range of addresses. > + * @mm: Address space to map the pages into. > + * @addr: Address to map the first page at. > + * @ptep: Page table pointer for the first entry. > + * @pte: Page table entry for the first page. > + * @nr: Number of pages to map. > + * > + * May be overridden by the architecture, or the architecture can define > + * set_pte() and PFN_PTE_SHIFT. > + * > + * Context: The caller holds the page table lock. The pages all belong > + * to the same folio. The PTEs are all in the same PMD. > + */ > +static inline void set_ptes(struct mm_struct *mm, unsigned long addr, > + pte_t *ptep, pte_t pte, unsigned int nr) > +{ > + page_table_check_ptes_set(mm, addr, ptep, pte, nr); > + > + for (;;) { > + set_pte(ptep, pte); > + if (--nr == 0) > + break; > + ptep++; > + pte = __pte(pte_val(pte) + (1UL << PFN_PTE_SHIFT)); > + } > +} > +#ifndef set_pte_at > +#define set_pte_at(mm, addr, ptep, pte) set_ptes(mm, addr, ptep, pte, 1) > +#endif > +#endif > +#else > +#define set_pte_at(mm, addr, ptep, pte) set_ptes(mm, addr, ptep, pte, 1) > +#endif > + > #ifndef __HAVE_ARCH_PTEP_SET_ACCESS_FLAGS > extern int ptep_set_access_flags(struct vm_area_struct *vma, > unsigned long address, pte_t *ptep, > -- > 2.39.2 > -- Sincerely yours, Mike.