From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C791C61DA4 for ; Wed, 15 Mar 2023 09:41:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C7B776B0072; Wed, 15 Mar 2023 05:41:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C2BE06B0078; Wed, 15 Mar 2023 05:41:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF2DE6B007B; Wed, 15 Mar 2023 05:41:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9F9826B0072 for ; Wed, 15 Mar 2023 05:41:27 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 68ADB805FA for ; Wed, 15 Mar 2023 09:41:27 +0000 (UTC) X-FDA: 80570639814.07.DFD5D2F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id A2C77140003 for ; Wed, 15 Mar 2023 09:41:25 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nrXQuPUT; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678873285; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WDe73GQ65LWnFPWejNii85Z4hqlTF0Y+VGFGV8fHVwA=; b=6y77oLKYqczWVmUsKSorhs4w5Ec7zlPoD9CZuVfrPeN8fBq/7UX9q9k3d2UlvNuRn/1w8g nhBwPVlxkk5Rj7JrGlaXtmX+mE4+dm1f7dC3mQHM9M3TEA74wnWNN+fyeSg63WR3qHYU+6 5RCONGbqB7NJkdQAaMLyi6XryETHw+g= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nrXQuPUT; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678873285; a=rsa-sha256; cv=none; b=o5R4L0CeEWp2arbT4lOYC9UC87os/fqIUnWlI1qO23GiiN5ceVxbWJQ3IrT0+zlVqTybAU C5MB0VxA+pPDXQYcGAapoqndgdJ2TDqBYIbsDMFjGDK+bPtM1d5uhBcJNIZ5Dq3wberFpL hm6q+jxBlqwJdsoI+1AMCqpwnomQTvI= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B75AD61C52; Wed, 15 Mar 2023 09:41:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 276FAC433EF; Wed, 15 Mar 2023 09:41:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678873284; bh=Cim+4pekCAc6dpHMNLRE6AIUDtCV/gkcBRk0QINAJ5Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nrXQuPUT4evsWtsWlZ2uMBFB1LfoezrU7lVIQLMe07h99kaVdYPx8T+x7G4CxROhm y3BVzMDBY0G5vUSbtkElRhOt7stkFUGlvkLFdLb3Pvj8y3XQwcE1Enp5sJxg60koFA EauRumzpUMFZZ1lgyDx8aox8RlMZ4fL9c1IS+laRhaGdYhdNibg6qwz5EscTjEVVKM c3Z4k/LgV1A/CtnRNPtdnayMGaHAnoog9eStV5YAPxd7Mk6mRQ36VnBdJaGPEorQiJ ORmbTlbzhmnZpxA+wQDL1B39w6D9TCwJWKWQN74JSPTKhpxhAHWdmZFVv440S6iPZ2 K6JBddKX5nqQw== Date: Wed, 15 Mar 2023 11:41:10 +0200 From: Mike Rapoport To: "Matthew Wilcox (Oracle)" Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Richard Henderson , Ivan Kokshaysky , Matt Turner , linux-alpha@vger.kernel.org Subject: Re: [PATCH v4 06/36] alpha: Implement the new page table range API Message-ID: References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-7-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230315051444.3229621-7-willy@infradead.org> X-Rspamd-Queue-Id: A2C77140003 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 3rdds3hzdk1ini6q3iyt5yof6f169npq X-HE-Tag: 1678873285-683215 X-HE-Meta: U2FsdGVkX1/ftQDAG4gczhP1DqGY6EhUorI/gV/t6HAcWcyGtFnfrIwwGYLV1fvbsQTPEjIbB76jzyrbDMgwnNjLOwp5X+SjdSohan9DOJC52nUmb3mIa5pcaPZ/W+sm9C7N5upxJr/eyylt+uRDb5LG9l6sMAdR4m3u9f+GO/du7ZlnoVzPP8HiQ0TL/kYC0sCm+Fe9BBo1/EGlxUtCC77t2sG2kUeMbYrDt3UgMikTnIVle79qcF2nMtbUcvlat2pTqfC/LHFknhak+ak8imgUfYgqK6gv/YcGLu7M8mp1BD3iBp7O32d6ENkyDvHDYqrGNMkBy6PEgpECS1mwwv0DqMGwLrYgNLIynzZLHNkVfq22ffm09iScf8D+IQh+Eg89WV3RHL7CDqUFsSSx34xYPHkScnsSwHc4xsbe2L/H/myojpJevo36IPKpv0HNauTGN1GYLGFPYDNkW95xJp3AMXCOjcYdTRAw5o/N+1gfTka9eRqzqMhvJ/1jvkGD/zbDs90QAnAcQ4seYOPruLqhy1RmnmOp315f8CUW4HQ5zxM2TCGM4Ci9k4n5oUN6ZVStG0KI7ZjYHi+5oIHFJltYkjkqkeazsCmGuutBBs4BvKV6Q/kOsxSkzA9splHbuv5uYRJFirTQ89LTe9kxS1/TrDBPBv8R7Qz/VjfEGTcU+uYPNzojRJRgB2sBfTwALE/0BZCHCIwlafCTL07FoJtraoGCjUfNBcmYGI10TDR6cnobaHpiD3kgRWyofdweKdPz7eLGdj2ZGNEu6z0yJDjzy4gWu1QWrk9Q6DnI9N9Bf+OotqoLehEg22maRp1hcfwL9wNm/3mvFpyJomkNGc+A0awbmMHuUt5p1+tU6ll9KbKFbLow1Uw3HxnnES7Fz9huz0ZlvySILKqQFR4pNu2BeVHiGR8uQymS4sm9sw4ZA7D4gniS7E4XS8iKUmRf9n5KvBeeyyuUwb1OqKh uVWWWrIK dPJl0tZ9RF6cGYl1dnrJrqYxMtX51YW1J3fgAKzlv8jYHLn5hctC272QeLtB0giyhraWWGwifZFpVc2XhVfuUEF8hCxmnqQ+rHDvcf20GveBKXFCgU7oZutcQUrRg/AyFi3S6aF5kZSxsCA/ZV2/GFBr1EqbI6CvEiYJ0yGRjporbZVvi/m9kSFtAS/wchfMQ5Ckovoax/uQPnRw95uaXqoHpWt2QeJGWt3NBuBUq+awD3wgdMLzAcGSeUpO77jLHApEm1VGVXxLODs/ptCcMDSkYPWyUgmPGy4cueGUYnCdMYAP5IzL1Sbv9wvTamZFsHybVBvm0pv8/kW41M+4QitH7GU0sYgQkaOu73Sqjsa4nrvYAdbyeIldeRnm2Q0v+P3gEYwejT7sbOn1gKMRM9znnYkZeqD3eN1Yy9kP4egQRG7jedHfIiN2RIFmKEFV9EbNp2ug6Z/HLHJ+Wf4fWYNm6VS0ReZd9v9h7Hn4BIZXJ1eFB1tt/fez/jIPlQC6T8/vjgcsuW88NRjBMmPCLxIOQp/fpaJwmmF7ksyGcYKh0da/+tsLiX+2UPQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 15, 2023 at 05:14:14AM +0000, Matthew Wilcox (Oracle) wrote: > Add PFN_PTE_SHIFT, update_mmu_cache_range() and flush_icache_pages(). > > Signed-off-by: Matthew Wilcox (Oracle) > Cc: Richard Henderson > Cc: Ivan Kokshaysky > Cc: Matt Turner > Cc: linux-alpha@vger.kernel.org Acked-by: Mike Rapoport (IBM) > --- > arch/alpha/include/asm/cacheflush.h | 10 ++++++++++ > arch/alpha/include/asm/pgtable.h | 9 +++++++-- > 2 files changed, 17 insertions(+), 2 deletions(-) > > diff --git a/arch/alpha/include/asm/cacheflush.h b/arch/alpha/include/asm/cacheflush.h > index 9945ff483eaf..3956460e69e2 100644 > --- a/arch/alpha/include/asm/cacheflush.h > +++ b/arch/alpha/include/asm/cacheflush.h > @@ -57,6 +57,16 @@ extern void flush_icache_user_page(struct vm_area_struct *vma, > #define flush_icache_page(vma, page) \ > flush_icache_user_page((vma), (page), 0, 0) > > +/* > + * Both implementations of flush_icache_user_page flush the entire > + * address space, so one call, no matter how many pages. > + */ > +static inline void flush_icache_pages(struct vm_area_struct *vma, > + struct page *page, unsigned int nr) > +{ > + flush_icache_user_page(vma, page, 0, 0); > +} > + > #include > > #endif /* _ALPHA_CACHEFLUSH_H */ > diff --git a/arch/alpha/include/asm/pgtable.h b/arch/alpha/include/asm/pgtable.h > index ba43cb841d19..6c24c408b8e9 100644 > --- a/arch/alpha/include/asm/pgtable.h > +++ b/arch/alpha/include/asm/pgtable.h > @@ -26,7 +26,6 @@ struct vm_area_struct; > * hook is made available. > */ > #define set_pte(pteptr, pteval) ((*(pteptr)) = (pteval)) > -#define set_pte_at(mm,addr,ptep,pteval) set_pte(ptep,pteval) > > /* PMD_SHIFT determines the size of the area a second-level page table can map */ > #define PMD_SHIFT (PAGE_SHIFT + (PAGE_SHIFT-3)) > @@ -189,7 +188,8 @@ extern unsigned long __zero_page(void); > * and a page entry and page directory to the page they refer to. > */ > #define page_to_pa(page) (page_to_pfn(page) << PAGE_SHIFT) > -#define pte_pfn(pte) (pte_val(pte) >> 32) > +#define PFN_PTE_SHIFT 32 > +#define pte_pfn(pte) (pte_val(pte) >> PFN_PTE_SHIFT) > > #define pte_page(pte) pfn_to_page(pte_pfn(pte)) > #define mk_pte(page, pgprot) \ > @@ -303,6 +303,11 @@ extern inline void update_mmu_cache(struct vm_area_struct * vma, > { > } > > +static inline void update_mmu_cache_range(struct vm_area_struct *vma, > + unsigned long address, pte_t *ptep, unsigned int nr) > +{ > +} > + > /* > * Encode/decode swap entries and swap PTEs. Swap PTEs are all PTEs that > * are !pte_none() && !pte_present(). > -- > 2.39.2 > > -- Sincerely yours, Mike.