From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93578C6FD1D for ; Wed, 15 Mar 2023 09:54:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25F7E6B007E; Wed, 15 Mar 2023 05:54:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 20FAB6B0080; Wed, 15 Mar 2023 05:54:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D8936B0081; Wed, 15 Mar 2023 05:54:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EF7E16B007E for ; Wed, 15 Mar 2023 05:54:42 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AE45A400C8 for ; Wed, 15 Mar 2023 09:54:42 +0000 (UTC) X-FDA: 80570673204.22.BCA9686 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 86DD4100004 for ; Wed, 15 Mar 2023 09:54:40 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=XC5w9ktw; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678874081; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6OZl+BxZcLt3Yq8ef109kYr8QxZBr4291N4hbhBFE6c=; b=ADBe9s+WEJGHK/slK7xczfJzDzNFiaPACD1Ov1GD9g9+6GsDJUA5TmxpXoanqAElVkxIUr XzwCxhQQ+E6NiwhtamHOYlCwL+x5tXDnziy32nUuwdGg3GM2+bqWwMXPI4Mect8/T3R77w WXctf+hr+ZF0b+FQgHOsAD01hs4BCp4= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=XC5w9ktw; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678874081; a=rsa-sha256; cv=none; b=WvXjOsCb9enlCCeQ/kiwkFWiDAtkhQScuA1Udl7S4zN76XUs24/HcNFYK0yPTtX3jsjP4k V38k7uluOzYRahOHpgEh2RpqZo/msQXDLY0s/rUBukxtkK/08GSrMG4Vc/z28cUc1Ye3kB GEgwR1Fk4NvX4Rve4s5eNu7UrIptTc0= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9736861C50; Wed, 15 Mar 2023 09:54:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5708BC433EF; Wed, 15 Mar 2023 09:54:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678874079; bh=UPGSk+5zktSkQHlM1EsT/d9MKHUsVB44bqN+4h6y90g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XC5w9ktwzv0KtrbuxuLbJTDg2kuUjk3TNktAQOjE/AOHk4SByNzVyYhHK6/cfJRkq wocrXxvM3dGU7M2+gQPpRiznCPhfP/hkwkH6NmxcG7Qcs7Dvg8r289VPUC21vEx1sQ x+3l6j3qSWvuvGcWOToYQbU8NCyFpLCnYyAvtfcREzye+03z9HGbuowCepc3S0KXA6 d5NxGSVYNzenULUslt+gwAgAcrn7NLdM45212/qpiCoTQTJLU8wB75OYGhDd3KjnN6 C6L6k7d6sjL4TTUnyOJuUY2GyNk+HTI11GVz/v3Vw1ORCOHMTkjwapV2l3HKJ2hHlc KiCO9ySnXBG2w== Date: Wed, 15 Mar 2023 11:54:26 +0200 From: Mike Rapoport To: "Matthew Wilcox (Oracle)" Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Brian Cain Subject: Re: [PATCH v4 11/36] hexagon: Implement the new page table range API Message-ID: References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-12-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230315051444.3229621-12-willy@infradead.org> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 86DD4100004 X-Stat-Signature: 9ibaedy1xk4mnweraorr4xseoikij93p X-HE-Tag: 1678874080-744128 X-HE-Meta: U2FsdGVkX1+VUW40gsk4ggnvlDM99cLEs0IT8MYWRlgUZNk2U4T8WfKpLeiwLjbauoCkLSsrODgSfnPoVoEUF6ZkmTXEg2J8urFhtmx7ZsbtCMQhpiIMHCj1z3t8saHOkcirG8c2bxMqWPkwxYtjSVqbxiS3CdxQW666XK8DPbZuwgjDpzWZbrYOpRkBOmpMbB+mggFpL1i/6WDLh3qEkQbMUE3N2BruodK6XsfHZNrLmmZIFLzNvoKHAssMmZGlmYZpFuqjqGrqpLJ/aHdBHs417q9wpUBF6JPm+DzcU9ew0shDYlygK3tkncA0/gnY3m07nJ06J/9LC++bIS5u1x1Bc5WYLOIlPpvwt2NxezXVeYgA2hk1VxPiWzb7jcmuZzkKBLy51clmVpzmxWQjYg6/lZrzjln5ZSABthUKgJM24QlFaNCnH2ODdvzPe9YLfKMF1eUeMvsv3HO0wrVL6E0mnK1t8+NbtXqQKvwnF09XFpVsPO+nOAUYaQbWepIpvaSJ/XQrudKqpMM0mFSL7jX8LBtVf9FIghXFrfd3a8RwWuj0FASQA84NhBZ0kr/x9kdc3S0qkQSH+UdzYCV0fFST4dboaRBCdD4+gHX32a5iu/eUUX6JWsFwBd8E2o+Z84VPr5IkQ2JWV2AYS0TAxUW7UlaPcWHTrFCO+mPbpYEl5UzglOi/6hv1Ze9sd6tKVhbck4FdMvtUK/zqgMFUVuiTakHhAmS5zrDX+uKXqSsdOWqPQcbwLTVNAmkCmaebb0G3GAMYdbqnHgkPA4Tta8C300LYAqKYAiRUl17Djkg1FJQV5X349/ahQWUldClkT/yvfggVKP6oC/ogDK+auKOICXS+Kb+8QP0zfD6AwBbesQdheHthZTvbBL6juX0XRTnTG+tGqZHFGTBLyc5O9scf7qFgBkcZKSh270VVYFKTS3t22dUpFeVk6JER3aJ1nQDiUuRQ0tvf6621xqW H4rPCaJL r38+frv9EdRhXzs1xwDW4a6KaSg5h7MTA40q7oUDLBgqRMphCh1ERSni7eHoCuMFT9beSQuMaJXcJsF4nxrgWbVbPLVKkcvpbfh/QycJeDv0QYt24mVkrXc9LyjcHm6kqAXRX+7o/CUNuPOmQ/GsQ//dZp8QO7y40ojGPJtMqsIXfBTOLoGnv48a6+azkI4J+d5/ZwKrq8RDSDYI1WLP24ayBhlt2djpPFQ5ZIqKiEJmmfPTXh286DH/5EvjsIXjsKpusbK6Rv7kszd3Nbx++1p0V3bA44n3HGJ5LhVemZsDk21gbvv1b5LR/Ck71klv0pG4/UYI2BoDp8qEtkL+/EiJww6HsB7+zq5rwmhN0j4zYDFQ5yZL2HmWCGQNfDR3J5WufJpUIXtTYRVxEA67fa8MZgWI2X+wJWqJ57Jfdjs5/6kQTgtMNRbwkmfTrihnKQrLx8NkzJXk6qKYGRrBZRDzfLpGVr/i9Ui0oifbbLp0EqQ4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 15, 2023 at 05:14:19AM +0000, Matthew Wilcox (Oracle) wrote: > Add PFN_PTE_SHIFT and update_mmu_cache_range(). > > Signed-off-by: Matthew Wilcox (Oracle) > Acked-by: Brian Cain Acked-by: Mike Rapoport (IBM) > --- > arch/hexagon/include/asm/cacheflush.h | 7 +++++-- > arch/hexagon/include/asm/pgtable.h | 9 +-------- > 2 files changed, 6 insertions(+), 10 deletions(-) > > diff --git a/arch/hexagon/include/asm/cacheflush.h b/arch/hexagon/include/asm/cacheflush.h > index 6eff0730e6ef..63ca314ede89 100644 > --- a/arch/hexagon/include/asm/cacheflush.h > +++ b/arch/hexagon/include/asm/cacheflush.h > @@ -58,12 +58,15 @@ extern void flush_cache_all_hexagon(void); > * clean the cache when the PTE is set. > * > */ > -static inline void update_mmu_cache(struct vm_area_struct *vma, > - unsigned long address, pte_t *ptep) > +static inline void update_mmu_cache_range(struct vm_area_struct *vma, > + unsigned long address, pte_t *ptep, unsigned int nr) > { > /* generic_ptrace_pokedata doesn't wind up here, does it? */ > } > > +#define update_mmu_cache(vma, addr, ptep) \ > + update_mmu_cache_range(vma, addr, ptep, 1) > + > void copy_to_user_page(struct vm_area_struct *vma, struct page *page, > unsigned long vaddr, void *dst, void *src, int len); > #define copy_to_user_page copy_to_user_page > diff --git a/arch/hexagon/include/asm/pgtable.h b/arch/hexagon/include/asm/pgtable.h > index 59393613d086..dd05dd71b8ec 100644 > --- a/arch/hexagon/include/asm/pgtable.h > +++ b/arch/hexagon/include/asm/pgtable.h > @@ -338,6 +338,7 @@ static inline int pte_exec(pte_t pte) > /* __swp_entry_to_pte - extract PTE from swap entry */ > #define __swp_entry_to_pte(x) ((pte_t) { (x).val }) > > +#define PFN_PTE_SHIFT PAGE_SHIFT > /* pfn_pte - convert page number and protection value to page table entry */ > #define pfn_pte(pfn, pgprot) __pte((pfn << PAGE_SHIFT) | pgprot_val(pgprot)) > > @@ -345,14 +346,6 @@ static inline int pte_exec(pte_t pte) > #define pte_pfn(pte) (pte_val(pte) >> PAGE_SHIFT) > #define set_pmd(pmdptr, pmdval) (*(pmdptr) = (pmdval)) > > -/* > - * set_pte_at - update page table and do whatever magic may be > - * necessary to make the underlying hardware/firmware take note. > - * > - * VM may require a virtual instruction to alert the MMU. > - */ > -#define set_pte_at(mm, addr, ptep, pte) set_pte(ptep, pte) > - > static inline unsigned long pmd_page_vaddr(pmd_t pmd) > { > return (unsigned long)__va(pmd_val(pmd) & PAGE_MASK); > -- > 2.39.2 > -- Sincerely yours, Mike.