From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32E41C61DA4 for ; Wed, 15 Mar 2023 10:08:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C41D96B0081; Wed, 15 Mar 2023 06:08:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF1616B0082; Wed, 15 Mar 2023 06:08:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB96D6B0083; Wed, 15 Mar 2023 06:08:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9C6346B0081 for ; Wed, 15 Mar 2023 06:08:07 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 39E40C099D for ; Wed, 15 Mar 2023 10:08:07 +0000 (UTC) X-FDA: 80570707014.09.71F0678 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id 874C840012 for ; Wed, 15 Mar 2023 10:08:04 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lK6TOlQd; spf=pass (imf27.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678874884; a=rsa-sha256; cv=none; b=nuLeU3QbylXhZKeS7uS7RvTUaWEL6wJIDT5kf17LY3oDWMJ5p3KZ56CXz7pj1Lm/7bBF+7 8EnMRVlHS7aOJ/jtRNDXWZ0URkxvH6L4torpuTDVOBogVwTkBygPxcTKiM7Xv2pmuzZUYD OT/sHyyZqk8qrN3fGwBM33m2fKGn7No= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lK6TOlQd; spf=pass (imf27.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678874884; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=knWKEtsW/3YYl6zpadiTLhzGAySwr0cKDzh6EJCuI0M=; b=kC+1/sc+73xLeJbZo98dOftIWp3H7tdnEJHLiK+YWNVZnZgkGuLLDcjvE2mxPaDysOdk6Q DP0e5Sh5fS+0r3KjLF3NZ+Pb0X8FYm8LJbWxmhrivLgh2jrv4Hs7B/yjP+PcVKy3rkBcKB vX1lqG500cXhM7JbGOOu1QV+jmR26VU= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B073861CBB; Wed, 15 Mar 2023 10:08:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F81AC433A1; Wed, 15 Mar 2023 10:08:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678874883; bh=GS3lMxONLmWS+eLW3cuLojN+5vMTrSIViV38pOJOeZc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lK6TOlQdwl3qfq90VS2bo45z3Oza3rw8s+9w12v2Y1tncCgkpGT+mew6dpow6FuDi CoMc6/0WjcN9nGPkxx0WI9EuqbRduQyKnFpQN0YFLOXF0aLaQGXD3+iQjDG4FoJYKn HbbFwsIsiiO1naGk/e0ADLmUdTa3q124jqOTOq72K7e75yDwN6Q20/i2WGEOaWjd71 EJd0W/6Jt2brDM1pl4jwE581Kktm/RhtjLjPDg5aP2v58KhK8WjJUYm8Y2FcNs+KSf WMkQbz6pB044FEfMSjSZNG9duTpJ3zw+z+1r6cwTYmueFiCBVuwmDn2FpOewNhZDUv eFxWqB5CUNrcw== Date: Wed, 15 Mar 2023 12:07:50 +0200 From: Mike Rapoport To: "Matthew Wilcox (Oracle)" Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Simek Subject: Re: [PATCH v4 15/36] microblaze: Implement the new page table range API Message-ID: References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-16-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230315051444.3229621-16-willy@infradead.org> X-Rspam-User: X-Rspamd-Queue-Id: 874C840012 X-Rspamd-Server: rspam01 X-Stat-Signature: 4rbkgwmtq8hthr995odskss3rjncemp6 X-HE-Tag: 1678874884-467233 X-HE-Meta: U2FsdGVkX18/yF7FiB+feHggrWT/UcbJG53FDQ54iNivDWV1IH58zgDJOgsKBNnNf3FZE4DmW+AAXAX0YfXR8l6t6saNkey3Lp8pkA3G8H1BEp05I45A2J2MvOgAs/I4ihYh/NQlTSb534QEdknXXtY+7nBb5zRvf/zFyushShlTy7YYuKP3RokrdpnXycH6QUTY5mEsFvClVBiRQVaYyI3F9P8xn0BB4gsil/cFe6xWPiCkYgxFwH8y9BWydUXKtmvl9ifZrm2FmH3Gorf8Dv/QLJ3oc/t+t2rG7BEWTB1Q8ZuIA/egOb/TdTjK5mz5Oey4XIbq6itNunYc80qtr1JFz0mtWmnWm9asHtYwA7gw9oJYZJU4aqBBJVc1goF+RSaTuMAiWvNO+X/DxcdPA86CQobAPv5dvy9wE6/WSBf8nobZygjAeP7qHHtbh/2Pyw6GROJL5vwjRdWMusMgPxBtPnlql4ZAe4Sjqn/TT+hqVuGbV+s3NG8nVXiOHB04aI/VpNoPYRaMFc0NuMu1zjmnKNSXxCjCw0ZUUmR2csDjqgv1f7toeAXlPHl7p9GEUzbwbqv87hv9FV9xBS8fHXzuYTMHoPa4xbRDpJk4+wttKsT+8P5WWd64AVLsNSiexj8/HwShHKra1XHurjCR/sgrHJxDrnrbs7pDSe96aKu6oqjqkjuhtgMQflBFHzOGxts5M9guF8/ZlPa6e33fPFn/81aTRwuW6HykmvUucuYQDomFsR9dqoFH6joe1oqjS/5b2neS2pVb58q2p9dcbeRy9yPZ7SJNbfDTKhChncuwwbluVMLR4ifKX5Z2ivG4Mzc/mBfCxCUDOiXS7PbjzaY4R4O5Ye5q/lwOV8qATtXWKdens+siqKuohBTwv0ToPAUk6tZP6+gmuxgLV6XVIGzckH5Zjq0lbivUG84OsBYuK9em4UYETQrfzpbX6xv1uRbIcuXO69KqQWLr4Aj YB/zn32Y jHI/46c5WzqdsgrP4COvyXpCyJpc1ii2mGhQGxB09gZzBaIgoNiB7vVyzyEJ+i74IopyGCf1nD6qlVoE58LK6z3d1WU1ouHZ/1ESBpSq+ygLmE1OhfGnkHe1Ngtt4jVT8M4rhRkZ8gETNmlml4sGQFV/5QS7uaqgJIBInsID1RBH2oHQyQ4d4kQ+s3YkHosOX2srH7LPT3hziP1dXpn17XRgI0ksANwHPbBy6QAOYPN0Rz6PaTWDSv0aCbjM9oYJiMq981mJxD8nTaEiuS30Ri9/4LvUK+iDzNbSkPpsFbDPbChgBdtz8EOe0tuIfqCX7dBJrs9hTbeOS1sPND/hRtSC7E5jg775gKafZnCze2UJm7OufnkxtqVBjtRtu/8ytF4NTLhtr0Rqo2SQJ8mp6D1QlxYEil0RmGrtQmICFCb2v2gFskV6H6wynOD5JB71AQ71NCUdzs7iZUMOBvygoCVag96+4kFUFkCUctis7RJltVeM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 15, 2023 at 05:14:23AM +0000, Matthew Wilcox (Oracle) wrote: > Rename PFN_SHIFT_OFFSET to PTE_PFN_SHIFT. Change the calling > convention for set_pte() to be the same as other architectures. Add > update_mmu_cache_range(), flush_icache_pages() and flush_dcache_folio(). > > Signed-off-by: Matthew Wilcox (Oracle) > Cc: Michal Simek Acked-by: Mike Rapoport (IBM) > --- > arch/microblaze/include/asm/cacheflush.h | 8 ++++++++ > arch/microblaze/include/asm/pgtable.h | 15 ++++----------- > arch/microblaze/include/asm/tlbflush.h | 4 +++- > 3 files changed, 15 insertions(+), 12 deletions(-) > > diff --git a/arch/microblaze/include/asm/cacheflush.h b/arch/microblaze/include/asm/cacheflush.h > index 39f8fb6768d8..e6641ff98cb3 100644 > --- a/arch/microblaze/include/asm/cacheflush.h > +++ b/arch/microblaze/include/asm/cacheflush.h > @@ -74,6 +74,14 @@ do { \ > flush_dcache_range((unsigned) (addr), (unsigned) (addr) + PAGE_SIZE); \ > } while (0); > > +static void flush_dcache_folio(struct folio *folio) > +{ > + unsigned long addr = folio_pfn(folio) << PAGE_SHIFT; > + > + flush_dcache_range(addr, addr + folio_size(folio)); > +} > +#define flush_dcache_folio flush_dcache_folio > + > #define flush_cache_page(vma, vmaddr, pfn) \ > flush_dcache_range(pfn << PAGE_SHIFT, (pfn << PAGE_SHIFT) + PAGE_SIZE); > > diff --git a/arch/microblaze/include/asm/pgtable.h b/arch/microblaze/include/asm/pgtable.h > index d1b8272abcd9..19fcd7f8517e 100644 > --- a/arch/microblaze/include/asm/pgtable.h > +++ b/arch/microblaze/include/asm/pgtable.h > @@ -230,12 +230,12 @@ extern unsigned long empty_zero_page[1024]; > > #define pte_page(x) (mem_map + (unsigned long) \ > ((pte_val(x) - memory_start) >> PAGE_SHIFT)) > -#define PFN_SHIFT_OFFSET (PAGE_SHIFT) > +#define PTE_PFN_SHIFT PAGE_SHIFT > > -#define pte_pfn(x) (pte_val(x) >> PFN_SHIFT_OFFSET) > +#define pte_pfn(x) (pte_val(x) >> PTE_PFN_SHIFT) > > #define pfn_pte(pfn, prot) \ > - __pte(((pte_basic_t)(pfn) << PFN_SHIFT_OFFSET) | pgprot_val(prot)) > + __pte(((pte_basic_t)(pfn) << PTE_PFN_SHIFT) | pgprot_val(prot)) > > #ifndef __ASSEMBLY__ > /* > @@ -330,14 +330,7 @@ static inline unsigned long pte_update(pte_t *p, unsigned long clr, > /* > * set_pte stores a linux PTE into the linux page table. > */ > -static inline void set_pte(struct mm_struct *mm, unsigned long addr, > - pte_t *ptep, pte_t pte) > -{ > - *ptep = pte; > -} > - > -static inline void set_pte_at(struct mm_struct *mm, unsigned long addr, > - pte_t *ptep, pte_t pte) > +static inline void set_pte(pte_t *ptep, pte_t pte) > { > *ptep = pte; > } > diff --git a/arch/microblaze/include/asm/tlbflush.h b/arch/microblaze/include/asm/tlbflush.h > index 2038168ed128..1b179e5e9062 100644 > --- a/arch/microblaze/include/asm/tlbflush.h > +++ b/arch/microblaze/include/asm/tlbflush.h > @@ -33,7 +33,9 @@ static inline void local_flush_tlb_range(struct vm_area_struct *vma, > > #define flush_tlb_kernel_range(start, end) do { } while (0) > > -#define update_mmu_cache(vma, addr, ptep) do { } while (0) > +#define update_mmu_cache_range(vma, addr, ptep, nr) do { } while (0) > +#define update_mmu_cache(vma, addr, pte) \ > + update_mmu_cache_range(vma, addr, ptep, 1) > > #define flush_tlb_all local_flush_tlb_all > #define flush_tlb_mm local_flush_tlb_mm > -- > 2.39.2 > > -- Sincerely yours, Mike.