From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC3D0C61DA4 for ; Wed, 15 Mar 2023 11:16:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 616226B0072; Wed, 15 Mar 2023 07:16:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C6786B0074; Wed, 15 Mar 2023 07:16:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48E716B0075; Wed, 15 Mar 2023 07:16:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3C5FC6B0072 for ; Wed, 15 Mar 2023 07:16:45 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F3AF41610CE for ; Wed, 15 Mar 2023 11:16:44 +0000 (UTC) X-FDA: 80570879928.10.1563712 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf25.hostedemail.com (Postfix) with ESMTP id 256A8A001E for ; Wed, 15 Mar 2023 11:16:41 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=P6SboyT9; spf=pass (imf25.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678879002; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6FkKr6hz4lj2rc+43yyuNPgWH7bGblNb9DC/OIv2qnQ=; b=OSIB/DTeBI1hUp+SiUHairV4YCoawylvXck6wVSLlpSl5lgXWP8o8axS3DA5NQaH7DwnLt F9zuZPXR2gvgz7jrLVyk8Pd/IKYmGHsPC5dlMti4b7dRolGODjsUR7QF9F/DyGNaKjelBG nfyFTk8xeUiipa5R0FsvK+EZ2dz0/jI= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=P6SboyT9; spf=pass (imf25.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678879002; a=rsa-sha256; cv=none; b=Qp0M1mKSVLItJW19Q/EhPXAwsPTsekq3Whq+3d8hur/rOML1r2LztQUEmX+rOBnfXWjoIb igRyobERR51fmiQC7k8oloFsd8wKfuQZLK5y3WElHw+uBPF0Rd5RU1XRzDxNVPCvV7a42d 5iZJ4yjs/6tYQcLgH4OO2fyQsUTBugU= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7C1CBB81DC4; Wed, 15 Mar 2023 11:16:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C3B5C433EF; Wed, 15 Mar 2023 11:16:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678878999; bh=6qnXmLvpgW1dKuRejebdDAlmRA6DSSuhtauL3YzHJEc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P6SboyT9BZ+Khj+LLT3W2kU0ZHohELN+EMUyzCjU0HKSQ7x8CxQwxLS0LJU8qrBXx u6T/qcL5a5lodS3bTdSUEk5rETDLxkPprF1wnmpCss4kf/lR4i3tq+QTCWDYwdUJwe nA2xURtKRyPlr2rjCrBQX1QyUqW3le9UwYG169nQLbSJx5+MIys/i2qFK0qKKPPmvu L9Lf9F0vnXAIu3zKCp7p3t34Chrp0zo7Z7eB23GJTm2lT3GJ7VXn5qZuL4Iyc6Z+kF k//33TWF/xvl90OR3EyeOAIMvADhZCkkgMnCXaYCgPpyDSaVvvw05mHjDvLqnVnPxq 9yNhs6sjyPQkA== Date: Wed, 15 Mar 2023 13:16:24 +0200 From: Mike Rapoport To: Peter Zijlstra Cc: "Matthew Wilcox (Oracle)" , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Subject: Re: [PATCH v4 27/36] x86: Implement the new page table range API Message-ID: References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-28-willy@infradead.org> <20230315103436.GA2006103@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230315103436.GA2006103@hirez.programming.kicks-ass.net> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 256A8A001E X-Rspam-User: X-Stat-Signature: st7fh19rtmy8o9gbo9udkf4rxxbngtmm X-HE-Tag: 1678879001-590422 X-HE-Meta: U2FsdGVkX1+srV3ogtupyDr9FgSE9pIwjsIpOYyeDnhVwCGMvLKSUF7MVPb26vKiNDf6hVvey9h55wBL/IGwuyFipRi8+HMTXvl2ctrQYANFmpOP665Jo89BFaFvk9urmDY2UJYivZU9FaoZ5fY8Clya2NQNKA44jXu8IMvrlb6UG7+Pn9H0H4Vv205PaHr3KdS0E2yk5txVv4uDbeyuzBRZ665qlTh8MzKB8NXSsOJdVnCEiHspd3g4icbkTEbOKDplVbvP+TTcKoaIagH7eUp+aRbcJjCmaqBEi2kh83iUrUHw8Hoke9aLSqEEhozYde/uIvojOTVACaAtfwTHDjzPl08xJe9KnrAB0MoCXcV5Wl5XL/Ez/xYHHqStkJpXPVDw1V5XBXq9v+tyzk0EmhWpNFxQmbLqczUZ1H9yNq7np0PNcls6DTDrsg71icra2AVOKVcKA1Oay5Sntz9ZlyY8n2b52De/UsABrXSv86KrowQbld4I8PsNWyhtDmKuwLUtUrLrkA0HUhKvmWM15JvbTrxqsLc+n/+Pa7Hn97LL3IHcwwYergJ7KsFmCjq6cYIHHRUwdtjsZEUGIf/3xR7KsE7Rzs9ppW79LcXRzISKQGpWaVQSOz/B+R/IYOc73hHEKokq/du0AhW/u0KK2fjSYsaRONhxgYMwspa83EhnET0kdnLAoypjYKs/hY5IZbvu0t+c+Jqa6DsH8ECtDwyPOOit+1mGINiVuKrEraDPPiln4a2tAFKEuhWHrRExct+7AlpRRaD20rOx4P9RSNtkaJ7DWh3+cmf1DVFYOLnJast2Zo5XRHQOr7TzhO4jWtu4B/Bq4J88zmTEHYFyCKeP44xqcBCaJLby6l3jFj4bLDyA3ob9d1T6+n/dhkCYmPjfiSo2EOPygMGX2i2I1hoxADCei+X6jUgyVGelzjCa6QkppDN0iT7gmrL61mwYPHr4XXIy8RyIA8Tv3el 7Vu0kuNT P0uAB5iJKiiIV1gWOk1XAXAxWAFMpAycYDo54jqWVagrvFnA7IpwmLbtN61d0Ac93ivxDUn3URIYSaz4aguDnoxtHGbXbzy32XFFCaC0TRYecN3ac4/FBIvw/H5XPqih0YdBKqKM/VTkb07PIxfW2A/3QXs0CD8fZNPe2YgQX0vKhqU0NJz3NXT6J7fneBS/sVh0gvFGPcqsB94GRKm6/1EsjhuDhsT06kRRrcPWHX+vy2zeffxSXw/OvtkUiEtyKwCD5zaAPoIha9LyVF1TNxORPjJSOSNrasEh2xsNvn4LYZMdzApG0CLiyDHQc08xaniMps1TH0t8PaSuxws/8fg4hsbHDauf4DR4M7xfDFlH3rrt4LeyK47Up/8CHnbDuKXtcM8HKWV9HVCKbpqjv83UvvpaZaSSi6LK0r0BAKpEJZAh7esrcmZGfll3Zbr3N91Q6KBj7/xji8WU219lt0pw7ZHZGunHlbdLLmWdOdoYTmcIuQkbPHw9+96L4yC9zON0Yq2pKWP3H9Y3+6PS183g6Yg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 15, 2023 at 11:34:36AM +0100, Peter Zijlstra wrote: > On Wed, Mar 15, 2023 at 05:14:35AM +0000, Matthew Wilcox (Oracle) wrote: > > Add PFN_PTE_SHIFT and a noop update_mmu_cache_range(). > > > > Signed-off-by: Matthew Wilcox (Oracle) > > Cc: Thomas Gleixner > > Cc: Ingo Molnar > > Cc: Borislav Petkov > > Cc: Dave Hansen > > Cc: x86@kernel.org > > Cc: "H. Peter Anvin" > > --- > > arch/x86/include/asm/pgtable.h | 13 ++++++------- > > 1 file changed, 6 insertions(+), 7 deletions(-) > > > > diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h > > index 1031025730d0..b237878061c4 100644 > > --- a/arch/x86/include/asm/pgtable.h > > +++ b/arch/x86/include/asm/pgtable.h > > @@ -184,6 +184,8 @@ static inline int pte_special(pte_t pte) > > > > static inline u64 protnone_mask(u64 val); > > > > +#define PFN_PTE_SHIFT PAGE_SHIFT > > + > > static inline unsigned long pte_pfn(pte_t pte) > > { > > phys_addr_t pfn = pte_val(pte); > > @@ -1019,13 +1021,6 @@ static inline pud_t native_local_pudp_get_and_clear(pud_t *pudp) > > return res; > > } > > > > -static inline void set_pte_at(struct mm_struct *mm, unsigned long addr, > > - pte_t *ptep, pte_t pte) > > -{ > > - page_table_check_ptes_set(mm, addr, ptep, pte, 1); > > - set_pte(ptep, pte); > > -} > > - > > And remove set_pte_at() apparently.. whut?!? It's now in include/linux/pgtable.h > > static inline void set_pmd_at(struct mm_struct *mm, unsigned long addr, > > pmd_t *pmdp, pmd_t pmd) > > { > > @@ -1291,6 +1286,10 @@ static inline void update_mmu_cache(struct vm_area_struct *vma, > > unsigned long addr, pte_t *ptep) > > { > > } > > +static inline void update_mmu_cache_range(struct vm_area_struct *vma, > > + unsigned long addr, pte_t *ptep, unsigned int nr) > > +{ > > +} > > static inline void update_mmu_cache_pmd(struct vm_area_struct *vma, > > unsigned long addr, pmd_t *pmd) > > { > > -- > > 2.39.2 > > > -- Sincerely yours, Mike.