From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43B6AC6FD1D for ; Wed, 15 Mar 2023 14:56:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C282A6B0074; Wed, 15 Mar 2023 10:56:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD8C96B0075; Wed, 15 Mar 2023 10:56:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC79C6B007B; Wed, 15 Mar 2023 10:56:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9D17E6B0074 for ; Wed, 15 Mar 2023 10:56:40 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 614728122A for ; Wed, 15 Mar 2023 14:56:40 +0000 (UTC) X-FDA: 80571434160.19.B0C0E1B Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf21.hostedemail.com (Postfix) with ESMTP id 985491C0020 for ; Wed, 15 Mar 2023 14:56:38 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=PiUZ5d9s; spf=none (imf21.hostedemail.com: domain of BATV+a00a5bee4fa3ced32ffa+7143+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a00a5bee4fa3ced32ffa+7143+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678892198; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NtGVTT0RE5iHf8BDlNnJJTmqknLyFuFovkq+NsrgLe4=; b=VWoh6tFRuVFoTURbt7xUSvON2e5KsRFkUZ7Yz5diZ07sy1lOQjAOB8vrCWX8lLNwf3jnAu brzMmHtZnRerMOEODaw8izlHsP8P7bUlnHgGjMV2ShKb2c1Rgal3v9GWudHTE7fj6ykkUM PSM2muxHrotPs4wSTekQdLlK7huuoS4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=PiUZ5d9s; spf=none (imf21.hostedemail.com: domain of BATV+a00a5bee4fa3ced32ffa+7143+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a00a5bee4fa3ced32ffa+7143+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678892198; a=rsa-sha256; cv=none; b=76jVC+rKM7NDeFWMk8r+Mmf3PwIRmT+2yG/MgXQgTVemccmc8A9KQ7OO5Df9ZXSrHNTWU3 yf2027oX1YiBHq606hkGpcUsBgtLK6kZ0Ln4Xl6zCAjuo4+K1N9tS3q8ca3THhtuNtr5Aa V+RgVoZZgt+UYG92W+ndV/Rxxt/G+Yk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NtGVTT0RE5iHf8BDlNnJJTmqknLyFuFovkq+NsrgLe4=; b=PiUZ5d9s1025RuKr4ecGq9sArC v2VR2D3pHXH/amZGn6D1lD6vqM5Q6MKJ+O0jzI3lm5p4zSfr+CaXeZEWzGkwhdH5oL2f3vQ+1PRKr XWE3xORmmUTQzRCIe/Ld9xRWfOKkgPiPn76MIdw3IPtqfMg8w6RLpMDGCc3SwI0U4fS0yOCLGAoKJ UH1IbfqoDsFCA3AelyRBAXKTzhCoZPNWjKSMOjvxJS1hts1kazbIti2grOrPssBOPJAUk410i1pyd A9B/Gw8gGSqj4qSh+zmFT5AK2yUl6d2Ge/M0xXZlezoUqkwhBH8NX2IAew9BWt+V7S8o7Bwh5szem c21/Ugbg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pcSYB-00Dhrz-0d; Wed, 15 Mar 2023 14:56:23 +0000 Date: Wed, 15 Mar 2023 07:56:23 -0700 From: Christoph Hellwig To: Pankaj Raghav Cc: hubcap@omnibond.com, senozhatsky@chromium.org, martin@omnibond.com, willy@infradead.org, minchan@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org, axboe@kernel.dk, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, mcgrof@kernel.org, devel@lists.orangefs.org Subject: Re: [RFC PATCH 1/3] filemap: convert page_endio to folio_endio Message-ID: References: <20230315123233.121593-1-p.raghav@samsung.com> <20230315123233.121593-2-p.raghav@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230315123233.121593-2-p.raghav@samsung.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: g6nzpz5na7xo1up9bd35i67jtzsqxxe8 X-Rspamd-Queue-Id: 985491C0020 X-HE-Tag: 1678892198-423953 X-HE-Meta: U2FsdGVkX1/QllskeXrDhOfwb4IfV1E7ofCbLw8n6pKkRiF3VJda+KDG8gCXGafdjjkCYE1n2V9zZHOqJHTyh2VEYXbpjVULf8ZZ8cvakn6tuW28JRe+l6eaz8XdYWYPXGCU2RQxJN8HGaQUl/My3KOo5Gd+v3caFkKcNNqAy3kLr4vpH+LnHdtyXZXY6v28WKa/FVy6TpYqscD7F4HS07RJnlVV0g6p+NrtUpREwu9llDBcTT173gXuqyCZ2qnGpL1ZFbGVdv90I91u7y2bz6K6Yk+IxeUtJ0QYez5NzkMnPQ+GEhThh2r5dgiJ9EeulW0jy4+KQlOLHM+ay6Z4oQz+CIgqu0jCNBzcZ7oi8kpCW2xPp/0GqsigJDTl3gqjfqVwuPf2nYj4jQOXW1BzqGOvtsvHtk+qMMWoXjF49VxHpRXbjwlyXtf9PXeLyxCHu6u1TpRPMILIRvoQLltBu2GdsLRtOPhD+hzpa/qKCPI4JOeR4T7zTsTgqOQ9bm8dlmCtiPYUvY1BFgAEVHoE2Ffu9vVD7+2fUBBxC8yzQIyqiSq5KXLFMpmVP9cT4dl8Pq6sELuPrxA/IxFJ499EHyVbzBzhD69TAasgahxRK62zXtL67GH9q7Y0rPLSICDKonyr0z7TkPP4fFk6VschBz/XeyJm+mRes2eaYpikiWLEG5F81rMA/nKtE/1uGGPqR4EEzDOKjIKWvhKlYHE2y5CDFGVs/YkYiuixgE5mMU2J8K1ElYDeH4vn3bwEuYwvKPgXct3vZy82qEnH580pMwqP6kCL0qKkeh7mazieODi/xYpHwS+mYjstic8i7d7CqvQZfep+gxTsQgnCiiKYAusehFXqLmyKqQSLGSbROMIHgzUyT5k8Vcr3b5ifbyJmychjh3xgU1vX0WibrK1YyNkZQK1gb7cRLC+Z2iumt3fqKgmqPGbit0eHDF/PSMyhuCFIwvSAfPEl2+JH5wJ T3/AhAEH k0hfFlXUxYxtqiaLIENRk4HLlTgHLkJpYDN4XTnY4QzD0YWeceY8cNhYC4O3F6+OI/5qoPm8gxE9RcKUnpRhuBruABhJlrXpC5ayk6L8TYVuJWLwJJVdLev6RzUtsUujbZRJzmexlX42ad7H/7tarXP/i/lp4KM4FLsiYwa7+IddBgQadlhf97yWe59WDkXMsVwgb2dykshHlEz+9EGhGFZvxgRa0jtZf3kH3bWiGlqTQSQkMDnsHBC2hZ4FZ0sBSX+E7H9KO9rMS3k5q0NNri+dwQg0ihQkHtbW7BDQvlG76zRfK90rjzqpE4O4J8JT47mFgpuWoiwffSheaStLDgcp+7+6gp/8hoc6u5L/1DDbqIfqXEL8bSlW96NCSeUQn5wdBbdUJXMbRa1ksS5DDC62xAdhFGJ7lSUx4wxTQvrKWllnSvsbKFdcNkeH2c9xJAghZywzmMge6LLk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Can we take a step back and figure out if page_endio is a good idea to start with? The zram usage seems clearly wrong to me. zram is a block driver and does not own the pages, so it shouldn't touch any of the page state. It seems like this mostly operates on it's own pages allocated using alloc_page so the harm might not be horrible at least. orangefs uses it on readahead pages, with ret known for the whole iteration. So one quick loop for the success and one for the failure case would look simpler an more obvious. mpage really should use separate end_io handler for read vs write as well like most other aops do. So overall I'd be happier to just kill the helper.