From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B873C61DA4 for ; Wed, 15 Mar 2023 20:33:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7DF96B0071; Wed, 15 Mar 2023 16:33:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D2D8C6B0072; Wed, 15 Mar 2023 16:33:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1BA16B0075; Wed, 15 Mar 2023 16:33:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AF4F96B0071 for ; Wed, 15 Mar 2023 16:33:32 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 81BDC1A123A for ; Wed, 15 Mar 2023 20:33:32 +0000 (UTC) X-FDA: 80572283064.17.84B79A2 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP id 376CE4001D for ; Wed, 15 Mar 2023 20:33:27 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=WFbMM+6P; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678912409; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5K3MTIiWRAke5f5Y30usc/ns7fPnYLy4udBXjthSldA=; b=ylZSohuf3gBXERYzx5t3qWuYwJeGSooZA5ACY7CH0ezgbEKtvW+r84wsYqx6FOHueMb8XF a5N64OUEP75duONqX5vV5LsLI2MLsR/3X6veY89n50AqUZxNst9gXc4JomQMtZJXZusxPr lEnty/Xbg5GCb/BNkefMCHxM42BXNM4= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=WFbMM+6P; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678912409; a=rsa-sha256; cv=none; b=cY8zPyubM7G9cO1kUpnEy7TGzcuWttRfD1vCL/pGNb+pcqu2qo9IWQXYEbLPRSQuHVvN+Y xkDFNYehJoVNwGBgx3xqjZwuCqPoPiBo9XNMhFz5npL5mIwoo3iQnUYTaHAs2hx8bd4faf 0rk4qrOOsVU4ZdkMeNuJ2C/b5Fk8Y9o= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=5K3MTIiWRAke5f5Y30usc/ns7fPnYLy4udBXjthSldA=; b=WFbMM+6P427s5nnGrau486ysU5 ZZPHk0mYbRO/vW57prDzEzvDaq2TNPTKxnxKTIniIC9zs/IDY1thLp5tZ5wcykn7EhTwAqV/mm3Sr zJnNhILkZnjCOGcdzX8OLHb1i3ftX4UrPvU1h3esz0SZA3+anzwFxsQu4qh5RzdEvQtODAqNVzxOU o5PimTbgRXiH8NV273zWWnMX86kUTZSnImz8hUEvHLlQpHdxHzbLDUyapN0+mGTKmncZEdy0yA0u8 m1TGRY09SRGYl+W6qy5bBIHPWtdlc7XiQeSxq82uvCfdvbx6pfDzSOJPlFJ9sJECo1yidGFrn7xEa AjnBKyCQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pcXoH-00E9oi-Um; Wed, 15 Mar 2023 20:33:22 +0000 Date: Wed, 15 Mar 2023 20:33:21 +0000 From: Matthew Wilcox To: Thomas Bogendoerfer Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org Subject: Re: [PATCH v4 16/36] mips: Implement the new page table range API Message-ID: References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-17-willy@infradead.org> <20230315105022.GA9850@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230315105022.GA9850@alpha.franken.de> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 376CE4001D X-Stat-Signature: 4g8o1m3hixn9u9fx3n7az7z8a7kn757b X-HE-Tag: 1678912407-60798 X-HE-Meta: U2FsdGVkX18JEbUI4ArrEEHtBv1NRmT4mydHhlQNHst5+8FZU3KwY9RU7qRpsNxsVjobmpqViwqc2jFIw/xXFAxZlIX6r8peNzVpVta18LEWjf6vtCDMjwSDG+05YN3vvaDJJ6vlvqLJFq13yZAc/TsBRnUxcH+hYPqLLUoq7dPZg28aUE4yo7yezIOQwtm7IDyfwTYTvnM/SYbZ1ecRZmB2Y0lfYS/qfCgVGsZ/LLuvPwPjEPF1MgeNhLv3DhsqZ0GX6IvnwcH/LCoi6cwbp9JNSwsohDxDNx3DYvbDxnv+h66ZePZzQ9zDcLTZMIJY/6/hTNWYnHoLTJkCKELvBFqkfBKhjAEhcHz1KcDIorYV4P3Og69P7svZORYUkiPNPRoyWM9nnASYBXy2WlUs4jeMK1fOat3MdVNAs9c3zfYFf78ha6m1FRrB/94p8ArIk2HE1aMYt+NZb7YAI7dP+HcvgIZl6dLyNhy0lt5/nNOy/1mgRb1MiCR0iifo3p0AdSibNHF/D76OSWyFCOHTiyuPYayZ3rfxujt+ejs8N/4bO/+GaE6qdpn7kLsRSLB7AFm1EeDdtyQvv7IXu1T24Sq9VvZKere8yod6hzi/ciwBHunICogUL0fVeLVrG5mgSSuJJKQxNeBSDT+7rYWpjPFudWAIcFuDOerOqGQ6IHdqsIGSZXMvNpA5kmaKgvN02doNjBM5MKhB2FkHXpebCFBP1/TYvUTnjsq15nuWwCWltvixlBvX52g+XNFBi6J5ejMij6wB1YT6+fJXEOFQMeOCJqqAo4vfmr4hcz7SgX0SEBtNsjGKrUUzVKpP3e8w2MWMziOruW0AR1+85nXIsIV5DJpS6UGpTMjhsq/5FahY+hBJdJoyyInr8vbecAbWUZXxIJFE+ASFwQbpzFXqmZWDXxN3QYZE+EsjhBoaP/bSjHeVJl0brM7i1L8ZGARRT6v/aXFKBqIvqvzyg0O N4ljRoLY MRCQrkSflG8MKXAfAUlELPLu6e0FTMt73a0Qy/7mFNBlHOnGB5Wj0KppR6OaNleKPg4n1Bi0oZe+dTfs3TE5RUoQhw5+fNyo+iNzDF6EA6uafE3JOhTief5tWRy6sgSqX7pPg8xKllKowJQOXrXdkUDlBog== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 15, 2023 at 11:50:22AM +0100, Thomas Bogendoerfer wrote: > On Wed, Mar 15, 2023 at 05:14:24AM +0000, Matthew Wilcox (Oracle) wrote: > > Rename _PFN_SHIFT to PFN_PTE_SHIFT. Convert a few places > > to call set_pte() instead of set_pte_at(). Add set_ptes(), > > update_mmu_cache_range(), flush_icache_pages() and flush_dcache_folio(). > > /local/tbogendoerfer/korg/linux/mm/memory.c: In function ‘set_pte_range’: > /local/tbogendoerfer/korg/linux/mm/memory.c:4290:2: error: implicit declaration of function ‘update_mmu_cache_range’ [-Werror=implicit-function-declaration] > update_mmu_cache_range(vma, addr, vmf->pte, nr); > > update_mmu_cache_range() is missing in this patch. Oops. And mips was one of the arches I did a test build for! Looks like we could try to gain some efficiency by passing 'nr' to __update_tlb(), but as far as I can tell, that's only called for r3k and r4k, so maybe it's not worth optimising at this point? Anyway, this add-on makes the mips build compile for me and I'll fold it into v5. diff --git a/arch/mips/include/asm/pgtable.h b/arch/mips/include/asm/pgtable.h index cfcd6a8ba8ef..9f51b0813dc6 100644 --- a/arch/mips/include/asm/pgtable.h +++ b/arch/mips/include/asm/pgtable.h @@ -578,12 +578,20 @@ static inline pte_t pte_swp_clear_exclusive(pte_t pte) extern void __update_tlb(struct vm_area_struct *vma, unsigned long address, pte_t pte); -static inline void update_mmu_cache(struct vm_area_struct *vma, - unsigned long address, pte_t *ptep) +static inline void update_mmu_cache_range(struct vm_area_struct *vma, + unsigned long address, pte_t *ptep, unsigned int nr) { - pte_t pte = *ptep; - __update_tlb(vma, address, pte); + for (;;) { + pte_t pte = *ptep; + __update_tlb(vma, address, pte); + if (--nr == 0) + break; + ptep++; + address += PAGE_SIZE; + } } +#define update_mmu_cache(vma, address, ptep) \ + update_mmu_cache_range(vma, address, ptep, 1) #define __HAVE_ARCH_UPDATE_MMU_TLB #define update_mmu_tlb update_mmu_cache