From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AF01C74A5B for ; Fri, 17 Mar 2023 08:25:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 888326B0078; Fri, 17 Mar 2023 04:25:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 811B16B007B; Fri, 17 Mar 2023 04:25:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D9BE6B007D; Fri, 17 Mar 2023 04:25:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5A2436B0078 for ; Fri, 17 Mar 2023 04:25:08 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 16BCDAC163 for ; Fri, 17 Mar 2023 08:25:08 +0000 (UTC) X-FDA: 80577705096.18.5AC6F3C Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf21.hostedemail.com (Postfix) with ESMTP id 43DEB1C000C for ; Fri, 17 Mar 2023 08:25:06 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=I98xJ1+R; spf=pass (imf21.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679041506; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YoMad97VlS/2zN0ctQ2AEgRPz948dQy79e+dbi8Pers=; b=X7lfOb0M05xZir0QCgc0ASKvxzhFnQK3T5I/GzCedQRUFSXe7mhNU09VqcNGpITWyfUhS8 70obCJr6MKRFfQOONU27b4fQrxw5N7cQFEvNsq/ZFOs65aKpXLz1cKIylSdXOp9DgredTx vcuCGluXFuDXxmb87q7TQhioSFxQKjM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=I98xJ1+R; spf=pass (imf21.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679041506; a=rsa-sha256; cv=none; b=4ZSFDJD+SXCx8CznFuMm8E++3zoHWMYyr7ZAK89nvdKcXqz9a7lYMFAP6YLngYu/LHGtJc gQYYSdNlOErEAMwl5/QHEy8RWNJYbdVof2Vl+BT9swhU1umGXdoli6Lq5R6AQ2TrdiR8BQ XJSu+ERzQvHnjJIB2lSwfMrLqPxUW6g= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 60F39B824EC; Fri, 17 Mar 2023 08:25:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8064C433EF; Fri, 17 Mar 2023 08:24:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679041503; bh=IJACNKHIMb3VFfqK/F0n1ocUFyj5JkV9qD04tkUiy+E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I98xJ1+R5+Q4vUrRCuN3h1Z0L/EO9nUXMCZes6aAGimw8aKjPg6DXS5iGBKnNpi7b 0/RbqwoPvXAfNOo8cBQXsFMGqRhacpD/iVBsywCYl9HTlxNgbnQlFbe6zO9/VpHkZM n3UgqsbEPGEpefsLcHZQnY4aAoHQMuYnGSnYFlhS5H+onzap+PpMZWgdJbjj0ydsav wkAHS/bfI3S3NZNLQQBvPDI2gK5Lv4avbDVonmBpusH0N334glBCsZwmn7mL9YPWVZ T7IWac1Ljl7KHmGLsjLF4dqiJh2yef8JCd2innzJwStG4wIuL+i/+tWs7CJlJygS9K bJrDf1L22rHuQ== Date: Fri, 17 Mar 2023 10:24:47 +0200 From: Mike Rapoport To: Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Arnd Bergmann , David Hildenbrand , Nick Piggin , Peter Zijlstra , Vlastimil Babka , Mel Gorman , Uladzislau Rezki , Christoph Hellwig Subject: Re: [PATCH] mm: prefer xxx_page() alloc/free functions for order-0 pages Message-ID: References: <50c48ca4789f1da2a65795f2346f5ae3eff7d665.1678710232.git.lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50c48ca4789f1da2a65795f2346f5ae3eff7d665.1678710232.git.lstoakes@gmail.com> X-Rspamd-Queue-Id: 43DEB1C000C X-Stat-Signature: 8e66d4djn9pc17b9prjf55yw3aejqaxo X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1679041506-235768 X-HE-Meta: U2FsdGVkX1+Y2mZDouaKNST18GsUuhQHZSDmnwACZ3hbp0SDXjsVZHmEwyqbtnFWFOclkisRdZTWD21L9I6GEMs+MTH460Zb97DBZbY8kD9F4JjJDVsDPHgtJAllkok27k3hFh65kSabMLOlwrKYzY1QXnBKNnLK8/ldb2yFWRLZILaBM2RBNvopDp/vQY8sCJLQWXDj6z0WqQLo9ePxb//8k/NXuZildXdX+vDeejYEcnbT/Kr7ppA+OZDHwcYq+OW9mScnTk7NS1w3s8JBmCMEZThE6xulgcz9zhUK3YR/2f4v2m8hogk/7R4Uctptn4rofK/iNFV6hn+kAJGOUrfb3DW1WHlZCgOT3cn6q+GiL+es5jdXioSsPAeRUCctclkMk8ZsJIxba/JGGEHeSUpEBeYrVNwNWy2rtLLVK6qa6h4Yih+QwjtctyDTBBqD4jLy02feIvOXM3mzrY5NfdWr60JYNzXHMyB9nBDj2Zv/hZlnBVw4LbzafSIGf5QUki7ZDI+R3eWJEeorsl+zAQXKjwAucKKmJ8NDSwZxveZGlJg5L28Tlc4RxV3r9Z1GuVs0h94S2OS34D4O7c5j8fwQFUmPuW5LrZuXs1xBp0Ajv7hKBTmsebT+EAbu/Em0lxKOi29jlwEEyP5wBkBCLX60kw6pouYZQBJMGdzBv9DIUI4CPS3Eestocj18GaNOheJtdrgtasqgDgA6xfhG300OCBaVVlxgbbIEoFLAtTMdoNJksYkpLWYMErQyhq8LzlsYamYGOcaAmLaeXDCTzBJf6ZUJRg0qqV5FQvHusvjnjrIlkxlQPPhu/gbqNc3lTGcbAKrgTMb5/FJ3vOlNzC83eF3C1f/hamYrPnD8u8vSVvlufHrDb6IPnhEyzSXybqaMS/BKILzzbgorq0A6TtNSyRZxSndwdmrj4mzxR62Uaz1vbpSOizv6a1+mJA3kgsJrsfyNU0znsgqmLC9 Ecv8q+IL q2eLakkvUz3jvdA8tpoFv16Bndj21NmFHQ70fk4QcfvwsVj+5UPjCvyBaZyS12So/f3sWgQCByyaaxsgLQq3FWlNye/c0hd9SaO6ZohBlGffdAgnE4OvBmhISvFE4IlISIGQbHednznxE/WJJEt1zIpiAricCo17k0lMgdQpgBYbDCA9lsUsp5so2UB3Dz6cBPSBYzdfU9+556q+EgW1S8GhlL5UuElDEU9BnTc2Y2rOwac6Y6VAoMQGhoF/uMxLrH4NNYy/X5R/hvsFTyKVXS/5yv5dbHvKF2CMf2oP53ZDPEAfM1i1P4FGV/LqjoVTxtVKDCMFErEHn2/h7ytAjXG8gLmT+BUOcQQG9w0+ySBW6e+qjh2Kgj1SmHJJo9hBJSaThBifEpI5wEMnNVzy2PvqGOUtFUFmOGf++TdesnwhH6zK1xtbbxx5wNQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 13, 2023 at 12:27:14PM +0000, Lorenzo Stoakes wrote: > Update instances of alloc_pages(..., 0), __get_free_pages(..., 0) and > __free_pages(..., 0) to use alloc_page(), __get_free_page() and > __free_page() respectively in core code. > > Signed-off-by: Lorenzo Stoakes Reviewed-by: Mike Rapoport (IBM) But why limit this only to mm? > --- > include/asm-generic/pgalloc.h | 4 ++-- > mm/debug_vm_pgtable.c | 4 ++-- > mm/hugetlb_vmemmap.c | 2 +- > mm/mmu_gather.c | 2 +- > mm/page_alloc.c | 2 +- > mm/vmalloc.c | 2 +- > 6 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/include/asm-generic/pgalloc.h b/include/asm-generic/pgalloc.h > index 977bea16cf1b..a7cf825befae 100644 > --- a/include/asm-generic/pgalloc.h > +++ b/include/asm-generic/pgalloc.h > @@ -123,11 +123,11 @@ static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long addr) > > if (mm == &init_mm) > gfp = GFP_PGTABLE_KERNEL; > - page = alloc_pages(gfp, 0); > + page = alloc_page(gfp); > if (!page) > return NULL; > if (!pgtable_pmd_page_ctor(page)) { > - __free_pages(page, 0); > + __free_page(page); > return NULL; > } > return (pmd_t *)page_address(page); > diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c > index 7887cc2b75bf..4362021b1ce7 100644 > --- a/mm/debug_vm_pgtable.c > +++ b/mm/debug_vm_pgtable.c > @@ -1048,7 +1048,7 @@ static void __init destroy_args(struct pgtable_debug_args *args) > > if (args->pte_pfn != ULONG_MAX) { > page = pfn_to_page(args->pte_pfn); > - __free_pages(page, 0); > + __free_page(page); > > args->pte_pfn = ULONG_MAX; > } > @@ -1290,7 +1290,7 @@ static int __init init_args(struct pgtable_debug_args *args) > } > } > > - page = alloc_pages(GFP_KERNEL, 0); > + page = alloc_page(GFP_KERNEL); > if (page) > args->pte_pfn = page_to_pfn(page); > > diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c > index a15cc56cf70a..1198064f80eb 100644 > --- a/mm/hugetlb_vmemmap.c > +++ b/mm/hugetlb_vmemmap.c > @@ -400,7 +400,7 @@ static int alloc_vmemmap_page_list(unsigned long start, unsigned long end, > return 0; > out: > list_for_each_entry_safe(page, next, list, lru) > - __free_pages(page, 0); > + __free_page(page); > return -ENOMEM; > } > > diff --git a/mm/mmu_gather.c b/mm/mmu_gather.c > index 2b93cf6ac9ae..ea9683e12936 100644 > --- a/mm/mmu_gather.c > +++ b/mm/mmu_gather.c > @@ -32,7 +32,7 @@ static bool tlb_next_batch(struct mmu_gather *tlb) > if (tlb->batch_count == MAX_GATHER_BATCH_COUNT) > return false; > > - batch = (void *)__get_free_pages(GFP_NOWAIT | __GFP_NOWARN, 0); > + batch = (void *)__get_free_page(GFP_NOWAIT | __GFP_NOWARN); > if (!batch) > return false; > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 680a4d76460e..256e8d3c8742 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5538,7 +5538,7 @@ EXPORT_SYMBOL(__get_free_pages); > > unsigned long get_zeroed_page(gfp_t gfp_mask) > { > - return __get_free_pages(gfp_mask | __GFP_ZERO, 0); > + return __get_free_page(gfp_mask | __GFP_ZERO); > } > EXPORT_SYMBOL(get_zeroed_page); > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 5e60e9792cbf..978194dc2bb8 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2739,7 +2739,7 @@ void vfree(const void *addr) > * High-order allocs for huge vmallocs are split, so > * can be freed as an array of order-0 allocations > */ > - __free_pages(page, 0); > + __free_page(page); > cond_resched(); > } > atomic_long_sub(vm->nr_pages, &nr_vmalloc_pages); > -- > 2.39.2 > -- Sincerely yours, Mike.