From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42771C74A5B for ; Fri, 17 Mar 2023 08:36:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C28516B0078; Fri, 17 Mar 2023 04:36:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD93D6B007B; Fri, 17 Mar 2023 04:36:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC73E6B007D; Fri, 17 Mar 2023 04:36:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 993C66B0078 for ; Fri, 17 Mar 2023 04:36:03 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 688C2417B3 for ; Fri, 17 Mar 2023 08:36:03 +0000 (UTC) X-FDA: 80577732606.13.9077CA1 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id C2E46180007 for ; Fri, 17 Mar 2023 08:36:00 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=K+Oan4h2; spf=pass (imf24.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679042160; a=rsa-sha256; cv=none; b=lWalg5Td+pKAaZ3pAKLSrnaUZDjETf+PkLwM1JreSQwnhpY1goI5xSKZ1/h3B3xlsIeuaq HhF8DzmLFvKOORQB7lLAC97EFWktsmFRoX3Qvtdr98HykFGJ1WZ2YT1c+sseC8bKf4XZIn hMb7vCdGF5t4W/8J/X7ahsOAVb/Q9AQ= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=K+Oan4h2; spf=pass (imf24.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679042160; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ou82sAQuxo3i5Y9lurWTATrR9DGwd594Q6Gk4JP0YEM=; b=mydCQIe1h5J/a81MLKJ0RKqrj21p9kGz8PZAc8c2qfm9dR0x0qqrlPOpTSBG5Fpe9o7liZ 9Z8Xqr8qtmwCdyR4bcRbSjgep8jquL4SI4X/vKKg22y0xyL+NLRwE/JSdTc68IKGjwTkw7 FJDP/w1SdMLRiss7F9EYsUngSODyJHA= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C0B81621EF; Fri, 17 Mar 2023 08:35:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 765A3C433EF; Fri, 17 Mar 2023 08:35:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679042159; bh=0U8d1LMWaEZQgafPkPZom810OpVwizNioSkYu9Ua+ns=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K+Oan4h2AJGsMePeKGlfKytnhkDM1qtdUfuMAeZSwnfAVazgO72kZeLCVwsg4vkH4 NQjtcIYPbxm09chvEPyyjV8agLCk1qrZtLaBGjEF2ZnStax/I91MJ80mGg9ijXI3m9 +bKY320hHoUFifi3bJRO0JVWMN0M2uTQVSZSe6DdHZSQ2lg1SmWRVi2YGXEm2lOYbo RcC5XWa2trUVyNudNZzXWg7mIPfrGFeBHkwUtwPwvpUMZRz+ND1MEZ+ruqTW9BO5KL pOBP3AvRts4ikjdVX5kIcsacITLSX5l27sDwuCAPXixR0Hbl7Ud4huCS5Cxi9xvrpd HOdKFnktWuJVw== Date: Fri, 17 Mar 2023 10:35:46 +0200 From: Mike Rapoport To: "Kirill A. Shutemov" Cc: Andrew Morton , Mel Gorman , Vlastimil Babka , David Hildenbrand , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, David Miller Subject: Re: [PATCH 01/10] sparc/mm: Fix MAX_ORDER usage in tsb_grow() Message-ID: References: <20230315113133.11326-1-kirill.shutemov@linux.intel.com> <20230315113133.11326-2-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230315113133.11326-2-kirill.shutemov@linux.intel.com> X-Rspam-User: X-Rspamd-Queue-Id: C2E46180007 X-Rspamd-Server: rspam01 X-Stat-Signature: jwsbuese9wh9nc5wpzk1ym1gikghe4wg X-HE-Tag: 1679042160-422400 X-HE-Meta: U2FsdGVkX1911GIB1ynQgO8F/TzbUd0Z8nG+pfTOoHaM3kYgHAh0mggjcYTgHNchLN8uP0c8THcMywSTCBODxB28bJTaL7mgKb/Ze1hfWyF483r5EdtJeZMvAhf/V8yZybVzy72coM9VChIOoixh211sqZz0DslzNKXAx6NWA+o9mGwx6OjhCx7TWNuyYaSpLWn+AzW9ydwhqFf1nPkkxuT1NS482aKkUjPGTEwhiAbnflTkLHatdK9ABbLmoqNZr8D1f121W+oOW/zVnwvdPLuRFPiS17l/coPKGXyTkqjgv+2Ex8T9E2+7sY0tuCnC2RantsJrB9/Dgfe4VaNpW6U+fdxFak/9arCknkDjZmLFljw0g6Sxf5hetm9n6lKbdo3x+N8HWhvWd1F9fx03TLJmCZw1PkBeb8pATYveVvSXCZgRNajCYiaZkG8Xpoopi+zDoq2Ooyp2UTSMwCjodrJotVgWkFBgMNQp6R7KgNAzm59QgXeYQBEXAZYHdRU8oODm5e4x68dBj+KhOWM8F4khXmYpq7YpjJdA7YogEAzKGwVbXsfWxQNygmo8iuFfExAl/f3OLxP8dkvCHttGv0NmgVNX+9iBitiDe+t+2v4areA6Wo9WTiuBn2mtvCRmhYZ0MJ7FTF9YjwHnNfza2SxCJQwGXhwtTFwPV6tKHY79IKpHbbtCRzpFP+zmn+fUruxCcZzolZKxJkTUc+eQt1slBf3J2ucxVwIzl7AGkQs7O7I5j+LINSYTmrbPqegB1iWMgImqLIFQWS3r3W6yzvZ5l+1zq9NvKTExRaI1G/admf6jAWgu9xwtbMuMtWCAdiMyPwiRcCRYU8XsryrpE9IAFi0yv5nacrcC5f8LdBUArQcEJ/nVKhzc37NVMSliB38j3jQtA2rX60uIFTTMllNmSyy4RPOFOBpi+05v61rMpy6jcU5Rn4+Ar7ia8y6d37nBrwJ0e+B9fLYtOOF BEmX18Ik RIsF82UtNskyBsZw5Yp7sYx3a9BKu/8Uq+dV99IfSsh9Uy4dGu62P/pJnouIoOvLs/WCh2RgdOVIt7c01PRNqynJSa6rLKGBjPYsdS1/grjWVJ/ETZ9PmXy1oRTsA06MBGWgCIRIUaMwNm1NOKpgM8w5wR0FWUIKTZRwhfmTwpuoyRNBWAW7LJdZEgq20R1HpRHeNjGPJe1PHKXLAJKr/iLN0M276TEfNd/Ylf5UWDzAP9vGI8abmyyHBLOX3HGMj93KpNheUzOxtVROhq7Vg/IWw3W4HqBrzYR4mH3qJcrtnT8itqVmE7pNm/pEQatVc8T96PUjSHRrd4KUXGXIx3pUO7+sdNFtdTAxNT22CplEKxko5uUGwsHKCDfLA2YmOTb4E3SYcKLjR0qsfpqiOJfyaDmx2cRCynH9x65kbQL+FTNIKKnvSeNYsIH4fPxtDE1Yxp84fjr7kVwFvtvvVBDSkjzhoDyMQ9LILuD/8j0HLwGHvACFygz3hmw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 15, 2023 at 02:31:24PM +0300, Kirill A. Shutemov wrote: > MAX_ORDER is not inclusive: the maximum allocation order buddy allocator > can deliver is MAX_ORDER-1. > > Fix MAX_ORDER usage in tsb_grow(). > > Signed-off-by: Kirill A. Shutemov > Cc: sparclinux@vger.kernel.org > Cc: David Miller Acked-by: Mike Rapoport (IBM) > --- > arch/sparc/mm/tsb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/sparc/mm/tsb.c b/arch/sparc/mm/tsb.c > index 912205787161..dba8dffe2113 100644 > --- a/arch/sparc/mm/tsb.c > +++ b/arch/sparc/mm/tsb.c > @@ -402,8 +402,8 @@ void tsb_grow(struct mm_struct *mm, unsigned long tsb_index, unsigned long rss) > unsigned long new_rss_limit; > gfp_t gfp_flags; > > - if (max_tsb_size > (PAGE_SIZE << MAX_ORDER)) > - max_tsb_size = (PAGE_SIZE << MAX_ORDER); > + if (max_tsb_size > (PAGE_SIZE << (MAX_ORDER - 1))) > + max_tsb_size = (PAGE_SIZE << (MAX_ORDER - 1)); > > new_cache_index = 0; > for (new_size = 8192; new_size < max_tsb_size; new_size <<= 1UL) { > -- > 2.39.2 > -- Sincerely yours, Mike.