From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CFF6C6FD1D for ; Fri, 17 Mar 2023 08:46:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E929A6B0078; Fri, 17 Mar 2023 04:46:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E48396B007B; Fri, 17 Mar 2023 04:46:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D09B26B007D; Fri, 17 Mar 2023 04:46:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BEF166B0078 for ; Fri, 17 Mar 2023 04:46:32 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8DB3B141762 for ; Fri, 17 Mar 2023 08:46:32 +0000 (UTC) X-FDA: 80577759024.16.985327A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id D2EC340005 for ; Fri, 17 Mar 2023 08:46:30 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uJzYOtsV; spf=pass (imf17.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679042790; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GO7Xkf/fTSxVSpKO6xtwo2lBmcQJK+hY5kMxhJv3DtE=; b=YCxWZRZufa2IQSqKQtrbA1mSw/A2z18JCjEqy5r7bspMV0zyoGgZ+yQ4igm2+t9+i8LsOE cRcWXVeT3M04MEwbygYcqlhsKpjiK/elbtNG44QRV2Qi/T7e+yu6LQN5wIbo84GclUQJYM 1NsQtBzKd2A/XO86CjTgALP/RTyT/Es= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uJzYOtsV; spf=pass (imf17.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679042790; a=rsa-sha256; cv=none; b=dV2rereCq6Og1RH8+rAzl6US0ZoqfBJtUqOG1cis9CnjnNx2XNc/Z3Jt6wdNl5LHQLQ8mK d6RCvOXCajLRXEM7peyahkwDnU8m/uuju8deBnMsIgBF/SV2Cu8JAqF27qWMHQnlDw1HfV 6Gag6chT3Ekd7OJFhoVwa8nC6o6SmL4= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D68D76222A; Fri, 17 Mar 2023 08:46:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88B0AC433D2; Fri, 17 Mar 2023 08:46:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679042789; bh=eZNvNwV6QaJLpDQt/LL3N1gO2o4a3oCnClv1PSM9XeM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uJzYOtsVjg8yXxg3J2EU7rYSRGVMTNdq+xiS1UKbgTt4yAo4AWLckqLIAUmAi6f/Y colg1stCYv54Uf1/5mYpRAwYTuuQLcZAlBo7yfcCvTDo7w3AtCDBuE/ASeou95rihG MlxFnldm04gfXJUCE0HKonnt6tXFsIsgy3vXERRXiKWs1638wS1pMNquvxoQb/g5av jBC9Ai1maPLR0XzOmDA0fZ2Ar1n86fFOdhBJE6PPU5Qm4prbB8BBChvuTuiFTsdEc8 9tJ/NDCx4fRxgo/g8bxqh7rnJ+QGKvvqcQ1/S+MkB6g3vykNLK60/14vHCo+BU3QxI 8dP2atFEEH+eA== Date: Fri, 17 Mar 2023 10:46:14 +0200 From: Mike Rapoport To: Mike Kravetz Cc: "Kirill A. Shutemov" , Andrew Morton , Mel Gorman , Vlastimil Babka , David Hildenbrand , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, David Miller Subject: Re: [PATCH 01/10] sparc/mm: Fix MAX_ORDER usage in tsb_grow() Message-ID: References: <20230315113133.11326-1-kirill.shutemov@linux.intel.com> <20230315113133.11326-2-kirill.shutemov@linux.intel.com> <20230316030437.GD3092@monkey> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230316030437.GD3092@monkey> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: zsiw9nb57c7b1i7pguhtc595fhotyaxa X-Rspamd-Queue-Id: D2EC340005 X-HE-Tag: 1679042790-931651 X-HE-Meta: U2FsdGVkX19iWdjbhfwOu/C3PmrzyEAyZderXIh6xRC6HsYeNm68w1X/U8w5O//GeQH3HAx711wGctEWIcZxD0kkIiGC1b83EVQQZU9JmcEzYoptm/mBIQ1I8tNCciqHymsuZIvqBTy5HDD5YvhJlUrQ0RAjd0p2EPBdB3cGWa+uXqiAsX6FPGjVsO0mUFh22KgUeVpr8f6CdEj1lUKuiid5FC9gILbLPiZDTd2J3sqr/nWlk5e8eyj5t7F3ng/npeMEbrFYcznkWOz3BeDaN+xY+Hro80SmYrYqsQ4CxQs8uAWNxckh+2x16NuQVK69Ab20MjzKdFFAUw8fU14HPjPWEYqsxJtLTiOWqxj8Bdd8BpPls0epiK22YbLleG6p39jznumL/KWsPbHDewlqqINChHg4dB7wctzG0+DP7p0pXrzc1V1NOLGmpiYzmAl+VA6S3q9Cn0doyCpe6S674dg8Cc0W+aonc5n9KsL5M4KM+WgUsHdR81Pn1D56CTOIb85asTyt5YalhQLYmpXzO4aipRg5rZop8GX9lptMYCK1bK9oj0KQeCH729yvbQC7+IoLR1vfRVLgrpj2zNb7zwB4tno+anSiIIpQp7BaWRI+K5DdLPQqiXEN+COG9bVUMJsI+hxkl0bmD2KApPq+D53CkIxm3f9GwzTUwh4vj/wlspevxvj9FihPPu54S/aXV/PaBoXsqrUNS4kJbHFlq+FDIusJYe7OITID9uEhvWMeEF4oX9qXO80CJLpE8HCdfT6ICtQJd2LBuoiZaW6YOVJueN6S9s8DQr8f/xbN7yfkj1m2Df5FoUSwNE8Tcfz7U35kKMgytO0Q5P2vIiRNFIEdVuKpw5LyFLZVFuT1IK5Zel7khUTGYRnjW5SStKRRejevRD09iEmW3+GBsMCLVraHCpG1toD8pYMkxi9NX/DblLj32ITD0R9bzcyENYGQFpLk76qCGNu8Q0eNqoq Anr+kTN2 Ta97ukSNfOwi2BAOrGA8tBl9EXwcHCu4uDOAWkXBjWf9Pt/on2rrAhb/EnWJAXosVYiKe27jHcS4cPyDJYGKMihhiE/zVRE+U0nT52A4XGqkuK+C1/thkcmomfdLKiwV1NhFvPm7pj7ecTK5nNv22l62fcU4qJTct7x7bqNiQD+DH+DbRlV9cNE9fLc9+bXmmpbw2/c5XtqXF/CMgSoSBmjgR6kyc5xGppvmKbMW85+LnOKAOA6tg+fHnXKd7px73p1zDGvxTZ8IJzb9HPubOEmtoQa8TsBGnrjJxxSJR7IgwWXzWAdQMREmvQTJC6HHwI0m/QKfihYVtkW9S+OvZCOzzbidTOqSwBEMHRnJRSEpWvudCwnnWW+8IUoQMcpSaPTHTEUhMtz1MtRLcPkm9s7Cg4ZPlZNzesAcY7y6mOv85JJyT+dG1k9hBc8fOG3kbzn4ax0AaRHzWcF5gt76sTlcRitATCutEwHCGGei40E6YXQWvSDIjkfBCsqSoHW1fVkJa03zPoMSs3vo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 15, 2023 at 08:04:37PM -0700, Mike Kravetz wrote: > On 03/15/23 14:31, Kirill A. Shutemov wrote: > > MAX_ORDER is not inclusive: the maximum allocation order buddy allocator > > can deliver is MAX_ORDER-1. > > > > Fix MAX_ORDER usage in tsb_grow(). > > > > Signed-off-by: Kirill A. Shutemov > > Cc: sparclinux@vger.kernel.org > > Cc: David Miller > > --- > > arch/sparc/mm/tsb.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/sparc/mm/tsb.c b/arch/sparc/mm/tsb.c > > index 912205787161..dba8dffe2113 100644 > > --- a/arch/sparc/mm/tsb.c > > +++ b/arch/sparc/mm/tsb.c > > @@ -402,8 +402,8 @@ void tsb_grow(struct mm_struct *mm, unsigned long tsb_index, unsigned long rss) > > unsigned long new_rss_limit; > > gfp_t gfp_flags; > > > > - if (max_tsb_size > (PAGE_SIZE << MAX_ORDER)) > > - max_tsb_size = (PAGE_SIZE << MAX_ORDER); > > + if (max_tsb_size > (PAGE_SIZE << (MAX_ORDER - 1))) > > + max_tsb_size = (PAGE_SIZE << (MAX_ORDER - 1)); > > > > new_cache_index = 0; > > for (new_size = 8192; new_size < max_tsb_size; new_size <<= 1UL) { > > > > Fortunately, I think this only comes into play if MAX_ORDER <= 7. I think it's unlikely that such low ARCH_FORCE_MAX_ORDER is ever used. Judging by c88c545bf320 ("sparc64: Add FORCE_MAX_ZONEORDER and default to 13") log the option to override MAX_ORDER was added to "request large (32M) contiguous memory during boot for creating IOTSB backing store", so it was about to increase MAX_ORDER. Generally, we may restrict sparc::ARCH_FORCE_MAX_ORDER to be above 7 and drop this check entirely > Reviewed-by: Mike Kravetz > -- > Mike Kravetz > -- Sincerely yours, Mike.