From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 954A6C6FD1D for ; Fri, 17 Mar 2023 08:49:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DCDB86B0071; Fri, 17 Mar 2023 04:49:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA3A56B0072; Fri, 17 Mar 2023 04:49:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB9866B0074; Fri, 17 Mar 2023 04:49:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BD22D6B0071 for ; Fri, 17 Mar 2023 04:49:30 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 73E54141762 for ; Fri, 17 Mar 2023 08:49:30 +0000 (UTC) X-FDA: 80577766500.14.797045F Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf13.hostedemail.com (Postfix) with ESMTP id 8E63C2000E for ; Fri, 17 Mar 2023 08:49:28 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ASlDJrZe; spf=pass (imf13.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679042968; a=rsa-sha256; cv=none; b=OokFjLDxwdNRoLZW5ojtr75IuOmQuvAaYCXyY1TwdyxiM6/G/bV0moDGRS7TNIGF2yZBSx eRqs7MVs2hVf1yKafdCdVwXmn6+lZsvKMZ5iw0622qnwOWHLuTTwcE9kEpgFKWhm6iMywY u5KIgPVb3DDMlbxi224RlSkxvsSt+hk= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ASlDJrZe; spf=pass (imf13.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679042968; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hw5o6LeVao4EQjgmt2TCyJfaEwdRTNubA3pP7ZxZHuQ=; b=F6hR4N2sqx+zyYUHiM9NoLgm3eByqzr7kLyiU3Lr70iHNtAcF/xj9LAUr7eIWqxBiZmelc nlvtSLlUKnUuLs64TGZlCZlPsN5R5vi7opdcCHnn6Njv7id/JakwyGas9ZSLXj0iJMs1tz tG6rx05lDv5cYBCQtULOw3jjobCXD64= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E4E98B81DEB; Fri, 17 Mar 2023 08:49:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7303C433D2; Fri, 17 Mar 2023 08:49:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679042965; bh=ykt+2ZCz3fJnDj9RH3P/+IvPyVarY3iXaWoZy2um+KQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ASlDJrZelehzIwW2Z9VzYs6Yymp4sfhk+lPTy1rfj7IMYKry3XAmgaEkxvKDPNLuo UKP1933d6dTIUg9+GFtsFk6iiwHfK3dtxpHxb/0jUE4K/rErFB2RmpNA8ZsANeTj1u 18FxT5XPdx30MtVkPfwqtMZeDoDeAFrXHS1qQ9ndhOtdA1yFGgtnHORVFmfSVop1F3 s5XO3h1/KbvYLFpyFzBoSMWLGIelKa/6Lp+Lk0ydn3t1z7D2+4+qiifR8aLa91xvO5 LZsjEcZiG1OND+JJiZFUrNqNGEI1k8c+hS7BmRP45mhj9VU5hfyOtGmH2c3+iNJ1eU R5ZP2HY3NSONQ== Date: Fri, 17 Mar 2023 10:49:11 +0200 From: Mike Rapoport To: "Kirill A. Shutemov" Cc: Andrew Morton , Mel Gorman , Vlastimil Babka , David Hildenbrand , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Richard Weinberger , Anton Ivanov , Johannes Berg Subject: Re: [PATCH 02/10] um: Fix MAX_ORDER usage in linux_main() Message-ID: References: <20230315113133.11326-1-kirill.shutemov@linux.intel.com> <20230315113133.11326-3-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230315113133.11326-3-kirill.shutemov@linux.intel.com> X-Rspam-User: X-Rspamd-Queue-Id: 8E63C2000E X-Rspamd-Server: rspam01 X-Stat-Signature: cx9kqy5wpateofu61fgfnpnm7snie79w X-HE-Tag: 1679042968-882787 X-HE-Meta: U2FsdGVkX1/FkkhzIaIopqQdR9ctr4tJaO3OBGkOFktetpkAQXPN1PMcla7Kir8p6Rm4y7RGfv8TdM1pqJjflpCVtxeS2xEIHLuMIJxnVrKBOU4Srr96fMcEZbxSNZvsvBPoISnKQTdkixWcWYgWN5+kB/BKndvwHfoaCzeCFIQeuSjFPInilnIRaqCoYrHKlG7ZVki2/tHtVIEs56kvmxb78YYjX/AQWAn/Ru7DGk2QHXtwRECTLQ6Fn5VQG8bJYBNzT3lnaD0tf27NbTFWD/I9dUNxlD9hyg6alqSXS+hIVlqjhEm6pakAim7kb9zu5L4GYpeP8lzxQGC6L9DCir7ROIRW6hGkw1hzkYM3GNMa/Z84/eSJuYFdUYY0TmxCpC0aH5hASaV3uPU7uS69CXboFCFSGN32RTTOep400ZRpklWPef18Muh7MSAxfn11o3ESW/P/RqSTV+dWo84m2Mf/nCbLU8ua9ptGJsVYWnt2jGYbSaquqE6OsF0P8Uuu7aoZcHFory6Yvl4TA1EEDNtIal8yUa5tY4B7fxezBT366pXZcSnU0JemxkuHO9asGFeFCVAyGUOnWXtcz0RETu9GYIlbqdiVev0RmxOjwiSb1yJ0W8LpJVQXYjgCOOVv7VZead8K/mExDFb0o/81E3dPYWr4Z6PaVDjHEHevvvB/92J9N6MS4pLZ7GNwuLFNxAtu7Ykp0Xoneu/A6wdgrQM0Ao14jquCt8Sv+VPZyeVVgPH8sub4C5QvDZrihXqslvzhxvq54uSq7JRznV+JZlhs9iUkJMl0VJn7CVzA0Uzpxkd8A+M7dcHpEJlr2uxO+imsT9UVluZJvPBgfqxemi0MzJTm59VFn++yQHLkGdhkjIO+DP/11Zcf43BK4zu4tYhS96OUgoeB+6k7SKSoR6SbBdQhG26hLcGPj05DHP+yzi/LyqtYpsOg++mpvHuo877YbZTQ3+oCDvTS+e1 UIFLokHt hwvYUCZ28345b9iks55Cdedt0D7dwVcb1m6Xxc4OaWCFdfpJ4oZCBRZgakG6gBBayNqqcclVpk9Od+0jjGzLNgd4D7ngi+/kRX2y2KfwGEsBGhkuktouDv3wBf5s5F7O+QpAy5ax7oO73sOyCgXgQ0XhnScu29d1PofP7nb0G5ODrmidb9BG8oRu7umJA3yCMskm+AS9D3j/nR6zPMJsmJNuIOAoQF8lYJskYqIgrQqn9XeQJQIlTXDQIfvq+cdUjDguF1xIycQFz0gxSSr6Ts83xb8ul5HkiJHoHzAPLnnQcGqjWuqlLB4ic0G6UpSl569XvI4D+BJbbZ30IlFuZriY3siUsf4wmJ+f73WQQyiEeb7jgdgY65lPHRzEkjJtycqVQQwJevKXGnKA0x9jsTQvclxfMovzfsL8qmRQAhX4x4bLmjDoxSeVyUqKDzd6jQEqZYnC7FtCMR0tZjRbVTLp2REzFP7DSLDeAg6/sKJt4wXDTnqHZ5vLkOSLKgFyo/NYavRPAKMKC0GOlMNJXLOuvIUt4rBCLu1DQ6mTVAMi4MUI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 15, 2023 at 02:31:25PM +0300, Kirill A. Shutemov wrote: > MAX_ORDER is not inclusive: the maximum allocation order buddy allocator > can deliver is MAX_ORDER-1. > > Fix MAX_ORDER usage in linux_main(). > > Signed-off-by: Kirill A. Shutemov > Cc: Richard Weinberger > Cc: Anton Ivanov > Cc: Johannes Berg Acked-by: Mike Rapoport (IBM) > --- > arch/um/kernel/um_arch.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/um/kernel/um_arch.c b/arch/um/kernel/um_arch.c > index 8dcda617b8bf..5e5a9c8e0e5d 100644 > --- a/arch/um/kernel/um_arch.c > +++ b/arch/um/kernel/um_arch.c > @@ -368,10 +368,10 @@ int __init linux_main(int argc, char **argv) > max_physmem = TASK_SIZE - uml_physmem - iomem_size - MIN_VMALLOC; > > /* > - * Zones have to begin on a 1 << MAX_ORDER page boundary, > + * Zones have to begin on a 1 << MAX_ORDER-1 page boundary, > * so this makes sure that's true for highmem > */ > - max_physmem &= ~((1 << (PAGE_SHIFT + MAX_ORDER)) - 1); > + max_physmem &= ~((1 << (PAGE_SHIFT + MAX_ORDER - 1)) - 1); > if (physmem_size + iomem_size > max_physmem) { > highmem = physmem_size + iomem_size - max_physmem; > physmem_size -= highmem; > -- > 2.39.2 > -- Sincerely yours, Mike.