From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5071C6FD1D for ; Fri, 17 Mar 2023 08:53:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 391276B0074; Fri, 17 Mar 2023 04:53:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3404D6B0075; Fri, 17 Mar 2023 04:53:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2084E6B0078; Fri, 17 Mar 2023 04:53:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0D0246B0074 for ; Fri, 17 Mar 2023 04:53:20 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CEFDF8179E for ; Fri, 17 Mar 2023 08:53:19 +0000 (UTC) X-FDA: 80577776118.28.939B883 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf23.hostedemail.com (Postfix) with ESMTP id 19DB314000C for ; Fri, 17 Mar 2023 08:53:17 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HHI3JC3c; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679043198; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mz7xYxu4nGCHN3dRDSDZcn4Fn/f2z5J/uhVY8LiOxo8=; b=YSNcDNaEdTtF9bNDpVguhzZU29UA91COlNdpNkcD+Cyqdg4zB9vQIWyOSpNlq89Y0Gtz2U aNtDZ/Rb06pxH5XD5iq8D3vzTSAgNTesfoDRcrmmCeshnUV2VPBvZowAeuXzS6g9mIXvBE YgedAdhsG67c3KwqYnyGCbmaL0Z5PAg= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HHI3JC3c; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679043198; a=rsa-sha256; cv=none; b=UC5G1DFHQyCjBwsQCgGn1Jt9fK/gwY6wbuM6PrPz87x10yWasdGnz0snHVCE790/hUbvR/ GDOsCuf1XIfnehIyn4DAbOT3GIY5QGoB/9yruUshb+0BrfGjWroybLSkNN9Taq7QGH0NW2 EiBdKNteaa2YkGX5un/ysKf7uaB1q84= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B59C3B81DEB; Fri, 17 Mar 2023 08:53:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9FFAC433EF; Fri, 17 Mar 2023 08:53:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679043195; bh=B3wahgcn5mCya2QfzNpjGhDRim/NPquzm6i3xLDnJT0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HHI3JC3cw2rpX/l/4nDWRywUopCJn3cKlLScYDDBt/1oyDV9dArx93sY9+r6VpUyl XUJ5xQsKry3BPZIL3rKV6jRHTv4/WLwW2vm+5lM52YiFp1TOwMI5AOHWodC9cwUmpt z0KIG0OJzoQ9nU8aQfvszQWSuwRFOEzpOnublDNFSzAI+FhDQ29Cn/qsfaaB3T3j2p k0jHqtwm+0VP0eKbAsH5nFdQWcO04sHGXTx73YWU5vZehIrCm7IL5jtzQJCSsOrEIr 4NDXJ9bLLST47RNuXXzYlkGncP/2MUUHMVD/CJ2qv3kU3yU11pacIsp4mtawxKZyJ7 jzJGqwRXIt21A== Date: Fri, 17 Mar 2023 10:53:02 +0200 From: Mike Rapoport To: "Kirill A. Shutemov" Cc: Andrew Morton , Mel Gorman , Vlastimil Babka , David Hildenbrand , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Denis Efremov Subject: Re: [PATCH 03/10] floppy: Fix MAX_ORDER usage Message-ID: References: <20230315113133.11326-1-kirill.shutemov@linux.intel.com> <20230315113133.11326-4-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230315113133.11326-4-kirill.shutemov@linux.intel.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 19DB314000C X-Stat-Signature: mbnu187z1wc1mzec4eazyizo4e3yeh9o X-HE-Tag: 1679043197-232590 X-HE-Meta: U2FsdGVkX18Vs2hp/m0fsaZW8tHNf8aIe30uZiSPGLRvBhm4m0curmErn11bplce4V3V+JVK/BRVWJz/X3QYMI9uzE+LuFKepI27tcw9t/6fGuyT2XqTWBMJrTgK/RfPVt+qsfpNLse4k6iPSr8KkgKWgh3ME7LGV/BIqY7CYGT0gW2cJXk+b/EWGBK+HSikPrvGZAUdnfnz04y9wlpvezRhNcxCAD3k45ODzHvacjRIqVqfRPQoSPvZzSWrOJmRbKEAG3nvabRcrX5yZ7HrsoedpnjgyhX4sA5gGwmsfe4VH9adPlRM9f9ioScHF7qwmH7TsYm5i084lDxZTMR2BJFEbwQFcRiXcoBaX3dy37lZAsdBO3zlMdjqebCA3wzubigoZ9ZiAVhhJRG/RLp4GkMhotCqr9Ogvo0jNkL5ajjH1EWIU+fu6Q3ceRPpggjDWE//pPUSpqSm5qKd6ehW6bAG3C6RxKxF9udveLrGt1B798K4lCpm2TZyAPtlXU9EJWyb5mpM5DPg1vnsIFpZr4FAvdDSfX/Am8ylZswQiSM4Te/9W8qFwi/VEWNtACgSgrjFn/W+HVp9gwe62I+zcocq4PuhfZiAOpuzz9/Kf1sS446aAL319PBbOAgIIoD+opiK1B38BMfA2yV4E4GBgu6Dqnzfnq73Iz3j58tNQALFzmow6xgZUkgZd0UeuOhvvmg1U+EmdvpBDveI/5Jo3C21RRavfDjXejKAM9myj9Bji7CWH/iHd/cVnVUAZmzYk1ytoIIU9I/aX77IL/uVNAwY56IhYTjOnCJQGMREq+ygnmf8IBa6RUBOYO9aU7zOdgB5ExNu3kpNN+GMcKc6eYQ59lml3ZMgioMgpEVZ5qiobCgfb4SkYCFwXf3PzVJUT0e16vDqseLgGQaJ1OaRBh9QBXL3S54SjpqsiPHDbWkYiDvwpSnVYc3wnATDmQs0e68IjQBCEnYiPqA25rG +gSPcRYF 8S0Pmf6xdFjyPIdX5yX7cnGl4A5WwJhE5MLrZlCcd4hqbHFO01Y6Vqzk4yAWJhuL4Ug2GAQDTpNQ2z5UNHgcyXfDihAW+SAUL5PQoxNx3Otdt5PhB1V4WJCX0YFaoW7t4aD/m2K+iaYis+hWZB2wvT2R9VAjM+onpxtCKuBf/BAA2j+gN2kSUspGuYIfm7kYqDL6yy8mvQ2Bg4oIMMOe6IK9BZqHaeCF4tOgVCIkVMgcDlehIqwUePqh13XfbOAgFWA678wd4OgamIyW7qC6QZSEQf89J0J19ZmbcppNO2LmDxMhzJUh691wH66Zu7AhJaLVu0DnUyI9MEfcJWwBasQw0w6m5o1nn0DFyEduIN+Y1SQEjnyQ7Ry76cN874AUtyv8aqSAXxOd3WeFxbTep/l/yWe7GfahwEXfbGSNIhmXGrFxfsitUVwPjtEpgLzwhLqzPFb1f+YolDVFvT7I7wP0aM8GciEP3ddwIUHVC+1+aBA2kvPHdKpwEyw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 15, 2023 at 02:31:26PM +0300, Kirill A. Shutemov wrote: > MAX_ORDER is not inclusive: the maximum allocation order buddy allocator > can deliver is MAX_ORDER-1. > > Fix MAX_ORDER usage in floppy code. > > Also allocation buffer exactly PAGE_SIZE << MAX_ORDER bytes is okay. Fix > MAX_LEN check. > > Signed-off-by: Kirill A. Shutemov > Cc: Denis Efremov Acked-by: Mike Rapoport (IBM) > --- > drivers/block/floppy.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c > index 487840e3564d..90d2dfb6448e 100644 > --- a/drivers/block/floppy.c > +++ b/drivers/block/floppy.c > @@ -3079,7 +3079,7 @@ static void raw_cmd_free(struct floppy_raw_cmd **ptr) > } > } > > -#define MAX_LEN (1UL << MAX_ORDER << PAGE_SHIFT) > +#define MAX_LEN (1UL << (MAX_ORDER - 1) << PAGE_SHIFT) > > static int raw_cmd_copyin(int cmd, void __user *param, > struct floppy_raw_cmd **rcmd) > @@ -3108,7 +3108,7 @@ static int raw_cmd_copyin(int cmd, void __user *param, > ptr->resultcode = 0; > > if (ptr->flags & (FD_RAW_READ | FD_RAW_WRITE)) { > - if (ptr->length <= 0 || ptr->length >= MAX_LEN) > + if (ptr->length <= 0 || ptr->length > MAX_LEN) > return -EINVAL; > ptr->kernel_data = (char *)fd_dma_mem_alloc(ptr->length); > fallback_on_nodma_alloc(&ptr->kernel_data, ptr->length); > -- > 2.39.2 > -- Sincerely yours, Mike.