From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A33FEC76196 for ; Fri, 17 Mar 2023 15:32:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 23EC76B007B; Fri, 17 Mar 2023 11:32:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1EDB86B007D; Fri, 17 Mar 2023 11:32:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B71B6B007E; Fri, 17 Mar 2023 11:32:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EF1AB6B007B for ; Fri, 17 Mar 2023 11:32:15 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B254081930 for ; Fri, 17 Mar 2023 15:32:15 +0000 (UTC) X-FDA: 80578781430.04.22E7879 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id A8B1F10001A for ; Fri, 17 Mar 2023 15:32:11 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=eIu8cVVE; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679067133; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=inUvHEu4HUOp2iy8ZcRjHwFFv7P6+MbAHF55eOD5Mdw=; b=kHQ12S56mKL2yDz611KXPfDfnyL1qgWTmuOxdG9lNx86EF9K2ZOA0Q72hnhaPv3a7KHAJb m2s5d7kLrxZIKZhqdnNVjoyie/xfX7rjRNZgR939kMseuWeVraresSggTw/sETr1ybxNo0 fOLi4enw/1MHtjBpk9z4Fv2EmXeYUbs= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=eIu8cVVE; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679067133; a=rsa-sha256; cv=none; b=LGf/4lrhqmO7cFQoXR3ecTdg4zJaonDIScN5bMBl2T8/1Q/DUR3jY8PY28eHbIHP65N1Fp TS6Lmaa0TIBMn1JZPPk4l7Tqbhd7ne0IxCVkxWdPr9xJhuMfxkMqBR3apgHUguB+foXRHU gPS7Y4z042Mp4mfycsW0T/OurW+pQg0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=inUvHEu4HUOp2iy8ZcRjHwFFv7P6+MbAHF55eOD5Mdw=; b=eIu8cVVErxdUVQNrKy4EFwDue/ RJ0stM0TyUWl3VnVLFZYeOvuOTwJ2udGzfFYdyBTVKHhNKVK3VUUJ9izcE+n1jzCKOI/OyC/hbtl4 pEzeWP1fDuv16Nh3tjqz7wfZDBzAamimQM6/6ar6GVSIC0hPeKTQjlIEnwPS7f4OSrgTpHE++8FlP sLbqg6taQ64TtHMZPTdjIDzRCuLAZnbC3jfhWveMaoQD1r3kPvtYOrRS7XJg3PGvrSVexghCtAKXO U/HqBzlSgYAz68iJFK6bhwPOrd85yzZxGvJxAq/+c5NlE7oLGtqw8yNKS+M4tzox1RZJZsPiarZoa qKVFIlnQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pdC3d-00Fzmq-V3; Fri, 17 Mar 2023 15:31:54 +0000 Date: Fri, 17 Mar 2023 15:31:53 +0000 From: Matthew Wilcox To: Pankaj Raghav Cc: Christoph Hellwig , hubcap@omnibond.com, senozhatsky@chromium.org, martin@omnibond.com, minchan@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org, axboe@kernel.dk, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, mcgrof@kernel.org, devel@lists.orangefs.org Subject: Re: [RFC PATCH 1/3] filemap: convert page_endio to folio_endio Message-ID: References: <20230315123233.121593-1-p.raghav@samsung.com> <20230315123233.121593-2-p.raghav@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: A8B1F10001A X-Stat-Signature: 5ykiuuyfcf4xtmtmz1hoz47shawued6z X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1679067131-719602 X-HE-Meta: U2FsdGVkX19T94hkddGT0np7mgimzHD8moD5b3FV0uElgHmcSQEJfkRcLw7+If1ujoOWxTxXBnhBi7plUsCDyisMhUH9jva6yJsgBPKEN17UiOPfFV+UktcumtLM+wOgf6BGc1nFyD/gBYGaUIORLWj8dfaEk8GjeHW+DSeBZZijZVwS66t3aqIj6dc0OGZbuedKQTV6z7ewP7PyW0kfsGI70bBWWb5gmTbzkAaWZ5MS4BX8xC88IhqVavQbaCTqwe35uGzHeQg134pvr5sPb3mjSOzU67OctXr6JjzAIbRRoNRXPxFNKzV1+xHWsh9kJNho1OfLq5WpRAr7i543xghvay7K0f0OPuZhILuevsLSiEKpOuIrMWN0mN0GraxggAvj1nVBncg36hWMO72r68GZG5GLy6ZAPzCASNqLBnyl6mmBdBsnRec5e0VklyNuFVqVEN+Hiwr6xl4/uPq8+m3f64Q0yiILIvlltq88SiyKeEnBu6S2XAKMcGjki4adTQxDpptrxQhfO1Hm/oGqcOMMPclfGhSbhKHuOLNdFhlrj/8fhFNl6an2FXDZVuo+wO1aCOm6R5+7azG2wrrMtylPszJ21m1u/4ayv5vlRp61OvMvxkV8wRSPgJ/Fm1xopplyFSKGqiAbU/1JhZxSMtNDgG3v5bgiak/miwhTmRG5Vwe+TcPNmIM8kxrLBh4ab0Gev3ptQCoBQriPDdgnJlILTOAG/bsup6WbQ2n8ouCFeAYmNmHQyPmqsbmnZV0trIHgKbLPNOvmDvmLsI6Ypzu9nazmFniPLFKzaGWwYibhj9j7gAHqD1mCZLk8RyfrUYbocha5ETO0Dhr0SQq3ofpA1arNi/4YOJispdR2ZuJXzD8dnZyYcrGImsBm7cD2tCqka7ABrjZcQD4vPQqK4z5YlDTI0+tGiCwKk15CI+H8yf0AOci1Lzyyo86YWd5oBdJ8E2kYdx2ZO2m60AJ Q3KlZtKS tJUBnnJnwb2qu9LByitBYxChUEXVe3F1NA2c29Zrx2k5w1XEe75yry0aijw2bqEvnEOqtJyEA67G/rMAv4Nz96nK+bph8yiYeoROB6JmcnPJkwsfZ2p9rGaziE8WktQW18+Jm3177eZscPL7RqQc6D0lhStBNPTWLU446HmktwMWrqP2SabYQ8NjEMOQQTMK90/q8p331pX3fXM8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 16, 2023 at 11:04:54AM +0100, Pankaj Raghav wrote: > - /* clean up. */ > - while ((page = readahead_page(rac))) { > - page_endio(page, false, ret); > - put_page(page); > + while ((folio = readahead_folio(rac))) { > + folio_clear_uptodate(folio); > + folio_set_error(folio); > + folio_unlock(folio); > + } > + return; > + } > + > + while ((folio = readahead_folio(rac))) { > + folio_mark_uptodate(folio); > + folio_unlock(folio); > } readahead_folio() is a bit too heavy-weight for that, IMO. I'd do this as; while ((folio = readahead_folio(rac))) { if (!ret) folio_mark_uptodate(folio); folio_unlock(folio); } (there's no need to call folio_set_error(), nor folio_clear_uptodate())