From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5077C7618D for ; Mon, 20 Mar 2023 13:15:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69FF26B0074; Mon, 20 Mar 2023 09:15:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 64FBF6B0075; Mon, 20 Mar 2023 09:15:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5176B6B0078; Mon, 20 Mar 2023 09:15:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4353B6B0074 for ; Mon, 20 Mar 2023 09:15:59 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 146FC160BC7 for ; Mon, 20 Mar 2023 13:15:59 +0000 (UTC) X-FDA: 80589324438.22.B5DD5C7 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf25.hostedemail.com (Postfix) with ESMTP id 71B84A0021 for ; Mon, 20 Mar 2023 13:15:57 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="3/Cd7tv5"; spf=none (imf25.hostedemail.com: domain of BATV+c562255d70dcb65b4262+7148+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c562255d70dcb65b4262+7148+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679318157; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F/TTEgg3GkVaespoiM96CPCivVzyP5tcJdUcXD4VzT0=; b=uQ9L+x6bPE4bvrMG4kXCGbWNUNstE7zRq0nkcaAl21z0N8dazb+LW1D7vryoAKP0gq0Q0G j75zcJ3cG5eKT55lSh4bcwpT9VktnOfvshmuehyYZdIs03VzcLQlTlmOe0vRTCSY/I7hvs fLZMbWekx42WtG543LyTqEqxqrscJGE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="3/Cd7tv5"; spf=none (imf25.hostedemail.com: domain of BATV+c562255d70dcb65b4262+7148+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c562255d70dcb65b4262+7148+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679318157; a=rsa-sha256; cv=none; b=5veJB4cGe4V/IE8AuUqdnYckWDfCW2bVIQPqzM7QmtcdpicvJDv8hYmuPFTEMV1i68i4Hg 55LMizvRMhaD510jRQIAjYSCvie1vztcKRb/DTFx1Q1+tL1hnWH7L4/zBJtZtrhlRIxBv2 BmhQHDuvwDWPx9CQAR/n8S8vf6a6yw0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=F/TTEgg3GkVaespoiM96CPCivVzyP5tcJdUcXD4VzT0=; b=3/Cd7tv53ft6K6Oi2VGC0tA4ZH N9wtxKXTWwSHxzaeKJpyR22dqA47ZwuJnm8qJpAtsrEmGFJ5bavj4FWjeEHY0CxnbzG4bx9tphrp5 nMXjtD6TXEKUbmWXRcji0xJWOoyajfvJthZVbJqlfA5bVKa+JH/lBwO+tKGtY+TztO05bxrmZcOnp H+vaivPOgMOterR7KN2+u08zI9cM25jqH7DYDgUVhGm+040sK1NvCCPnTiFccqbU7e5NYAzwr9L/F 08BYBkN9e+AaeLBvFQ+0mxERAxd0XDt9sqQdSUNRqntJJ3UOT9Mu9TggWP/9lNTJz9wjD4x9KHPPt Dh/bjcVg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1peFMg-0094nn-0e; Mon, 20 Mar 2023 13:15:54 +0000 Date: Mon, 20 Mar 2023 06:15:54 -0700 From: Christoph Hellwig To: "Ritesh Harjani (IBM)" Cc: Jan Kara , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, lsf-pc@lists.linux-foundation.org Subject: Re: [RFCv1][WIP] ext2: Move direct-io to use iomap Message-ID: References: <87ttz889ns.fsf@doe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 935x3cz734a661cjdx3frbqkhcfw5n69 X-Rspamd-Queue-Id: 71B84A0021 X-HE-Tag: 1679318157-626508 X-HE-Meta: U2FsdGVkX1/pw1VkHRJ6HuOHeueAKB/MHV2XqBlh/RcNOJD9+w/CEpF2ACJRCbvn6EvKRgSvRhQb+qbBt1URh9mpixtwLSjumsmaD30SMwZWe/TmZmugspgCT7T0h8Z6HH1gxhm1zwrPQOyOuTh26XDEJl+oQJp9RD3DISIIt8YNr2Zrgwgw9S1AkLpHzHeci9z28OJSUeplSERfLbovTYFQI5EDAUIfM5gvBtd+IDrkp/0d4iTOX0ivZKX0iaLJLxNPywycoK2V5i68IyEpdUfXiMumWcSJwLPFQpVr5u+k0OVLKY0lZ10Fxa8LEK9A+ubAyNfuUgHF6ldYEUsuYklq66LjyS0z5GrQJHcHudlrO4gOhBf5j34lGe8c7lvtzX7wlvh18MhQkbGffTfCCOZ18YzDKnybL6LXUajlE3z2q/W+i1YGGDWnHqPhl5J62Zijrvjh7g9DyfNGBxzU6jZ5+FC0kH45RMM5jOe5Kan9IMt/FfvpyvGQfH7xQz/RQiJQRzX2jhtdPBUQfCZlcJY+JCQzFXCFHqE4oXEyNeENU1bObCqVIzWpwa0Yg5H79iNNse9pWYPXWtN4JUm5RZK4Eh5dEj/CEFXAcZLiM69upK0Z4fa7XMvnaJ+ndT2OCClvkM0//D7is/9OCYgihVpVas4mlHldv94XbCgHHym/9e6DYczhRe47Qd+T21UH4pcXRLqWhAQvx5bdCvopKPv1ttnuY2mnoAqoqVf3F98WO+zLUJM4Lb7mLPGUXDXUPEoSaKlBtjhhQoPqpo8uY23y1DVo3eQhAgD2Gh8YqeUKteq+3VxkSAgX6W2ABlu73pJBayWF+kH9uGffTOMMLfBsHEbPEK0efAz77fJteUb05nPhERa39KIkTsv4YuMSiWsxjKVkFDyW433T/HAxtiqQAkMAXUMry9HLDagx00jIHXGN1oKaBxrJLe+R4TIdTO8lEzpX/pYdBKAGPHr Qopafqpw +qIus+QQPE/fL8shBRVxK0MDj6pU7GvLHclc9/AO4fMV9BkPHxRQ8XszntHXaQYwrU2h2V9JCBkODFdbbQBMX6PDqEADxYxjVNKSKqHjMuoIqfrIBXfhOb9hnLGWcEFJ1ZcZCInAUL/HZ8HZcN4eXs+Q7URdlGTqgH0ujqfdaWNKznz1UdbNwRNIAufywKyc1UlsMSjuZDve4rKV4rEsDOJ+Vs6We86PGm6L2FQjG6iD1LaAxm4iMrL6K9rs4dI3eUZ61ADEx5YNYm3QdOTXfPw9lwSDlMENBHlbCB0pto0MBmdha8PhLgsuocCklNNKWjEP9PIVrCwusKNc6+ZnZETZpQKm2eC1yLRpoIyZtUnEn23fDtu443uDMFLob5tf9f26Ncewyh8fAXDt67whhsU9v2NjC+cNv/Wn4MFRdV5mNPkw4snndTJcyiAZU7hzos11VMbTGrZnWSTjlitqFCniHFac9rDCOovaS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 16, 2023 at 08:10:29PM +0530, Ritesh Harjani (IBM) wrote: > +extern void ext2_write_failed(struct address_space *mapping, loff_t to); Nit: please don't bother with extents for function prototypes. > +static int ext2_dio_write_end_io(struct kiocb *iocb, ssize_t size, > + int error, unsigned int flags) > +{ > + loff_t pos = iocb->ki_pos; > + struct inode *inode = file_inode(iocb->ki_filp); > + > + if (error) > + return error; > + > + pos += size; > + if (pos > i_size_read(inode)) > + i_size_write(inode, pos); Doesn't i_size_write need i_mutex protection? > + /* > + * We pass IOMAP_DIO_NOSYNC because otherwise iomap_dio_rw() > + * calls for generic_write_sync in iomap_dio_complete(). > + * Since ext2_fsync nmust be called w/o inode lock, > + * hence we pass IOMAP_DIO_NOSYNC and handle generic_write_sync() > + * ourselves. > + */ > + flags = IOMAP_DIO_NOSYNC; So we added IOMAP_DIO_NOSYNC for btrfs initially, but even btrfs did not manage to mak it work. I suspect the right thing here as well is to call __iomap_dio_rw and then separately after dropping the lock. Without that you for example can't take i_mutex in the end_io handler, which I think we need to do. We should then remove IOMAP_DIO_NOSYNC again.