From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AD6AC6FD1D for ; Fri, 7 Apr 2023 09:23:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DA36900004; Fri, 7 Apr 2023 05:23:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 38999900002; Fri, 7 Apr 2023 05:23:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2038B900004; Fri, 7 Apr 2023 05:23:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0B4E4900002 for ; Fri, 7 Apr 2023 05:23:33 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D9F701C6890 for ; Fri, 7 Apr 2023 09:23:32 +0000 (UTC) X-FDA: 80654057064.10.21DECAA Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf20.hostedemail.com (Postfix) with ESMTP id A46BF1C0008 for ; Fri, 7 Apr 2023 09:23:30 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=KLyNja2Z; spf=pass (imf20.hostedemail.com: domain of rppt@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=rppt@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680859410; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J0NLgY2eKMMih3APjlZunVE93FXMckGfYTJYgjYSqqo=; b=o6yQbNud7pa79ffI0V+2ujc/iahkePwdr47mS36Dyrj83okNyeWbFJ9YQfSPt3T61eQOuo W5rhaZD+D9H14Pxptq80GRmBsvpVtRac/1eaA5H3/FNGpPj+NtgYDgLtskoSj33K9OyHbR 31UOWbNziw6wSk/KHGjBiEKkvnM692Y= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=KLyNja2Z; spf=pass (imf20.hostedemail.com: domain of rppt@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=rppt@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680859410; a=rsa-sha256; cv=none; b=a8Wag6oGRaJT0lsOtxo6OmkM5i1T0JSUscQgH/uFW+nz1I3vIzeZ9zDrMY5V+YsgEEtO/Z a/6L0hIHtSd4IDgjw/zfqhmzDyqEEjYiQLde9x1tvIa+b5hb21L+lsGnxLBlU1r+xUVTn8 KRX5hZ8kfOPpdm757hBczrxIebeL+Rc= Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3378EYLJ032187; Fri, 7 Apr 2023 09:23:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=J0NLgY2eKMMih3APjlZunVE93FXMckGfYTJYgjYSqqo=; b=KLyNja2ZlPUVljxHJYZyXdPAGPiUf2bmEzqcinI2aRH823qIzki9BoeXXxXYkyTaCowU y55+FjjxRp4xNOrMQKQxcC0hrIiiTSzaGLnQBCRSsV2ekGCSnUK9RAjEmi15GvdC/63n DsJb7DVu5o411Hgf4OtGEbAv4bUEdC7KHKiCvu7ts82Pj3CSS9adxbPO9pyuZRk9+X+w nyS6S9Ow9xKfCI6tZh++SI+Vc0byq4EQ0DebWzgnk5ElaiHiPNvNJSfrXiw7eR4jckhc zq0FKfZhAuHBsitCfhSe7RQ7Ovfz7N0jPrf0nqywdiz0gVs88lxUYOCqE+xyTgBk0kgl mA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ptc41dhbr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 07 Apr 2023 09:23:29 +0000 Received: from m0098417.ppops.net (m0098417.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3378r2Gl009695; Fri, 7 Apr 2023 09:23:28 GMT Received: from ppma06fra.de.ibm.com (48.49.7a9f.ip4.static.sl-reverse.com [159.122.73.72]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ptc41dhb8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 07 Apr 2023 09:23:28 +0000 Received: from pps.filterd (ppma06fra.de.ibm.com [127.0.0.1]) by ppma06fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 336MP18a000624; Fri, 7 Apr 2023 09:23:26 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma06fra.de.ibm.com (PPS) with ESMTPS id 3ppbvfup74-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 07 Apr 2023 09:23:26 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3379NNWe19989206 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 7 Apr 2023 09:23:24 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DEA0D20049; Fri, 7 Apr 2023 09:23:23 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A5CBE20043; Fri, 7 Apr 2023 09:23:22 +0000 (GMT) Received: from linux.ibm.com (unknown [9.171.71.120]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTPS; Fri, 7 Apr 2023 09:23:22 +0000 (GMT) Date: Fri, 7 Apr 2023 12:23:20 +0300 From: Mike Rapoport To: Peter Xu Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand , Andrew Morton , Andrea Arcangeli , Axel Rasmussen , Mike Kravetz , Leonardo Bras Soares Passos , Mike Rapoport , Nadav Amit Subject: Re: [PATCH 06/29] selftests/mm: Link vm_util.c always Message-ID: References: <20230330155707.3106228-1-peterx@redhat.com> <20230330160700.3106955-1-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230330160700.3106955-1-peterx@redhat.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: DDXyBlwNKZQlGv4wcbp0HrRO1mv885VO X-Proofpoint-GUID: MguoooGxFqttbPmVH5r-cmW29DXPbeFD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-07_05,2023-04-06_03,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=635 impostorscore=0 bulkscore=0 phishscore=0 priorityscore=1501 clxscore=1015 adultscore=0 lowpriorityscore=0 mlxscore=0 malwarescore=0 suspectscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304070084 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A46BF1C0008 X-Rspam-User: X-Stat-Signature: yrkfigu3kzbn8ynx6ffd61ypf75o481f X-HE-Tag: 1680859410-593346 X-HE-Meta: U2FsdGVkX19GXLB4vTtaQqjHOX2UxuTLwJ0UQn00bfnMuvfAovd6tZGmgLKIKSXLonlsvGtqb+LQhA7dWvrP4xkVr3vDeBksKw7cSoPj/7CXGUwJfNwq9FtPbGDxOSUOsfpWwUnfaMRvvHgchqmjrbm8AFP1J+64o1Ih0cudL/4W/wVa7jhFXOEbjgNHEZZkxb2Gi2n5uKz4wO+5PEW4Nuus+2bv8DSdEDG+SwaOCEOPVzL8DarrLF4Px5yvsBkKz+KKV/En0NcTO3g9lVA8iikgWDBDIX1vuwsrrDIPYGa4siOCsGjQ+KiNPYKJdPUP9noRGuf4NM/wtwzHKcJgBVLBmd5/bLte3fqOuw3n15EhmCQco/3eIjobFzfHEc5MnJr+hoBqReErepDc8UzlcwpbWSwnpSJWDTfgOQzoIto8OfAXqyVRmfDoX72ijjyz3gf/Suw9upCiuoyuPJQ0pijlXix5LW2wEgHNYhAFHC5h3qwqAD4tHJ1DSL5SgeFXGZ8iIC8F9dblPsm9qSWQWLkzXhwWn9ZJ0fau1AWPYQdXmPZ+AYE1nLvLdrTIBEWRJME6Sy4td8OquPalyeQ+CGC+FWEWH5hpb4AQlbQ1rMhy2BAJPXJlA7TzeF2WByLfh2qtVXljLOXC6KWVjv9PE97za9WRaj+GNSaiDZkJ/+Y8mZ1Gv089Su8PH5uHdyjzySp7c83lCUZj2fgX7phpE4AqQ+cODpZ/uneKnkENyb75cu7tIg7e/FmWLGfVHS+h4HnMCHxZo7FWxGayuw7uQxiPzFfE4FHZZR3B6n2uD1IXvsDAAcI83qoy3bOfr+06wxsygeMKvBWnPqMjJnyrIQrw4ZAjDrU2fJrLL3kHanewten9ldmEh4EpJDwDWknIB4scKeZdcTg3oNjvZrelKUmDsTKz4ZFlhpn+c4WQZ/93By4HtRBVCnHloMS36WhsjqQ7qg1Wv3p8zgMMiuw 9Zsny3Iq yGOCAyuHbp/0nTnY4QyMHNTAMAHvh49NFmI8qgMe0cXa29/Gri1RjdBZR86FK5ROvxCx5SLrYQdEj8GZsB6RLPYqHafPP7jnveVxPfZtAGJ5ah9tVcJgshovPbyff5CaGT1uTKRu3yVX4DNlD9LxSyhJYyxouQmGbv7aXVKRQTBi4OxHz6DYrpUiVpScnnWlouCfvUp7STNVTz/vZAfkXin8snogBOM88vDY5qLWjg2dKuf2oC2OLnrhfhU/r6RmvUDCTloTpDAFhBwerilIZDBl6b0trIL010dhNWKNbXgc0SBQ9VYuP1fb2qKgtkqH3hZzK+DQpgLVKP1vJhLSjBHGGyKBr2ilYtATG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 30, 2023 at 12:07:00PM -0400, Peter Xu wrote: > We do have plenty of files that want to link against vm_util.c. Just make > it simple by linking it always. > > Signed-off-by: Peter Xu Reviewed-by: Mike Rapoport (IBM) > --- > tools/testing/selftests/mm/Makefile | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile > index 47516a78d447..b35f3eafde3c 100644 > --- a/tools/testing/selftests/mm/Makefile > +++ b/tools/testing/selftests/mm/Makefile > @@ -105,17 +105,7 @@ TEST_FILES += va_128TBswitch.sh > > include ../lib.mk > > -$(OUTPUT)/cow: vm_util.c > -$(OUTPUT)/khugepaged: vm_util.c > -$(OUTPUT)/ksm_functional_tests: vm_util.c > -$(OUTPUT)/madv_populate: vm_util.c > -$(OUTPUT)/soft-dirty: vm_util.c > -$(OUTPUT)/split_huge_page_test: vm_util.c > -$(OUTPUT)/userfaultfd: vm_util.c > -$(OUTPUT)/gup_test: vm_util.c > -$(OUTPUT)/mrelease_test: vm_util.c > -$(OUTPUT)/transhuge-stress: vm_util.c > -$(OUTPUT)/ksm_tests: vm_util.c > +$(TEST_GEN_PROGS): vm_util.c > > ifeq ($(MACHINE),x86_64) > BINARIES_32 := $(patsubst %,$(OUTPUT)/%,$(BINARIES_32)) > -- > 2.39.1 > -- Sincerely yours, Mike.