From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DA41C76196 for ; Tue, 28 Mar 2023 15:21:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44C0B6B0071; Tue, 28 Mar 2023 11:21:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D5FC6B0072; Tue, 28 Mar 2023 11:21:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2767A6B0074; Tue, 28 Mar 2023 11:21:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0F8BF6B0071 for ; Tue, 28 Mar 2023 11:21:39 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A07ED1A0312 for ; Tue, 28 Mar 2023 15:21:38 +0000 (UTC) X-FDA: 80618671476.13.F740348 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id F04D71C0022 for ; Tue, 28 Mar 2023 15:21:36 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=T3UwVlxb; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680016897; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OSlnzCNxt0KdotKHUVgrriB1TzoU+1B8CYF5yyGE4wY=; b=jnibSWzI+6A+DuQHZGdkVq6Lg+UiPYqdmNnCYR4z3vyjrC0aVLFyE/rjVGSMVhUKsib2zi VA4bVbyyq62Zg1bu3ZrhLR8mw9NQW+tLd1a+xdUK7E1Y3ceJ4BRFNW4qLpmI1kIuZG6ST5 4DCf50pp2cbTyPdaS54Rr5k0qv1a3E4= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=T3UwVlxb; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680016897; a=rsa-sha256; cv=none; b=TgA8vAFXvmu1ES9ybRc2lY8RhFfaKgQk5Toa1x7AIUHvv1ujdf8E5cjaTnRsTTwHsU5Yel Cp1oLN6TQ8084DZNy5B4X5Wn8LX6o/nVJHHiRehBQPH1D1lSuJRPH87sDUQkf6b21Kz4mZ Nz3CZCKe07t5zkChWcwr1i8M3z8sikA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OSlnzCNxt0KdotKHUVgrriB1TzoU+1B8CYF5yyGE4wY=; b=T3UwVlxbjnBe0qWhtVGyVsRai+ ftMAaz0Kaey7nxYegHsY3Cb8ufJgIxLbwpIY8HzfdZ8ITqwItXQIo8aUziRO+hNeImCwCNXL9kmG9 FE+JAZd9HPWwfFTcGZ4GAWWxbIi6BOYyQSfFjd2zXnH28i0EDQZibREpMI0RUQtbK30utgObbkDdO FjlNQZFB71JrwQW+b1nbus2B+ubac07Bw71ynwQTiRYW8pD1QkVCqpn52wkEMEk8aLdE0WhyQre1X eXMc+IRdQi8sP5NE6Ms9L9ObTbtNDbv097G4UbO1uiRlQ/J/C+BtNzjY2isjYDiI8gIUSeOJjvt3m zEiq5KZw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1phB8b-008XGU-KA; Tue, 28 Mar 2023 15:21:29 +0000 Date: Tue, 28 Mar 2023 16:21:29 +0100 From: Matthew Wilcox To: Pankaj Raghav Cc: martin@omnibond.com, axboe@kernel.dk, minchan@kernel.org, akpm@linux-foundation.org, hubcap@omnibond.com, viro@zeniv.linux.org.uk, senozhatsky@chromium.org, brauner@kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, mcgrof@kernel.org, linux-block@vger.kernel.org, gost.dev@samsung.com, linux-mm@kvack.org, devel@lists.orangefs.org Subject: Re: [PATCH 2/5] orangefs: use folios in orangefs_readahead Message-ID: References: <20230328112716.50120-1-p.raghav@samsung.com> <20230328112716.50120-3-p.raghav@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230328112716.50120-3-p.raghav@samsung.com> X-Stat-Signature: cycweaj18nduf31kkktnrjy6hd5qethm X-Rspam-User: X-Rspamd-Queue-Id: F04D71C0022 X-Rspamd-Server: rspam06 X-HE-Tag: 1680016896-140608 X-HE-Meta: U2FsdGVkX197WDptFNNnHMn72OKXqAeFYmf3c/UvYuiwWD53IDQigjcSeLssL63uL24gw/x5BQrdXWaQ3YDBz6x9MLL3u46C1JQh6ZSEiTS2QXsaCIzl+VDE9XMdjG1w+qeZMlo10r9OmergLhrlhBy7Gs4bJGd+SFM96tgk1lb/IYEbWDgYs9TYtdRwu5yXV6rfDgAfXSrCtoZ2KZNN51wodwTcjWzfDrQnz/jXFB0cQzV2/dtI4pVngppDtycDn7fnAAwcKkC6te8rxllCNem8MiwmsIRVGslM8/fgeu963fWUOegWd/GVpzxq4Vhl9z1yGDJwaF/YXlhlbnEg3Ozq0/vnugjUjF7f3T0J8JPgDtL60SdU7auXfQdNzC967k8qPfw/I6uvOWLVAG0wtVaNlO0sNyNX1vkLjaaiVPryO5hysdWYksGPDZenqtjM0Vqdh4dJw8L2e+k+rsPxdQEGm7CGZoj5pCKpBy2JSLovKe2PSZzy1AlsSDMSUba3dZxoGVjohEPgkRPvLH8lfFUTSWzZTJxCPHyMFKUmgguo6rP67jxhSfJUFD2rY6gYIjpmKqmfO4ZhuHqW+d1SWMxdRnAjBsRL4t8tQuxgcraVBF39mbuCCQEH3peAEovPwiOWxGvgEJMfrLnoGztIwtkBxpMYmy+6bU6BYnRtFg4sK1UWq6o8FEMHeyY7TqcS+TBnL28aX9E3Y19t7xtAeGm/B4Yuo99t1sXym2Dov/yysZA56pzI9o7vWqCO8ge7NaFyjKaTwOCD07tAw4dRKd88bNLQiVuK7JliLeCb6jwprXgsp9yIK62VjCGFhewgNndVcJglUlxR48NqvjKARcrUF3e3bNK8U8cpNKjqPYk8a6Tjk1pzooV6NsPLQqimE+Rvd9JLhml99okmQR0JbLN8RHjMGPpoarqB1pxFxin61Fn2HEZZh6udMYhg9nEGkllEK/wB5rTsaKU/lbI JZjt7Ftu b4byzZilkUGe02IkbvpdN4gn0VhEVJvptg8eGAOVEo8FTV8W1j3qWSQ5V0A0WQzDZ/zU8y77hTp8pHs/gbF2TNFTD5FMYOzuGEBbVz1wJQ2oOP65pn72x+dTiillf3wnMjWaDlM8eMnszEYQdmcwhAWtGSDXvcxwgHYi/lJFZmgNkjiDk8nD7GNEXFaT3J+Pw1xSmxiMpS/2pkdTtwd8gY7XuQcadf0EwrrO6WR+tyeKNuFmPlyggFcaE8c7VUp4hjvr259DvwIjub7SYL0fEQS4a4WCDB8yahb+P X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 28, 2023 at 01:27:13PM +0200, Pankaj Raghav wrote: > Convert orangefs_readahead() from using struct page to struct folio. > This conversion removes the call to page_endio() which is soon to be > removed, and simplifies the final page handling. > > The page error flags is not required to be set in the error case as > orangefs doesn't depend on them. > > Signed-off-by: Pankaj Raghav Reviewed-by: Matthew Wilcox (Oracle) Shouldn't Mike's tested-by be in here?