From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42D10C77B73 for ; Wed, 19 Apr 2023 08:56:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B5BC48E0002; Wed, 19 Apr 2023 04:56:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B0A668E0001; Wed, 19 Apr 2023 04:56:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9ABA28E0002; Wed, 19 Apr 2023 04:56:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 83E648E0001 for ; Wed, 19 Apr 2023 04:56:45 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4C174C02C0 for ; Wed, 19 Apr 2023 08:56:45 +0000 (UTC) X-FDA: 80697535170.30.042B943 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id 7D79A1A0004 for ; Wed, 19 Apr 2023 08:56:43 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BR7WTzhV; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681894603; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DSv6BPfXDcfRnbG3/fV5FR8pw3KX1w0J6v4bLhi8s40=; b=guq/xB3kzs0yfjxhdqv+XhUoxV6LtBNeghyKwxWWuVIJl3u3FzUFVo7M42CxsplIc046ho Vk4VmKDm9KR7bLHCOy+yqst+hAV70y4G2LnuXpESTOJqpSQUGmLbZhDZuKGwj2iJzJ9D/X 9FpgLKB8wJZLjQo2+5WNbCuzZ8WDL9A= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BR7WTzhV; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681894603; a=rsa-sha256; cv=none; b=Y59W9ZkwisBH5joYsX6mIvqG4nk0SQjXGcdWCOZ6pxT94FouathSIVVPW/NIwNaaY3t9Rv 7qN1Pvj4oF1ADf700s7G3mmHDoK+/9WKBK3X5xkfANrSXSraqDKT74l1Q0jr1+VV7TmHBb bS3u0zwaGEQLZzFcItzTiXsut+U5wQY= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7164860D24; Wed, 19 Apr 2023 08:56:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9CC62C433EF; Wed, 19 Apr 2023 08:56:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681894601; bh=oL3JfeXWUvBPUZYm3G7h4erIKqKht1v9PUQNBf1+rOo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BR7WTzhV+iyHBxQ8Oa1rcV4sSIOUSmp0fX0gCgozNiJSx7eQY1V/PMcvXsLGM4MLi y4DnDqR7GqUjCxVTLISQvLmr2xZLJnC5y9M53YFeOk0EC55PkeSod5brJmGrM0EGhR LG0KfajjZxgU7WsGUQJoVUMk/Ks7yPViz5AWk33QbGZSpDZZ5+Qg4wlnTRsGq7tgaE 1cVsFasQNA+emk3GBpqmUV+J3vB+6qhs/PLg4X0Yjqqz5dz31oXpgtwJPdVN8f05kZ Oj/30StHYGewt51jyd4ViqMaxcXCkBDpbFqe91wYXXx7hb0cja/0MnPVN2RsvZIgYt VRrAqyXH2ZrNQ== Date: Wed, 19 Apr 2023 11:56:22 +0300 From: Mike Rapoport To: Kefeng Wang Cc: Andrew Morton , Arnd Bergmann , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , John Paul Adrian Glaubitz , "Kirill A. Shutemov" , Max Filippov , Michael Ellerman , Rich Felker , Russell King , Will Deacon , Yoshinori Sato , Zi Yan , linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mm@kvack.org, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v3 05/14] ia64: don't allow users to override ARCH_FORCE_MAX_ORDER Message-ID: References: <20230325060828.2662773-1-rppt@kernel.org> <20230325060828.2662773-6-rppt@kernel.org> <02dd2437-32fa-31aa-4ff3-b33a058f2363@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <02dd2437-32fa-31aa-4ff3-b33a058f2363@huawei.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7D79A1A0004 X-Stat-Signature: 681kzm55mshijkw9ufiptaedyoxf4ry9 X-Rspam-User: X-HE-Tag: 1681894603-614223 X-HE-Meta: U2FsdGVkX193T+HhYEbrb8U/uV0nl4AQ+oQfKKGdNpLyTSaSXjIrXuqFpcQ0wGvCvTYypoNRfMiFk1VFPT25VTk9iGVera3fUNVg4X/xB7t6O5HZHPRPdcQWJAZy/7JwA13k5JiMWPdBIfihP2vAQ5rCAF+SHuB7ScgIb8IBKvab43j0dGwrH4IhNmo0RIOHJvxmyaWuiQpHBrpe99pDoo+Y1f5KAHwN3hbDrVpwARlRCLjbWTJp11W63AdjZ+UyzCC3q8SotztCI1dsG/OKNtO72/wVobJsAPiRvk37pShTCgfMx4DZyNEHumDfrQugACz/25YzpDNCo6As7F7pC2ciaTSsl8G9mWdC+apfvq1x6CH0mck5OuXiJPSPLTKPA+Te7XkD/WQ0jr93H6tPxkko308w9hXF0mkrvgaKYbWYeYAiqpvSlfYW/xGlOVADllt36MDLu/z+w8dPQw3jZ9uAzAMpwDn0BrtGrUSdWGcIpxUQqPMPnrBek8y0AA433MWy3YLYdrT3ee+qo2rrmj03m/oUdM0i05/ZI6a3CmsyjjNqoV+R32Tk9smQQNuXW0Z6X46kLkmcTztcAMFrpZ/7ypYLBuvYpnLuVVg4sElFGUVKiA8cBnDDBa8udMOgXbx9yQsvShv9XREABT1QKBEVcGm7PHpcS10GRgXFgbUS4yD7gpKc3MMBvvMjRzYiHfThG6jgleUhxEuwSYBSZg2OTdoeduwD0Q/VNtFvfJUXbX/LsOv9GpNW4Y9Uwgc9i1OnsH1qrb8/AG6yuSw8a14lj6iV/iqjI48hiC+MiVKwr3GeWBYji7SvRM4gmt7QUf/t7+2+zsSBWYLEYbp5H9wXBFPvUdNiBPpEPErt2XnLQR+l0NrkxhUdy4EW430fOVw6CnJOMqnnmCME8hlW512dPQvqQKlXyywYGX1rszLBZJrnaM4GIqKkZ0L216YePfeaW7KcggtdnIWkLGj oqQt3/cn FAkVVIRd5n6HDQRqh5XfA3ljjnOzL78bMSEDf4RQ9s+63ihT/RKH18yoJGWXHaQuFeFwvBattj2YzlMKdRrsxX9Tr7mlQw/kKQnsocbV4EjPbdXPpiE+myKlLD9fsT+EcPHn1mRmPYAm+zY+ssjwMzWYsWJYR3wG/OQXZY1gsD0hnrL/eLDcotU6dI9b1JTmt3n6VyCXvi+mAEpdgZLQqUmV7oRXUxjY2EvhcUvYRqoSiGcEbPWC9chW7x7qk+8jj8WY1LOMEIASaT5EcV7BHH8oL6uhnXiy5jNWlmhoyybt92D+ZKlo0lCp+cq1Me8jTDfsSEgEOg8O2zh2o2E1iTOX0XZzkqgg4bFoNEsFitBcFD6WqFSKY55vFZtntDSv3cc24suVPHj+dHFGYqf9+moYkFVQdQeX/vCNNj6rROJaCb+zHJv5LWS/iQ5N+XMBXb8LK/KCq8Ex4a5DfYunyEAXRHsKsBFWayt1acZdlKFE44pB0CZq5PnMloA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Mar 25, 2023 at 02:38:15PM +0800, Kefeng Wang wrote: > > > On 2023/3/25 14:08, Mike Rapoport wrote: > > From: "Mike Rapoport (IBM)" > > > > It is enough to keep default values for base and huge pages without > > letting users to override ARCH_FORCE_MAX_ORDER. > > > > Drop the prompt to make the option unvisible in *config. > > > > Acked-by: Kirill A. Shutemov > > Reviewed-by: Zi Yan > > Signed-off-by: Mike Rapoport (IBM) > > --- > > arch/ia64/Kconfig | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig > > index 0d2f41fa56ee..b61437cae162 100644 > > --- a/arch/ia64/Kconfig > > +++ b/arch/ia64/Kconfig > > @@ -202,8 +202,7 @@ config IA64_CYCLONE > > If you're unsure, answer N. > > config ARCH_FORCE_MAX_ORDER > > - int "MAX_ORDER (10 - 16)" if !HUGETLB_PAGE > > - range 10 16 if !HUGETLB_PAGE > > + int > > default "16" if HUGETLB_PAGE > > default "10" > > It seems that we could drop the following part? ia64 can have 64k pages, so with MAX_ORDER==16 we'd need at least 32 bits for section size > diff --git a/arch/ia64/include/asm/sparsemem.h > b/arch/ia64/include/asm/sparsemem.h > index a58f8b466d96..18187551b183 100644 > --- a/arch/ia64/include/asm/sparsemem.h > +++ b/arch/ia64/include/asm/sparsemem.h > @@ -11,11 +11,6 @@ > > #define SECTION_SIZE_BITS (30) > #define MAX_PHYSMEM_BITS (50) > -#ifdef CONFIG_ARCH_FORCE_MAX_ORDER > -#if (CONFIG_ARCH_FORCE_MAX_ORDER + PAGE_SHIFT > SECTION_SIZE_BITS) > -#undef SECTION_SIZE_BITS > -#define SECTION_SIZE_BITS (CONFIG_ARCH_FORCE_MAX_ORDER + PAGE_SHIFT) > -#endif > #endif > -- Sincerely yours, Mike.