From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16E93C7619A for ; Tue, 11 Apr 2023 19:13:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88FDA900003; Tue, 11 Apr 2023 15:13:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 84B3D6B0078; Tue, 11 Apr 2023 15:13:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7079E900003; Tue, 11 Apr 2023 15:13:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5CCDB6B0074 for ; Tue, 11 Apr 2023 15:13:25 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 253B2A0CD2 for ; Tue, 11 Apr 2023 19:13:25 +0000 (UTC) X-FDA: 80670058770.01.6AB2EE4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 13E632002B for ; Tue, 11 Apr 2023 19:13:22 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EA8xy2pW; spf=pass (imf03.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681240403; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z6FiPt73jUvE9HN/xxHQnIU3dr3lCFLdEnuNJPVYshY=; b=5D+T7xFB7S9Os4qr9JJAX6grT/83xY3peWHiZ/toURblR46AnkS91nfYpK8WSCFTi1tGka 8+tSDOlqCspG6puX8tVKVi7OlMtoOR95SbCmNQMjMmilixyvTWfiSPeQMu63xOQi2Ymu57 xI2CqKrVSzhaZ8Uj3tdUy296U5Kplb4= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EA8xy2pW; spf=pass (imf03.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681240403; a=rsa-sha256; cv=none; b=W4Qy9l2eMZx2Jc8SLnFs8XASfX3icRJpM1ylnOG8IIMdHT2Sx7kqaAWW4IcVPLlyCnpe5p eokThlH+iS++2+pzEDo9RIZJDs98iG3Me1JwX9gL3BoW8mnkTL3ICZ754ARe8rlTh9ubx7 ZOInuM+Jv8v6M0JX8vAhL+Dk1dT2gdU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681240402; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z6FiPt73jUvE9HN/xxHQnIU3dr3lCFLdEnuNJPVYshY=; b=EA8xy2pW/K9mN53j+z9HIbRltkmwUOs1JUGPM2v5n6cdOcAbV03oA4pZdMdtyTYnS2+ba0 h7DS23aaSTyPJCkxMhy3VmFnCS7QACJ+gxBctu+Iw1Y3A3i820HMCfKrGCplpjU3kl0mot 3OBJgY2bDKZiY7JoVYEuLV0bYfcelIo= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-453-4zgSXqp1PvmSZ7_YkTMJbg-1; Tue, 11 Apr 2023 15:13:21 -0400 X-MC-Unique: 4zgSXqp1PvmSZ7_YkTMJbg-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-5e9b05246edso2113016d6.1 for ; Tue, 11 Apr 2023 12:13:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681240400; x=1683832400; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Z6FiPt73jUvE9HN/xxHQnIU3dr3lCFLdEnuNJPVYshY=; b=WSlGwwbEIkE2e19/EdSVWUsU5WqjQhGJjzQHMh+vCxBPDcDy9287QUuxsqZuOXXOVK H04EnlFMvk2h1KGG/NGinJFgrNuotXE/+a8VIKARQJ90cLNAzNFIzllMbUfqLDuSGf+R SitBcvRRKZWOCigIsKy9TvvJf+Vy6qBNuZGU7pSh9uxkVyixKKNwZALSruiqwD1ZZGq1 lKv4gkuvsxr48+MYIguCyGCkGguFTtBmhW2SwIkGhAqqR3Lb5Eojr6RBG4o6J4Ls2Tct U3bEUSvaecAK5HVchGcWDYv7hK6Dcq5b2rHTI+T3UL7sIfnbe3gmBFDf96STKNr5CV+4 +qVQ== X-Gm-Message-State: AAQBX9eINXufIeWXSdB+PB4AWmXsioVw2G6Ed3pgDA7Vpde24x38kOJ7 HfZnMoNngajaS4Raec/j/DE5ilD4jIYDu9qfqYuC+8lFqF/Rz293uJoHZD0C5Zwt23wgzJ7+Y0g t3xCu2TQrL6k= X-Received: by 2002:a05:6214:401a:b0:5aa:14b8:e935 with SMTP id kd26-20020a056214401a00b005aa14b8e935mr432361qvb.2.1681240400430; Tue, 11 Apr 2023 12:13:20 -0700 (PDT) X-Google-Smtp-Source: AKy350Yz/PVf5BMXpbem+zIl11PzhPIN0ay8hXNJgJqOaO3WtVPZPih40W1kkIj33fXsyBeTAw9RWA== X-Received: by 2002:a05:6214:401a:b0:5aa:14b8:e935 with SMTP id kd26-20020a056214401a00b005aa14b8e935mr432338qvb.2.1681240400187; Tue, 11 Apr 2023 12:13:20 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-40-70-52-229-124.dsl.bell.ca. [70.52.229.124]) by smtp.gmail.com with ESMTPSA id f9-20020ad442c9000000b005e26dcaa159sm4320158qvr.25.2023.04.11.12.13.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Apr 2023 12:13:19 -0700 (PDT) Date: Tue, 11 Apr 2023 15:13:18 -0400 From: Peter Xu To: Mike Rapoport Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrea Arcangeli , David Hildenbrand , Andrew Morton , Nadav Amit , Mike Kravetz , Axel Rasmussen , Leonardo Bras Soares Passos , Mike Rapoport Subject: Re: [PATCH 14/29] selftests/mm: uffd_[un]register() Message-ID: References: <20230330155707.3106228-1-peterx@redhat.com> <20230330160747.3107258-1-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: r8cwtt15dc5yc3ubbu9pwxdtq8ppazx4 X-Rspam-User: X-Rspamd-Queue-Id: 13E632002B X-Rspamd-Server: rspam06 X-HE-Tag: 1681240402-971606 X-HE-Meta: U2FsdGVkX1/MuA+7m2wsGWRzEI363ZGeec0Mt0W5Ov+46VCnbqORRsuZvbtjgvPqiSSwUuXthuGJDp6k69o4Erp9oCR9Uox+TN0dZ1Dwpyn3FDjnkTsb3jr7xoJD3gCqWUEp/Jg2SOrgc16Dx1vLo4t4d+HY4zSOuHduMWm1rJGNDEoykmcRObUzEW83rdJehSGIISX8rHxxIju5/PeIpY008EqpgYycSX+2CBJ+yVPLq9YeVmi5E1xtIE0G1m8Tb83imjW1gvV1X1DGiaqBu1NeOaTlkGRN91vG1rBsbZ8ozsFQHNG8wfl3aKGl+cVW3/RUiw0dSPIOM1/1cGBc3W6QioidBAfdFLW6yKSuwmVPqqEpyumNmN1w21yBBBE7/rjGeiJA7i0h9LqqqBFjpKtSp6WL1YC70zJpmXV3Q1dkyU4ZGopE43CIwNkkTJuRPX/EnmMM7oTouSl+ADhwi9iJ6a2DbY613VY4b3tJEPeASsow2jmCJCGNNxA3T9/Zsz2xBSUF1vm7vaBddxU/EQOO98XcV6pwKkCoJy9Hjzb3pK71p0Im8yKKGgvpNiz/YpC1CBfNOeUz4n40LmCjWDZ1MsFl7KUHxXaGnETF4l5Hf17QGdcsDQB4zgpyh+lfDmP0eehLLr+7MMbyFYE/V9s0Ych0a7fb7AVtmmIBTeizyMvWTlflhRmyNxTW1pC0AnvVt2F6lm3Wo/tuTy018tBZhzWK0FTUETQm43ZghSQ6Kw7Kb3htOZLmsD1xT+M6CE2ncOpwOmG/fW0wZNva3LWC6vxY4g3tTP5YrL63oanBJTNUDERPUXB4QrtX+97017Gc2xGObNpywal3BmYxIkzYvH8htz2xD5jDU6NIot1TPEiwsgJVELmkYio4h2WKCeFxDfEXmkjcz+MMcNXroUVAKZtJXTAXvD3G5kX5jbs97P538jEisEhlZre99OrnxO09TXP6hRMUato7ADV yh8G4yvg c+fXpAJqkL6As5qvFfJHXiK0yvdk3GMNiSyuKglcCwNa59W0SxrC536EyOcP2GcBPgNSDEVW5IpMKd9/epxbjrr4BqU+bcRO+nziPK0SwTskS8d/X/Ohy9Gq4g4vte0nui1e+GiYBqgcZK0e4gBPTY5MMpfUlWKee2RPc4uSSAqrDk2wRF8VWFUtMZ2u0m1rcs/7Spulj6scxKHkNiXteuvZN1LCqzNVzrp6OMIsGX6C3qQ/OrulH2VyonzhLiutew8WKHA0SDOaiVk7S0ddOLavQ49nn+Hp7roZU8WSEH6FFBeJbb7+Q1f9sNR/g+WJs4crz2rW/fPlnEh3O9LGY7ttvPV6v69McRv7XhqSo4hsJ+FMJ+rJIUhaogbyVP9pfBdwbA/aQRTBjlcZnzfvLErj5Xo4Q8GTbTHR26xStbB36OdBBcIwZE7bzyQJ60fwy4B6N2/S31Sl6j0kQDPHjYhE9j3k3JX2OIgJGo796wTVvS9OBflSpZcbidw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 07, 2023 at 02:08:54PM +0300, Mike Rapoport wrote: > > @@ -96,11 +95,7 @@ static void register_region_with_uffd(char *addr, size_t len) > > * handling by the userfaultfd object. In mode, we request to track > > * missing pages (i.e., pages that have not yet been faulted in). > > */ > > - > > - uffdio_register.range.start = (unsigned long)addr; > > - uffdio_register.range.len = len; > > - uffdio_register.mode = UFFDIO_REGISTER_MODE_MISSING; > > - if (ioctl(uffd, UFFDIO_REGISTER, &uffdio_register) == -1) { > > + if (uffd_register(uffd, addr, len, true, false, false)) { > > I'd replace booleans with a bit flags as it easier to read. > Other than that LGTM. It was mostly for no need to remember the long names of macros, and easier when conditionally set with some modes. E.g., we have 5 callers have things like: uffd_register(..., test_uffdio_wp ? UFFDIO_REGISTER_MODE_WP : 0); The bools simplifes it to: uffd_register(..., test_uffdio_wp, ...); But let me know if you still think that's better - I can switch here. Thanks, -- Peter Xu