From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49DD8C6FD18 for ; Wed, 19 Apr 2023 16:06:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BCA6D900002; Wed, 19 Apr 2023 12:06:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B7A806B0072; Wed, 19 Apr 2023 12:06:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A43B0900002; Wed, 19 Apr 2023 12:06:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 922F86B0071 for ; Wed, 19 Apr 2023 12:06:15 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 415FA1A0340 for ; Wed, 19 Apr 2023 16:06:15 +0000 (UTC) X-FDA: 80698617510.10.AE1999B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id 582E110001D for ; Wed, 19 Apr 2023 16:06:13 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf14.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681920373; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mOSXsVr7vCkNXz9hQ1SZrkiRb7xvGNAzd6R4dUqVPHQ=; b=gL3XHeQVoXe8+MDmwAAsmVryFNf8ANqqrgDs5vBXwrJxvh+EY30w2QI5LpBmrMAOt2q7IF oc8XIV7LlkhLpqLwIw/2/Ai1+ztBj2BnChTriUwVxaNiyuasBMoPZGewg3WhlDNMy+8dLC C4B3xr9XVeYjYdLyX28KXYPv1xW7dgU= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf14.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681920373; a=rsa-sha256; cv=none; b=8Ff4++ZVdw28XQFBggbaJiydKLoo5DKi7I2NdkSUNjVEeJv6+xg2G/2FTBZv85aA693SEj t/nA+vqW3lNP4yVMSafP+ZiVVb59ZnCejZSC7EDwS+bbb8T3jLArH9zEFjL4HX4nWniYb3 r7LoJXdfVu6RUHntNqS5m82rpqxcyZQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 326DA640B6; Wed, 19 Apr 2023 16:06:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46F4AC4339B; Wed, 19 Apr 2023 16:06:07 +0000 (UTC) Date: Wed, 19 Apr 2023 17:06:04 +0100 From: Catalin Marinas To: Isaac Manjarres Cc: Linus Torvalds , Arnd Bergmann , Christoph Hellwig , Greg Kroah-Hartman , Will Deacon , Marc Zyngier , Andrew Morton , Herbert Xu , Ard Biesheuvel , Saravana Kannan , Alasdair Kergon , Daniel Vetter , Joerg Roedel , Mark Brown , Mike Snitzer , "Rafael J. Wysocki" , Robin Murphy , linux-mm@kvack.org, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Petr Tesarik Subject: Re: [PATCH v3 00/13] mm, dma, arm64: Reduce ARCH_KMALLOC_MINALIGN to 8 Message-ID: References: <20221106220143.2129263-1-catalin.marinas@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 582E110001D X-Stat-Signature: pjc4a5kbzn3ugdiy4taa9rzpdnpcff7x X-HE-Tag: 1681920373-836168 X-HE-Meta: U2FsdGVkX1/7dG/yXXh5n7JC/gQ6a/rrev4YZGtwke/1LWPOr91XZihx4VikrxlExSZGS6asOqs0i7CSiZqm7R9rYdv+wME55QWPfjSKYvKmW8lWrawxYCNT7S1z/ANILC9CRU/k0uJ2JcZNOSVGJiJk1pazwDnGFZv62zbGAvXDgx0pxhrDVxzGGLt61kkM/c4XL40NxPEzyAPqYxwWIOpXBZohp6SzwjYnXmMJjvyxNhVea+5U9hmFGSLqlrg/oNXmGe+4pEfn12WO6JqnnBBazHaII948U3I7HiGhWIg0sP/PaE488BjfzJz5mvfT/gICF368EKQ5CK8VQysr/Nxw7YfU+EJe0JCHIO0WL0O0Pkm9EgTV+WfWHra3h7tIE8QR3DvsFCtBRbAq+hCrhEGv8rS0oqz39XaH4QBOpy0BykZfoBXuFVRYQJuFRxPboP8d7BwqG9Wpp/AczND7yDVFdDtSKUOtwnj56GnvgF0J+OIXLZh3NlEHfVDRf9zkpvxzAu5BUePorsEASJ2JKsipirywSe0pRWxUrkP/PF686KrzaEEQNr8seGzFqk+kc3xTUjlQyITWdRRztQk9vXiZJ/eAOE7paK29POyS8WKa9NQ6NCqmShdmeAQe6v+/ZM8Fj2/s/9xDZODuK60EVnop/edNDvOG9glpL0dXb5QaBRRsAbRFSCD0Eyv/cZ9cKhL/vWun9LIpE/NTv3kkEB0DTqVIGNZPNbk5UjdF8TY/y3E2YIgATuvYKsG0pqN3BfDO/QHwUyzqvL+HnxH++ohaAuMpNogFDRCIzNF0EmGhQQIeJhW/fm3XR7jaCw6NdpovjQTI4HsIUTcqx8klKT4Ce0+tV5QkewwO/Okdw2Jlx+bFZ5E1bRnDaNzL4pwFyKb0wr1VAEsEIDqAQej5qbCaH2Pftm96/pSnQqvky0Vnnn59pNVXgjaqnHG7b8a6rt/WxyLfEJIcewlbqf3 /Pfs9TLv b0YG3vwJ2TOQPhz3oZw60DP3E/njvxoWskbtKxkEglwz+hQouAJ3jRXFd8Vzf9xlAg6GaA8m1gORf8+uhCfHPjRxtupYJ8db6bwySevrML/okgli3wL4v3/715+V2Ql75gQsAjV8pNEs8Hz5p1WMrxC0XMxAOWRypiZpgTSBIUT0tnbqeFwW3yZXe866CM/3WCQCtI1LOGerH4EmOdMF4pEXbX0+qI+28ewNE3oglS7CC/zhl2Wjt3NKWwtGgA8zTQEGzDzArx7oxRKAHlmoWqUIbPba0keSYRZ5gJ4je9hc/S7eRDrSJLQgDXX2TaBNyLOfsj6L6DQgsoI6o42P2mTl1yn2ndHtjkN0H3mjH6mD11runcVKlgDbbQazOWjSKVuOPeW5j7F2q8RpsJ1lpi26RMPYCjOvzbp0fxq7tWdqk4VV+PskdpqBNBcXtSKUTTZ5kbFxasbyHukFnoTYHzs5z5LUVwXhy0wMLLlqbWnTkY1soLpz0fG5yhO3bD+mW/6EoZ2cgT8m80AIVRDnqXMmLJH0z5kFr8KAC2GI1WleognCQFwpeRE8Ylg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 16, 2023 at 11:38:47AM -0700, Isaac Manjarres wrote: > On Sun, Nov 06, 2022 at 10:01:30PM +0000, Catalin Marinas wrote: > > Patches 7-12 change some ARCH_KMALLOC_MINALIGN uses to > > ARCH_DMA_MINALIGN. The crypto changes have been rejected by Herbert > > previously but I still included them here until the crypto code is > > refactored. > > Herbert merged the changes to the crypto code that were required to be > able to safely lower the minimum alignment for kmalloc in [1]. Yes, I saw this. > Given this, I don't think there's anything blocking this series from > being merged. The requirement for SWIOTLB to get to the minimum > kmalloc alignment down to 8 bytes shouldn't prevent this series from > being merged, as the amount of memory that is allocated for SWIOTLB > can be configured through the commandline to minimize the impact of > having SWIOTLB memory. Additionally, even if no SWIOTLB is present, > this series still offers memory savings on a lot of ARM64 platforms > by using the cache line size as the minimum alignment for kmalloc. Actually, there's some progress on the swiotlb front to allow dynamic allocation. I haven't reviewed the series yet (I wasn't aware of it until v2) but at a quick look, it limits the dynamic allocation to bouncing buffers of at least a page size. Maybe this can be later improved for buffers below ARCH_DMA_MINALIGN. https://lore.kernel.org/r/cover.1681898595.git.petr.tesarik.ext@huawei.com > Can you please rebase this series so that it can be merged? I rebased it locally but the last stumbling block is sorting out the iommu bouncing. I was hoping Robin Murphy can lend a hand but he's been busy with other bits. I'll repost the series at 6.4-rc1. -- Catalin