From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F22E4C77B7E for ; Fri, 21 Apr 2023 20:14:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6BDF76B0071; Fri, 21 Apr 2023 16:14:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 66D936B0072; Fri, 21 Apr 2023 16:14:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55BD06B0074; Fri, 21 Apr 2023 16:14:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 474506B0071 for ; Fri, 21 Apr 2023 16:14:18 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 14602AC6BF for ; Fri, 21 Apr 2023 20:14:18 +0000 (UTC) X-FDA: 80706500196.26.EFF9073 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id BEFD6180011 for ; Fri, 21 Apr 2023 20:14:15 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=KazI3OCh; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682108056; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A2XozTJws4toh13zEJ4n565nKKguH3N7JeE3lhWnoDE=; b=1q4SjnP405Jn18S6vju5Run6RImoY9/Nmvb2Y1AxbAAWVR4eDbt37/XGOOM7G+TTeIkMJx dDd4d0wDrexcCTDml1C45UVeJ3NlL111iUgFj3bc5K5Cktgs/PSXq5FmlPLNaJYEnGlPPA +bjEGXZekOattTvVONPIfhF+DL3kP5Y= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=KazI3OCh; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682108056; a=rsa-sha256; cv=none; b=hwjKiFAOBA608+76yD3QqqrQcHXH3WB+ww846YEx3MIEvjhZwpc8GqXyAx1Gq4tvvkaJ4l ZZi0gQjFSKCNRmQcXGQMgo/9WXksLsUHkpHZenRVylbQuCVv0cu53Ams/wr3aHKAe5IUxP 16CR62OLmVfesEKvxTNNVhxu/wjb1Jg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=A2XozTJws4toh13zEJ4n565nKKguH3N7JeE3lhWnoDE=; b=KazI3OChQ8xi0cwyBWWi2wSA+d Dv6s5by1QWGWvpAlTZWGesKNdytZlLSAOalemBEZO5rELZUMfVeAY1yZ3qclyF0geINsWblz8o9JL KrCp/O0cKi2DLEYQQN08eZ21fTIZ0L+F8tqLSxzO0hmvR/ttXJr3rOL0pEgRfoaFXGQvs5IVHOHZZ zxTc3G+5goFSv5y1kllt2rSeIkt+cwOtNK+S+HhWtGPacqN3frlkpTebwCYWwbszRhF/mRefjwcIe CuzZGi/qjzq6oLG6SAyyoiOIgXbRDVTOGZtPQOQ5R3M4zoPS5TI38FfuJsg7RWNB05tynED3yvDp7 IUu5SVig==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ppx8q-00FZlw-Dy; Fri, 21 Apr 2023 20:14:00 +0000 Date: Fri, 21 Apr 2023 21:14:00 +0100 From: Matthew Wilcox To: Luis Chamberlain Cc: axboe@kernel.dk, agk@redhat.com, snitzer@kernel.org, philipp.reisner@linbit.com, lars.ellenberg@linbit.com, christoph.boehmwalder@linbit.com, hch@infradead.org, djwong@kernel.org, minchan@kernel.org, senozhatsky@chromium.org, patches@lists.linux.dev, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, hare@suse.de, p.raghav@samsung.com, da.gomez@samsung.com, kbusch@kernel.org Subject: Re: [PATCH 3/5] iomap: simplify iomap_init() with PAGE_SECTORS Message-ID: References: <20230421195807.2804512-1-mcgrof@kernel.org> <20230421195807.2804512-4-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230421195807.2804512-4-mcgrof@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: qgeh66y3z6uqknipnwdey3xkhnk6qm57 X-Rspamd-Queue-Id: BEFD6180011 X-HE-Tag: 1682108055-231735 X-HE-Meta: U2FsdGVkX18z0rfISEMjREkEi8bkIM3K1Zec5siBpiI3C1CK7WHK/bwXYijea4SrdBE5/2D7NMtb9V//7R4DD7+piIKnpkPckZ0t2lwh2QGuLTso4RS8yOepFs16BWrQGLukGYYODViY2x3sbM9nrAhpUlKHTr40tJSVywPlEWMplMuzTSAFwKnOdtxo4W9p0G0iqZcH5y3ChyNsdDqgvDXfdsM4ax1qj5+8CB+fID3BzZXCmj7Rt/iwTxgfFETNh/3ZgW3uF+0o/hEi1PZpP3HcEGbsOrz5mfeQOYGW6+Zsk66BAbswfNcFe5d+lOJ04nCR/BaxR8+2LpMjRritesZvAqBEFVdwbY2DLahcsvO2hzregjYytK8a+VDecZUiLctPSt2wNZ3bOGF/zPkl3XuX0zsGoKrSAMjbQXzKLyfG8ePC+LrFGznP7cpoPxzZhciA1LPDyPqWZvGH0rqITnHxPlKwvOOEkmY5yokspuzZcXVvfOYm0TdGFmUM2Xrui7x8T6P1z2CI+4oPV2vYNA7s6Mo3QeTDRZDmMA4MzQJ/pi++mU/6Zs6FUy+v/iNewVUJsj3v2ee6yVTL60v2rvJk5keLbIW+pccOfAsUh7u6Y2FWp5KrQd8M1hUXAZo3siTTH8TNf6KFDplLdiSiAuOGfn6iYPUGFnWa1Fk7QnSWvLUzwjlzLKZ3k4FiY+RrT4MPPVXYXxmP8xQZHEIGMng1QMcq98I+/UxwmewyRoTQtkLliktmKRJD8uBKZsXNTPfcyqvGqTOOff11GjQ3xQSlBVn3fNKagDHLTSIG20IRMny6toif40Qe41O52XYH5qThMLXCfUwGSE/1J869IK4jIjhtrdEc0+3j5otvXAkBadllDhZ7CeNJHs4YA/A+HCLViLbiRJzQjCXnm1VwFrerbPa8KVcG5rPTabntO2ox8ylTSCRYuLG9gfAcxC+spUCHcr2LiJsllj9VAjW Jm1OiUxN RPuxrFOw3uE6V+OC6qLO8hEr8gGaWRBQX3l/pabh4Q3WbcV2Xv1a6di3P59iH5vBsSD5oVUuvpk7iyKSWKQPPt72QGGhn5Dgx2hzg5hK8iQPP9QAE9qE9zexkCFbOCObj9S+EkT3kkP8r3BmilKzC34AIrtoTWtHFVUrbJCh05I+P/10N1Pe/kx3hyA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 21, 2023 at 12:58:05PM -0700, Luis Chamberlain wrote: > Just use the PAGE_SECTORS generic define. This produces no functional > changes. While at it use left shift to simplify this even further. How is FOO << 2 simpler than FOO * 4? > - return bioset_init(&iomap_ioend_bioset, 4 * (PAGE_SIZE / SECTOR_SIZE), > + return bioset_init(&iomap_ioend_bioset, PAGE_SECTORS << 2,