From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9B60C77B75 for ; Wed, 17 May 2023 08:08:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63DAB900006; Wed, 17 May 2023 04:08:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EC85900003; Wed, 17 May 2023 04:08:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DC43900006; Wed, 17 May 2023 04:08:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3E7AA900003 for ; Wed, 17 May 2023 04:08:51 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0928C1C71FF for ; Wed, 17 May 2023 08:08:51 +0000 (UTC) X-FDA: 80799020862.14.188F36B Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf18.hostedemail.com (Postfix) with ESMTP id 3ECB91C000B for ; Wed, 17 May 2023 08:08:49 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=MiwoWHnu; spf=none (imf18.hostedemail.com: domain of BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684310929; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mctQMwQ1c+oB4gTe4gyG4JXC6wODbSHM0afcemBmK5E=; b=G9hV98WgbLrtblRULEYvKiidGEbQXqevxMyRHU/l0CPKbCtr2gAkSZsaEb2/WRWkkFdZ8F uauMXSU241T6QU0WQmDONElFfmqaovFbUQBc99n5lVGW06XyetZRbqRsz3m1N1WxgUKNpi LQsjMp1fJqbX4mE3jQeWNIW+Qso0AGM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=MiwoWHnu; spf=none (imf18.hostedemail.com: domain of BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+53f544913e229716bd7d+7206+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684310929; a=rsa-sha256; cv=none; b=AGijTDR4m0jZaU5wA7Gcpj2DtKoDg8tnBi5MN4wrmyjGdCmJpJ6Q614iYkkrsZYjWRxX+V rXWlATR3lnG73pV8PZy2khnny6oou1+N13WLe8XKGfWHIqkIXymjGwaZmywZ9Cvtdx89Xw 7yn9+gL5RY0YrY11s9EurEKggyK37Yg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mctQMwQ1c+oB4gTe4gyG4JXC6wODbSHM0afcemBmK5E=; b=MiwoWHnukWLEc8HHBAQxr0V8gf heQzrC+fYM732ZPWIGHsBBhOAVy7EANqo+XUQlqKsLq+8XPSvRXU9rfE4M3eaDKYZeA5FgSYRMwZX lTHufQAa+Vf5hPr8800DznETF9mp/aOnIUHBQ6wn/8/A6iFiqxNst1VUYH1rmWDT2E5SMn4yQba6L txoPhqt9J50W/b/Oc4I4oGKU8wMHw6GyEWssUVDIU5H6buv/1n6SwwxzBUG7YVCr/MpQ4qtcoHkaH m4c2OzhwHT8NgX+yYXN4xnEMWtLz2drxB3cS9TEgqbuaY6FwuvO0YruAYlA3b5xrBJWKfJCsiI3gX EWKCzfJA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pzCDC-008nJF-2n; Wed, 17 May 2023 08:08:42 +0000 Date: Wed, 17 May 2023 01:08:42 -0700 From: Christoph Hellwig To: Sumit Garg Cc: Christoph Hellwig , Xiaoming Ding , Jens Wiklander , Matthias Brugger , AngeloGioacchino Del Regno , op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, fei.xu@mediatek.com, srv_heupstream@mediatek.com, linux-mm@kvack.org Subject: Re: [PATCH] tee: add FOLL_LONGTERM for CMA case when alloc shm Message-ID: References: <20230517031856.19660-1-xiaoming.ding@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 3ECB91C000B X-Stat-Signature: p3x78qftf5at46nh13t76tqnxsex5i9x X-HE-Tag: 1684310929-625096 X-HE-Meta: U2FsdGVkX18hCwpGEbiIt1PZ1ENegk2aUGtqz1ujsKz1RRoSfLf6b2VOGmCuJIhqkqpMdnrH+O0lNlmAx+4LIq65mIGoKndNrnqtpDQd/kIKnSeZNR2mI/MHD5RocekqbXG7h+1DAhoT3YU8QSUxfyD80ti+LSnYYCiv6XlSLODJ+deDacd7l2jkAfQldvh+cvgh612ev4GWTZoqrmkl4Fg9xUPGsYi4hHRxfmMQqyE1en6dtNKIrSRpj4TyIa0WJvqfAXLI9AFBUeOkQeAN3kNKNZ2mIAnvcNUD/gqVUvLBZGBLsTvGLpnur+ZcUkn2kqBT8a8qMdwmJbHLG1q12+EsAjOCErN2ocnS0HwL8sg1pN9dtwfI+R5stTs6c2v6Kc/Mlc5zkrZZluyep7FSLepA6TGNZaXo44v7Ztw2Doc6lt2kGxRR8rXhFJAgcORPdiZoucOqljR7dH5dXydNkipvRLoofz5yIV/0QpaPtRbvY7dd8V8jzuWrGnlaef0OEHtcIEcjuEp97H6aOl+17JM0dBbgb0AzSSx0WjrSBPLM3rIcRTArguMYhWTZqJrDrqrtQFVO3GvaDwK/h8BbaEoeJVJQ8W7G7c38GERxDwHnBmJGz0igwOSae+gthMCjSMbuZ2jt3GxF6xUyYOVpkl7Uos71nwh0Ux6K/EJbaDrpIetyNuyhMHOjd2rnPAuSi4zPhuiaSkPKf0LoG3UM/1iGlb5h86UApW9ShkmbIvVUvIzzCUfdvIoglqgFzJN/HGIyBZITocvz8M71dzqMbMwtzZDLEdB6L2wz112xAg2zkioSeLMN5mvcJF4M4qsVtM3NQqRHSL4mdYA0SP6Jr0O6wm51CwuNi7adHnY2QrpIPLepZh6ygiI/hNmfRw7iEQCJkoenSuzhXYKAuYEu9DjUjKhiY+zSM69VDTQot+sNXnNRUvmToCdSZJ0lVvt//BYXnkxEYopQL3hGxUv WL2iBKPa GHdywONPrdSCb4GcaDt2lgU23DkxQ2kC9APeS6XJGV6ZmjHF7ygPN7VV8BVjfGu9Au75jzwrCsyqSf8CuolLzLcUvjtnKz5kCzsSSAZt/HrCRyBC5tos9IHlSWfIbcH/zAEqfDlkRSTKoZr7GZnWqPNsufFGf0ONjRFmX0zb8Jjsl4DkUMMmOswNpjO6LJwrNI0wh5HZFDfJgznUovIVzCX+KFZFYUd18xTBZR1974wDDL2dS3vNrFslLmzSf3IPGEJDeLra6UyAg0fodH9bwgeWE89PZ2qEj7tfl01YXpuywP9mO2GucLOY4e2xHmScL1CFsa4PFGS4NO6ZKPdET/NyzV87GueL1D+AA3aF1Zg7gBnUwzWoVlA6g1AFmpLXZDlbQAhxU6UM6Eqt0dMXtPJwQwaJo2tUg+IpRxQBcrjEdqV9y5xT1ubBSC+9QVMBfsfhluoNmOZtpLttN+c5iNMbs41HnKOSG1CFj+8r4Qbsb0caNQv9AOzWLeMMoz+lYq8rc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 17, 2023 at 01:22:51PM +0530, Sumit Garg wrote: > > > +#if IS_ENABLED(CONFIG_CMA) > > > + page_flag |= FOLL_LONGTERM; > > > +#endif > > > if (flags & TEE_SHM_USER_MAPPED) > > > > If this mapping is long live it should always use FOLL_LONGTERM. > > It depends on the userspace application needs. However, I think it > should be safe to use FOLL_LONGTERM by default to serve cases like > secure media playback. long term is defined as won't automatically go away during the same syscall.