From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1890CC77B75 for ; Tue, 23 May 2023 14:53:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AFD646B0074; Tue, 23 May 2023 10:53:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AAD826B0075; Tue, 23 May 2023 10:53:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94E926B0078; Tue, 23 May 2023 10:53:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8286A6B0074 for ; Tue, 23 May 2023 10:53:33 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1DD9C8061B for ; Tue, 23 May 2023 14:53:33 +0000 (UTC) X-FDA: 80821813506.09.17F849F Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by imf08.hostedemail.com (Postfix) with ESMTP id B4127160018 for ; Tue, 23 May 2023 14:53:30 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=DdHuAtDL; spf=pass (imf08.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.41 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684853610; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZPDh95iV7ZIM20wN/RJo+ESwo6JWKcZLQ714XdToWTM=; b=pJYlMWaoluZ8NJQgUgf2WrDYoHCAyPzLFjickLNtgOYZZo5vqlS5uxoCWkhR5+ZSPM4vH9 Mxa5G+EUkeagt97ZXZZ8xLfpJRsjZLPRZVGoIudWc7br/NdGOx4MUguUHzFufQ9+6DQab4 S9zNMmaXU5CoOkk3j/haabT9kz+RQrA= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=DdHuAtDL; spf=pass (imf08.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.41 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684853610; a=rsa-sha256; cv=none; b=pq8nepLARjZA5xRHJFQ/pDwQVjvB1wsNZTcv1PHTr741AlcOBsgVTi5Cvb0xV6KSHWwxvZ u+VGgp/rDfmdoE82RqJQpR2gAMz2Yx7Kf1XNoS5k8tu+lus1hLZKldu+4Gdtd86h/1SLRn z1U2U91ipu5F6WCfGD9Fgaug5CbCHHg= Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-4f4bdcde899so979440e87.0 for ; Tue, 23 May 2023 07:53:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684853609; x=1687445609; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=ZPDh95iV7ZIM20wN/RJo+ESwo6JWKcZLQ714XdToWTM=; b=DdHuAtDLZ9Aq51LhMVyMbW66l8PWVwpjFPyAL61hIwDs2FRDPLSzbn5lL5TSEU8FYe A0iVDHBCruSZFsZFzXga9b/u4binsWQaYCtWpm+OQn6yWKklx1PrG34abagolPcGljBH abIcZkGgzvY9CkvZsFzobWfaVkIrhMhwdrbFn8u2SRw3k2/gk1UzBawPNHAPf7lup4Rr Tu6Fj2CXDgLMIYhMA+gw3d6LEcjs82jRu4IFQ/+M1qZMpoRnqsISgOLfQ4T76XJNAnfy qeJSKVqbQbpWAWXoobZMO4l3FeqIpv/OzMjNijaoz6K1x3GrcZUiyypu06cwqSRaFzrs 6u/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684853609; x=1687445609; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZPDh95iV7ZIM20wN/RJo+ESwo6JWKcZLQ714XdToWTM=; b=WcHJJYzY+bnFpYp6eaPtfPkcSImcVPjsX+Kskz/lLBMhn4GbbhZkOMdiLCNmGirdx0 JzZmtXQYHTiejUK6YfrPWVWbEXRslal3YxLSYYRsspeYy2Zm9owSdkZfbZA7xPb2cyEQ eDXH56oJEg6rH2W4o0YCTeEZipKe2UPGcV++jYjJHPMccZs7sG7x/c/AoiD64X7ebCbP JR9ia3H8Vw4ZCIrbhhtwDPwR7ZtI2n0QDkWiGHG/7ND3V1uPH7f+joVsLDTZlHFmMZ0o pth5K1JO/KUrz5zi5HhZjoeeRvblSNDLLSHYP93dc8FEJGSrB623kkkn0+U6Mu+KDCRP w5yw== X-Gm-Message-State: AC+VfDwcvY9RiOQgUsXJxZ4KekLBgYeLUgabRWZXsRB50GmzS1OxGcaC p5TPx6P+M53+SmZLpfgzXXY= X-Google-Smtp-Source: ACHHUZ7xLEhYELzSdWO0jZx+QmWP4agZmxO45Aopzbemh2+A2FF5b+51Q4BYW3u6x1LYMlHl4DuLfA== X-Received: by 2002:ac2:4182:0:b0:4f3:93d6:377b with SMTP id z2-20020ac24182000000b004f393d6377bmr3877478lfh.37.1684853608618; Tue, 23 May 2023 07:53:28 -0700 (PDT) Received: from pc636 (host-90-235-19-70.mobileonline.telia.com. [90.235.19.70]) by smtp.gmail.com with ESMTPSA id x7-20020ac25dc7000000b004eff6c7bc08sm1351889lfq.75.2023.05.23.07.53.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 07:53:28 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 23 May 2023 16:53:25 +0200 To: Christoph Hellwig Cc: "Uladzislau Rezki (Sony)" , linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Lorenzo Stoakes , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko Subject: Re: [PATCH 4/9] mm: vmalloc: Add a per-CPU-zone infrastructure Message-ID: References: <20230522110849.2921-1-urezki@gmail.com> <20230522110849.2921-5-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: B4127160018 X-Rspam-User: X-Stat-Signature: fu3siy4677um1sxt3otf75n3nkk6djki X-Rspamd-Server: rspam01 X-HE-Tag: 1684853610-86060 X-HE-Meta: U2FsdGVkX1+yh/AFRcU8U3T+EBcIxo9aBJL1cl1LvVfMY2W7sR02oHLGKAtCtLf8Jg/jNQvSfmtHdPjF1T65DRFGoSIKrxVPH9ML11zM9hEQd15+V8U4B59zEtEevrFS+aKj0I2SZ+KbLjCmuFZVVrzOlZvl7gSWWO2ZYfyo/xtcCR8bhGCyjBPu+NWzH5EmNOjX9fP2q9Sqon3Z+2+vfiHX1XwFMfnH0/N68tw7BjNb7wJLhS/6dy7FQc06ZXuTUXlDZ62Wb44EHQRUFnaDxnjkXx/egYwm7NKB/m190NwaGAI37tCPP5GtNBuZ+MBsuoRcfCBJoRol368hsaOaIku3BEZX71pcxKezm0PpM1SCJNi5Ru+07C8xqXZ6TvVJ3B2cgY+KI+T1pBPBaHn4cf7X14AxyT9ShRkxibNPxwjqWqgO5pbbQILmU6RHv9j+KMbFWQ1r/FlXA4iVGsZjoLV2jbwhLyaJTr/OxrPOp/PdhKPBg+wrLIhyZG+D9cjPn7NTfHlbpEkhj1oHERVXnfZuU/Py13Kb48FhfZwjctN1KnCTzucT1OUxQmdjGUTZ7TFlK/qcYkANvaosdVuXDUQfDsFjjWmqWm/F2m+5mJ5az5WQhgCCU+OtlJ18dSITaeY68DdA0UMyorMgV8MmkSKICjyYuMDhhqlenjdn9ISJqk2wVwn0x7yo2PkDLJ+bD3GtmoXm54uNv0SkMa5V/A5345f2F8EIHGIzll+/IJM8KCpFQvgSlyMpTDaHvEf98JcnE6hpeFAddxUyXYpyD2LALqImH8PNaHOz5XrP7pRE6xyGKd0gh6zrZONrrH6NiuesEl8Sl20lJGNuAK6XREvnfBH4QqQTvdqxFiVTp3nJNqasH1UVH1Dy0aboW+fbBrzeu/q0onROmmp7XuBj2i/CMhFm1q9ZB9RKV/wdwBg+PAdPLwAE7hqgZHZxPsBS7t+3z3mXqeE8WFI2l1t ZT6cXgD+ CyP4Q0ORaUFoz8JtN8yKrBcb5PvxSTrexDK62NnvFAuI5N72U8e0V0FokZIFwjaPRfulL3GYVmNglTNH2V7bJVCaRX1slsPCiUqiObmHu2A1vwkTJCgxMYiXaiG53Ry3OHwWuUSNCSygV9q7h30gdhcOYuKn3CzDZBSitmr/LmyymyGKKCiPgsQkCVJgTsZbp2boMFoMbDb6r8an0u5KUFiMyoXnByeqOJpfKQuUYFRn15ac20VwlbV4yZXS5lYGr+tHW5vwe/6QSXTVG+FBaCceTf7mcDv4bf/tzb4NES7tu6SlUEU6SRMhoHBzodSEjb5XpeNj/qj+KZ1ZmOCkZpl83jdIgZGBKEEu3bvLIT0iQUvMqHB0UNkdp8uKFbTRg6idgWvbLhCB+i41/u3YApaRGEVvNoVxas90TbntEhApU6YI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 22, 2023 at 11:08:38PM -0700, Christoph Hellwig wrote: > On Mon, May 22, 2023 at 01:08:44PM +0200, Uladzislau Rezki (Sony) wrote: > > +#define fbl(z, i, m) z->fbl[i].m > > +#define fbl_root(z, i) fbl(z, i, root) > > +#define fbl_head(z, i) fbl(z, i, head) > > + > > +#define fbl_lock(z, i) spin_lock(&fbl(z, i, lock)) > > +#define fbl_unlock(z, i) spin_unlock(&fbl(z, i, lock)) > > Even if it is just temporary, I don't think adding these wrappers > make much sense. > If open-coded, it looks like: spin_lock(&z->fbl[BUSY].lock); fbl_lock(z, BUSY); the reason of adding such helpers is to make the name shorter. > > +struct cpu_vmap_zone { > > + /* > > + * FREE, BUSY, LAZY bookkeeping data of this CPU zone. > > + */ > > + struct { > > + struct rb_root root; > > + struct list_head head; > > + spinlock_t lock; > > + } fbl[NFBL]; > > Maybe replace NFBL with something longer and more descriptive? > > But also in general it feels like this should be folded into a patch > doing real work. As-is it doesn't look very useful. > I split it for better understanding for review. But i can fold it. -- Uladzislau Rezki