From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D04ABC7EE2E for ; Fri, 9 Jun 2023 19:37:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4EB548E0003; Fri, 9 Jun 2023 15:37:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 49C828E0002; Fri, 9 Jun 2023 15:37:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38A308E0003; Fri, 9 Jun 2023 15:37:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 28DB28E0002 for ; Fri, 9 Jun 2023 15:37:56 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 018C0402C5 for ; Fri, 9 Jun 2023 19:37:55 +0000 (UTC) X-FDA: 80884219752.29.98DF97A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id 6FF35140004 for ; Fri, 9 Jun 2023 19:37:52 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=CNfhC6+W; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686339473; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lusZ+n63tKGbL0NLAwyLdzJ9q5GPTx8lfmxKN/LB0PY=; b=voxDiduywwMkF8+oK2z+BJ3lc6y0o1BQmKj7KFo8a3uV+KueBcQtyvc8WJi2mvVDa3YiPU sG7UBCWLlgt0UYsDtiUg+RaOjLjHj6JV6DqdrdT9z+5/h9GAy8HgzUeC4uITFmsd6Br8aq 5IJBQK7QcIAOg6QGmd8f9XI/UrsN9oY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686339473; a=rsa-sha256; cv=none; b=5XXBsWjmH89C3B5rY/Kv8rwAKpNVoMgH8TZxPkfaXEisBvxj08+cDp4QXRV3ApEfE2R121 6CTr+7Ifa9onJfj4n1L3U8lb9tPilPPPyBA7Auo21MlQT2E22xiIxKBXNlwCX42GOF5Rvk Wijaf2jsafewQLVw2+0JKz57pw9gykc= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=CNfhC6+W; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=lusZ+n63tKGbL0NLAwyLdzJ9q5GPTx8lfmxKN/LB0PY=; b=CNfhC6+WyPlV8tbFcjbN0TEnbz dLYLnJhghcLMBiB+AgpZ+6tvYAU+jvfv/ohGWsHslgWuDKY0TQHqBY76FBp+4BukmWSGPC3pmxIsG m7XyIZHxWmmF4+rQdH0MclhhopxKtiWggD5WFChzDKTULUh35ze6FQKnWjYPAEeJLNNjXZ8sdErHA 8MIVtuOjD2fnDUYqjiiWnaLLJcpa4G4rgV8ajNQVt/y/JiYjoMrslA4llfYW00daPRVQaU8FMh4zK GD3x+k4C3yQdikVVx2Z0k3ylJa1Eh0PBj+FZTTfqbE/sZoIR/a2XcysQ32fJkX5x2MY9E5+4KehvZ x4pWS85Q==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1q7hun-00GxfZ-V3; Fri, 09 Jun 2023 19:36:53 +0000 Date: Fri, 9 Jun 2023 20:36:53 +0100 From: Matthew Wilcox To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@suse.com, josef@toxicpanda.com, jack@suse.cz, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, michel@lespinasse.org, liam.howlett@oracle.com, jglisse@google.com, vbabka@suse.cz, minchan@google.com, dave@stgolabs.net, punit.agrawal@bytedance.com, lstoakes@gmail.com, hdanton@sina.com, apopple@nvidia.com, peterx@redhat.com, ying.huang@intel.com, david@redhat.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v2 5/6] mm: implement folio wait under VMA lock Message-ID: References: <20230609005158.2421285-1-surenb@google.com> <20230609005158.2421285-6-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 6FF35140004 X-Rspam-User: X-Stat-Signature: uxajcbzsbz11jr6tfkd13oi8d65x549q X-Rspamd-Server: rspam03 X-HE-Tag: 1686339472-400399 X-HE-Meta: U2FsdGVkX1/ypqIxLypdyGKgqG5DYrfqscHSLqUTkeQjWPQtmVAzNtWD0BFS53yXPsoqU4m7ju9hvpBW03tcdDrFSF2b5Kz6U9m/yy65WpMBg+83TwNeqMPSV5DKpfGqfAr5V8UpIH5S207X7EVewZQwfCdg/CuiOSE/on6CrLJz5Oi5G9znhEmCCRR3Sm7JLalF4mPto/05BdR830Jarc+7Pa81fiTHvFc8K5512j4e/B76GqMLB8FEsZCoaSH5D5roJ74nq2CgMp8Crm5MVZgAeBU1mkygguvmi73sF5iQtxQhlLOknAYoBCwcVATGdOfKLxGZfJBxi1LHvW2IxuP0dH0k66Lm5WN4dnxcFZU93Rmj2y+NzG6G+k2gl6G8/Lr0UaCzkLUXcStxBXVOtx7X/S+4w+93dKBSl5eQyDlww0LQZmhzwSHlgCOxXS0rShpYYUIhF+fA++hxTvcq3cP5dnQ1rZHNnSwoL6BJWwpsKXjNftAXmNvqTiwgBmVspVFfHPdHwWWTOsLvv6kYoNbgoykbzTIyqARFo+VAQcvG6EYwKF+x4G93Dhq7QpIJZ3acK1F/2+ux19J2e2FmFIF30Oc4BcU2C8/gT/tiZGs3hFKf1e3wZs3z9iySkA5VA/c4K+1BCVs7SmIdkjHWv9Mj+F2PrvkXu1FEw6ai6xfSME7Y3PwuFNOGD8w81IDmtcjVvMjdAYCBbG1RVTLbSAoBLxUKuGWA4TXGj7fV2oMdFCDq7a3z+MOkwdgMN1tbmO0o5dTjoJztTFk9T0COkyNDtvsFioKGaHK3b47wjpojN9B2cWOfI7K6W4KjZIhggN1Rjn9+7s57WWQLzYLKMcI7GGAPKVhkbEQORGLeWnF7azAD/eojNbm6Nvshkjaw5eI0bZwnl8zjdb5kWmbUp9v4VEgu6lA9Wnjdua/1MZql6uYkPjec/vkgTaaqbCl1Mk5giJGbpBf8dlsFU2m RqWpCYWH yHcb6l92qIgkgFV7fOI9OVGktkq+A4PfLXIPmcGjhvd7zAtBLhCJsrXEDUA/Uytxf6eKm4UH6RAPj2XKurou1ew+A1kDo4ZQSQNK1ZJ5fJCKg4qGWyonQ+nv85HLFqfPKnRpc45wXpGLm+iU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 09, 2023 at 11:55:29AM -0700, Suren Baghdasaryan wrote: > Oh, after rereading I think you are suggesting to replace > folio_lock_or_retry()/__folio_lock_or_retry() with > folio_lock_fault()/__folio_lock_fault(), not to add them. Is that > right? Right. It only has two callers. And I'd do that before adding the FAULT_VMA_LOCK handling to it.