From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19ACDC7EE2E for ; Mon, 12 Jun 2023 18:47:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 983C58E0003; Mon, 12 Jun 2023 14:47:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 933A26B007D; Mon, 12 Jun 2023 14:47:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FB3C8E0003; Mon, 12 Jun 2023 14:47:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 749A16B007B for ; Mon, 12 Jun 2023 14:47:50 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 54CDEC02FD for ; Mon, 12 Jun 2023 18:47:50 +0000 (UTC) X-FDA: 80894979900.25.0E93E3D Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by imf02.hostedemail.com (Postfix) with ESMTP id 0C03E80007 for ; Mon, 12 Jun 2023 18:47:47 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=O81aDnr3; spf=pass (imf02.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.128.175 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686595668; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CxyhqstePeQfYqzLq3Lp9OYUr4bYf695tH9QHUQdHmQ=; b=HCEu9SrVlNLVfdOeyCBmXQIU/oGGnjmUv6wlNQVuPjIK00n/LKkXAhi1RZ32wJSkI+hq3f 24VyRRjWg+VV7wz34msx4G0phjSLYsy/D6ryrt5XK9NbVRazvcEpyjqBV84fLZsh5fjLFf jdHZa/hnQ+KFVRwgLinNYlxXuSPpaDk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686595668; a=rsa-sha256; cv=none; b=kckCEnUuck7DhH1zHk1xVNY7kLaE2rvt16Dlg6iGCKHcD20E/lnTrmU700ENE8WSaydT75 M2vSv3hJd4V1vGUH8XkrqqDrMiBsl3RmrW65lGRDs/Wz0dwuEbpXJnEUEuvtYrN4BzTNJs VA276XpslfBN7cy5z6dK/vYsTa0GrtA= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=O81aDnr3; spf=pass (imf02.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.128.175 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-56d2b950447so14625447b3.2 for ; Mon, 12 Jun 2023 11:47:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20221208.gappssmtp.com; s=20221208; t=1686595667; x=1689187667; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CxyhqstePeQfYqzLq3Lp9OYUr4bYf695tH9QHUQdHmQ=; b=O81aDnr3tRyEiHzVtbMrq8h22172aZZfn4XcltPOoNEqW5pc3TIi4wbi7NlW31vKgb nEA3Tn/ISxYUxKggrFsDhypK1rnJZHSl14Ud6vXxovPQVjAr8XYnMUTEoqmH5cIArNrk FuDMfsI7ZXHUdsRuupWeDR0OwQTV6b3IYlJZ2yTaqQncIQoS0Af7iuzMgrfMoGsBz1Dd kVkiJScel3Hl74T5PT0DGz97UaRpEwtSt64FarcUIsAi9IDHzJhTR3PJNn4pSG0sgVXD xvyAd8j8KwNBKbmaNwkLOfTk43VpNTuEZh57lF9F8Oj1Or22eV61MapXq2pkXl8OEPEh Tlbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686595667; x=1689187667; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CxyhqstePeQfYqzLq3Lp9OYUr4bYf695tH9QHUQdHmQ=; b=L4iOHZb/tQSeqYDl+/UiS20cgfzRltXhike+NIeAwKXhgyQBsNlDCXKcj0Y+Al04/B FAz9r9up4V3UBJQdWtdtUBx1XnqOph2bMF0IlrfLyDS0PXWV1L6BJQAr/DFSW/HaedDp i0GLKcc62vSmf4dn1edZuuhA6maUORpaDn+V3+75SmwNyOoKD3BGl4mNX+ithDTigzgk kDzokyrW4jdVkx5sehv6S4XF45w+hny/N0kI6VXZh3VmgHoviczs6aUh9dDmztW25V95 g7ePSc5vbch3JNZ2zhSNS/Up4HWOVvsZIBMfYurHlM3DLw1N2xyJOIQmdL/T27ronvDO k0gA== X-Gm-Message-State: AC+VfDwL7W7kb9U0F/ajMN1H+hdCrnA1svmF9IxughmyFZOVJnuwgwaF 4QhkSSS0QcYivkr+BPE/hpaK9Q== X-Google-Smtp-Source: ACHHUZ5oxeJJILFEWlLmpgSf5tV7m9tDDXdClQ+/v7tSgiw6o3zbxm8PZJKbaGMnBokIIit4ZQoDcQ== X-Received: by 2002:a81:6ec5:0:b0:55d:a9d7:521e with SMTP id j188-20020a816ec5000000b0055da9d7521emr10386835ywc.18.1686595667030; Mon, 12 Jun 2023 11:47:47 -0700 (PDT) Received: from localhost ([2601:58a:8200:2b0::e699]) by smtp.gmail.com with ESMTPSA id t202-20020a8183d3000000b005619cfb1b88sm2708807ywf.52.2023.06.12.11.47.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 11:47:46 -0700 (PDT) Date: Mon, 12 Jun 2023 14:47:45 -0400 From: Johannes Weiner To: Domenico Cerasuolo Cc: vitaly.wool@konsulko.com, minchan@kernel.org, senozhatsky@chromium.org, yosryahmed@google.com, linux-mm@kvack.org, ddstreet@ieee.org, sjenning@redhat.com, nphamcs@gmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v3 7/7] mm: zswap: remove zswap_header Message-ID: References: <20230612093815.133504-1-cerasuolodomenico@gmail.com> <20230612093815.133504-8-cerasuolodomenico@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612093815.133504-8-cerasuolodomenico@gmail.com> X-Rspamd-Queue-Id: 0C03E80007 X-Rspam-User: X-Stat-Signature: 3fzosux1n1ggqhwfbs5j3s58qx49oeyi X-Rspamd-Server: rspam03 X-HE-Tag: 1686595667-984463 X-HE-Meta: U2FsdGVkX19NgazlfxjgJr8MADW21JABubf7ktExjHsKTp345uOYxQBuMd5NDo4NtPIzkeDCNsHCSzrIwcr2KQT0YHqdzFt122+gFe0ZD7+du2USXpDPF5ysxvgDz8gANOT7cpXJeP1HM2Vpnngi3uLqJsRWrfRv6Rf0Xx4XW6a9wfz/irUoXQ/3bZaGZUEe6sUxoOgKDwXltvlEUFhuqAbSdinWiHOwEzzP9urt3n5Te8eiqI5VOllb6hHiAXnZSckE9YAT/CTAB9GwRWrp1QBil0GDoXGOY3fB1mSwrQjkiPbw2QjJXkrWHD8fLEayYLA5a1WKd+eSNO9mmjGpNxc21qWz4t0uhu1/0S4c2p61GW4MJ3sC0E1vsFBq4romnf423Msc55IscgziIqeXJrxfdJAWc1kTU8uigpcJiMV3IQye24gS/YJ7GLDUsMdytpHUEH6BdKe/IATp9ohyQ78yHpqEueYmKoLTTiBEVNTMQyNjIX1fQWPVAVgFUI5f2Qv/N0cBUqzrJWNsnKFAh40kp2ARNZNpFwknYlNB+F8aCdgiDTUf8mgV579vFLBNhQwmoxUaEC+ICxJ+yczM8YS8hiEr9+41OqVJmvVdcLvLSnxr2kwCsEZDsbfubAUQ6KIQaX+7Mwc30rhNYUswa6tOg9qfNS2xI0yQXceTcueZY1oX+kKNaSw5OanNMnnCGwBarffT51I6mDtEqozlSwOjV2tplImZXFlG/90tOG09AIfNlrLJjTSAYX8y2zSd7dz1IFr8eZ3YUKwouFVYc8DipNv3WrJCBxggdSIKyh9H4KjfdlkVUb7X1fh/kTYMv2IeHptXV6mp95xoskEg7yLGsaR0exUV5SiLDI/hSmEgWrhslJfjZnJrlBL92OurFXoCjAzz/02QJF2pjUOhxPzZzuf9b6NudhRyyxrizidIxWdq07FZD7coO0r/LDQTSS1o7AEJClI/wmoKNHS Id/xd6z9 29ezqebmrkURT+iB28Sxf2Arm3er1czIvVxUfFDy6Kn6SkeB+1LmzJVQshcwxaqxnWl3w0O6SmtrnJXT69ANE/CehO3grNdA+XI3/RX8YY9SuCjA5iSaCYrUpmfiFbcipTWCRp5QnL733bDf/eEsw4hzZXfp9JJDnHFVbzJX/Sk4mXjm6Obc01HtUz1pw+MqGOkEkQh2UNvzkBBs8PzWH1ElNvL17+NPWpIVSrRE9y9VgygH+jjutq8tgPDD/zcsrUtpz7W5qdJaWlOb1v2ooM3PPIrUXNnVH2XAG+pQuE3g7FcO7prYxcCOrieIYKe5WhCGmIyy/Oag5cFYDobDVh71jzXaK2cdhhEjNyRjVQwiVoI0LktJmbBdoZh8XbU5JIDkztXi/YdOTw2wMs8dSSoCyv2+UqHIwoWINCzT/1q8l/Eo0EVXmLCQ4dy7a+5grSMh5r5a7z+Mw75Dw8u+PsdJtCJfa0rE01ZhDL8qnweKEo+LHXxir5or4cQfSGUE4rKn+Otj15D2BZv2ZSeL8btRXKCI6fbt2OS4DZVW1r+ZzHrLFrS3xPC++6BZqbVkURG0c X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 12, 2023 at 11:38:15AM +0200, Domenico Cerasuolo wrote: > Previously, zswap_header served the purpose of storing the swpentry > within zpool pages. This allowed zpool implementations to pass relevant > information to the writeback function. However, with the current > implementation, writeback is directly handled within zswap. > Consequently, there is no longer a necessity for zswap_header, as the > swp_entry_t can be stored directly in zswap_entry. > > Tested-by: Yosry Ahmed > Suggested-by: Yosry Ahmed > Signed-off-by: Domenico Cerasuolo Very cool. Acked-by: Johannes Weiner