From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8E1DEB64D7 for ; Fri, 23 Jun 2023 17:04:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 360E98D0002; Fri, 23 Jun 2023 13:04:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 311488D0001; Fri, 23 Jun 2023 13:04:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B0FD8D0002; Fri, 23 Jun 2023 13:04:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 087D28D0001 for ; Fri, 23 Jun 2023 13:04:01 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C1F041A0C71 for ; Fri, 23 Jun 2023 17:04:00 +0000 (UTC) X-FDA: 80934635040.26.835DF40 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf19.hostedemail.com (Postfix) with ESMTP id 706F41A007A for ; Fri, 23 Jun 2023 17:03:28 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=L8n5f0pJ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf19.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687539808; a=rsa-sha256; cv=none; b=BwbfCPFesiUl4BrwHcV9Bl1+xg222j4KIodANlZf78kYjql2t676h9CG1G+PAHoR/TQktd iuVCcdI53qVI21/j1KHgfJSsVskFc9X+WSWkVDY0A0nZo1uginsb7IiyZkvU65At+vjwLF Q0NxAuLeRcdQhJUH3quFq8N3G55Vleg= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=L8n5f0pJ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf19.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687539808; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YGVbdq0PfdPRT7dxn3Byv/mEeTQHM8LBcocYU/UsfW8=; b=GPpms4Us7/UotQcWRMEeVo2Ucs7Td1ruXXNvd8/jVnmaCE8U7inLp3Hzx5UchGUQRnrepp tLnO5DCyjLUHS4HLCFH/UFneHSJyaBnnLWxqxfUbNsOFFyX4ybxhPX3+wES7v22a6rlB7j CjDRfROhPgb3OR8mUawUmp1Fjjm1TYo= Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-666eb03457cso529821b3a.1 for ; Fri, 23 Jun 2023 10:03:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687539807; x=1690131807; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=YGVbdq0PfdPRT7dxn3Byv/mEeTQHM8LBcocYU/UsfW8=; b=L8n5f0pJhHI9pFcRr/v1kGwoAAQO+wkzpaiveuPI7CIfVCCbHlffN4OnAZrSdqt6Wl O3Tw7TQjUwnqtEtGlu7cUkN3xdp0d9Me00Gl5PityqAPRhUn5dm35/qAS3VNLd0naprA 1RW5V8V4eFjPTV6xFH4H3ZnW6rfAc8vNNg77R2S0oOWM2f+o01QzvC66/YCa5T+ISwoG wuX3RJcFzVm+TnXRebqTbbNx65gD7LcGcfo/aH1RAn7difklmt3yMvlw22iO3qxfSsyU 9I0fF3eUKSVkCdNpS7zuOvUkDh4H3AnsQJAn8VftQnz7GcJAjNbYb/zdx6fEsxTwNhpt cCTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687539807; x=1690131807; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YGVbdq0PfdPRT7dxn3Byv/mEeTQHM8LBcocYU/UsfW8=; b=doxAJE5aTji53eKggSWSqQFBk6doBZtZ4tMjkg3RN1anSfTPcBzrRbRW5kvPZoaKaf xfbzZWuhbr4wUvx0kUO0CxS2Ky1Dx0nyNQS37TmBy82N2EPIu+m1DAfBjGtBYuX74RKd JAj4QchFWcnLB049ebHw5x2QfJOQuKK6i/n20C54WKKvXNZgdeFl4bR9Te7LIzo5c+M2 4HqHPVNpu2zfNtaBGGRNTXo0i8PiJxaMqd7zB/UbXoF6xZWEMd3CTBMr6Kuz+EpkaXmg stLUSF4pOsHvyrpUmPXNKu9X2EBQe74PiKfegNoouYD3MXY1ZB/nB+cXr6Meu4Y1C2sV BS4A== X-Gm-Message-State: AC+VfDynYC9XmIAW2smNYNDvYSzT9EqQEkNB40DkDATud2pzQLFFhGIv cEfDTv/R0O5zb2FK/XWmaoE= X-Google-Smtp-Source: ACHHUZ70raWdrpthTkLoDsElBp9EGBRlvIl2vWaEdMEjbRb/VN5DSrGDKT/T20qeMIO981voBs+F5Q== X-Received: by 2002:a17:903:1210:b0:1ae:305f:e949 with SMTP id l16-20020a170903121000b001ae305fe949mr18403825plh.6.1687539806956; Fri, 23 Jun 2023 10:03:26 -0700 (PDT) Received: from google.com ([2620:15c:211:201:48fe:dc9f:b08a:e219]) by smtp.gmail.com with ESMTPSA id ju18-20020a170903429200b001b045c9ababsm7429654plb.264.2023.06.23.10.03.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jun 2023 10:03:25 -0700 (PDT) Date: Fri, 23 Jun 2023 10:03:23 -0700 From: Minchan Kim To: Sergey Senozhatsky Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] zsmalloc: small compaction improvements Message-ID: References: <20230623044016.366793-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230623044016.366793-1-senozhatsky@chromium.org> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 706F41A007A X-Stat-Signature: 541rc7pde331bwk9989w5utzyrz871do X-HE-Tag: 1687539808-981918 X-HE-Meta: U2FsdGVkX1/m+TNktDi6ovrxFW7D3Ypd01726QDndzlmWZ+GsrJwgRTpiv7IPF7RZHV7geljIX2ff6zCTl/nTHNsuAUa/BIL72CftincfDW+MwXTatbJuwCHXea5DQVm7NI5sZ2wVrOCD5pBD75qyOjruMAsxb89bXHVX5ATzhMv20gBrQ3XPd1M7Ncj3lMcUlmWtFRi6ZT7R1jor8M3VTh4ewRT7nP2soVTyzdDGXxx/3CUS91DZAb0QOZm7Z3hjqgWj15lCv5K2Z8LIIG+7cI+00WMnDNIXwPMa/RcG652H/8HtLiHT2rHTXlErVlpjI0Ys3ooJ03neDKtttC8z4LVAqoQbozup24roFwkSdjAHJjEQhciZUX6vBtHh6vYp9Yxa3VxfLLfoODLGEXkMnbFLkIYyLNYqEUrjG+Jxy3GE4NE9/FXW3odebUx9j3tomtAWBFabr0+0VqTReMDiUTVTuXqtol5KuQGWvYDyLEzDPIxkyf+wQ00g9GRAgkAxlu9cwE9I/K3SkhVaH9ob/nHUd5DZEff8flWxH5k3+AkSvCUYUHhzIxIm9KOdubW4AvPmBEj7MKuaW5qm3t1JjHd5yd007hu3bkFrNsNY2PVzItejDIvU7C2DbE5Bsq6d4FblV8DpWEp1Hp0rejfk1BzYvYBXLhCZakSYmOjX14mnVmXqeUqsqW9vgCM3pG7YOB360kUErVWe5RuBl40yF0XeNKSxd2uyAjt7WCwvGJdvK/n6ELCsnRELb/B2M9sTidLZpQgmDSjxwB9tjgwJiq3B1AEB+1jxphQhsYpgS0AeSXYFmlW3Le8L7OE4kbt09bL2AnyaegyOuq/PhcOKmA5WbbwhnegCZxSncVt6GYKLF0LDm7NIBiBNYN/BhKwwBkkd/vLXBMFCGf2LTex+TJzyQrzMb0JonT40iTubE+z6fAX8vVSO8yoZN7EySF56Xmu/3VwQp6lbs+GMYX +xOT1F1P KE1Kbbs4U0rDdAj++AtB31jtfKrhPqZKqcY3lXgwABvx37tQbL8ZFdKSTNUEJP/pIzUbB7zTUXCYXlV1e0frOXY6zsa4Ri1Kqc7+lDNGjJm+JV7NLxgNaJ6/Z5nd2cV3Of67Ec5RwinbHM3I0IU3VtolRz9QISv8wr/0/0/+Y1GQoADaL/2679oEBbl6aQY+pzvwIGWflumTgS5zOxEz+M8YJCe1p8ag1v0y6RgWmFcdBu5/R49dkSFlHl1q3Vl1k+HMZTzi/Sprvvk0oT5dXErB1LLKTQwTjEjXqkhZPe8zTqcjuvhObKyR6f5go+rXpS0y5ztxIuMIFO1+0sTL9cMqH6tL/0spOg+FEtK+5T3YsJFQnsvr7iiArhGGaXr3bHurce7GRXcY3MauW+1eSxg5ez9kin5TVD/tejGAANpZtJbzITAMqmjAxutoaVRoQvrc6ccACJm8VAWAgpokoMYKm6peDnpVIcG8LnhQiXZU0haIqVeGYyuAUvFI3GndB7UkW2xgsGXGb003L7Oz3Wf9CXtGvuQAB9zYDWKWmsc3zMRztGByIpdeeUtcCfAO6vTy41ZfsGtrCDeIvsXjluqarIkxBkxP3OokVpnhnQOKO8y//verRGSsINQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 23, 2023 at 01:40:00PM +0900, Sergey Senozhatsky wrote: > Hi, > A tiny series that can reduce the number of > find_alloced_obj() invocations (which perform a linear > scan of sub-page) during compaction. Inspired by Alexey > Romanov's findings. > Both patches looks good to me. In this chance, can we have little more cleanup after these two patches? >From 3cfd4bb0bf395e271f270ee16cb08964ff785a3a Mon Sep 17 00:00:00 2001 From: Minchan Kim Date: Fri, 23 Jun 2023 09:45:33 -0700 Subject: [PATCH] zsmalloc: remove zs_compact_control __zs_compact always putback src_zspage into class list after migrate_zspage. Thus, we don't need to keep last position of src_zspage any more. Let's remove it. Signed-off-by: Minchan Kim --- mm/zsmalloc.c | 37 +++++++++---------------------------- 1 file changed, 9 insertions(+), 28 deletions(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 4a84f7877669..84beadc088b8 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -1590,25 +1590,14 @@ static unsigned long find_alloced_obj(struct size_class *class, return find_tagged_obj(class, page, obj_idx, OBJ_ALLOCATED_TAG); } -struct zs_compact_control { - /* Source spage for migration which could be a subpage of zspage */ - struct page *s_page; - /* Destination page for migration which should be a first page - * of zspage. */ - struct page *d_page; - /* Starting object index within @s_page which used for live object - * in the subpage. */ - int obj_idx; -}; - -static void migrate_zspage(struct zs_pool *pool, struct size_class *class, - struct zs_compact_control *cc) +static void migrate_zspage(struct zs_pool *pool, struct zspage *src_zspage, + struct zspage *dst_zspage) { unsigned long used_obj, free_obj; unsigned long handle; - struct page *s_page = cc->s_page; - struct page *d_page = cc->d_page; - int obj_idx = cc->obj_idx; + int obj_idx = 0; + struct page *s_page = get_first_page(src_zspage); + struct size_class *class = pool->size_class[src_zspage->class]; while (1) { handle = find_alloced_obj(class, s_page, &obj_idx); @@ -1621,24 +1610,20 @@ static void migrate_zspage(struct zs_pool *pool, struct size_class *class, } used_obj = handle_to_obj(handle); - free_obj = obj_malloc(pool, get_zspage(d_page), handle); + free_obj = obj_malloc(pool, dst_zspage, handle); zs_object_copy(class, free_obj, used_obj); obj_idx++; record_obj(handle, free_obj); obj_free(class->size, used_obj); /* Stop if there is no more space */ - if (zspage_full(class, get_zspage(d_page))) + if (zspage_full(class, dst_zspage)) break; /* Stop if there are no more objects to migrate */ - if (zspage_empty(get_zspage(s_page))) + if (zspage_empty(src_zspage)) break; } - - /* Remember last position in this iteration */ - cc->s_page = s_page; - cc->obj_idx = obj_idx; } static struct zspage *isolate_src_zspage(struct size_class *class) @@ -2013,7 +1998,6 @@ static unsigned long zs_can_compact(struct size_class *class) static unsigned long __zs_compact(struct zs_pool *pool, struct size_class *class) { - struct zs_compact_control cc; struct zspage *src_zspage = NULL; struct zspage *dst_zspage = NULL; unsigned long pages_freed = 0; @@ -2031,7 +2015,6 @@ static unsigned long __zs_compact(struct zs_pool *pool, if (!dst_zspage) break; migrate_write_lock(dst_zspage); - cc.d_page = get_first_page(dst_zspage); } src_zspage = isolate_src_zspage(class); @@ -2040,9 +2023,7 @@ static unsigned long __zs_compact(struct zs_pool *pool, migrate_write_lock_nested(src_zspage); - cc.obj_idx = 0; - cc.s_page = get_first_page(src_zspage); - migrate_zspage(pool, class, &cc); + migrate_zspage(pool, src_zspage, dst_zspage); fg = putback_zspage(class, src_zspage); migrate_write_unlock(src_zspage); -- 2.41.0.178.g377b9f9a00-goog