From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC6F7EB64D7 for ; Mon, 26 Jun 2023 20:40:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 040548D0002; Mon, 26 Jun 2023 16:40:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F32F88D0001; Mon, 26 Jun 2023 16:40:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFB998D0002; Mon, 26 Jun 2023 16:40:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D26C78D0001 for ; Mon, 26 Jun 2023 16:40:44 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 956F212031A for ; Mon, 26 Jun 2023 20:40:44 +0000 (UTC) X-FDA: 80946067608.15.80E146F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 60E8C1C000B for ; Mon, 26 Jun 2023 20:40:42 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QirhHOqP; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687812042; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ev54ExPXzaNvJTg8/MBf9yolJcrgbZXoUayWT02Jx5E=; b=oaT2eNy7oEo3o9e3dCsfW9vxad3cTMJuVjSYA8b4XRnajMNakn/dDk+rjF85gYEMd/5cQD TrFDK1Y4wwih6iHVOHX0k9VrF/uHTvhJdMcreobaENbNwfVEJ1J/Yg+NqXZ7D3Z83BLRpn 3TZpFhdSoJTkCqprgvUmHcJlx/pNur0= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QirhHOqP; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687812042; a=rsa-sha256; cv=none; b=kxsA69y8H1Uh+gHJb0Pth6/JeMI8ph+SZ41+a7H8EY5XBWfr5v7JLy4u2avdLx5o7COPaC DW1zsrgB8hRJbp/Z7JxBLS2JFhH26FC2VOwcRZhcjTyG5JATxKxFDG2FvZf0L+ouksfD6v B+yUmzwd3xF3nM/reLJiui7QWD+Rwqk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687812041; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ev54ExPXzaNvJTg8/MBf9yolJcrgbZXoUayWT02Jx5E=; b=QirhHOqP3aXyqPConighjb8msLUJ/3gfpvLbKi5tRrtSWwsZp5qHUNEkGxPY4lcwBgaD6D 18pH5ZwsOW/PfkZhFpvfnlJq0i1O7kKinHsUvV6yRHfPZlyvRYot8o406pRNKVNph3BXHL rFr9TStl0RRoGtODziaxgLCdPsFBXy4= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-577-V6T88qxiNji06T6rlDemNA-1; Mon, 26 Jun 2023 16:40:39 -0400 X-MC-Unique: V6T88qxiNji06T6rlDemNA-1 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4007918c09aso12402001cf.1 for ; Mon, 26 Jun 2023 13:40:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687812038; x=1690404038; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ev54ExPXzaNvJTg8/MBf9yolJcrgbZXoUayWT02Jx5E=; b=U3BhSuVNfK3akcOsKbh0t0zvliAEYIfPPjuBla6kUqAz+1O2L4hvdSCHJ6ztWoQ2M7 EVQ6R9IQME/i9sl3NF/FyiVorYFy2CgtmZqfT1kc/ANVqaxukHeLQW8Lgg9h1fD6DEay RRKPHcm2UalSIQaVu8/iBvxpHFpajIpVnY78ojj18c2S50gcXs0yVZQYDmty+2TxJ4aG UU8e0k1LNAU6xFoK8iskOy7oyHfY6GCvu8QgA9MO7bsJPAzkwReZtmrPWwpNKaFyJcC3 LMnYMr42HBlWRHHSqX7c7/5/z8zvOcuzCqmCYwWpsETTquHZnjYs0HA2A6rKE+fUaMIj 7Kuw== X-Gm-Message-State: AC+VfDw+4oy9CAGNUfUYp15nECgsww6McUWTxTBK9rQa2ojXTX/SiuMk 4xCHnaG6gI9b4WEpVlcAvoCQumLEWDYBZVxCGJqkuIyat9x3Q0pkg/4110+r+P0jYO6zfqFAavU pSmcvL0ZNfrI= X-Received: by 2002:a05:6214:401a:b0:62b:5410:322d with SMTP id kd26-20020a056214401a00b0062b5410322dmr38030186qvb.6.1687812037931; Mon, 26 Jun 2023 13:40:37 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6Dtb63C7KvmjXbiTlKTAOd4PeeO3zkzCwG3AgPJj8QsyFnRHiYIK3DBwF3XpzBiJbIWbFn2g== X-Received: by 2002:a05:6214:401a:b0:62b:5410:322d with SMTP id kd26-20020a056214401a00b0062b5410322dmr38030157qvb.6.1687812037679; Mon, 26 Jun 2023 13:40:37 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id a17-20020a0ccdd1000000b005dd8b9345b4sm3512551qvn.76.2023.06.26.13.40.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 13:40:37 -0700 (PDT) Date: Mon, 26 Jun 2023 16:40:36 -0400 From: Peter Xu To: John Hubbard Cc: David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Lorenzo Stoakes , Andrew Morton , Mike Rapoport , Yang Shi , Andrea Arcangeli , Vlastimil Babka , "Kirill A . Shutemov" , James Houghton , Matthew Wilcox , Mike Kravetz , Hugh Dickins , Jason Gunthorpe Subject: Re: [PATCH v3 7/8] selftests/mm: Add -a to run_vmtests.sh Message-ID: References: <20230623142936.268456-1-peterx@redhat.com> <20230623142936.268456-8-peterx@redhat.com> <1f81260b-f569-87b9-a100-f6cd65ee5a5f@redhat.com> <29f9a86d-8ee7-5e54-2979-c5fd3b6fbe2d@nvidia.com> MIME-Version: 1.0 In-Reply-To: <29f9a86d-8ee7-5e54-2979-c5fd3b6fbe2d@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 60E8C1C000B X-Stat-Signature: gewjg1k48db3si1i4ymckqwj5rrhpryr X-HE-Tag: 1687812042-952362 X-HE-Meta: U2FsdGVkX19xuSbi9oMkEvJ+m7oqTFi2PmdBA8OTB9CicoelANcwvG5SlvJHoaof9O5A+XKyUODbss3dSFmFy0ahP6CYpNp8wDPvE5PKDk6moH6m1JxA0RGdSVFUrukhFxjv16ZYZCOzqumhfFZX4ZT8pxu6EhBIspdHecdc+oFaYITq7fWudX1FkDM7twhrVlEq1Ow0YN9IN13iTKyo+kxVgh8sPHA2awu1QhbRvRn6F1MmXA+5UKLvoVl121vTJSbbDsUeKk71yV+ykEwav1eRlLBFVF24XqwrupsFX0acfHPGVxhgHUJZkvJqWNDHhxUPysPCd9cWlcITaPO/DlYoZGX3qpUlq21bzBOi8TwX7c+LpfhpgQFAQ9wYglrfrAIk64xzuz27CPTINZPywXR6XIzGuG1E8CP+pOq/eUoUtogA0726a62JnUY2xwwoW2BMk3bSU7H65gVpgR1Xd2FQL0HwUXpltFf4mlnhzEmQCd0TnHZl6u6QToOwMQ1ZmEh/ZV3b7Oi/sljqFIG5R0fTb/+rpIIkUU/Ga/lPhpmRG/IsY7faS+5dV4CE/NFRil0RyiI1lNrd7h0xL2sS+Ng+0LjLHo8Cr9GT4uddgNMm6fcK7v7bLvAWhEf9AbKQ+DWmdr1366rGyMdlXrJFJ2aLMGzVFre+R5/w8cTK3NTn7DIIEXD1w2CkqJMCssUrPZrp2F5VYqgYMQOCeN0J5X/T/VnC+3DTq4OS9W5/91QGUz92p2HucjcF+6CIJwBNfwRjnsbmzr1y0A6oF7YSz/l3yxVqwNPF4EfYq5uefPy1T6nLT+htmW39V6nTWU12IxsPfKrzDdcq/dS1AVoxGkLlq8SECpfhxoxCCk61yu8JrQaucYWd6kprMeysoOh21oY8lyHSDT0aWvYOvix0tNosi58jPq1cHh01lV+Rq62FfstK3JKOJgM5Ze6h76xJQGp3PdgR5f7wpP13wWZ P7f7cZ0R dsjS6srCdmaEe/G7t8O2X532Si+yb6IKw+/DBKfRWtiMkpr0O3Kx/dFLnx2JEZI44kORvmNdi0jvv5F0tpApxrQQFWrIiO8vbBVp/xVfJIyIaiL35fg/rCRh//dGyUGAgOKYFabpZIlWcgfs4ehAVDaknYh3q+TidMhARTfMTv18Ahd/apjXQbpQG9vQPonfXTX/6k9oRNwgyOySVVk7NoxmD6s8WFJ+tgPhuq6JGmuE7Rmd46uw87qq0vnfi84jHnEj1Q2Zbfa1PvbvgnpQiJGtauH9lGWxe5xHyX1OljiDUErz7q3C+1R+OI5pq4w5cnP+ggmy9WKqSi0qHSZ8bExcUylGWXK/NFzvbsQJrznclu5aQb81C2rl2bPjbSX+SDOq+2PF++cg/w/snC4J36TLJpNBo6pVr9dkC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 26, 2023 at 01:24:45PM -0700, John Hubbard wrote: > On 6/26/23 09:24, Peter Xu wrote: > > On Mon, Jun 26, 2023 at 10:10:26AM +0200, David Hildenbrand wrote: > > > On 23.06.23 16:29, Peter Xu wrote: > > > > Allows to specify optional tests in run_vmtests.sh, where we can run time > > > > consuming test matrix only when user specified "-a". > > > > > > I'd have used something like "-e: extended tests that might be more > > > time-consuming". > > > > '-a' stands for "all" here, I worry '-e' may be misread into running "extra > > tests only". > > > > It's getting to the point where long options would help. This one > could be "--stress-tests" or "--all", or "--include-long-running", > for example. > > I hesitate to suggest it because it's extra work, but at some point > it would be nice. The options are already hopelessly un-guessable. Thanks for being considerate, John. Yes I do hope this series can converge soon, indeed hopefully any further test patches can be worked on top. To me I would be fine with either option (-a/-e), as long as there's easy way to dump a help message, where "run_vmtest.sh -h" works for me always. What's more "hopeless" along my way as an user is there's no help message for gup_test.c even though its parameter list is crazily long. I used to "convince" myself that gup is just so special so someone should just understand what option goes to what ioctl, better read into the .c file. But I know that's an excuse. Thanks, -- Peter Xu